resque-heroku-signals 1.27.4 → 1.27.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5c3bda2200bc909e3b085034fbbf5f7b4b39828
-  data.tar.gz: 75fe2983a09fe4511e99b8415d1097cfee7f9382
+  metadata.gz: d5132b492fff85cf94f3eb40020be2db975ec429
+  data.tar.gz: ca1220cdbd9711c5330d34e41fa50ad54f69609f
 SHA512:
-  metadata.gz: ff03eb6273bce727ab50a6939d69687630d9db065bc65d1e2a1d3fe3d6f26d14400cc2c829460f6b54816b6c9d59c05858b469167ea041ba0c40e611c431ef19
-  data.tar.gz: 36625fbff4fafba8e770abc05de271465664716945e8254c3aee119654839ac6c32e571767eba133c0300983ac8b7d73abef423267e6c72c14d8b0d02bc6be06
+  metadata.gz: a62bda832166979be5ec4ef9a7e62b6581b0f1992eae9b2444ec35f723738690dcf2d2c3f40fa49da45f396304fa1ed9271d946f3de82c73e0a2b2af3b69d1ba
+  data.tar.gz: da0e78106868f5794a423092a7979d2cf58a167ec0fa0b50b50be4a2d995c4ca6a5faf7f5c4603320fdfc21e5cf14d562bfbb88b55eea8e51f33a8fc8b13915f

data/.gitignore

@@ -8,6 +8,7 @@
 /spec/reports/
 /tmp/
 /vendor/
+*.gem
 
 # rspec failure tracking
 .rspec_status

data/README.md

@@ -15,18 +15,25 @@ Add this line to your application's Gemfile:
 gem 'resque-heroku-signals'
 ```
 
+Since this gem monkeypatches the Heroku worker the `gemspec` is locked to a `x.x.x` version of Resque. Issue a PR if this is not compatible with the version of resque you are using. 
+
 ## Example Procfile
 
 ```
 worker: env QUEUE=* TERM_CHILD=1 INTERVAL=0.1 RESQUE_PRE_SHUTDOWN_TIMEOUT=20 RESQUE_TERM_TIMEOUT=8 bundle exec rake resque:work
-
 ```
 
-* Total time should be less than 0
 * `RESQUE_PRE_SHUTDOWN_TIMEOUT` time a job has to finish up before the `TermException` exception is raised
 * `RESQUE_TERM_TIMEOUT` time the job has to cleanup & save state
+* Total shutdown time should be less than 30s. This is the time [Heroku gives you to cleanup before a `SIGKILL` is issued](https://devcenter.heroku.com/articles/dynos#shutdown)
 * `INTERVAL` seconds to wait between jobs
 
+Also, make you don't buffer logs: import log messages could fail to push to stdout during the worker shutdown process:
+
+```ruby
+$stdout.sync = true
+```
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/lib/resque/heroku-signals.rb

@@ -6,16 +6,16 @@ Resque::Worker.class_eval do
   def unregister_signal_handlers
     trap('TERM') do
       trap('TERM') do
-        puts "[resque-heroku] received second term signal, throwing term exception"
+        log_with_severity :info, "[resque-heroku] received second term signal, throwing term exception"
 
         trap('TERM') do
-          puts "[resque-heroku] third or more time receiving TERM, ignoring"
+          log_with_severity :info, "[resque-heroku] third or more time receiving TERM, ignoring"
         end
 
         raise Resque::TermException.new("SIGTERM")
       end
 
-      puts "[resque-heroku] received first term signal from heroku, ignoring"
+      log_with_severity :info, "[resque-heroku] received first term signal from heroku, ignoring"
 
     end
 

data/lib/resque/heroku/version.rb

@@ -1,5 +1,5 @@
 module Resque
   module HerokuSignals
-    VERSION = "1.27.4"
+    VERSION = "1.27.4.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-heroku-signals
 version: !ruby/object:Gem::Version
-  version: 1.27.4
+  version: 1.27.4.1
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-06 00:00:00.000000000 Z
+date: 2017-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque