resque-heroku-signals 1.27.4.2 → 1.27.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 32e4dc2857b3a023cebda645c4de0471c5ec8c6c
-  data.tar.gz: 2909dac3fe78ac1dc81148738a12d973647af6a0
+  metadata.gz: b9c16646fceadc63c6de9f13561c375add6161ec
+  data.tar.gz: 852b25d7b002bc6c4c93caaa2ee587a9b5b53625
 SHA512:
-  metadata.gz: 3a7bf798568412f2343f842e3ffc45de06f673728368b2084b9c810a0dcf3e3948d775a0005befbc5a47ba2c863924f3db0ce43af2926b21fc66a618d6c6b418
-  data.tar.gz: f85109d7c9739200a0c258ed457c514417b2dde880076b542327d50ae71b9b9d5f960bfa780cfce42a965d54f9947ac732f231f57a9aeb126cf4e135f3068f75
+  metadata.gz: f966ab995b091384bf764b7305bc8459502bdcb03307878277e92b8f46afb88d84baaf029fa432432d29fbbcdeb95d8f0334c4a75d1554fa9f5a8bf1d477624e
+  data.tar.gz: 2949155a0ad39b5463b933429dafc039cb6efe4ac6e113db7cf498223aadcc0d29acb71fd15c137e69cb7b86aadc1334ac8589c06f70106e3af25f139b876069

data/Gemfile

@@ -1,2 +1,5 @@
 source 'https://rubygems.org'
 gemspec
+
+gem 'pry'
+gem 'pry-byebug'

data/README.md

@@ -15,7 +15,15 @@ Add this line to your application's Gemfile:
 gem 'resque-heroku-signals'
 ```
 
-Since this gem monkeypatches the Heroku worker the `gemspec` is locked to a `x.x.x` version of Resque. Issue a PR if this is not compatible with the version of resque you are using. 
+Since this gem monkeypatches the Heroku worker the `gemspec` is locked to a `x.x.x` version of Resque. Issue a PR if this is not compatible with the version of resque you are using.
+
+## Determining When a Process Will Shutdown
+
+Heroku sends a `TERM` signal to a process before hard killing it. If your job communicates with slow external APIs, you may want to make sure you have enough time to receive and handle the response from the external system before executing the API requests.
+
+Ideally, using an idempotency key with each external API request is the best way to ensure that a given API request only runs. However, depending on your application logic this may not be practical and knowing if a process will be terminated in less than 30s by Heroku is a useful tool.
+
+Use `Resque.heroku_will_terminate?` to determine if Heroku will terminate your process within 30s. 
 
 ## Example Procfile
 
@@ -28,7 +36,7 @@ worker: env QUEUE=* TERM_CHILD=1 INTERVAL=0.1 RESQUE_PRE_SHUTDOWN_TIMEOUT=20 RES
 * Total shutdown time should be less than 30s. This is the time [Heroku gives you to cleanup before a `SIGKILL` is issued](https://devcenter.heroku.com/articles/dynos#shutdown)
 * `INTERVAL` seconds to wait between jobs
 
-Also, make you don't buffer logs: import log messages could fail to push to stdout during the worker shutdown process:
+Also, make you don't buffer logs: important log messages could fail to push to stdout during the worker shutdown process:
 
 ```ruby
 $stdout.sync = true

data/lib/resque-heroku-signals.rb

@@ -1,9 +1,19 @@
 require 'resque'
 
+$HEROKU_WILL_TERMINATE_RESQUE = false
+
+Resque.class_eval do
+  def self.heroku_will_terminate?
+    !!$HEROKU_WILL_TERMINATE_RESQUE
+  end
+end
+
 # https://github.com/resque/resque/issues/1559#issuecomment-310908574
 Resque::Worker.class_eval do
   def unregister_signal_handlers
     trap('TERM') do
+      $HEROKU_WILL_TERMINATE_RESQUE = true
+
       trap('TERM') do
         log_with_severity :info, "[resque-heroku] received second term signal, throwing term exception"
 
@@ -15,7 +25,6 @@ Resque::Worker.class_eval do
       end
 
       log_with_severity :info, "[resque-heroku] received first term signal from heroku, ignoring"
-
     end
 
     trap('INT', 'DEFAULT')

data/resque-heroku-signals.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "resque-heroku-signals"
-  spec.version       = '1.27.4.2'
+  spec.version       = '1.27.4.3'
   spec.authors       = ["Michael Bianco"]
   spec.email         = ["mike@suitesync.io"]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-heroku-signals
 version: !ruby/object:Gem::Version
-  version: 1.27.4.2
+  version: 1.27.4.3
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-29 00:00:00.000000000 Z
+date: 2018-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque