resque-fifo-queue 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b962de3ad6dec018f3c39ae6dd0a1bce29552c6a
-  data.tar.gz: 7bb016d06b063bd45459668ede1de61df13b0d6d
+  metadata.gz: a25c70e4b591afb416801f0dec6c0476416a4339
+  data.tar.gz: 69e80b0d5a41cbdf9872c323f29942d2ecb2c36f
 SHA512:
-  metadata.gz: 3026f465971b56dd870ca6f177d0783ec0070d9231b0e4b17657664cadfe6bf22d753bbeeb7b64392472fddfa75cd8d828ed5b9bf675bfe8f0a1637f708ea764
-  data.tar.gz: c584f50175d9ae9e9ef934427e0b10688f40867ab40a913f0616ec909974e21baf2275e9fe956fff3ce951d893636ae5cbc17641056350b0b265416e9bf8f221
+  metadata.gz: 4d8753985baedc02f5ee413fa4466706ceae626af39830103630d015b1e20fea9a0ab33bf27eaa1e9fd8a09e7f9d9c063e176e836a51240c947932d0914af199
+  data.tar.gz: 7cc503d852863dda10ffb313a0c437b62188d22972f9200db4a8cab5e44e33ecabba2d4ff5acb3620bc908ea2149476370ad824444cacce04c725f5f3fa636aa

data/README.md

@@ -74,18 +74,11 @@ workers and queues used. This can be accessed via:
 
 http://localhost:3000/resque/fifo_queue
 
-## Development
-
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
 ## Ensuring workers are updated
 
-Since only one worker is assigned to a particular shard, it is important to make sure a worker is running. The
-fifo shard table is updated everytime a worker is started or stopped properly (using kill -S QUITE).
-
-Though for some cases a scheduled task is necessary to make sure the worker list is constantly updated:
+Since only one worker is assigned to a particular shard, it is important to make sure a worker is running otherwise jobs will
+pile up for that shard. The shard table is updated everytime a worker is started or stopped properly (using kill -S QUITE). However
+in exceptional cases (workers are forced killed for example), a shard may be left without a worker. In cases like this a scheduled task is necessary to make sure the worker list is constantly updated:
 
 ```yaml
 # resque_schedule.yml
@@ -96,6 +89,21 @@ auto_refresh_fifo_queues:
   description: 'Check if fifo workers are still valid and update worker table'
 ```
 
+Do make sure to add the resque-scheduler as well https://github.com/resque/resque-scheduler
+
+## Related Projects
+
+If you need something more performant and robust, Apache Kafka is still the way to go. Though you need a couple more libraries
+to set it up with rails.
+
+https://github.com/karafka/karafka
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/resque-fifo-queue. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/lib/resque/fifo/queue.rb

@@ -3,7 +3,6 @@ require 'resque/fifo/constants'
 require "redis"
 require "redlock"
 require 'xxhash'
-require 'resque_solo'
 require "resque/plugins/fifo/queue/version"
 require "resque/plugins/fifo/server"
 require "resque/plugins/fifo/extensions"

data/lib/resque/fifo/tasks.rb

@@ -1,6 +1,7 @@
-require 'resque/fifo/queue'
+task "resque:fifo-worker" => [ "resque:preload", "resque:setup" ] do
+  require 'resque'
+  require 'resque/fifo/queue'
 
-task "resque:fifo-worker" => :environment do
   prefix = ENV['PREFIX'] || 'fifo'
   worker = Resque::Plugins::Fifo::Worker.new
   worker.prepare
@@ -8,7 +9,7 @@ task "resque:fifo-worker" => :environment do
   worker.work(ENV['INTERVAL'] || 5) # interval, will block
 end
 
-task "resque:fifo-workers" => :environment do
+task "resque:fifo-workers" do
   threads = []
 
   if ENV['COUNT'].to_i < 1

data/lib/resque/plugins/fifo/queue/drain_worker.rb

@@ -3,8 +3,6 @@ module Resque
     module Fifo
       module Queue
         class DrainWorker
-          include Resque::Plugins::UniqueJob
-
           def self.perform
             Resque::Plugins::Fifo::Queue::Manager.new.update_workers
           end

data/lib/resque/plugins/fifo/queue/version.rb

@@ -2,7 +2,7 @@ module Resque
   module Plugins
     module Fifo
       module Queue
-        VERSION = "0.1.1"
+        VERSION = "0.1.2"
       end
     end
   end

data/resque-fifo-queue.gemspec

@@ -39,7 +39,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency "resque", "~> 1.27"
   spec.add_dependency "resque-scheduler"
   spec.add_dependency "resque-pause"
-  spec.add_dependency "resque_solo"
   spec.add_dependency "xxhash"
   spec.add_dependency "redlock"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-fifo-queue
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Joseph Emmanuel Dayo
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-27 00:00:00.000000000 Z
+date: 2018-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -136,20 +136,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: resque_solo
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: xxhash
   requirement: !ruby/object:Gem::Requirement