resque-disable-job 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: acc1e95ce6c23efb0f9a1f6e4f83dbc4c791ff89
-  data.tar.gz: 1058c2273ec04f487a0f89a44f6cd82aa4fa95ac
+  metadata.gz: 4e5443eca7a655fcfe205105c1db550c43bb9f32
+  data.tar.gz: f27ded11981d8260271c23788319f184bae52932
 SHA512:
-  metadata.gz: fe0543e6cecac2551a46e9b9634c47672cfc74617626ab3cf0365bc3b263f0c22d0c4033e9b5ef6940afd657f17e88b193abacb1bc359963551dbf541b80f81a
-  data.tar.gz: bf8a921179b2f961879bab400f1a2ccde087a9233cf266ded058ffa968f0fec50164fbbfebe15ffd470cd6efe2519118df86a641869cd3c9b9515efd4b74a1c9
+  metadata.gz: e5e0ba4713b9a816863e93c7f2f98a74eb5c1a27243e7ddf6eba1ceae60012b67a4e47594406a3db21f07717514e7088d5d540345131194ab26c4e21a04d29df
+  data.tar.gz: 3183fc7f2f292dce6eacfe2cf13649bce1ed74a41a2b3e26eb1a59dd6c5045d3afe25d79e25ea4afe82811024514a8134524fa1a524f07fe156422626c36e414

data/.gitignore

@@ -13,3 +13,6 @@
 Gemfile.lock
 .ruby-version
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
+
+# Exclude the built gems
+*.gem

data/README.md

@@ -42,9 +42,9 @@ By default this will just raise `Resque::Job::DontPerform`. If you want to do mo
 
 ### Disabling a Job
 
-In your application's console you can use the `Resque::Plugins::DisableJob.disable_job` method to disable a job.
+In your application's console you can use the `Resque::Plugins::DisableJob::Job.disable_job` method to disable a job.
 
-`Resque::Plugins::DisableJob.disable_job(job_name, matching_arguments, ttl = 3600)`
+`Resque::Plugins::DisableJob::Job.disable_job(job_name, matching_arguments, ttl = 3600)`
 
 Note: By default, each rule has a ttl of 1 hour. This is because disabling a job should be a temporary action.
 
@@ -74,11 +74,12 @@ Resque::Plugins::DisableJob::Job.enable_all!
 
 ### Operations
 
-`Resque::Plugins::DisableJob::Stats` comes with a a few methods that will help you keep track of actively disabled jobs and how many times the rule was matched.
+`Resque::Plugins::DisableJob::Stats` comes with a a few methods that will help you keep track of actively disabled jobs and how many times the rule was matched. 
+They all return an `Array[Resque::Plugins::DisableJob::Rule]`.
 
-* `all_disabled_jobs` - returns a hash of all the disabled jobs and their rules 
-* `job_disabled_rules(job_name)` - returns a hash of all the rules for one particular job 
-* `disabled_stats` - returns an array of all the disabled jobs, their rules, and the counter of how many times it was matched 
+* `all_disabled_jobs` - a list of all the disabled jobs and their rules
+* `job_disabled_rules(job_name)` - a list of all the rules for one particular job 
+* `disabled_stats` - all the disabled jobs, their rules, and the counter of how many times it was matched (the `Rule` objects have the `counter` attribute set)  
 
 ## Development
 

data/lib/resque/disable_job/version.rb

@@ -2,6 +2,6 @@
 
 module Resque
   module DisableJob
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

data/lib/resque/plugins/disable_job/rule.rb

@@ -22,6 +22,7 @@ module Resque
       class Rule
         JOBS_SET = 'disabled_jobs'
         attr_reader :job_name
+        attr_accessor :count
 
         def initialize(job_name, arguments = [], digest = '')
           @job_name = job_name

data/lib/resque/plugins/disable_job/stats.rb

@@ -9,25 +9,20 @@ module Resque
       # These are methods that inspect the rules
       class Stats
         def self.all_disabled_jobs
-          Hash[Job.disabled_jobs.map { |name| [name, job_disabled_rules(name)] }]
+          Job.disabled_jobs.map { |name| job_disabled_rules(name) }.flatten
         end
 
         def self.job_disabled_rules(name)
-          Resque.redis.hgetall(Rule.new(name).all_rules_key)
+          Resque.redis.hgetall(Rule.new(name).all_rules_key).each_with_object([]) do |(digest, arguments), rules|
+            rules << Rule.new(name, arguments, digest)
+          end
         end
 
         def self.disabled_stats
-          counts = all_disabled_jobs.map do |name, rules|
-            rules.map do |digest, arguments|
-              {
-                job_name: name,
-                digest: digest,
-                arguments: arguments,
-                count: Resque.redis.get(Rule.new(name, arguments, digest).rule_key)
-              }
-            end
+          all_disabled_jobs.map do |rule|
+            rule.count = Resque.redis.get(rule.rule_key).to_i
+            rule
           end
-          counts.flatten
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-disable-job
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Andrei Balcanasu
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-08 00:00:00.000000000 Z
+date: 2017-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque