resque-access_worker_from_job 0.2.3 → 0.3.0

data/README.rdoc

@@ -43,12 +43,6 @@ as well.
 
 
 == Warnings
-=== Argument errors in mixed environments
-Internally, this overrides Resque::Job to append the worker to the argument list passed to any <code>JobClass#perform</code>
-method. For a class that extends Resque::Plugins::AccessWorkerFromJob, this is handled transparently (worker is 
-removed from the argument list and is available via the <code>@worker</code> instance variable, instead).  For mixed environments
-where not all jobs to be run extend AccessWorkerFromJob, and where some of these expect a set number of arguments,
-this may cause problems ("wrong number of arguments" exceptions).
 
 === Ephemeral nature of worker changes
 Be careful to note that each job forks before running, so instance variables will be a _copy_ and, if changed,

data/VERSION

@@ -1 +1 @@
-0.2.3
+0.3.0

data/lib/resque/plugins/access_worker_from_job.rb

@@ -1,11 +1,15 @@
 require 'resque' unless defined?(Resque)
 
 module Resque # :nodoc:
-  # Resque-AccessWorkerFromJob plugin overrides the Resque::Job#args method to pass the worker along as the last argument.
+  # Resque-AccessWorkerFromJob plugin overrides the Resque::Job#args method to
+  # pass the worker along as the last argument, if the class on which to call perform wants it.
   class Job
+    
     # Overridden args appends the worker when returning the list of args represented in this job's payload.
     def args
-      @payload['args'] + [worker]
+      base_args = @payload['args'] || []
+      base_args << worker if payload_class.respond_to?(:wants_worker_access) && payload_class.wants_worker_access
+      return base_args
     end
   end
 end
@@ -43,12 +47,14 @@ module Resque # :nodoc:
       attr_accessor :required_worker_class, :worker
       
       def self.extended(base)
-        
         unless base.methods.include?('perform')
           raise %Q{You must call "extend Resque::Plugins::AccessWorkerFromJob" AFTER (below) defining the perform method}
         end
         
         class << base
+          def wants_worker_access
+            true
+          end
           
           # Remove worker from last argument, so can write their perform method assuming just the arguments
           # they sent it, without worrying about the appended worker.

data/resque-access_worker_from_job.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{resque-access_worker_from_job}
-  s.version = "0.2.3"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kali Donovan"]
-  s.date = %q{2010-04-25}
+  s.date = %q{2010-06-02}
   s.description = %q{By allowing multiple jobs to share a single socket, which is persisted over the life of the worker, this plugin is an important building block for implementing a Resque-based service send background iPhone messages via the Apple Push Notification servers.}
   s.email = %q{kali.donovan@gmail.com}
   s.extra_rdoc_files = [
@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/kdonovan/resque-access_worker_from_job}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.5}
+  s.rubygems_version = %q{1.3.6}
   s.summary = %q{Resque plugin to allow jobs access to their calling worker at runtime.}
 
   if s.respond_to? :specification_version then

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: resque-access_worker_from_job
 version: !ruby/object:Gem::Version 
-  version: 0.2.3
+  prerelease: false
+  segments: 
+  - 0
+  - 3
+  - 0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Kali Donovan
@@ -9,19 +14,21 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-25 00:00:00 -07:00
+date: 2010-06-02 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: resque
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :runtime
+  version_requirements: *id001
 description: By allowing multiple jobs to share a single socket, which is persisted over the life of the worker, this plugin is an important building block for implementing a Resque-based service send background iPhone messages via the Apple Push Notification servers.
 email: kali.donovan@gmail.com
 executables: []
@@ -56,18 +63,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Resque plugin to allow jobs access to their calling worker at runtime.