responders 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1dc27831fc7b12f53a28dba5186e256cceab2d17
-  data.tar.gz: 277b5266e4495e11b903ca12b36aecd192d494b3
+  metadata.gz: 8b652ad426b4ce87cb002a4b5562f79c2335c412
+  data.tar.gz: ee67a5d29f4cd5920a228ccc6229c52bfdddfea8
 SHA512:
-  metadata.gz: 6cb93c417ef6b0dd0844684cecc12e29822e422f88bdaf3fee3188d83c581042e6fc302b25e2717168821fc248dd2530f104d2819501aeec4887cdfdaaf3b575
-  data.tar.gz: b289b2e512aa9fcbb8ffdeaaa04857bbcf0caeef8a0026a257891856e4e0f13f8d90858bb276d44d4a1fe38919fd832c831b09e26fa79da15ed1855d237465cf
+  metadata.gz: 102cd8209ca03e4275003de1c82814eec7da60f92f118d7dd38bbaca8ce56a1e1fef7b0278a99cecaf9a3016fc85e4381e1fee440a1ecc376c024924b3b9d2dd
+  data.tar.gz: 6733104f4c7ce9f7250f1ce410562661f16b8d11ce0193c0054264682d4757f4b44d47ce2931df6986d0864b6bc74411388caf7a09c2e5707bf00470f29784bd

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.0.1
+
+* Require "rails/railtie" explicitly before using it
+* Require "action_controller" explicitly before using it
+* Remove unecessary and limitting `resourceful?` check that required models to implement `to_#{format}` (such checks are responsibility of the rendering layer)
+
 ## 2.0.0
 
 * Import `respond_with` and class-level `respond_to` from Rails

data/README.md

@@ -60,7 +60,7 @@ You can also have embedded HTML. Just create a `_html` scope.
 
 See also the `namespace_lookup` option to search the full hierarchy of possible keys.
 
-### Location Responder
+### LocationResponder
 
 This responder allows you to use callable objects as the redirect location.
 Useful when you want to use the `respond_with` method with
@@ -72,7 +72,7 @@ class ThingsController < ApplicationController
   respond_to :html
 
   def create
-    @thing = Things.create(params[:thing])
+    @thing = Thing.create(params[:thing])
     respond_with @thing, location: -> { thing_path(@thing) }
   end
 end

data/lib/action_controller/responder.rb

@@ -187,8 +187,8 @@ module ActionController #:nodoc:
       else
         display_errors
       end
-    rescue ActionView::MissingTemplate => e
-      api_behavior(e)
+    rescue ActionView::MissingTemplate
+      api_behavior
     end
 
   protected
@@ -205,8 +205,7 @@ module ActionController #:nodoc:
     end
 
     # This is the common behavior for formats associated with APIs, such as :xml and :json.
-    def api_behavior(error)
-      raise error unless resourceful?
+    def api_behavior
       raise MissingRenderer.new(format) unless has_renderer?
 
       if get?
@@ -218,12 +217,6 @@ module ActionController #:nodoc:
       end
     end
 
-    # Checks whether the resource responds to the current format or not.
-    #
-    def resourceful?
-      resource.respond_to?("to_#{format}")
-    end
-
     # Returns the resource location by retrieving it from the options or
     # returning the resources array.
     #

data/lib/responders.rb

@@ -1,4 +1,5 @@
-require 'action_controller/base'
+require 'action_controller'
+require 'rails/railtie'
 
 module ActionController
   autoload :Responder, 'action_controller/responder'

data/lib/responders/http_cache_responder.rb

@@ -34,11 +34,11 @@ module Responders
 
     def do_http_cache?
       get? && @http_cache != false && ActionController::Base.perform_caching &&
-        persisted? && resourceful? && resource.respond_to?(:updated_at)
+        persisted? && resource.respond_to?(:updated_at)
     end
 
     def persisted?
       resource.respond_to?(:persisted?) ? resource.persisted? : true
     end
   end
-end
+end

data/lib/responders/version.rb

@@ -1,3 +1,3 @@
 module Responders
-  VERSION = "2.0.0".freeze
+  VERSION = "2.0.1".freeze
 end

data/test/action_controller/respond_with_test.rb

@@ -4,8 +4,6 @@ class Customer < Struct.new(:name, :id)
   extend ActiveModel::Naming
   include ActiveModel::Conversion
 
-  undef_method :to_json
-
   def to_xml(options={})
     if options[:builder]
       options[:builder].name name
@@ -201,9 +199,9 @@ class RespondWithControllerTest < ActionController::TestCase
     assert_equal "<name>david</name>", @response.body
 
     @request.accept = "application/json"
-    assert_raise ActionView::MissingTemplate do
-      get :using_resource
-    end
+    get :using_resource
+    assert_equal "application/json", @response.content_type
+    assert_equal "{\"name\":\"david\",\"id\":13}", @response.body
   end
 
   def test_using_resource_with_js_simply_tries_to_render_the_template

data/test/test_helper.rb

@@ -6,7 +6,6 @@ require 'mocha/setup'
 ENV["RAILS_ENV"] = "test"
 
 require 'active_support'
-require 'action_controller'
 require 'active_model'
 require 'rails/engine'
 require 'rails/railtie'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: responders
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - José Valim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-17 00:00:00.000000000 Z
+date: 2014-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties