resizing 1.0.0.pre → 1.0.1

data/test/resizing/mock_client_test.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Resizing
+  class MockClientTest < Minitest::Test
+    def setup
+      @client = Resizing::MockClient.new
+    end
+
+    def teardown
+      # NOP
+    end
+
+    def test_post_returns_parsed_json
+      VCR.use_cassette('client/post', record: :none) do
+        result = @client.post(nil)
+
+        assert_instance_of Hash, result
+        assert result.key?('id')
+        assert result.key?('public_id')
+        assert result.key?('latest_version_id')
+        assert result.key?('latest_etag')
+      end
+    end
+
+    def test_put_returns_parsed_json_with_modified_name
+      VCR.use_cassette('client/put', record: :none) do
+        name = 'test-image-123'
+        result = @client.put(name, nil, {})
+
+        assert_instance_of Hash, result
+        assert_equal name, result['id']
+        assert_includes result['public_id'], name
+        assert result.key?('latest_version_id')
+        assert result.key?('latest_etag')
+      end
+    end
+
+    def test_delete_returns_parsed_json_with_modified_name
+      VCR.use_cassette('client/delete', record: :none) do
+        name = 'delete-test-image'
+        result = @client.delete(name)
+
+        assert_instance_of Hash, result
+        assert_equal name, result['id']
+        assert_includes result['public_id'], name
+      end
+    end
+
+    def test_metadata_returns_parsed_json_with_modified_name
+      VCR.use_cassette('client/metadata', record: :none) do
+        name = 'metadata-test-image'
+        result = @client.metadata(name)
+
+        assert_instance_of Hash, result
+        assert_equal name, result['id']
+        # The cassette contains a fixed public_id, so we just check it exists
+        assert result.key?('public_id')
+      end
+    end
+
+    def test_post_response_contains_expected_fields
+      VCR.use_cassette('client/post', record: :none) do
+        result = @client.post(nil)
+
+        # Verify response structure
+        assert result['id'].is_a?(String)
+        assert result['public_id'].is_a?(String)
+        assert result['latest_version_id'].is_a?(String)
+        assert result['latest_etag'].is_a?(String)
+      end
+    end
+  end
+end

data/test/resizing_module_test.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class ResizingModuleTest < Minitest::Test
+  def setup
+    # Reset configure before each test to ensure clean state
+    if Resizing.instance_variable_defined?(:@configure)
+      Resizing.remove_instance_variable(:@configure)
+    end
+  end
+
+  def teardown
+    # Reset configure after each test
+    if Resizing.instance_variable_defined?(:@configure)
+      Resizing.remove_instance_variable(:@configure)
+    end
+  end
+
+  def test_configure_raises_error_when_not_initialized
+    assert_raises Resizing::ConfigurationError do
+      Resizing.configure
+    end
+  end
+
+  def test_configure_returns_duplicate_of_configuration
+    config = Resizing::Configuration.new(
+      image_host: 'https://test.example.com',
+      project_id: 'test_id',
+      secret_token: 'test_token'
+    )
+    Resizing.configure = config
+
+    result = Resizing.configure
+
+    assert_instance_of Resizing::Configuration, result
+    assert_equal config.image_host, result.image_host
+    assert_equal config.project_id, result.project_id
+    refute_equal config.object_id, result.object_id # Should be a duplicate
+  end
+
+  def test_configure_setter_accepts_configuration_object
+    config = Resizing::Configuration.new(
+      image_host: 'https://test.example.com',
+      project_id: 'test_id',
+      secret_token: 'test_token'
+    )
+
+    Resizing.configure = config
+
+    assert_equal config, Resizing.instance_variable_get(:@configure)
+  end
+
+  def test_configure_setter_converts_hash_to_configuration
+    config_hash = {
+      image_host: 'https://hash.example.com',
+      project_id: 'hash_id',
+      secret_token: 'hash_token'
+    }
+
+    Resizing.configure = config_hash
+
+    result = Resizing.instance_variable_get(:@configure)
+    assert_instance_of Resizing::Configuration, result
+    assert_equal 'https://hash.example.com', result.image_host
+    assert_equal 'hash_id', result.project_id
+  end
+
+  def test_get_raises_not_implemented_error
+    assert_raises NotImplementedError do
+      Resizing.get('test')
+    end
+  end
+
+  def test_url_from_image_id_returns_url_without_version_and_transforms
+    Resizing.configure = {
+      image_host: 'https://img.example.com',
+      project_id: 'project123',
+      secret_token: 'token123'
+    }
+
+    url = Resizing.url_from_image_id('image456')
+
+    assert_equal 'https://img.example.com/projects/project123/upload/images/image456', url
+  end
+
+  def test_url_from_image_id_returns_url_with_version
+    Resizing.configure = {
+      image_host: 'https://img.example.com',
+      project_id: 'project123',
+      secret_token: 'token123'
+    }
+
+    url = Resizing.url_from_image_id('image456', '789')
+
+    assert_equal 'https://img.example.com/projects/project123/upload/images/image456/v789', url
+  end
+
+  def test_url_from_image_id_returns_url_with_transformations
+    Resizing.configure = {
+      image_host: 'https://img.example.com',
+      project_id: 'project123',
+      secret_token: 'token123'
+    }
+
+    url = Resizing.url_from_image_id('image456', nil, [{ w: 100, h: 200 }])
+
+    assert_includes url, 'https://img.example.com/projects/project123/upload/images/image456/'
+    assert_includes url, 'w_100,h_200'
+  end
+
+  def test_url_from_image_id_returns_url_with_version_and_transformations
+    Resizing.configure = {
+      image_host: 'https://img.example.com',
+      project_id: 'project123',
+      secret_token: 'token123'
+    }
+
+    url = Resizing.url_from_image_id('image456', '789', [{ w: 100 }])
+
+    assert_includes url, 'image456/v789/'
+    assert_includes url, 'w_100'
+  end
+end

data/test/test_helper.rb

@@ -1,9 +1,28 @@
 # frozen_string_literal: true
+require 'simplecov'
+require 'simplecov-cobertura'
+
+SimpleCov.start do
+  add_filter "/test/"
+
+  if ENV['CI']
+    formatter SimpleCov::Formatter::CoberturaFormatter
+  else
+    formatter SimpleCov::Formatter::MultiFormatter.new([
+                                                         SimpleCov::Formatter::SimpleFormatter,
+                                                         SimpleCov::Formatter::HTMLFormatter
+                                                       ])
+  end
+
+  enable_coverage :branch
+  primary_coverage :branch
+end
 
 $LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'time'
 require 'timecop'
 require 'vcr'
+require 'logger'
 
 require 'rails'
 require 'active_record'
@@ -13,6 +32,7 @@ require 'resizing'
 require 'pry-byebug'
 
 require 'minitest/autorun'
+require 'minitest/mock'
 
 VCR.configure do |c|
   c.cassette_library_dir = 'test/vcr'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resizing
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre
+  version: 1.0.1
 platform: ruby
 authors:
 - Junichiro Kasuya
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-06-02 00:00:00.000000000 Z
+date: 2026-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -28,16 +28,22 @@ dependencies:
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: carrierwave
   requirement: !ruby/object:Gem::Requirement
@@ -70,16 +76,16 @@ dependencies:
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.16'
 - !ruby/object:Gem::Dependency
   name: minitest-ci
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +142,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: mysql2
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-cobertura
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 'Client and utilities for Resizing '
 email:
 - junichiro.kasuya@gmail.com
@@ -146,7 +194,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - CHANGELOG.md
@@ -159,6 +207,8 @@ files:
 - exe/generate-changelog
 - exe/setup
 - lib/resizing.rb
+- lib/resizing/active_storage.rb
+- lib/resizing/active_storage/service.rb
 - lib/resizing/active_storage/service/resizing_service.rb
 - lib/resizing/carrier_wave.rb
 - lib/resizing/carrier_wave/storage/file.rb
@@ -171,18 +221,22 @@ files:
 - lib/resizing/mock_client.rb
 - lib/resizing/public_id.rb
 - lib/resizing/version.rb
-- lib/resizing/video.rb
-- lib/resizing/video/client.rb
 - resizing.gemspec
 - test/data/images/empty_file.jpg
 - test/data/images/sample1.jpg
+- test/resizing/active_storage_service_test.rb
 - test/resizing/carrier_wave/storage/file_test.rb
 - test/resizing/carrier_wave/storage/remote_test.rb
 - test/resizing/carrier_wave_test.rb
 - test/resizing/client_test.rb
+- test/resizing/configurable_test.rb
 - test/resizing/configuration_test.rb
+- test/resizing/constants_test.rb
+- test/resizing/error_test.rb
+- test/resizing/http_clientable_test.rb
+- test/resizing/mock_client_test.rb
 - test/resizing/public_id_test.rb
-- test/resizing/video/client_test.rb
+- test/resizing_module_test.rb
 - test/resizing_test.rb
 - test/test_helper.rb
 - test/vcr/carrier_wave_test/remove_resizing_picture.yml
@@ -192,9 +246,6 @@ files:
 - test/vcr/client/metadata.yml
 - test/vcr/client/post.yml
 - test/vcr/client/put.yml
-- test/vcr/video/metadata/success.yml
-- test/vcr/video/prepare/success.yml
-- test/vcr/video/upload_completed/success.yml
 homepage: https://github.com/jksy/resizing-gem
 licenses:
 - MIT
@@ -202,7 +253,7 @@ metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/jksy/resizing-gem
   source_code_uri: https://github.com/jksy/resizing-gem.
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -210,15 +261,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: Client and utilities for Resizing
 test_files: []

data/.circleci/config.yml

@@ -1,73 +0,0 @@
-version: 2
-
-jobs:
-  build:
-    docker:
-      - image: circleci/ruby:2.6.2-node
-        environment:
-          BUNDLE_JOBS: 4
-          BUNDLE_RETRY: 3
-          BUNDLE_PATH: vendor/bundle
-          BUNDLE_APP_CONFIG: "./.bundle"
-          TZ: /usr/share/zoneinfo/Asia/Tokyo
-          LANG: ja_JP.UTF8
-      - image: circleci/mysql:5.7
-        environment:
-          MYSQL_ROOT_PASSWORD: secret
-          MYSQL_DATABASE: resizing_gem_test
-          MYSQL_USER: resizing_gem
-          MYSQL_PASSWORD: secret
-          TZ: /usr/share/zoneinfo/Asia/Tokyo
-          LANG: ja_JP.UTF8
-        command: mysqld --character-set-server=utf8mb4 --collation-server=utf8mb4_bin
-
-    steps:
-      - checkout
-      - run:
-          name: Which bundler?
-          command: |
-            bundle -v
-            bundle config
-
-      - restore_cache:
-          keys:
-            - v2-{{ .Environment.CACHE_KEY }}-gem-cache-{{ arch }}-{{ .Branch }}
-            - v2-{{ .Environment.CACHE_KEY }}-gem-cache
-
-      - run:
-          name: reinstall rake && bundle install
-          command: |
-            sudo gem install bundler
-            sudo gem uninstall -x rake
-            echo "install: --no-document" >> ~/.gemrc
-            bundle config set --local path vendor/bundle
-            bundle config set --local clean true
-            bundle check || bundle install
-
-      - save_cache:
-          key: v2-{{ .Environment.CACHE_KEY }}-gem-cache-{{ arch }}-{{ .Branch }}
-          paths:
-            - vendor/bundle
-
-      - run:
-          name: connectable MySQL?
-          command: |
-            dockerize -wait tcp://127.0.0.1:3306 -timeout 1m
-
-      # - run:
-      #     name: rubocop
-      #     command: bundle exec rubocop --parallel
-      # - run:
-      #     name: brakeman
-      #     command: bundle exec brakeman --no-exit-on-error -w 1 -z
-      - run:
-          command: bundle exec rake test
-          when: always
-      - store_test_results:
-          path: test/reports
-
-workflows:
-  version: 2
-  build-deploy:
-    jobs:
-      - build

data/lib/resizing/video/client.rb

@@ -1,116 +0,0 @@
-# frozen_string_literal: true
-
-module Resizing
-  module Video
-    class Client
-      include Resizing::Constants
-      include Resizing::Configurable
-      include Resizing::HttpClientable
-
-      def initialize(*attrs)
-        initialize_config(*attrs)
-      end
-
-      def prepare
-        url = build_prepare_url
-
-        response = handle_faraday_error do
-          http_client.post(url) do |request|
-            request.headers['X-ResizingToken'] = config.generate_auth_header
-          end
-        end
-        handle_prepare_response response
-      end
-
-      def upload_completed response_or_url
-        url = url_from response_or_url, 'upload_completed_url'
-
-        response = handle_faraday_error do
-          http_client.put(url) do |request|
-            request.headers['X-ResizingToken'] = config.generate_auth_header
-          end
-        end
-        handle_upload_completed_response response
-      end
-
-      def delete response_or_url
-        url = url_from response_or_url, 'destroy_url'
-
-        response = handle_faraday_error do
-          http_client.put(url) do |request|
-            request.headers['X-ResizingToken'] = config.generate_auth_header
-          end
-        end
-        handle_upload_completed_response response
-      end
-
-      def metadata response_or_url
-        url = url_from response_or_url, 'self_url'
-
-        response = handle_faraday_error do
-          http_client.get(url) do |request|
-            request.headers['X-ResizingToken'] = config.generate_auth_header
-          end
-        end
-        handle_metadata_response response
-      end
-
-      def build_prepare_url
-        "#{config.video_host}/projects/#{config.project_id}/upload/videos/prepare"
-      end
-
-      private
-
-      def url_from response_or_url, name
-        if response_or_url.kind_of? String
-          response_or_url
-        elsif response_or_url.kind_of? Hash
-          response_or_url[name.to_s] || response_or_url[name.intern]
-        else
-          raise ArgumentError, "upload_completed is require Hash or String"
-        end
-      end
-
-
-      def handle_prepare_response response
-        raise APIError, "no response is returned" if response.nil?
-
-        case response.status
-        when HTTP_STATUS_OK, HTTP_STATUS_CREATED
-          JSON.parse(response.body)
-        else
-          handle_error_response response
-        end
-      end
-
-      def handle_upload_completed_response response
-        raise APIError, "no response is returned" if response.nil?
-
-        case response.status
-        when HTTP_STATUS_OK
-          JSON.parse(response.body)
-        else
-          handle_error_response response
-        end
-      end
-
-      def handle_metadata_response response
-        raise APIError, "no response is returned" if response.nil?
-
-        case response.status
-        when HTTP_STATUS_OK
-          JSON.parse(response.body)
-        else
-          handle_error_response response
-        end
-      end
-
-      def handle_error_response response
-        result = JSON.parse(response.body) rescue {}
-        err = APIError.new("invalid http status code #{response.status}")
-        err.decoded_body = result
-        raise err
-      end
-    end
-  end
-end

data/lib/resizing/video.rb

@@ -1,8 +0,0 @@
-# frozen_string_literal: true
-
-module Resizing
-  module Video
-    autoload :Client, 'resizing/video/client'
-  end
-end
-