resizing 0.1.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46b4c727294bdd92f33e9fa5cf32ee2cd320987a1b2d65dccba240a5a776f0b4
-  data.tar.gz: c9c7b2a9b568c216804afb3f6108e9190644df0ed241eee73a600fe228982eca
+  metadata.gz: 9c99cc84265ede5a14f6045b73ac9cc06da7e8a71ddb4f632a4c2bcf05f12b82
+  data.tar.gz: e0ee502a4fe4d5b30942e50a11d2dff1c17806a3a8f2090e87f70823e3d69e5d
 SHA512:
-  metadata.gz: d8fc3430aef73a2b20adbc4d6c649c62ff467944e03db06b977d1dc517205644573e5ab87eb891a3539ae9776e1f4adbb3b9fded9eb782b203c244892ad3e2be
-  data.tar.gz: e5f0122b6a5d06f04b55ef79f9da102f603cd397941135787ff1d121afedcbc4d18f6d72f472e4552daa7f11099c9dd493a175ef1763145c0828b72073d215b3
+  metadata.gz: 75ac29e319053ea1ee9e4ec8c50955c972431ca1df986e720681defe3930fec8d688787902ad6e07d35564d364bb23b5e919b5e369029301e16a2a41f891211d
+  data.tar.gz: b2a8a478965f384b130de2dc9e757f5bf449d28d2990a8d153578bb9d5685b3f84fb98760494a33a72693455b085a3aed390ff0e6c93e56723c2ebb8fd89ce2d

data/lib/resizing.rb

@@ -6,6 +6,7 @@ require 'json'
 
 module Resizing
   autoload :Client, 'resizing/client'
+  autoload :MockClient, 'resizing/mock_client'
   autoload :Configuration, 'resizing/configuration'
   autoload :CarrierWave, 'resizing/carrier_wave'
 
@@ -33,13 +34,11 @@ module Resizing
   end
 
   def self.post(file_or_binary, options)
-    client = Resizing::Client.new
-    client.post file_or_binary, options
+    self.client.post file_or_binary, options
   end
 
   def self.put(name, file_or_binary, options)
-    client = Resizing::Client.new
-    client.put name, file_or_binary, options
+    self.client.put name, file_or_binary, options
   end
 
   # TODO: refactoring
@@ -57,4 +56,12 @@ module Resizing
   def self.separate_public_id public_id
     public_id.match('/projects/(?<project_id>[0-9a-f-]+)/upload/images/(?<image_id>[0-9a-f-]+)(/v(?<version>[^/]+))?')
   end
+
+  def self.client
+    if self.configure.enable_mock
+      Resizing::MockClient.new
+    else
+      Resizing::Client.new
+    end
+  end
 end

data/lib/resizing/carrier_wave.rb

@@ -109,12 +109,21 @@ module Resizing
 
     # rubocop:disable Metrics/AbcSize
     def transform_string_from(processor)
-      case processor.first
+      action = processor.first
+      value = processor.second
+
+      case action
       when :resize_to_fill, :resize_to_limit, :resize_to_fit
-        name = processor.first.to_s.gsub(/resize_to_/, '')
-        { c: name, w: processor.second.first, h: processor.second.second }
+        name = action.to_s.gsub(/resize_to_/, '')
+        { c: name, w: value.first, h: value.second }
+      when :transformation
+        result = {}
+        result[:q] = value[:quality] if value[:quality]
+        result[:f] = value[:fetch_format] if value[:fetch_format]
+        result[:f] = value[:format] if value[:format]
+        result
       else
-        raise NotImplementedError, "#{processor.first} is not supported. #{processor.inspect}"
+        raise NotImplementedError, "#{action} is not supported. #{processor.inspect}"
       end.map do |key, value|
         next nil if value.nil?
 

data/lib/resizing/carrier_wave/storage/file.rb

@@ -33,7 +33,7 @@ module Resizing
           separted = Resizing.separate_public_id(public_id)
           image_id = separted[:image_id]
           resp = client.delete(image_id)
-          if resp.nil? # 404 not found
+          if resp['error'] == 'ActiveRecord::RecordNotFound' # 404 not found
             model.send :write_attribute, serialization_column, nil
             return
           end

data/lib/resizing/client.rb

@@ -11,7 +11,7 @@ module Resizing
   #   }
   #   client = Resizing::Client.new(options)
   #   file = File.open('sample.jpg', 'r')
-  #   response = client.post(file)
+  #   response = client.post(file, content_type: 'image/jpeg')
   #   {
   #     "id"=>"fde443bb-0b29-4be2-a04e-2da8f19716ac",
   #     "project_id"=>"098a2a0d-0000-0000-0000-000000000000",
@@ -28,6 +28,7 @@ module Resizing
     # to use standard constants
     HTTP_STATUS_OK = 200
     HTTP_STATUS_CREATED = 201
+    HTTP_STATUS_NOT_FOUND = 404
 
     attr_reader :config
     def initialize(*attrs)
@@ -58,7 +59,7 @@ module Resizing
         request.headers['X-ResizingToken'] = config.generate_auth_header
       end
 
-      result = handle_response(response)
+      result = handle_create_response(response)
       result
     end
 
@@ -76,7 +77,7 @@ module Resizing
         request.headers['X-ResizingToken'] = config.generate_auth_header
       end
 
-      result = handle_response(response)
+      result = handle_create_response(response)
       result
     end
 
@@ -87,7 +88,7 @@ module Resizing
         request.headers['X-ResizingToken'] = config.generate_auth_header
       end
 
-      result = handle_response(response)
+      result = handle_delete_response(response)
       result
     end
 
@@ -134,14 +135,25 @@ module Resizing
       raise ArgumentError, "need options[:content_type] for #{options.inspect}" unless options[:content_type]
     end
 
-    def handle_response(response)
+    def handle_create_response(response)
       raise APIError, "no response is returned" if response.nil?
 
       case response.status
       when HTTP_STATUS_OK, HTTP_STATUS_CREATED
         JSON.parse(response.body)
       else
-        raise APIError, "invalid http status code #{resp.status}"
+        raise APIError, "invalid http status code #{response.status}"
+      end
+    end
+
+    def handle_delete_response(response)
+      raise APIError, "no response is returned" if response.nil?
+
+      case response.status
+      when HTTP_STATUS_OK, HTTP_STATUS_CREATED, HTTP_STATUS_NOT_FOUND
+        JSON.parse(response.body)
+      else
+        raise APIError, "invalid http status code #{response.status}"
       end
     end
   end

data/lib/resizing/configuration.rb

@@ -16,7 +16,7 @@ module Resizing
   #++
   class Configuration
     attr_reader :host, :project_id, :secret_token, :open_timeout, :response_timeout, :enable_mock
-    DEFAULT_HOST = 'https://www.resizing.net'
+    DEFAULT_HOST = 'https://img.resizing.net'
     DEFAULT_OPEN_TIMEOUT = 2
     DEFAULT_RESPONSE_TIMEOUT = 10
 

data/lib/resizing/mock_client.rb

@@ -17,7 +17,12 @@ module Resizing
     private
 
     def load_yaml filename
-      YAML.load_file(filename)['http_interactions'].first['response']['body']
+      path = "#{library_root}/#{filename}"
+      YAML.load_file(path)['http_interactions'].first['response']['body']
+    end
+
+    def library_root
+      File.join(File.dirname(__FILE__), '..', '..')
     end
   end
 end

data/lib/resizing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Resizing
-  VERSION = '0.1.0'
+  VERSION = '0.3.1'
 end

data/resizing.gemspec

@@ -23,12 +23,12 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+    `git ls-files -z`.split("\x0")
   end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
-  spec.add_runtime_dependency 'faraday', '~> 0.13'
+  spec.add_runtime_dependency 'faraday', '~> 1.0.1'
   spec.add_development_dependency 'byebug'
   spec.add_development_dependency 'carrierwave'
   spec.add_development_dependency 'fog-aws'
@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest-ci'
   spec.add_development_dependency 'mysql2'
   spec.add_development_dependency 'pry-byebug'
-  spec.add_development_dependency 'rails', '= 5.2.3'
+  spec.add_development_dependency 'rails', '~> 5.2.3'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'timecop'
   spec.add_development_dependency 'vcr'

data/test/resizing/carrier_wave/storage/file_test.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Resizing
+  module CarrierWave
+    module Storage
+      class FileTest < Minitest::Test
+        def setup
+          # NOP
+        end
+
+        def teardown
+          # NOP
+        end
+
+        def test_store
+          # f = Resizing::CarrierWave::Storage::File.new(uploader)
+          # upload_file = File.new(uploader, path)
+          # f.store(upload_file)
+          # f.save!
+        end
+
+        def uploader
+          MiniTest::Mock.expect(:cache_path)
+        end
+      end
+    end
+  end
+end

data/test/resizing/carrier_wave_test.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Resizing
+  class CarrierWaveTest < Minitest::Test
+    def setup
+      TestModel.delete_all
+
+      @configuration_template = {
+        host: 'http://192.168.56.101:5000',
+        project_id: '098a2a0d-c387-4135-a071-1254d6d7e70a',
+        secret_token: '4g1cshg2lq8j93ufhvqrpjswxmtjz12yhfvq6w79jpwi7cr7nnknoqgwzkwerbs6',
+        open_timeout: 10,
+        response_timeout: 20
+      }
+      Resizing.configure = @configuration_template
+    end
+
+    def teardown; end
+
+    def test_xxxx
+      model = prepare_model
+
+      VCR.use_cassette 'carrier_wave_test/remove_resizing_picture' do
+        SecureRandom.stub :uuid, '28c49144-c00d-4cb5-8619-98ce95977b9c' do
+          model.remove_resizing_picture!
+
+          assert_nil model.resizing_picture_url
+        end
+      end
+    end
+
+    def test_picture_url_return_correct_value_and_when_model_reloaded
+      model = prepare_model
+      model.save!
+      assert_equal(expect_url, model.resizing_picture_url)
+
+      model.reload
+      assert_equal(expect_url, model.resizing_picture_url)
+    end
+
+    def expect_url
+      'http://192.168.56.101:5000/projects/098a2a0d-c387-4135-a071-1254d6d7e70a/'+
+        'upload/images/28c49144-c00d-4cb5-8619-98ce95977b9c/v1Id850__tqNsnoGWWUibtIBZ5NgjV45M/c_limit,w_1000'
+    end
+
+    def prepare_model
+      VCR.use_cassette 'carrier_wave_test/save' do
+        SecureRandom.stub :uuid, '28c49144-c00d-4cb5-8619-98ce95977b9c' do
+          model = TestModel.new
+          file = File.open('test/data/images/sample1.jpg', 'r')
+          uploaded_file = ActionDispatch::Http::UploadedFile.new(
+            filename: File.basename(file.path),
+            type: 'image/jpeg',
+            tempfile: file
+          )
+
+          model.resizing_picture = uploaded_file
+          return model
+        end
+      end
+    end
+  end
+end

data/test/resizing/client_test.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Resizing
+  class ClientTest < Minitest::Test
+    def setup
+      # NOP
+      @configuration_template = {
+        host: 'http://192.168.56.101:5000',
+        project_id: '098a2a0d-c387-4135-a071-1254d6d7e70a',
+        secret_token: '4g1cshg2lq8j93ufhvqrpjswxmtjz12yhfvq6w79jpwi7cr7nnknoqgwzkwerbs6',
+        open_timeout: 10,
+        response_timeout: 20
+      }
+    end
+
+    def teardown
+      # NOP
+    end
+
+    def test_that_it_is_initialized
+      Resizing.configure = @configuration_template
+
+      client = Resizing::Client.new
+      assert(!client.config.nil?)
+      assert_equal(client.config, Resizing.configure)
+    end
+
+    def test_that_it_is_initialized_with_configuration
+      config = Resizing::Configuration.new(@configuration_template)
+      client = Resizing::Client.new(config)
+      assert(!client.config.nil?)
+      assert_equal(client.config, config)
+    end
+
+    def test_that_it_postable_file
+      Resizing.configure = @configuration_template
+
+      client = Resizing::Client.new
+      VCR.use_cassette 'client/post' do
+        f = File.open('test/data/images/sample1.jpg', 'r')
+        r = client.post(f, content_type: 'image/jpeg')
+        assert_equal(r['id'], 'bfdaf2b3-7ec5-41f4-9caa-d53247dd9666')
+        assert_equal(r['project_id'], Resizing.configure.project_id)
+        assert_equal(r['content_type'], 'image/jpeg')
+        assert(!r['latest_version_id'].nil?)
+        assert(!r['latest_etag'].nil?)
+        assert(!r['created_at'].nil?)
+        assert(!r['updated_at'].nil?)
+        assert_equal(r['public_id'], '/projects/098a2a0d-c387-4135-a071-1254d6d7e70a/upload/images/bfdaf2b3-7ec5-41f4-9caa-d53247dd9666/vAyWaxx96gLaAzB9Bq.VbX1_pxfXJ0Jcq')
+      end
+    end
+
+    def test_that_it_putable_file
+      Resizing.configure = @configuration_template
+
+      client = Resizing::Client.new
+      VCR.use_cassette 'client/put' do
+        f = File.open('test/data/images/sample1.jpg', 'r')
+        name = 'AWEaewfAreaweFAFASfwe'
+        r = client.put(name, f, content_type: 'image/jpeg')
+        assert_equal(r['id'], name)
+        assert_equal(r['project_id'], Resizing.configure.project_id)
+        assert_equal(r['content_type'], 'image/jpeg')
+        assert(!r['latest_version_id'].nil?)
+        assert(!r['latest_etag'].nil?)
+        assert(!r['created_at'].nil?)
+        assert(!r['updated_at'].nil?)
+        assert_equal(
+          r['public_id'],
+          "/projects/098a2a0d-c387-4135-a071-1254d6d7e70a/upload/images/#{name}/v6Ew3HmDAYfb3NMRdLxR45i_gXMbLlGyi"
+        )
+      end
+    end
+  end
+end

data/test/resizing/configuration_test.rb

@@ -0,0 +1,128 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Resizing
+  class ConfigurationTest < Minitest::Test
+    def setup
+      @template = {
+        host: 'http://192.168.56.101:5000',
+        project_id: '098a2a0d-c387-4135-a071-1254d6d7e70a',
+        secret_token: '4g1cshg2lq8j93ufhvqrpjswxmtjz12yhfvq6w79jpwi7cr7nnknoqgwzkwerbs6',
+        open_timeout: 10,
+        response_timeout: 20
+      }.freeze
+    end
+
+    def teardown
+      # NOP
+    end
+
+    def test_that_it_has_default_host
+      template = @template.dup
+      template.delete(:host)
+      config = Resizing::Configuration.new template
+      assert_equal(config.host, Resizing::Configuration::DEFAULT_HOST)
+    end
+
+    def test_that_it_has_same_host_value
+      template = @template.dup
+      config = Resizing::Configuration.new template
+      assert_equal(config.host, template[:host])
+    end
+
+    def test_that_it_has_no_project_id
+      template = @template.dup
+      template.delete(:project_id)
+      assert_raises ConfigurationError do
+        Resizing::Configuration.new template
+      end
+    end
+
+    def test_that_it_has_same_project_id_value
+      template = @template.dup
+      config = Resizing::Configuration.new template
+      assert_equal(config.project_id, template[:project_id])
+    end
+
+    def test_that_it_has_no_secret_token
+      template = @template.dup
+      template.delete(:project_id)
+      assert_raises ConfigurationError do
+        Resizing::Configuration.new template
+      end
+    end
+
+    def test_that_it_has_same_secret_token_value
+      template = @template.dup
+      config = Resizing::Configuration.new template
+      assert_equal(config.secret_token, template[:secret_token])
+    end
+
+    def test_that_it_has_default_open_timeout
+      template = @template.dup
+      template.delete(:open_timeout)
+      config = Resizing::Configuration.new template
+      assert_equal(config.open_timeout, Resizing::Configuration::DEFAULT_OPEN_TIMEOUT)
+    end
+
+    def test_that_it_has_same_open_timeout
+      template = @template.dup
+      config = Resizing::Configuration.new template
+      assert_equal(config.open_timeout, template[:open_timeout])
+    end
+
+    def test_that_it_return_auth_header_token
+      Timecop.freeze(Time.parse('2020-05-29 05:40:00 +0900')) do
+        template = @template.dup
+        config = Resizing::Configuration.new template
+        assert_equal(
+          'v1,1590698400,2b35ee78cd6ce32edb9b4d97b69306c678ce8dea871638ff6144b7be0d26173c',
+          config.generate_auth_header
+        )
+      end
+    end
+
+    def test_that_it_return_image_url
+      template = @template.dup
+      image_id = 'some-image-id'
+      config = Resizing::Configuration.new template
+      assert_equal(
+        'http://192.168.56.101:5000/projects/098a2a0d-c387-4135-a071-1254d6d7e70a/upload/images/some-image-id',
+        config.generate_image_url(image_id)
+      )
+    end
+
+    def test_that_it_return_image_url_with_version_id
+      template = @template.dup
+      image_id = 'some-image-id'
+      version_id = 'version-id'
+      config = Resizing::Configuration.new template
+      assert_equal(
+        'http://192.168.56.101:5000/projects/098a2a0d-c387-4135-a071-1254d6d7e70a/upload/images/some-image-id/vversion-id',
+        config.generate_image_url(image_id, version_id)
+      )
+    end
+
+    def test_that_it_return_transformation_path
+      data = [
+        { args: { w: 100 }, path: 'w_100' },
+        { args: { h: 100 }, path: 'h_100' },
+        { args: { f: 'webp' }, path: 'f_webp' },
+        { args: { c: 'fill' }, path: 'c_fill' }
+      ]
+      config = Resizing::Configuration.new @template
+      data.each do |v|
+        assert_equal(
+          v[:path],
+          config.transformation_path(v[:args])
+        )
+      end
+    end
+
+    def test_that_it_generated_identifier_path
+      config = Resizing::Configuration.new @template
+      assert_match %r{/projects/#{config.project_id}/upload/images/[\da-z-]}, config.generate_identifier
+    end
+  end
+end