resizing 0.1.0 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46b4c727294bdd92f33e9fa5cf32ee2cd320987a1b2d65dccba240a5a776f0b4
-  data.tar.gz: c9c7b2a9b568c216804afb3f6108e9190644df0ed241eee73a600fe228982eca
+  metadata.gz: dc0185b74fd4488a798b0a5da33379e54b9d95081ac7e1160a3d6e41aadc306e
+  data.tar.gz: b21eaae81ea5fc991ddec3fdefca7d73ec35b9c008057407547552c045b12c22
 SHA512:
-  metadata.gz: d8fc3430aef73a2b20adbc4d6c649c62ff467944e03db06b977d1dc517205644573e5ab87eb891a3539ae9776e1f4adbb3b9fded9eb782b203c244892ad3e2be
-  data.tar.gz: e5f0122b6a5d06f04b55ef79f9da102f603cd397941135787ff1d121afedcbc4d18f6d72f472e4552daa7f11099c9dd493a175ef1763145c0828b72073d215b3
+  metadata.gz: 6e13ddf3fdb99165d35d73bd580fd45c316e93bc1e25769fc9cb7c6f28ed98dfdce57b22c15ee12dabbaeff27bc0156c3833adb79857853f41974ec0773b5ca5
+  data.tar.gz: e4b7d41e6b4e58fba560a73876913564c532101dc54c777ea994adf529fbc76088bb5ecd13f7dfa178fc198553abc504b8451b91141dc900b335737169438d13

data/lib/resizing/carrier_wave/storage/file.rb

@@ -33,7 +33,7 @@ module Resizing
           separted = Resizing.separate_public_id(public_id)
           image_id = separted[:image_id]
           resp = client.delete(image_id)
-          if resp.nil? # 404 not found
+          if resp['error'] == 'ActiveRecord::RecordNotFound' # 404 not found
             model.send :write_attribute, serialization_column, nil
             return
           end

data/lib/resizing/client.rb

@@ -28,6 +28,7 @@ module Resizing
     # to use standard constants
     HTTP_STATUS_OK = 200
     HTTP_STATUS_CREATED = 201
+    HTTP_STATUS_NOT_FOUND = 404
 
     attr_reader :config
     def initialize(*attrs)
@@ -58,7 +59,7 @@ module Resizing
         request.headers['X-ResizingToken'] = config.generate_auth_header
       end
 
-      result = handle_response(response)
+      result = handle_create_response(response)
       result
     end
 
@@ -76,7 +77,7 @@ module Resizing
         request.headers['X-ResizingToken'] = config.generate_auth_header
       end
 
-      result = handle_response(response)
+      result = handle_create_response(response)
       result
     end
 
@@ -87,7 +88,7 @@ module Resizing
         request.headers['X-ResizingToken'] = config.generate_auth_header
       end
 
-      result = handle_response(response)
+      result = handle_delete_response(response)
       result
     end
 
@@ -134,14 +135,25 @@ module Resizing
       raise ArgumentError, "need options[:content_type] for #{options.inspect}" unless options[:content_type]
     end
 
-    def handle_response(response)
+    def handle_create_response(response)
       raise APIError, "no response is returned" if response.nil?
 
       case response.status
       when HTTP_STATUS_OK, HTTP_STATUS_CREATED
         JSON.parse(response.body)
       else
-        raise APIError, "invalid http status code #{resp.status}"
+        raise APIError, "invalid http status code #{response.status}"
+      end
+    end
+
+    def handle_delete_response(response)
+      raise APIError, "no response is returned" if response.nil?
+
+      case response.status
+      when HTTP_STATUS_OK, HTTP_STATUS_CREATED, HTTP_STATUS_NOT_FOUND
+        JSON.parse(response.body)
+      else
+        raise APIError, "invalid http status code #{response.status}"
       end
     end
   end

data/lib/resizing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Resizing
-  VERSION = '0.1.0'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resizing
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.3
 platform: ruby
 authors:
 - Junichiro Kasuya
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-09 00:00:00.000000000 Z
+date: 2020-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday