research_metadata_announcement 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4e9c9fd7ba55dbdb831bf9fc25fc4c6df3785ba
-  data.tar.gz: 280d4111796b2ea9ad96b72076891027608bbac2
+  metadata.gz: bf0c1c8fc3b0e8d58f989fc77575708349146f54
+  data.tar.gz: 8ee85200f2fc1bfc3d16742a1c97ac9e75183e2b
 SHA512:
-  metadata.gz: 0599597e515308ad7183fddb3d59791fd596c25c5d02bb9dc1c2ec0487241618f957f72765bab6cf4dd293919b4eb77f40ae22913c844e763ee461f4f46cac00
-  data.tar.gz: 4ff2e913fb3b5621226d36b5c429be46fde5e3491df8dc275df97a8fe90ef09b71b5b02bbe0c9a6422898de5a0f45ba9fb584aa1f636479659fe83c6a07ef196
+  metadata.gz: 0951b8d89a3bbf596cfbace7aa7021c594bbc03bc383fa9b94d0830320224534f8f144480ca2d66d54d9ee60c775ce5465ce82bccb817c1dfaf08e558c1c85d2
+  data.tar.gz: 042f6d932f8366a8b1941aa0d1fd16104ebecb4b68f4dcfd06250bc10d9faf96597042721a84fa6442e705afa9f147d13e6156cdb36ef7009ae088acc09b90d2

data/CHANGELOG.md

@@ -2,6 +2,17 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 0.5.1 - 2018-01-17
+### Added
+- Testing announcements against known live data.
+
+### Fixed
+- Ellipsis after truncated title.
+
+### Changed
+- Cope with missing resolver in DOI.
+- Cope with full stop in title.
+
 ## 0.5.0 - 2018-01-11
 ### Changed
 - For Pure API 59.

data/README.md

@@ -84,7 +84,7 @@ transformer.transform id: 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'
 #=> "New journal article. Can poly-parameter linear-free energy relationships (pp-LFERs) improve modelling bioaccumulation in fish? #partitioncoefficients #pplfer. dx.doi.org/10.1016/j.chemosphere.2017.10.007."
 
 transformer.transform id: 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx', max_length: 140
-#=> "New journal article. The Parting of Burroughs and... #americancounterculture #arthurrimbaud. dx.doi.org/10.1179/1477570013Z.00000000045."
+#=> "New journal article. The Parting of Burroughs and Ker... #americancounterculture #arthurrimbaud. dx.doi.org/10.1179/1477570013Z.00000000045."
 
 transformer.transform id: 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx', composition: [:new, :title, :hashtags] # research output has no descriptors
 #=> "New conference paper. Deductive and inductive data collection for agent-based modelling."

data/lib/research_metadata_announcement/transformer/base.rb

@@ -29,7 +29,7 @@ module ResearchMetadataAnnouncement
         if composition.include? :uri
           return nil unless prepare_uri
         end
-        title = @resource.title
+        title = remove_full_stop @resource.title
         keywords = @resource.keywords
 
         # sizing
@@ -49,10 +49,16 @@ module ResearchMetadataAnnouncement
                 chars_needed += build_hashtags(keywords, max_descriptors).size + chars_component_end if !keywords.empty?
               when :uri
                 uri = prepare_uri
-                chars_needed += uri.size if uri
+                chars_needed += uri.size + chars_component_end if uri
             end
           end
 
+          # since the arrangement of the composition is unknown, after sizing
+          # chars_needed has two extra spaces allocated
+          # one is used for the terminating full stop
+          # one is not needed
+          chars_needed -= 1
+
           # determine if title needs truncating/removing before combining
           if chars_needed > max_length
             # truncate title
@@ -60,7 +66,7 @@ module ResearchMetadataAnnouncement
               excess_chars = chars_needed - max_length
               truncated_title_length = title.size - excess_chars
               truncated_title_length = 0 if truncated_title_length < 0
-              title = title[0..truncated_title_length - 2].strip + '..'
+              title = title[0..truncated_title_length - 3].strip + '..'
               composition -= [:title] if title.size <= 5 # give up on title if just too small
             end
           end
@@ -99,6 +105,15 @@ module ResearchMetadataAnnouncement
 
       private
 
+      def remove_full_stop(str)
+        arr = str.split('')
+        if arr.pop == '.' && arr.pop != '.'
+          return str.chomp('.')
+        else
+          return str
+        end
+      end
+
       def new_phrase(resource)
         part_1 = 'New'
         part_2 = ''
@@ -116,14 +131,21 @@ module ResearchMetadataAnnouncement
         end
       end
 
-      def prepare_uri
-        strip_uri_scheme @resource.doi if @resource && @resource.doi
-      end
-
       def strip_uri_scheme(uri)
         uri.sub %r{^.+//}, ''
       end
 
+      def prepare_uri
+        uri = strip_uri_scheme @resource.doi if @resource && @resource.doi
+        return unless uri
+        resolver = 'dx.doi.org'
+        if uri.include? resolver
+          uri
+        else
+          File.join resolver, uri
+        end
+      end
+
       def length_constrained?(max_length)
         max_length && max_length > 0
       end

data/lib/research_metadata_announcement/version.rb

@@ -1,5 +1,5 @@
 module ResearchMetadataAnnouncement
   # Semantic version number
   #
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: research_metadata_announcement
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Adrian Albin-Clark
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-11 00:00:00.000000000 Z
+date: 2018-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puree