rescue_like_a_pro 1.0.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 266decce14cac0ea24835fd8854a8309f6ecf48b5478dcbdf285699213be5983
-  data.tar.gz: 0c1de09f0a2d3299c1fd0f50cbc3e261ce4334d3eb0eec2dbfcf276f56d9b35e
+  metadata.gz: 730c804cff809632b9167826188f1f83860b31407439a36337459705c639afaf
+  data.tar.gz: 2fc56d9bf0be471f751c736f447f481f3ea81b89a39910013d4c51e010a09eeb
 SHA512:
-  metadata.gz: bce30af416ed66d867c0deeb20658ca78418311ce8c9d42bb834743cd11ea7a735b253e5db0e7df882eeb75ca2ef4199c3ffa4f15c58f4e91bea18ab338ab15d
-  data.tar.gz: 8cafb5c4db79a14c62a0a6c3a3bfa6c738ed38780bdda5041a88d47fa45b9458af44a21d4dc63f2c026089709e39a8ece18277b072484dab97b56068199fa1b7
+  metadata.gz: 865dcb84ce5050aceccb60d417033492d636377bf55b52f34c50271fdb7c6e6ceb1ec7acdbd47c25633b2629e9345470e8c79e3bd772ce58f673363b2bfeb24d
+  data.tar.gz: 7175c706b11ed3742cf359aae8cf1692640196a1b1407120cda0408c931d5b72ca2d190074496026214b2cdbef469b24bd33a37ddebf96a6f18955d65192dbca

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright 2022 thomas morgan
+Copyright 2022-2026 thomas morgan
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -23,8 +23,7 @@ RescueLikeAPro rethinks ActiveJob's exception handling system by:
 
   With ActiveJob's default exception handling, `DeserializationError`s will never be discarded by `SomeJob` because exceptions are processed from last to first. Since `DeserializationError` is a type of `StandardError`, `retry_on` will see it, reattempt 5 times, then trigger retries-exhausted--which in this case, without a block on `retry_on`, will bubble the error upward.
 
-  In contrast, RescueLikeAPro will recognize that `DeserializationError` is a more specific type of `StandardError` and will discard it immediately, while still retrying all other types of
-  `StandardError`s.
+  In contrast, RescueLikeAPro will recognize that `DeserializationError` is a subclass of `StandardError` and will discard it immediately, while still retrying all other types of `StandardError`s.
 
   Child classes may, of course, still redefine handling for an exception previously defined in a parent.
 
@@ -58,6 +57,12 @@ RescueLikeAPro rethinks ActiveJob's exception handling system by:
 
 * Jitter is applied to all retries. In contrast, ActiveJob skips jitter when `:wait` is a Proc.
 
+* ActionMailer::MailDeliveryJob is extended to allow for exception handlers, including retries, to be added to the job.
+
+  `ActionMailer::MailDeliveryJob` is the internal job used to deliver emails later with `SomeMailer.message.deliver_later`. By default, it only runs each Mailer's rescue_from handlers, bypassing any exception handlers (including retries) added to the job.
+
+  RescueLikeAPro changes this. Upon an exception, any rescue_from handlers on the Mailer will run first (using normal rescue_from rules). If no handler is found, or if the handler raises (or reraises) an exception, then the exception will be sent to the job's handlers.
+
 
 ### Example syntax
 
@@ -106,6 +111,7 @@ class ActiveJob::Base
   # on_discard{ ... }
   # on_retries_exhausted{ ... }
   # etc
+end
 ```
 
 Otherwise, to just modify all of your app's jobs, add instructions to `app/jobs/application_job.rb`.
@@ -113,6 +119,17 @@ Otherwise, to just modify all of your app's jobs, add instructions to `app/jobs/
 And of course, add any per-Job instructions directly to that job class.
 
 
+### ActionMailer::MailDeliveryJob
+
+MailDeliveryJob may warrant special attention. To make delayed mail deliveries retryable, add `retry_on` to either ActiveJob::Base or MailDeliveryJob.
+
+For example, again in an initializer:
+
+```ruby
+ActionMailer::MailDeliveryJob.retry_on IOError, SystemCallError, Timeout::Error, wait: 1.minute, attempts: 5
+```
+
+
 ## Installation
 
 As usual, add RescueLikeAPro to your Gemfile:

data/Rakefile

@@ -1,5 +1,8 @@
 require "bundler/setup"
 
+APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
+load "rails/tasks/engine.rake"
+
 require "bundler/gem_tasks"
 require "rake/testtask"
 

data/lib/rescue_like_a_pro/active_job.rb

@@ -86,7 +86,7 @@ module RescueLikeAPro::ActiveJob
 
   def determine_delay(seconds_or_duration_or_algorithm:, executions:, jitter: nil)
     case seconds_or_duration_or_algorithm
-    when :exponentially_longer
+    when :exponentially_longer, :polynomially_longer
       delay = executions**4
       delay_jitter = determine_jitter_for_delay(delay, jitter)
       delay + delay_jitter + 2

data/lib/rescue_like_a_pro/mail_delivery_job.rb

@@ -0,0 +1,10 @@
+module RescueLikeAPro::MailDeliveryJob
+  extend ActiveSupport::Concern
+
+  def handle_exception_with_mailer_class(exception)
+    super
+  rescue Exception
+    rescue_like_a_pro $!
+  end
+
+end

data/lib/rescue_like_a_pro/railtie.rb

@@ -5,5 +5,9 @@ module RescueLikeAPro
       prepend RescueLikeAPro::ActiveJob
     end
 
+    configure do
+      ActionMailer::MailDeliveryJob.prepend RescueLikeAPro::MailDeliveryJob
+    end
+
   end
 end

data/lib/rescue_like_a_pro/version.rb

@@ -1,3 +1,3 @@
 module RescueLikeAPro
-  VERSION = "1.0.1"
+  VERSION = '1.3.0'
 end

data/lib/rescue_like_a_pro.rb

@@ -1,7 +1,7 @@
 module RescueLikeAPro
 end
 
-%w(active_job version).each do |f|
+%w(active_job mail_delivery_job version).each do |f|
   require "rescue_like_a_pro/#{f}"
 end
 

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rescue_like_a_pro
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.3.0
 platform: ruby
 authors:
 - thomas morgan
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-01 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -80,6 +79,7 @@ files:
 - Rakefile
 - lib/rescue_like_a_pro.rb
 - lib/rescue_like_a_pro/active_job.rb
+- lib/rescue_like_a_pro/mail_delivery_job.rb
 - lib/rescue_like_a_pro/railtie.rb
 - lib/rescue_like_a_pro/version.rb
 homepage: https://github.com/zarqman/rescue_like_a_pro
@@ -89,7 +89,6 @@ metadata:
   homepage_uri: https://github.com/zarqman/rescue_like_a_pro
   source_code_uri: https://github.com/zarqman/rescue_like_a_pro
   changelog_uri: https://github.com/zarqman/rescue_like_a_pro/blob/master/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -104,8 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Improve ActiveJob exception handling with inheritance, fallback handlers,
   more jitter options, etc.