requires_approval 1.0.1 → 1.0.2

data/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

data/lib/requires_approval.rb

@@ -296,8 +296,14 @@ module RequiresApproval
     def set_up_version_delegates
       self.fields_requiring_approval.each do |f|
         define_method("#{f}=") do |val|
-          self.send("#{f}_will_change!")
-          self.latest_unapproved_version_with_nil_check.send("#{f}=", val)
+          # type cast our val so "0" changes to 'false'
+          type_casted_val = self.column_for_attribute(f).type_cast(val)
+          # make sure we don't already have this val in the approved
+          # version
+          unless type_casted_val == self.send(f)
+            self.send("#{f}_will_change!")
+            self.latest_unapproved_version_with_nil_check.send("#{f}=", val)
+          end
         end
       end
     end

data/requires_approval.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "requires_approval"
-  s.version = "1.0.1"
+  s.version = "1.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Dan Langevin"]
-  s.date = "2012-08-27"
+  s.date = "2012-10-02"
   s.description = "Gem to handle versioning and things that require approval"
   s.email = "dan.langevin@lifebooker.com"
   s.extra_rdoc_files = [

data/spec/lib/requires_approval_spec.rb

@@ -197,6 +197,28 @@ describe RequiresApproval do
 
     end
 
+    it "should not create new versions when attributes are not actually
+      updated" do
+
+      user = User.create(
+        :first_name => "Dan",
+        :last_name => "Langevin"
+      )
+      user.approve_all_attributes
+      user.reload
+
+      user.latest_unapproved_version.should be nil
+
+      user.update_attributes(
+        :first_name => user.first_name,
+        :last_name => user.last_name
+      )
+      user.reload
+      user.latest_unapproved_version.should be nil
+
+
+    end
+
   end
 
   context ".validates_approved_field" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: requires_approval
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-27 00:00:00.000000000 Z
+date: 2012-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2169692840 !ruby/object:Gem::Requirement
+  requirement: &2153934840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '3'
   type: :runtime
   prerelease: false
-  version_requirements: *2169692840
+  version_requirements: *2153934840
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2169692100 !ruby/object:Gem::Requirement
+  requirement: &2153933940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3'
   type: :runtime
   prerelease: false
-  version_requirements: *2169692100
+  version_requirements: *2153933940
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2169691300 !ruby/object:Gem::Requirement
+  requirement: &2153933280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169691300
+  version_requirements: *2153933280
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2169690220 !ruby/object:Gem::Requirement
+  requirement: &2153932400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169690220
+  version_requirements: *2153932400
 - !ruby/object:Gem::Dependency
   name: guard-bundler
-  requirement: &2169689620 !ruby/object:Gem::Requirement
+  requirement: &2153931680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169689620
+  version_requirements: *2153931680
 - !ruby/object:Gem::Dependency
   name: guard-spork
-  requirement: &2169688880 !ruby/object:Gem::Requirement
+  requirement: &2153930780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169688880
+  version_requirements: *2153930780
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2169687780 !ruby/object:Gem::Requirement
+  requirement: &2153929860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: 1.8.3
   type: :development
   prerelease: false
-  version_requirements: *2169687780
+  version_requirements: *2153929860
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &2169687160 !ruby/object:Gem::Requirement
+  requirement: &2153929100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169687160
+  version_requirements: *2153929100
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &2169674860 !ruby/object:Gem::Requirement
+  requirement: &2153928520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,10 +109,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169674860
+  version_requirements: *2153928520
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2169674240 !ruby/object:Gem::Requirement
+  requirement: &2153927900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -120,10 +120,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169674240
+  version_requirements: *2153927900
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &2169673400 !ruby/object:Gem::Requirement
+  requirement: &2153927340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169673400
+  version_requirements: *2153927340
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2169672520 !ruby/object:Gem::Requirement
+  requirement: &2153926620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169672520
+  version_requirements: *2153926620
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &2169671640 !ruby/object:Gem::Requirement
+  requirement: &2153925840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,7 +153,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2169671640
+  version_requirements: *2153925840
 description: Gem to handle versioning and things that require approval
 email: dan.langevin@lifebooker.com
 executables: []
@@ -193,7 +193,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2856595059415498144
+      hash: -4308162649724031230
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: