requires_approval 1.0.1 → 1.0.2

Sign up to get free protection for your applications and to get access to all the features.
data/VERSION CHANGED
@@ -1 +1 @@
1
- 1.0.1
1
+ 1.0.2
@@ -296,8 +296,14 @@ module RequiresApproval
296
296
  def set_up_version_delegates
297
297
  self.fields_requiring_approval.each do |f|
298
298
  define_method("#{f}=") do |val|
299
- self.send("#{f}_will_change!")
300
- self.latest_unapproved_version_with_nil_check.send("#{f}=", val)
299
+ # type cast our val so "0" changes to 'false'
300
+ type_casted_val = self.column_for_attribute(f).type_cast(val)
301
+ # make sure we don't already have this val in the approved
302
+ # version
303
+ unless type_casted_val == self.send(f)
304
+ self.send("#{f}_will_change!")
305
+ self.latest_unapproved_version_with_nil_check.send("#{f}=", val)
306
+ end
301
307
  end
302
308
  end
303
309
  end
@@ -5,11 +5,11 @@
5
5
 
6
6
  Gem::Specification.new do |s|
7
7
  s.name = "requires_approval"
8
- s.version = "1.0.1"
8
+ s.version = "1.0.2"
9
9
 
10
10
  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
11
11
  s.authors = ["Dan Langevin"]
12
- s.date = "2012-08-27"
12
+ s.date = "2012-10-02"
13
13
  s.description = "Gem to handle versioning and things that require approval"
14
14
  s.email = "dan.langevin@lifebooker.com"
15
15
  s.extra_rdoc_files = [
@@ -197,6 +197,28 @@ describe RequiresApproval do
197
197
 
198
198
  end
199
199
 
200
+ it "should not create new versions when attributes are not actually
201
+ updated" do
202
+
203
+ user = User.create(
204
+ :first_name => "Dan",
205
+ :last_name => "Langevin"
206
+ )
207
+ user.approve_all_attributes
208
+ user.reload
209
+
210
+ user.latest_unapproved_version.should be nil
211
+
212
+ user.update_attributes(
213
+ :first_name => user.first_name,
214
+ :last_name => user.last_name
215
+ )
216
+ user.reload
217
+ user.latest_unapproved_version.should be nil
218
+
219
+
220
+ end
221
+
200
222
  end
201
223
 
202
224
  context ".validates_approved_field" do
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: requires_approval
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.1
4
+ version: 1.0.2
5
5
  prerelease:
6
6
  platform: ruby
7
7
  authors:
@@ -9,11 +9,11 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2012-08-27 00:00:00.000000000 Z
12
+ date: 2012-10-02 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: activerecord
16
- requirement: &2169692840 !ruby/object:Gem::Requirement
16
+ requirement: &2153934840 !ruby/object:Gem::Requirement
17
17
  none: false
18
18
  requirements:
19
19
  - - ~>
@@ -21,10 +21,10 @@ dependencies:
21
21
  version: '3'
22
22
  type: :runtime
23
23
  prerelease: false
24
- version_requirements: *2169692840
24
+ version_requirements: *2153934840
25
25
  - !ruby/object:Gem::Dependency
26
26
  name: activesupport
27
- requirement: &2169692100 !ruby/object:Gem::Requirement
27
+ requirement: &2153933940 !ruby/object:Gem::Requirement
28
28
  none: false
29
29
  requirements:
30
30
  - - ~>
@@ -32,10 +32,10 @@ dependencies:
32
32
  version: '3'
33
33
  type: :runtime
34
34
  prerelease: false
35
- version_requirements: *2169692100
35
+ version_requirements: *2153933940
36
36
  - !ruby/object:Gem::Dependency
37
37
  name: bundler
38
- requirement: &2169691300 !ruby/object:Gem::Requirement
38
+ requirement: &2153933280 !ruby/object:Gem::Requirement
39
39
  none: false
40
40
  requirements:
41
41
  - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
43
43
  version: '0'
44
44
  type: :development
45
45
  prerelease: false
46
- version_requirements: *2169691300
46
+ version_requirements: *2153933280
47
47
  - !ruby/object:Gem::Dependency
48
48
  name: guard-rspec
49
- requirement: &2169690220 !ruby/object:Gem::Requirement
49
+ requirement: &2153932400 !ruby/object:Gem::Requirement
50
50
  none: false
51
51
  requirements:
52
52
  - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
54
54
  version: '0'
55
55
  type: :development
56
56
  prerelease: false
57
- version_requirements: *2169690220
57
+ version_requirements: *2153932400
58
58
  - !ruby/object:Gem::Dependency
59
59
  name: guard-bundler
60
- requirement: &2169689620 !ruby/object:Gem::Requirement
60
+ requirement: &2153931680 !ruby/object:Gem::Requirement
61
61
  none: false
62
62
  requirements:
63
63
  - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
65
65
  version: '0'
66
66
  type: :development
67
67
  prerelease: false
68
- version_requirements: *2169689620
68
+ version_requirements: *2153931680
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: guard-spork
71
- requirement: &2169688880 !ruby/object:Gem::Requirement
71
+ requirement: &2153930780 !ruby/object:Gem::Requirement
72
72
  none: false
73
73
  requirements:
74
74
  - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
76
76
  version: '0'
77
77
  type: :development
78
78
  prerelease: false
79
- version_requirements: *2169688880
79
+ version_requirements: *2153930780
80
80
  - !ruby/object:Gem::Dependency
81
81
  name: jeweler
82
- requirement: &2169687780 !ruby/object:Gem::Requirement
82
+ requirement: &2153929860 !ruby/object:Gem::Requirement
83
83
  none: false
84
84
  requirements:
85
85
  - - ~>
@@ -87,10 +87,10 @@ dependencies:
87
87
  version: 1.8.3
88
88
  type: :development
89
89
  prerelease: false
90
- version_requirements: *2169687780
90
+ version_requirements: *2153929860
91
91
  - !ruby/object:Gem::Dependency
92
92
  name: mocha
93
- requirement: &2169687160 !ruby/object:Gem::Requirement
93
+ requirement: &2153929100 !ruby/object:Gem::Requirement
94
94
  none: false
95
95
  requirements:
96
96
  - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
98
98
  version: '0'
99
99
  type: :development
100
100
  prerelease: false
101
- version_requirements: *2169687160
101
+ version_requirements: *2153929100
102
102
  - !ruby/object:Gem::Dependency
103
103
  name: rdoc
104
- requirement: &2169674860 !ruby/object:Gem::Requirement
104
+ requirement: &2153928520 !ruby/object:Gem::Requirement
105
105
  none: false
106
106
  requirements:
107
107
  - - ! '>='
@@ -109,10 +109,10 @@ dependencies:
109
109
  version: '0'
110
110
  type: :development
111
111
  prerelease: false
112
- version_requirements: *2169674860
112
+ version_requirements: *2153928520
113
113
  - !ruby/object:Gem::Dependency
114
114
  name: rspec
115
- requirement: &2169674240 !ruby/object:Gem::Requirement
115
+ requirement: &2153927900 !ruby/object:Gem::Requirement
116
116
  none: false
117
117
  requirements:
118
118
  - - ! '>='
@@ -120,10 +120,10 @@ dependencies:
120
120
  version: '0'
121
121
  type: :development
122
122
  prerelease: false
123
- version_requirements: *2169674240
123
+ version_requirements: *2153927900
124
124
  - !ruby/object:Gem::Dependency
125
125
  name: ruby-debug19
126
- requirement: &2169673400 !ruby/object:Gem::Requirement
126
+ requirement: &2153927340 !ruby/object:Gem::Requirement
127
127
  none: false
128
128
  requirements:
129
129
  - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
131
131
  version: '0'
132
132
  type: :development
133
133
  prerelease: false
134
- version_requirements: *2169673400
134
+ version_requirements: *2153927340
135
135
  - !ruby/object:Gem::Dependency
136
136
  name: sqlite3
137
- requirement: &2169672520 !ruby/object:Gem::Requirement
137
+ requirement: &2153926620 !ruby/object:Gem::Requirement
138
138
  none: false
139
139
  requirements:
140
140
  - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
142
142
  version: '0'
143
143
  type: :development
144
144
  prerelease: false
145
- version_requirements: *2169672520
145
+ version_requirements: *2153926620
146
146
  - !ruby/object:Gem::Dependency
147
147
  name: yard
148
- requirement: &2169671640 !ruby/object:Gem::Requirement
148
+ requirement: &2153925840 !ruby/object:Gem::Requirement
149
149
  none: false
150
150
  requirements:
151
151
  - - ! '>='
@@ -153,7 +153,7 @@ dependencies:
153
153
  version: '0'
154
154
  type: :development
155
155
  prerelease: false
156
- version_requirements: *2169671640
156
+ version_requirements: *2153925840
157
157
  description: Gem to handle versioning and things that require approval
158
158
  email: dan.langevin@lifebooker.com
159
159
  executables: []
@@ -193,7 +193,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
193
193
  version: '0'
194
194
  segments:
195
195
  - 0
196
- hash: -2856595059415498144
196
+ hash: -4308162649724031230
197
197
  required_rubygems_version: !ruby/object:Gem::Requirement
198
198
  none: false
199
199
  requirements: