request_recorder 0.3.0 → 0.3.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    request_recorder (0.3.0)
+    request_recorder (0.3.1)
       activerecord
       logcast (>= 0.1.4)
       multi_json

data/Readme.md

@@ -12,7 +12,7 @@ Add to your middleware stack:
     require "request_recorder/cache_logger"
     use RequestRecorder::Middleware,
       :store => RequestRecorder::CacheLogger.new(Rails.cache),
-      :frontend_auth => lambda { |env| Rails.env.development? } # TODO use something like `env.warden.user.is_admin?` in production
+      :frontend_auth => lambda { |env| Rails.env.development? } # TODO use something like `env.warden.user.is_admin?` in production, or return a [status, headers, body] array for custom failure message
       # if you get 502's because of too large headers, you can reduce them: everything in :remove will be removed when above :max
       # :headers => {:max => 10_000, :remove => [/Identity Map/, /Cache local read/, /Cache read/, /SELECT count(\*)/, /SELECT \* FROM/] }
 

data/gemfiles/rails2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/request_recorder
   specs:
-    request_recorder (0.2.4)
+    request_recorder (0.3.0)
       activerecord
       logcast (>= 0.1.4)
       multi_json
@@ -22,7 +22,7 @@ GEM
       redis (~> 3.0.0)
     json (1.7.7)
     logcast (0.1.4)
-    multi_json (1.7.2)
+    multi_json (1.7.3)
     rack (1.1.6)
     rake (10.0.4)
     redis (3.0.3)

data/gemfiles/rails3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/request_recorder
   specs:
-    request_recorder (0.2.4)
+    request_recorder (0.3.0)
       activerecord
       logcast (>= 0.1.4)
       multi_json

data/lib/request_recorder/middleware.rb

@@ -48,7 +48,9 @@ module RequestRecorder
           raise result # Do not mess up the apps normal exception behavior
         else
           path = [env["PATH_INFO"], env["QUERY_STRING"]].compact.join("?")
-          extra_headers = chrome_logger_headers(log, path) if @auth && @auth.call(env)
+          if @auth && auth = @auth.call(env)
+            extra_headers = chrome_logger_headers(log, path) unless auth.is_a?(Array)
+          end
           response_with_data_in_cookie(result, steps_left, id, extra_headers)
         end
       end
@@ -58,11 +60,15 @@ module RequestRecorder
 
     def render_frontend(env, key)
       if @auth
-        if @auth.call(env)
-          if log = @store.read(key)
-            [200, {}, Frontend.render(log)]
+        if response = @auth.call(env)
+          if response.is_a?(Array)
+            response
           else
-            [404, {}, "Did not find a log for key #{key}"]
+            if log = @store.read(key)
+              [200, {}, Frontend.render(log)]
+            else
+              [404, {}, "Did not find a log for key #{key}"]
+            end
           end
         else
           [401, {}, "Unauthorized"]

data/lib/request_recorder/version.rb

@@ -1,3 +1,3 @@
 module RequestRecorder
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/request_recorder_spec.rb

@@ -141,6 +141,12 @@ describe RequestRecorder do
       body.should_not include("yyy")
     end
 
+    it "returns custom auth failure response" do
+      status, headers, body = middleware.call("PATH_INFO" => "/request_recorder/xxx", "success" => [422, {}, "Barfoo"])
+      status.should == 422
+      body.should include("Barfoo")
+    end
+
     it "cannot view a missing log" do
       status, headers, body = middleware.call("PATH_INFO" => "/request_recorder/missing-key", "success" => true)
       status.should == 404
@@ -179,6 +185,11 @@ describe RequestRecorder do
         status, headers, body = middleware.call("QUERY_STRING" => "request_recorder=10-xxx")
         headers["X-ChromeLogger-Data"].should == nil
       end
+
+      it "does not log with array response from frontend_auth" do
+        status, headers, body = middleware.call("QUERY_STRING" => "request_recorder=10-xxx", "success" => [302, {}, "asdas"])
+        headers["X-ChromeLogger-Data"].should == nil
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request_recorder
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-25 00:00:00.000000000 Z
+date: 2013-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -119,7 +119,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1116155128447744450
+      hash: 480702955277085282
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -128,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1116155128447744450
+      hash: 480702955277085282
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25