request_recorder 0.2.3 → 0.2.4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    request_recorder (0.2.3)
+    request_recorder (0.2.4)
       activerecord
       multi_json
       rack

data/Readme.md

@@ -14,7 +14,7 @@ Add to your middleware stack:
       :store => RequestRecorder::CacheLogger.new(Rails.cache),
       :frontend_auth => lambda { |env| Rails.env.development? } # TODO use something like `env.warden.user.is_admin?` in production
       # if you get 502's because of too large headers, you can reduce them: everything in :remove will be removed when above :max
-      # :header => {:max => 10_000, :remove => [/SELECT count(\*)/, /SELECT \* FROM/, /Cache local read/, /Cache read/, /Identity Map/] }
+      # :headers => {:max => 10_000, :remove => [/Identity Map/, /Cache local read/, /Cache read/, /SELECT count(\*)/, /SELECT \* FROM/] }
 
 Usage
 =====

data/gemfiles/rails2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/request_recorder
   specs:
-    request_recorder (0.2.2)
+    request_recorder (0.2.3)
       activerecord
       multi_json
       rack

data/gemfiles/rails3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/request_recorder
   specs:
-    request_recorder (0.2.2)
+    request_recorder (0.2.3)
       activerecord
       multi_json
       rack

data/lib/request_recorder/middleware.rb

@@ -48,7 +48,8 @@ module RequestRecorder
         if result.is_a?(Exception)
           raise result # Do not mess up the apps normal exception behavior
         else
-          extra_headers = chrome_logger_headers(log) if @auth && @auth.call(env)
+          path = [env["PATH_INFO"], env["QUERY_STRING"]].compact.join("?")
+          extra_headers = chrome_logger_headers(log, path) if @auth && @auth.call(env)
           response_with_data_in_cookie(result, steps_left, id, extra_headers)
         end
       end
@@ -95,14 +96,14 @@ module RequestRecorder
       response.finish # finish writes out the response in the expected format.
     end
 
-    def chrome_logger_headers(log)
+    def chrome_logger_headers(log, path)
       log = log.split("\n").map { |line| remove_console_colors(line) }
       log = reduce_header_size(log) if @headers
 
 
       # fake chrome-logger format
       rows = []
-      rows << [["Rails log"],"xxx.rb:1","group"]
+      rows << [["Rails log #{path}"],"xxx.rb:1","group"]
       rows.concat log.map{|line| [line.split(" "), "xxx.rb:1", ""] }
       rows << [[], "xxx.rb:1", "groupEnd"]
 
@@ -128,8 +129,10 @@ module RequestRecorder
       removed_count = 0
       removed_match = []
 
+      unimportant = (@headers[:remove] || []).dup
+
       while array.sum(&:size) > size
-        if remove = (@headers[:remove] || []).pop
+        if remove = unimportant.shift
           removed_match << remove
           array.reject! { |line| line =~ remove }
         else

data/lib/request_recorder/version.rb

@@ -1,3 +1,3 @@
 module RequestRecorder
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/spec/request_recorder/middleware_spec.rb

@@ -17,5 +17,14 @@ describe RequestRecorder::Middleware do
         "a" * 40, "c" * 40, "Removed: all /b/"
       ]
     end
+
+    it "can remove multiple times" do
+      middleware.send(:reduce_header_size, ["a" * 40,"b"*40,"c" * 40]).should == [
+        "a" * 40, "c" * 40, "Removed: all /b/"
+      ]
+      middleware.send(:reduce_header_size, ["a" * 40,"b"*40,"c" * 40]).should == [
+        "a" * 40, "c" * 40, "Removed: all /b/"
+      ]
+    end
   end
 end

data/spec/request_recorder_spec.rb

@@ -187,7 +187,7 @@ describe RequestRecorder do
           "version"=>"0.1.1",
           "columns"=>["log", "backtrace", "type"],
           "rows"=>[
-            [["Rails log"], "xxx.rb:1", "group"],
+            [["Rails log request_recorder=10-xxx"], "xxx.rb:1", "group"],
             [["Car", "Load", "---"], "xxx.rb:1", ""],
             [[], "xxx.rb:1", "groupEnd"]
           ]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request_recorder
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
   prerelease: 
 platform: ruby
 authors:
@@ -104,7 +104,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 542393427719907215
+      hash: 2258445014574956169
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -113,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 542393427719907215
+      hash: 2258445014574956169
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25