request_recorder 0.0.2 → 0.0.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    request_recorder (0.0.2)
+    request_recorder (0.0.3)
       rack
 
 GEM

data/lib/request_recorder/middleware.rb

@@ -6,6 +6,7 @@ module RequestRecorder
   class Middleware
     MARKER = "__request_recording"
     MAX_STEPS = 100
+    SEPARATOR = "|"
 
     def initialize(app, options={})
       @app = app
@@ -39,7 +40,7 @@ module RequestRecorder
     def read_state_from_env(env)
       request = Rack::Request.new(env)
       if request.cookies[MARKER]
-        steps, id = request.cookies[MARKER].split(":")
+        steps, id = request.cookies[MARKER].split(SEPARATOR)
         [steps.to_i, id]
       else
         [env["QUERY_STRING"][/#{MARKER}=(\d+)/, 1].to_i, nil]
@@ -52,7 +53,7 @@ module RequestRecorder
       if to_go <= 1
         response.delete_cookie(MARKER)
       else
-        response.set_cookie(MARKER, {:value => "#{to_go.to_i - 1}:#{id}", :expires => Time.now+24*60*60, :httponly => true})
+        response.set_cookie(MARKER, {:value => "#{to_go.to_i - 1}#{SEPARATOR}#{id}", :expires => Time.now+24*60*60, :httponly => true})
       end
 
       response.finish # finish writes out the response in the expected format.

data/lib/request_recorder/redis_logger.rb

@@ -8,7 +8,7 @@ module RequestRecorder
 
     def write(id, text)
       old = (id ? @redis.hget(KEY, id) : "")
-      id = "#{Time.now.to_i}_#{Process.pid}" unless id
+      id = "#{Time.now.utc.strftime("%Y-%m-%d %H:%M:%S")}_#{Process.pid}" unless id
       @redis.hset(KEY, id, old.to_s + text)
       id
     end

data/lib/request_recorder/version.rb

@@ -1,3 +1,3 @@
 module RequestRecorder
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/request_recorder_spec.rb

@@ -41,12 +41,12 @@ describe RequestRecorder do
     it "sets cookie in first step" do
       status, headers, body = middleware.call(activate_logger)
       generated_id = stored.keys.last
-      headers["Set-Cookie"].should include "__request_recording=9%3A#{generated_id}; expires="
+      headers["Set-Cookie"].should include "__request_recording=9%7C#{generated_id.gsub(":", "%3A").gsub(" ", "+")}; expires="
       headers["Set-Cookie"].should include "; HttpOnly"
     end
 
     it "appends to existing log" do
-      middleware.call("HTTP_COOKIE" => "__request_recording=8:#{existing_request_id}")
+      middleware.call("HTTP_COOKIE" => "__request_recording=8|#{existing_request_id}")
       existing_request = redis.hget(redis_key, existing_request_id)
       existing_request.should include "SELECT"
       existing_request.should include "BEFORE"
@@ -55,19 +55,19 @@ describe RequestRecorder do
     it "creates a new log if redis dies" do
       existing_request_id # store key
       redis.flushall
-      middleware.call("HTTP_COOKIE" => "__request_recording=8:#{existing_request_id}")
+      middleware.call("HTTP_COOKIE" => "__request_recording=8|#{existing_request_id}")
       existing_request = redis.hget(redis_key, existing_request_id)
       existing_request.should include "SELECT"
       existing_request.should_not include "BEFORE"
     end
 
     it "decrements cookie on each step" do
-      status, headers, body = middleware.call("HTTP_COOKIE" => "__request_recording=2:#{existing_request_id};foo=bar")
-      headers["Set-Cookie"].should include "__request_recording=1%3A#{existing_request_id}; expires="
+      status, headers, body = middleware.call("HTTP_COOKIE" => "__request_recording=2|#{existing_request_id};foo=bar")
+      headers["Set-Cookie"].should include "__request_recording=1%7C#{existing_request_id}; expires="
     end
 
     it "removes cookie if final step is reached" do
-      status, headers, body = middleware.call("HTTP_COOKIE" => "__request_recording=1:#{existing_request_id};foo=bar")
+      status, headers, body = middleware.call("HTTP_COOKIE" => "__request_recording=1|#{existing_request_id};foo=bar")
       headers["Set-Cookie"].should include "__request_recording=; expires="
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request_recorder
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -60,7 +60,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3099537396771962597
+      hash: 4362379118001674709
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3099537396771962597
+      hash: 4362379118001674709
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24