request-replay 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0335c8c8c412eae553868c108b0d157521c76b0b
-  data.tar.gz: 393e2da293913de62fff4960b5e6fb12b70f6593
+  metadata.gz: 481cb39dcc322bbf56565497c32253602ac569f8
+  data.tar.gz: cf769c68314c369afe197eed38e2d624c010701b
 SHA512:
-  metadata.gz: 854270e4079d0737727d53e88f9ceabb836f16ecbbb6cbd7fde7a4400625ea999451c6931d7d1e406216f14cf83bb75cea257110d25657b861c0d4c3e5a03ada
-  data.tar.gz: dc452c780b57c25e28d763acccc48f3e0efa8d71472a772174bdac7ebd525e7af65f303b6d82e230037ef452cdb31585dd9148b7f7c088ec69869c84f4526cce
+  metadata.gz: e4800dd8b5e6a374b8f040302b402d38bb0e51e0f31d79238200bdb45adccc3f43aaecb3820035ff05544d97b2a1ac88326e8bff5a87f57eea18a29172bf5032
+  data.tar.gz: f3b2a8b62282e76ee189310020f2fe0cfe716fc0ec14bfef34390a9cfe4e4520459e6c6517432770b2ec2b0b6392a923bf759f3da64f4804da1b279eadcb6da0

data/CHANGES.md

@@ -1,5 +1,12 @@
 # CHANGES
 
+## request-replay 0.7.1 -- 2014-03-30
+
+* Add a default header: `Connection: close` for RequestReplay::Proxy since
+  we're not going to reuse the connection anyway. There's no way to return
+  the socket back to the web server after hijacking according to Rack's SPEC.
+  This should fix some weird issues with web pages with a lot of images.
+
 ## request-replay 0.7.0 -- 2014-03-30
 
 * Fixed a bug where nginx with sendfile on might not send a full file back.

data/README.md

@@ -14,7 +14,7 @@ Replay the request via Rack env
 
 ## REQUIREMENTS:
 
-* Tested with MRI (official CRuby) 1.9.3, 2.0.0, Rubinius and JRuby.
+* Tested with MRI (official CRuby), Rubinius and JRuby.
 
 ## INSTALLATION:
 

data/Rakefile

@@ -8,6 +8,6 @@ end
 
 Gemgem.init(dir) do |s|
   s.name    = 'request-replay'
-  s.version = '0.7.0'
+  s.version = '0.7.1'
   %w[bacon muack rack].each{ |g| s.add_development_dependency(g) }
 end

data/lib/request-replay/proxy.rb

@@ -4,17 +4,23 @@ require 'request-replay'
 class RequestReplay::Proxy
   def initialize host, options={}
     @host, @options = host, options
+    # since we're hijacking, we don't manage connections
+    (@options[:add_headers] ||= {})['Connection'] ||= 'close'
   end
 
   def call env
-    env['rack.hijack'].call
-    RequestReplay.new(rewrite_env(env), @host, @options).start do |sock|
-      IO.copy_stream(sock, env['rack.hijack_io'])
-      env['rack.hijack_io'].close
-    end
+    replay(rewrite_env(env), env['rack.hijack'].call)
     [200, {}, []]
   end
 
+  def replay env, io
+    RequestReplay.new(env, @host, @options).start do |sock|
+      IO.copy_stream(sock, io)
+    end
+  ensure
+    io.close
+  end
+
   def rewrite_env env
     if rewrite = @options[:rewrite_env]
       rewrite.call(env)

data/request-replay.gemspec

@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
-# stub: request-replay 0.7.0 ruby lib
+# stub: request-replay 0.7.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "request-replay"
-  s.version = "0.7.0"
+  s.version = "0.7.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]

data/test/test_proxy.rb

@@ -26,6 +26,7 @@ describe RequestReplay::Proxy do
 GET /?q=1 HTTP/1.1\r
 Host: localhost\r
 Pork: BEEF\r
+Connection: close\r
 \r
     HTTP
 
@@ -41,6 +42,7 @@ Pork: BEEF\r
 GET /?q=1 HTTP/1.1\r
 Host: ex.com\r
 Pork: BEEF\r
+Connection: close\r
 \r
     HTTP
 
@@ -56,6 +58,7 @@ Pork: BEEF\r
 GET /a?q=1 HTTP/1.1\r
 Host: localhost\r
 Pork: BEEF\r
+Connection: close\r
 \r
     HTTP
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request-replay
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Lin Jen-Shin (godfat)