request-replay 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 82468210714a1dd60ceadcd91e95752c0e85ce85
-  data.tar.gz: 906d7755d38d5a0748707068bc1f31d7c34beadb
+  metadata.gz: 16053b14d0f25a8a0a55a8416692f3a40438e06c
+  data.tar.gz: 8fb2ba84a1f33fbed931f0542cc692dfa96e932c
 SHA512:
-  metadata.gz: cf7b7b776083558e322f502a0de20cccf7dc51e4cd14f0be2a8eddfd8316fe3748add3a749ac336f50567e6c33755da185b8a2bd52618d2ef706a521f9f691e3
-  data.tar.gz: f61d88e1673fb50cc512e87b8702dc2ddeb51bf6e7976a90ecf3982033c1f243d477299eb5fe1b4db6dc199da29f773091af90dcaf39262d367cf1eabd5cc17b
+  metadata.gz: 1608f535929798711724cc4c8a5b0ef2aea2294085226d472f9bf27295a06de5385817e0a0cd349bee0fb1bd4a49b0ed98fb2d963d77bb639c35e7fbf47ca4e5
+  data.tar.gz: 9a5826abe20eccc9b24827e2df6065fad4b573cec50c4a08186626fb2a55faf4bc63e91b9140a090413606831abb7b7ec2b8b62a2a2a72560469ffb5e8b92238

data/CHANGES.md

@@ -1,5 +1,11 @@
 # CHANGES
 
+## request-replay 0.6.3 -- 2013-10-07
+
+* Fixed an issue where Rack::Request does not try to rewind rack.input for
+  form POST. We rewind for them. Thanks @yyjim
+* Extracted more constants. Might boost performance a bit.
+
 ## request-replay 0.6.2 -- 2013-10-01
 
 * Added :rewrite_env option for rewriting env for specific use.

data/README.md

@@ -45,6 +45,7 @@ run lambda{ |env| [200, {}, [env.inspect]] }
 
 ## CONTRIBUTORS:
 
+* Jim Wang (@yyjim)
 * Lin Jen-Shin (@godfat)
 
 ## LICENSE:

data/Rakefile

@@ -8,6 +8,6 @@ end
 
 Gemgem.init(dir) do |s|
   s.name    = 'request-replay'
-  s.version = '0.6.2'
+  s.version = '0.6.3'
   %w[bacon muack rack].each{ |g| s.add_development_dependency(g) }
 end

data/lib/request-replay.rb

@@ -5,9 +5,17 @@ require 'stringio'
 class RequestReplay
   autoload :Middleware, 'request-replay/middleware'
 
-  NEWLINE      = "\r\n"
-  HTTP_VERSION = 'HTTP/1.1'
-  RACK_INPUT   = 'rack.input'
+  NEWLINE        = "\r\n"          .freeze
+  HTTP_VERSION   = 'HTTP/1.1'      .freeze
+  RACK_INPUT     = 'rack.input'    .freeze
+  RACK_ERRORS    = 'rack.errors'   .freeze
+  REQUEST_METHOD = 'REQUEST_METHOD'.freeze
+  PATH_INFO      = 'PATH_INFO'     .freeze
+  QUERY_STRING   = 'QUERY_STRING'  .freeze
+  CONTENT_TYPE   = 'CONTENT_TYPE'  .freeze
+  CONTENT_LENGTH = 'CONTENT_LENGTH'.freeze
+  HEADER_CTYPE   = 'Content-Type'  .freeze
+  HEADER_CLENGTH = 'Content-Length'.freeze
 
   def initialize env, host, options={}
     @env, (@host, @port), @options = env, host.split(':', 2), options
@@ -16,6 +24,7 @@ class RequestReplay
       @buf = StringIO.new
       IO.copy_stream(env[RACK_INPUT], @buf)
       @buf.rewind
+      env[RACK_INPUT].rewind
     end
   end
 
@@ -35,8 +44,8 @@ class RequestReplay
     IO.select([sock], [], [], read_wait) if read_wait
     yield(sock) if block_given?
   rescue => e
-    @env['rack.errors'].puts("[#{self.class.name}] Error: #{e.inspect}") if
-      @env['rack.errors']
+    @env[RACK_ERRORS].puts("[#{self.class.name}] Error: #{e.inspect}") if
+      @env[RACK_ERRORS]
   ensure
     sock.close
   end
@@ -55,7 +64,7 @@ class RequestReplay
   end
 
   def request
-    "#{@env['REQUEST_METHOD'] || 'GET'} #{request_path} #{HTTP_VERSION}"
+    "#{@env[REQUEST_METHOD] || 'GET'} #{request_path} #{HTTP_VERSION}"
   end
 
   def headers
@@ -63,7 +72,7 @@ class RequestReplay
   end
 
   def request_path
-    "/#{@env['PATH_INFO']}?#{@env['QUERY_STRING']}".
+    "/#{@env[PATH_INFO]}?#{@env[QUERY_STRING]}".
       sub(%r{^//}, '/').sub(/\?$/, '')
   end
 
@@ -72,8 +81,8 @@ class RequestReplay
       @env.inject({}){ |r, (k, v)|
         r[capitalize_headers(k[5..-1])] = v if k.start_with?('HTTP_')
         r
-      }.merge('Content-Type'   => @env['CONTENT_TYPE'  ],
-              'Content-Length' => @env['CONTENT_LENGTH']).
+      }.merge(HEADER_CTYPE   => @env[CONTENT_TYPE  ],
+              HEADER_CLENGTH => @env[CONTENT_LENGTH]).
         merge(add_headers).select{ |_, v| v }
   end
 

data/request-replay.gemspec

@@ -1,13 +1,13 @@
 # -*- encoding: utf-8 -*-
-# stub: request-replay 0.6.2 ruby lib
+# stub: request-replay 0.6.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "request-replay"
-  s.version = "0.6.2"
+  s.version = "0.6.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Lin Jen-Shin (godfat)"]
-  s.date = "2013-10-01"
+  s.date = "2013-10-07"
   s.description = "Replay the request via Rack env"
   s.email = ["godfat (XD) godfat.org"]
   s.files = [

data/test/test_basic.rb

@@ -95,6 +95,15 @@ Pork: BEEF\r
     errors.string.should.start_with? '[RequestReplay] Error:'
   end
 
+  should 'not affect Rack::Request' do
+    input = StringIO.new('a=0&b=1')
+    e     = {'rack.input' => input, 'REQUEST_METHOD' => 'POST'}
+    t     = request[e]
+    serv.accept.close
+    t.join
+    Rack::Request.new(e).POST.should.eq('a' => '0', 'b' => '1')
+  end
+
   describe RequestReplay::Middleware do
     should 'PUT' do
       app = Rack::Builder.app do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: request-replay
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Lin Jen-Shin (godfat)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-01 00:00:00.000000000 Z
+date: 2013-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bacon