request-log-analyzer 1.12.7 → 1.12.8

data/lib/request_log_analyzer/file_format/rails3.rb

@@ -13,18 +13,18 @@ module RequestLogAnalyzer::FileFormat
       line.header = true
       line.teaser = /Started /
       line.regexp = /Started ([A-Z]+) "([^"]+)" for (#{ip_address}) at (#{timestamp('%a %b %d %H:%M:%S %z %Y')}|#{timestamp('%Y-%m-%d %H:%M:%S %z')})/
-      
+
       line.capture(:method)
       line.capture(:path)
       line.capture(:ip)
       line.capture(:timestamp).as(:timestamp)
     end
-    
+
     # Processing by QueriesController#index as HTML
     line_definition :processing do |line|
       line.teaser = /Processing by /
       line.regexp = /Processing by ([A-Za-z0-9\-:]+)\#(\w+) as ([\w\/\*]*)/
-      
+
       line.capture(:controller)
       line.capture(:action)
       line.capture(:format)
@@ -36,7 +36,7 @@ module RequestLogAnalyzer::FileFormat
       line.regexp = / Parameters:\s+(\{.*\})/
       line.capture(:params).as(:eval)
     end
-    
+
     # Completed 200 OK in 224ms (Views: 200.2ms | ActiveRecord: 3.4ms)
     # Completed 302 Found in 23ms
     # Completed in 189ms
@@ -44,13 +44,21 @@ module RequestLogAnalyzer::FileFormat
       line.footer = true
       line.teaser = /Completed /
       line.regexp = /Completed (\d+)? .*in (\d+(?:\.\d+)?)ms(?:[^\(]*\(Views: (\d+(?:\.\d+)?)ms .* ActiveRecord: (\d+(?:\.\d+)?)ms.*\))?/
-      
+
       line.capture(:status).as(:integer)
       line.capture(:duration).as(:duration, :unit => :msec)
       line.capture(:view).as(:duration, :unit => :msec)
       line.capture(:db).as(:duration, :unit => :msec)
     end
-    
+
+    # ActionController::RoutingError (No route matches [GET] "/missing_stuff"):
+    line_definition :routing_errors do |line|
+      line.teaser = /RoutingError/
+      line.regexp = /No route matches \[([A-Z]+)\] "([^"]+)"/
+      line.capture(:missing_resource_method).as(:string)
+      line.capture(:missing_resource).as(:string)
+    end
+
     # ActionView::Template::Error (undefined local variable or method `field' for #<Class>) on line #3 of /Users/willem/Code/warehouse/app/views/queries/execute.csv.erb:
     line_definition :failure do |line|
       line.footer = true
@@ -77,29 +85,32 @@ module RequestLogAnalyzer::FileFormat
     # Rendered collection (0.0ms)
 
     REQUEST_CATEGORIZER = lambda { |request| "#{request[:controller]}##{request[:action]}.#{request[:format]}" }
-    
+
     report do |analyze|
-      
+
       analyze.timespan
       analyze.hourly_spread
-      
+
       analyze.frequency :category => REQUEST_CATEGORIZER, :title => 'Most requested'
       analyze.frequency :method, :title => 'HTTP methods'
       analyze.frequency :status, :title => 'HTTP statuses returned'
-      
+
       analyze.duration :duration, :category => REQUEST_CATEGORIZER, :title => "Request duration", :line_type => :completed
       analyze.duration :partial_duration, :category => :rendered_file, :title => 'Partials rendering time', :line_type => :rendered
       analyze.duration :view, :category => REQUEST_CATEGORIZER, :title => "View rendering time", :line_type => :completed
       analyze.duration :db, :category => REQUEST_CATEGORIZER, :title => "Database time", :line_type => :completed
-      
+
       analyze.frequency :category => REQUEST_CATEGORIZER, :title => 'Process blockers (> 1 sec duration)',
         :if => lambda { |request| request[:duration] && request[:duration] > 1.0 }
+
+      analyze.frequency :category => lambda{|x| "[#{x[:missing_resource_method]}] #{x[:missing_resource]}"},
+        :title => "Routing Errors", :if => lambda{ |request| !request[:missing_resource].nil? }
     end
-    
+
     class Request < RequestLogAnalyzer::Request
       # Used to handle conversion of abbrev. month name to a digit
       MONTHS = %w(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec)
-      
+
       def convert_timestamp(value, definition)
         # the time value can be in 2 formats:
         # - 2010-10-26 02:27:15 +0000 (ruby 1.9.2)

data/lib/request_log_analyzer.rb

@@ -11,7 +11,7 @@ module RequestLogAnalyzer
   
   # The current version of request-log-analyzer.
   # Do not change the value by hand; it will be updated automatically by the gem release script.
-  VERSION = "1.12.7"
+  VERSION = "1.12.8"
 
   # Convert a string/symbol in camelcase ({RequestLogAnalyzer::Controller}) to underscores 
   # (<tt>request_log_analyzer/controller</tt>). This function can be used to load the file (using 

data/request-log-analyzer.gemspec

@@ -2,8 +2,8 @@ Gem::Specification.new do |s|
   s.name    = "request-log-analyzer"
   
   # Do not set the version and date field manually, this is done by the release script
-  s.version = "1.12.7"
-  s.date    = "2013-01-02"
+  s.version = "1.12.8"
+  s.date    = "2013-01-22"
 
   s.rubyforge_project = 'r-l-a'
 

data/spec/unit/file_format/rails3_format_spec.rb

@@ -3,24 +3,24 @@ require 'spec_helper'
 describe RequestLogAnalyzer::FileFormat::Rails3 do
 
   subject { RequestLogAnalyzer::FileFormat.load(:rails3) }
-  
+
   it { should be_well_formed }
-  it { should have(10).report_trackers }
-  
+  it { should have(11).report_trackers }
+
   describe '#parse_line' do
 
     it "should parse :started lines correctly" do
       line = 'Started GET "/queries" for 127.0.0.1 at Thu Feb 25 16:15:18 -0800 2010'
-      subject.should parse_line(line).as(:started).and_capture(:method => 'GET', 
+      subject.should parse_line(line).as(:started).and_capture(:method => 'GET',
             :path => '/queries', :ip => '127.0.0.1', :timestamp => 20100225161518)
     end
-    
+
     it "should parse :started lines in Oct, Nov and Dec correctly" do
       line = 'Started GET "/queries" for 127.0.0.1 at Thu Oct 25 16:15:18 -0800 2010'
       subject.should parse_line(line).as(:started).and_capture(:method => 'GET',
             :path => '/queries', :ip => '127.0.0.1', :timestamp => 20101025161518)
     end
-    
+
     it "should parse :started lines in Ruby 1.9.2 format correctly" do
       line = 'Started GET "/queries" for 127.0.0.1 at 2010-10-26 02:27:15 +0000'
       subject.should parse_line(line).as(:started).and_capture(:method => 'GET',
@@ -32,13 +32,13 @@ describe RequestLogAnalyzer::FileFormat::Rails3 do
       subject.should parse_line(line).as(:processing).and_capture(
         :controller => 'QueriesController', :action => 'index', :format => 'HTML')
     end
-    
+
     it "should parse nested :processing lines correctly" do
       line = ' Processing by Projects::QueriesController#index as HTML'
       subject.should parse_line(line).as(:processing).and_capture(
         :controller => 'Projects::QueriesController', :action => 'index', :format => 'HTML')
     end
-    
+
     it "should parse :processing lines correctly with format */*" do
       line = '  Processing by ProjectsController#avatar as */*'
       subject.should parse_line(line).as(:processing).and_capture(
@@ -55,30 +55,35 @@ describe RequestLogAnalyzer::FileFormat::Rails3 do
       line = '  Parameters: {"action"=>"cached", "controller"=>"cached"}'
       subject.should parse_line(line).as(:parameters).and_capture(:params => {:action => 'cached', :controller => 'cached'})
     end
-    
+
     it "should parse :completed lines correctly" do
       line = 'Completed 200 OK in 170ms (Views: 78.0ms | ActiveRecord: 48.2ms)'
       subject.should parse_line(line).as(:completed).and_capture(
           :duration => 0.170, :view => 0.078, :db => 0.0482, :status => 200)
     end
-    
+
     it "should parse :completed lines correctly when ActiveRecord is not mentioned" do
       line = 'Completed 200 OK in 364ms (Views: 31.4ms)'
       subject.should parse_line(line).as(:completed).and_capture(:duration => 0.364, :status => 200)
     end
-    
+
     it "should parse :completed lines correctly when other durations are specified" do
       line = 'Completed 200 OK in 384ms (Views: 222.0ms | ActiveRecord: 121.0ms | Sphinx: 0.0ms)'
-      subject.should parse_line(line).as(:completed).and_capture(:duration => 0.384, :view => 0.222, 
+      subject.should parse_line(line).as(:completed).and_capture(:duration => 0.384, :view => 0.222,
           :db => 0.121, :status => 200)
     end
-    
 
-    it "should pase :failure lines correctly" do
+    it "should parse :routing_error lines correctly" do
+      line = "ActionController::RoutingError (No route matches [GET] \"/static/faq\"):"
+      subject.should parse_line(line).as(:routing_errors).and_capture(:missing_resource_method => "GET",
+          :missing_resource  => '/static/faq')
+    end
+
+    it "should parse :failure lines correctly" do
       line = "ActionView::Template::Error (undefined local variable or method `field' for #<Class>) on line #3 of /Users/willem/Code/warehouse/app/views/queries/execute.csv.erb:"
-      subject.should parse_line(line).as(:failure).and_capture(:line => 3, 
-          :error   => 'ActionView::Template::Error', 
-          :message => "undefined local variable or method `field' for #<Class>", 
+      subject.should parse_line(line).as(:failure).and_capture(:line => 3,
+          :error   => 'ActionView::Template::Error',
+          :message => "undefined local variable or method `field' for #<Class>",
           :file    => '/Users/willem/Code/warehouse/app/views/queries/execute.csv.erb')
     end
 
@@ -87,7 +92,7 @@ describe RequestLogAnalyzer::FileFormat::Rails3 do
       subject.should parse_line(line).as(:rendered).and_capture(:partial_duration => [0.0006])
     end
   end
-  
+
   describe '#parse_io' do
     let(:log_parser) { RequestLogAnalyzer::Source::LogParser.new(subject) }
 
@@ -100,7 +105,7 @@ describe RequestLogAnalyzer::FileFormat::Rails3 do
         Rendered queries/index.html.erb within layouts/default (40.9ms)
         Completed 200 OK in 170ms (Views: 78.4ms | ActiveRecord: 48.2ms)
       EOLOG
-      
+
       log_parser.should_receive(:handle_request).once
       log_parser.should_not_receive(:warn)
       log_parser.parse_string(log)
@@ -118,22 +123,6 @@ describe RequestLogAnalyzer::FileFormat::Rails3 do
       log_parser.parse_string(log)
     end
 
-    it "should parse an unroutable request correctly" do
-      log = <<-EOLOG
-        Started GET "/404" for 127.0.0.1 at Fri Mar 19 06:40:57 -0700 2010
-
-        ActionController::RoutingError (No route matches "/404"):
-
-
-        Rendered /Users/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/routing_error.erb within rescues/layout (1.0ms)
-      
-      EOLOG
-
-      log_parser.should_receive(:handle_request).once
-      log_parser.should_receive(:warn).once
-      log_parser.parse_string(log)
-    end
-
     it "should parse a failing request correctly" do
       log = <<-EOLOG
         Started POST "/queries/397638749/execute.csv" for 127.0.0.1 at Mon Mar 01 18:44:33 -0800 2010

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request-log-analyzer
 version: !ruby/object:Gem::Version
-  version: 1.12.7
+  version: 1.12.8
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-02 00:00:00.000000000 Z
+date: 2013-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake