representable 3.2.0 → 3.3.0

data/test/class_test.rb

@@ -1,7 +1,6 @@
-require 'test_helper'
+require "test_helper"
 
 class ClassTest < BaseTest
-
   class RepresentingSong
     attr_reader :name
 
@@ -12,7 +11,6 @@ class ClassTest < BaseTest
     end
   end
 
-
   describe "class: ClassName, only" do
     representer! do
       property :song, :class => RepresentingSong # supposed this class exposes #from_hash itself.
@@ -25,10 +23,9 @@ class ClassTest < BaseTest
     end
   end
 
-
   describe "class: lambda, only" do
     representer! do
-      property :song, :class => lambda { |*| RepresentingSong }
+      property :song, :class => ->(*) { RepresentingSong }
     end
 
     it "creates fresh instance and doesn't extend" do
@@ -38,11 +35,10 @@ class ClassTest < BaseTest
     end
   end
 
-
   # this throws a DeserializationError now.
   describe "lambda { nil }" do
     representer! do
-      property :title, :class  => nil
+      property :title, :class => nil
     end
 
     it do
@@ -52,54 +48,71 @@ class ClassTest < BaseTest
     end
   end
 
-
   describe "lambda receiving fragment and args" do
-    let(:klass) { Class.new do
-      class << self
-        attr_accessor :args
-      end
+    let(:klass) do
+      Class.new do
+        class << self
+          attr_accessor :args
+        end
 
-      def from_hash(*)
-        self.class.new
+        def from_hash(*)
+          self.class.new
+        end
       end
-    end }
+    end
 
     representer!(:inject => :klass) do
       _klass = klass
-      property :song, :class => lambda { |options| _klass.args=([options[:fragment],options[:user_options]]); _klass }
+      property :song, :class => ->(options) { _klass.args = ([options[:fragment], options[:user_options]]); _klass }
     end
 
-    it { _(representer.prepare(OpenStruct.new).from_hash({"song" => {"name" => "Captured"}}, user_options: {volume: true}).song.class.args).
-      must_equal([{"name"=>"Captured"}, {:volume=>true}]) }
+    it {
+      _(
+        representer.prepare(OpenStruct.new).from_hash(
+          {"song" => {"name" => "Captured"}},
+          user_options: {volume: true}
+        ).song.class.args
+      )
+        .must_equal([{"name"=>"Captured"}, {:volume=>true}])
+    }
   end
 
-
   describe "collection: lambda receiving fragment and args" do
-    let(:klass) { Class.new do
-      class << self
-        attr_accessor :args
-      end
+    let(:klass) do
+      Class.new do
+        class << self
+          attr_accessor :args
+        end
 
-      def from_hash(*)
-        self.class.new
+        def from_hash(*)
+          self.class.new
+        end
       end
-    end }
+    end
 
     representer!(:inject => :klass) do
       _klass = klass
-      collection :songs, :class => lambda { |options| _klass.args=([options[:fragment],options[:index],options[:user_options]]); _klass }
+      collection :songs, class: ->(options) {
+                                  _klass.args = ([options[:fragment], options[:index], options[:user_options]]); _klass
+                                }
     end
 
-    it { _(representer.prepare(OpenStruct.new).from_hash({"songs" => [{"name" => "Captured"}]}, user_options: {volume: true}).songs.first.class.args).
-      must_equal([{"name"=>"Captured"}, 0, {:volume=>true}]) }
+    it {
+      _(
+        representer.prepare(OpenStruct.new).from_hash(
+          {"songs" => [{"name" => "Captured"}]},
+          user_options: {volume: true}
+        ).songs.first.class.args
+      )
+        .must_equal([{"name"=>"Captured"}, 0, {:volume=>true}])
+    }
   end
 
-
   describe "class: implementing #from_hash" do
     let(:parser) do
       Class.new do
         def from_hash(*)
-          [1,2,3,4]
+          [1, 2, 3, 4]
         end
       end
     end
@@ -109,11 +122,11 @@ class ClassTest < BaseTest
     end
 
     it "allows returning arbitrary objects in #from_hash" do
-      _(representer.prepare(OpenStruct.new).from_hash({"song" => 1}).song).must_equal [1,2,3,4]
+      _(representer.prepare(OpenStruct.new).from_hash({"song" => 1}).song).must_equal [1, 2, 3, 4]
     end
   end
 end
 
-#TODO: test fragment,
+# TODO: test fragment,
 
 # `class: Song` only, no :extend.

data/test/coercion_test.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'test_helper'
-require 'representable/coercion'
+require "test_helper"
+require "representable/coercion"
 
-class CoercionTest < MiniTest::Spec
+class CoercionTest < Minitest::Spec
   representer! do
     include Representable::Coercion
 
@@ -20,25 +20,35 @@ class CoercionTest < MiniTest::Spec
   end
 
   let(:album) do
-    OpenStruct.new(title: 'Dire Straits', length: 41.34,
-                   band: OpenStruct.new(founded: '1977'),
-                   songs: [OpenStruct.new(ok: 1), OpenStruct.new(ok: 0)])
+    OpenStruct.new(
+      title: "Dire Straits", length: 41.34,
+      band: OpenStruct.new(founded: "1977"),
+      songs: [OpenStruct.new(ok: 1), OpenStruct.new(ok: 0)]
+    )
   end
 
   it do
-    _(album.extend(representer).to_hash).must_equal({ 'title' => 'Dire Straits',
-                                                      'length' => 41.34,
-                                                      'band' => { 'founded' => 1977 },
-                                                      'songs' => [{ 'ok' => true }, { 'ok' => false }] })
+    _(album.extend(representer).to_hash).must_equal(
+      {
+        "title"  => "Dire Straits",
+        "length" => 41.34,
+        "band"   => {"founded" => 1977},
+        "songs"  => [{"ok" => true}, {"ok" => false}]
+      }
+    )
   end
 
   it {
     album = OpenStruct.new
     album.extend(representer)
-    album.from_hash({ 'title' => 'Dire Straits',
-                      'length' => '41.34',
-                      'band' => { 'founded' => '1977' },
-                      'songs' => [{ 'ok' => 1 }, { 'ok' => 0 }] })
+    album.from_hash(
+      {
+        "title"  => "Dire Straits",
+        "length" => "41.34",
+        "band"   => {"founded" => "1977"},
+        "songs"  => [{"ok" => 1}, {"ok" => 0}]
+      }
+    )
 
     # it
     _(album.length).must_equal 41.34
@@ -46,18 +56,18 @@ class CoercionTest < MiniTest::Spec
     _(album.songs[0].ok).must_equal true
   }
 
-  describe 'with user :parse_filter and :render_filter' do
+  describe "with user :parse_filter and :render_filter" do
     representer! do
       include Representable::Coercion
 
-      property :length, type: Representable::Coercion::Types::Params::Float,
-                        parse_filter: ->(input, _options) { "#{input}.1" }, # happens BEFORE coercer.
+      property :length, type:          Representable::Coercion::Types::Params::Float,
+                        parse_filter:  ->(input, _options) { "#{input}.1" }, # happens BEFORE coercer.
                         render_filter: ->(fragment, *) { "#{fragment}.1" }
     end
 
     # user's :parse_filter(s) are run before coercion.
-    it { _(OpenStruct.new.extend(representer).from_hash('length' => '1').length).must_equal 1.1 }
+    it { _(OpenStruct.new.extend(representer).from_hash("length" => "1").length).must_equal 1.1 }
     # user's :render_filter(s) are run before coercion.
-    it { _(OpenStruct.new(length: 1).extend(representer).to_hash).must_equal({ 'length' => 1.1 }) }
+    it { _(OpenStruct.new(length: 1).extend(representer).to_hash).must_equal({"length" => 1.1}) }
   end
 end

data/test/config/inherit_test.rb

@@ -1,8 +1,8 @@
-require 'test_helper'
+require "test_helper"
 
 # tests defining representers in modules, decorators and classes and the inheritance when combined.
 
-class ConfigInheritTest < MiniTest::Spec
+class ConfigInheritTest < Minitest::Spec
   def assert_cloned(child, parent, property)
     child_def  = child.representable_attrs.get(property)
     parent_def = parent.representable_attrs.get(property)
@@ -20,7 +20,6 @@ class ConfigInheritTest < MiniTest::Spec
     property :genre
   end
 
-
   # in Decorator ------------------------------------------------
   class Decorator < Representable::Decorator
     include Representable::Hash
@@ -30,7 +29,7 @@ class ConfigInheritTest < MiniTest::Spec
     end
   end
 
-  it { _(Decorator.definitions.keys).must_equal ["title", "artist"] }
+  it { _(Decorator.definitions.keys).must_equal %w[title artist] }
 
   # in inheriting Decorator
 
@@ -38,7 +37,7 @@ class ConfigInheritTest < MiniTest::Spec
     property :location
   end
 
-  it { _(InheritingDecorator.definitions.keys).must_equal ["title", "artist", "location"] }
+  it { _(InheritingDecorator.definitions.keys).must_equal %w[title artist location] }
   it { assert_cloned(InheritingDecorator, Decorator, "title") }
   it do
     _(InheritingDecorator.representable_attrs.get(:artist).representer_module.object_id).wont_equal Decorator.representable_attrs.get(:artist).representer_module.object_id
@@ -51,10 +50,9 @@ class ConfigInheritTest < MiniTest::Spec
     property :location
   end
 
-  it { _(InheritingAndIncludingDecorator.definitions.keys).must_equal ["title", "artist", "genre", "location"] }
+  it { _(InheritingAndIncludingDecorator.definitions.keys).must_equal %w[title artist genre location] }
   it { assert_cloned(InheritingAndIncludingDecorator, GenreModule, :genre) }
 
-
   # in module ---------------------------------------------------
   module Module
     include Representable
@@ -63,7 +61,6 @@ class ConfigInheritTest < MiniTest::Spec
 
   it { _(Module.definitions.keys).must_equal ["title"] }
 
-
   # in module including module
   module SubModule
     include Representable
@@ -72,7 +69,7 @@ class ConfigInheritTest < MiniTest::Spec
     property :location
   end
 
-  it { _(SubModule.definitions.keys).must_equal ["title", "location"] }
+  it { _(SubModule.definitions.keys).must_equal %w[title location] }
   it { assert_cloned(SubModule, Module, :title) }
 
   # including preserves order
@@ -84,8 +81,7 @@ class ConfigInheritTest < MiniTest::Spec
     property :location
   end
 
-  it { _(IncludingModule.definitions.keys).must_equal ["genre", "title", "location"] }
-
+  it { _(IncludingModule.definitions.keys).must_equal %w[genre title location] }
 
   # included in class -------------------------------------------
   class Class
@@ -93,7 +89,7 @@ class ConfigInheritTest < MiniTest::Spec
     include IncludingModule
   end
 
-  it { _(Class.definitions.keys).must_equal ["genre", "title", "location"] }
+  it { _(Class.definitions.keys).must_equal %w[genre title location] }
   it { assert_cloned(Class, IncludingModule, :title) }
   it { assert_cloned(Class, IncludingModule, :location) }
   it { assert_cloned(Class, IncludingModule, :genre) }
@@ -105,7 +101,7 @@ class ConfigInheritTest < MiniTest::Spec
     include IncludingModule
   end
 
-  it { _(DefiningClass.definitions.keys).must_equal ["street_cred", "genre", "title", "location"] }
+  it { _(DefiningClass.definitions.keys).must_equal %w[street_cred genre title location] }
 
   # in class
   class RepresenterClass
@@ -115,14 +111,13 @@ class ConfigInheritTest < MiniTest::Spec
 
   it { _(RepresenterClass.definitions.keys).must_equal ["title"] }
 
-
   # in inheriting class
   class InheritingClass < RepresenterClass
     include Representable
     property :location
   end
 
-  it { _(InheritingClass.definitions.keys).must_equal ["title", "location"] }
+  it { _(InheritingClass.definitions.keys).must_equal %w[title location] }
   it { assert_cloned(InheritingClass, RepresenterClass, :title) }
 
   # in inheriting class and including
@@ -131,5 +126,5 @@ class ConfigInheritTest < MiniTest::Spec
     include GenreModule
   end
 
-  it { _(InheritingAndIncludingClass.definitions.keys).must_equal ["title", "location", "genre"] }
-end
+  it { _(InheritingAndIncludingClass.definitions.keys).must_equal %w[title location genre] }
+end

data/test/config_test.rb

@@ -1,6 +1,6 @@
-require 'test_helper'
+require "test_helper"
 
-class ConfigTest < MiniTest::Spec
+class ConfigTest < Minitest::Spec
   subject { Representable::Config.new(Representable::Definition) }
   PunkRock = Class.new
   Definition = Representable::Definition
@@ -64,17 +64,16 @@ class ConfigTest < MiniTest::Spec
     end
 
     describe "inherit: true" do
-      before {
+      before do
         subject.add(:title, {:me => true})
         subject.add(:title, {:peer => Module, :inherit => true})
-      }
+      end
 
       it { _(subject.get(:title)[:me]).must_equal true }
       it { _(subject.get(:title)[:peer]).must_equal Module }
     end
   end
 
-
   describe "#remove" do
     subject { Representable::Config.new(Representable::Definition) }
 
@@ -88,7 +87,6 @@ class ConfigTest < MiniTest::Spec
     end
   end
 
-
   describe "#each" do
     before { subject.add(:title, {:me => true}) }
 
@@ -119,4 +117,4 @@ class ConfigTest < MiniTest::Spec
       _(subject.get(:length)).must_equal length
     end
   end
-end
+end

data/test/decorator_scope_test.rb

@@ -1,28 +1,30 @@
-require 'test_helper'
+require "test_helper"
 
 # TODO: remove in 2.0.
-class DecoratorScopeTest < MiniTest::Spec
+class DecoratorScopeTest < Minitest::Spec
   representer! do
-    property :title, :getter => lambda { |*| title_from_representer }, :decorator_scope => true
+    property :title, :getter => ->(*) { title_from_representer }, :decorator_scope => true
   end
 
-  let(:representer_with_method) {
+  let(:representer_with_method) do
     Module.new do
       include Representable::Hash
       property :title, :decorator_scope => true
       def title; "Crystal Planet"; end
     end
-   }
+  end
 
   it "executes lambdas in represented context" do
-    _(Class.new do
-      def title_from_representer
-        "Sounds Of Silence"
-      end
-    end.new.extend(representer).to_hash).must_equal({"title"=>"Sounds Of Silence"})
+    _(
+      Class.new {
+        def title_from_representer
+          "Sounds Of Silence"
+        end
+      }.new.extend(representer).to_hash
+    ).must_equal({"title"=>"Sounds Of Silence"})
   end
 
   it "executes method in represented context" do
     _(Object.new.extend(representer_with_method).to_hash).must_equal({"title"=>"Crystal Planet"})
   end
-end
+end

data/test/decorator_test.rb

@@ -1,6 +1,6 @@
-require 'test_helper'
+require "test_helper"
 
-class DecoratorTest < MiniTest::Spec
+class DecoratorTest < Minitest::Spec
   class SongRepresentation < Representable::Decorator
     include Representable::JSON
     property :name
@@ -22,16 +22,16 @@ class DecoratorTest < MiniTest::Spec
   let(:song) { Song.new("Mama, I'm Coming Home") }
   let(:album) { Album.new([song]) }
 
-  let(:rating) { OpenStruct.new(system: 'MPAA', value: 'R') }
+  let(:rating) { OpenStruct.new(system: "MPAA", value: "R") }
 
   describe "inheritance" do
     let(:inherited_decorator) do
-      Class.new(AlbumRepresentation) do
+      Class.new(AlbumRepresentation) {
         property :best_song
-      end.new(Album.new([song], "Stand Up"))
+      }.new(Album.new([song], "Stand Up"))
     end
 
-    it { _(inherited_decorator.to_hash).must_equal({"songs"=>[{"name"=>"Mama, I'm Coming Home"}], "best_song"=>"Stand Up"}) }
+    it { _(inherited_decorator.to_hash).must_equal({"songs" => [{"name"=>"Mama, I'm Coming Home"}], "best_song" => "Stand Up"}) }
   end
 
   let(:decorator) { AlbumRepresentation.new(album) }
@@ -68,7 +68,6 @@ class DecoratorTest < MiniTest::Spec
     end
   end
 
-
   describe "inline decorators" do
     representer!(decorator: true) do
       collection :songs, :class => Song do
@@ -87,18 +86,19 @@ class DecoratorTest < MiniTest::Spec
 end
 
 require "uber/inheritable_attr"
-class InheritanceWithDecoratorTest < MiniTest::Spec
+class InheritanceWithDecoratorTest < Minitest::Spec
   class Twin
     extend Uber::InheritableAttr
     inheritable_attr :representer_class
-    self.representer_class = Class.new(Representable::Decorator){ include Representable::Hash }
+    self.representer_class = Class.new(Representable::Decorator) { include Representable::Hash }
   end
 
   class Album < Twin
     representer_class.property :title # Twin.representer_class.clone
   end
 
-  class Song < Twin # Twin.representer_class.clone
+  # Twin.representer_class.clone
+  class Song < Twin
   end
 
   it do
@@ -106,4 +106,4 @@ class InheritanceWithDecoratorTest < MiniTest::Spec
     _(Album.representer_class.definitions.size).must_equal 1
     _(Song.representer_class.definitions.size).must_equal 0
   end
-end
+end

data/test/default_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 
-class DefaultTest < MiniTest::Spec
+class DefaultTest < Minitest::Spec
   Song = Struct.new(:id, :title)
 
   representer! do
@@ -31,4 +31,4 @@ class DefaultTest < MiniTest::Spec
       _(Song.new(nil, "").extend(representer).to_hash).must_equal({"title"=>""})
     end
   end
-end
+end

data/test/defaults_options_test.rb

@@ -1,4 +1,4 @@
-require 'test_helper'
+require "test_helper"
 
 class DefaultsOptionsTest < BaseTest
   let(:format) { :hash }
@@ -8,7 +8,7 @@ class DefaultsOptionsTest < BaseTest
   describe "hash options combined with dynamic options" do
     representer! do
       defaults render_nil: true do |name|
-        { as: name.to_s.upcase }
+        {as: name.to_s.upcase}
       end
 
       property :title
@@ -17,13 +17,20 @@ class DefaultsOptionsTest < BaseTest
       property :song_volume
     end
 
-    it { render(prepared).must_equal_document({"TITLE" => "Revolution", "AUTHOR_NAME" => "Some author", "DESCRIPTION" => nil, "SONG_VOLUME" => 20}) }
+    it {
+      render(prepared).must_equal_document(
+        {
+          "TITLE" => "Revolution", "AUTHOR_NAME" => "Some author", "DESCRIPTION" => nil,
+         "SONG_VOLUME" => 20
+        }
+      )
+    }
   end
 
   describe "with only dynamic property options" do
     representer! do
       defaults do |name|
-        { as: name.to_s.upcase }
+        {as: name.to_s.upcase}
       end
 
       property :title
@@ -45,7 +52,14 @@ class DefaultsOptionsTest < BaseTest
       property :song_volume
     end
 
-    it { render(prepared).must_equal_document({"title" => "Revolution", "author_name" => "Some author", "description" => nil, "song_volume" => 20}) }
+    it {
+      render(prepared).must_equal_document(
+        {
+          "title" => "Revolution", "author_name" => "Some author", "description" => nil,
+         "song_volume" => 20
+        }
+      )
+    }
   end
 
   describe "direct defaults hash" do
@@ -58,13 +72,20 @@ class DefaultsOptionsTest < BaseTest
       property :song_volume
     end
 
-    it { render(prepared).must_equal_document({"title" => "Revolution", "author_name" => "Some author", "description" => nil, "song_volume" => 20}) }
+    it {
+      render(prepared).must_equal_document(
+        {
+          "title" => "Revolution", "author_name" => "Some author", "description" => nil,
+         "song_volume" => 20
+        }
+      )
+    }
   end
 
   describe "direct defaults hash with dynamic options" do
     representer! do
       defaults render_nil: true do |name|
-        { as: name.to_s.upcase }
+        {as: name.to_s.upcase}
       end
 
       property :title
@@ -73,13 +94,20 @@ class DefaultsOptionsTest < BaseTest
       property :song_volume
     end
 
-    it { render(prepared).must_equal_document({"TITLE" => "Revolution", "AUTHOR_NAME" => "Some author", "DESCRIPTION" => nil, "SONG_VOLUME" => 20}) }
+    it {
+      render(prepared).must_equal_document(
+        {
+          "TITLE" => "Revolution", "AUTHOR_NAME" => "Some author", "DESCRIPTION" => nil,
+         "SONG_VOLUME" => 20
+        }
+      )
+    }
   end
 
   describe "prioritizes specific options" do
     representer! do
       defaults render_nil: true do |name|
-        { as: name.to_s.upcase }
+        {as: name.to_s.upcase}
       end
 
       property :title