representable 3.0.0 → 3.1.0

data/test/object_test.rb

@@ -18,23 +18,23 @@ class ObjectTest < MiniTest::Spec
     # TODO: collection
   end
 
-  let (:source) { Song.new("The King Is Dead", Album.new("Ruiner", [Song.new("In Vino Veritas II")])) }
-  let (:target) { Song.new }
+  let(:source) { Song.new("The King Is Dead", Album.new("Ruiner", [Song.new("In Vino Veritas II")])) }
+  let(:target) { Song.new }
 
   it do
     representer.prepare(target).from_object(source)
 
-    target.title.must_equal "The King Is Dead"
-    target.album.name.must_equal "RUINER"
-    target.album.songs[0].title.must_equal "IN VINO VERITAS II"
+    _(target.title).must_equal "The King Is Dead"
+    _(target.album.name).must_equal "RUINER"
+    _(target.album.songs[0].title).must_equal "IN VINO VERITAS II"
   end
 
   # ignore nested object when nil
   it do
     representer.prepare(Song.new("The King Is Dead")).from_object(Song.new)
 
-    target.title.must_equal nil # scalar property gets overridden when nil.
-    target.album.must_equal nil # nested property stays nil.
+    _(target.title).must_be_nil # scalar property gets overridden when nil.
+    _(target.album).must_be_nil # nested property stays nil.
   end
 
   # to_object
@@ -53,8 +53,8 @@ class ObjectTest < MiniTest::Spec
 
     it do
       representer.prepare(source).to_object
-      source.album.name.must_equal "Live"
-      source.album.songs[0].title.must_equal 1
+      _(source.album.name).must_equal "Live"
+      _(source.album.songs[0].title).must_equal 1
     end
   end
 end

data/test/option_test.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class OptionTest < MiniTest::Spec
+  class Callable
+    include Uber::Callable
+    def call(*); "callable" end
+  end
+
+  class MyRepresenter < Representable::Decorator
+    include Representable::JSON
+
+    property :static,   getter: "static"
+    property :symbol,   getter: :symbol
+    property :proc,     getter: ->(*) { "proc" }
+    property :callable, getter: Callable.new
+  end
+
+  Album = Struct.new(:static) do
+    def symbol(*); "symbol" end
+  end
+
+  let(:album_representer) { MyRepresenter.new(Album.new) }
+
+  describe ::Representable::Option do
+    it "supports all types of callables (method, proc, static etc)" do
+      _(album_representer.to_hash).must_equal({
+        "static"    => "static",
+        "symbol"    => "symbol",
+        "proc"      => "proc",
+        "callable"  => "callable",
+      })
+    end
+  end
+end

data/test/parse_pipeline_test.rb

@@ -22,12 +22,12 @@ class ParsePipelineTest < MiniTest::Spec
 
     it do
       representer.new(album = Album.new).from_hash("songs"=>nil)
-      album.songs.must_equal []
+      _(album.songs).must_equal []
     end
 
     it do
       representer.new(album = Album.new).from_hash("songs"=>[{"title" => "Business Conduct"}])
-      album.songs.must_equal [Song.new("Business Conduct")]
+      _(album.songs).must_equal [Song.new("Business Conduct")]
     end
   end
 
@@ -45,7 +45,6 @@ class ParsePipelineTest < MiniTest::Spec
     end
 
     def instance!(*options)
-      puts "@@@@@ #{options.inspect}"
       Song.new
     end
 
@@ -58,7 +57,6 @@ class ParsePipelineTest < MiniTest::Spec
     skip "TODO: implement :parse_pipeline and :render_pipeline, and before/after/replace semantics"
     album = Album.new
     Representer.new(album).from_hash({"artist"=>{"email"=>"yo"}, "songs"=>[{"title"=>"Affliction"}, {"title"=>"Dream Beater"}]})
-    album.songs.must_equal([Song.new("Affliction"), Song.new("Dream Beater")])
-    puts album.inspect
+    _(album.songs).must_equal([Song.new("Affliction"), Song.new("Dream Beater")])
   end
 end

data/test/pipeline_test.rb

@@ -24,15 +24,15 @@ class PipelineTest < MiniTest::Spec
   AssignFragment = ->(input, options) { options[:fragment] = input }
 
   it "linear" do
-    P[SkipParse, Setter].("doc", {fragment: 1}).must_equal "Setter(doc)"
+    _(P[SkipParse, Setter].("doc", {fragment: 1})).must_equal "Setter(doc)"
 
 
     # parse style.
-    P[AssignFragment, SkipParse, CreateObject, Prepare].("Bla", {}).must_equal "Prepare(#<OpenStruct>)"
+    _(P[AssignFragment, SkipParse, CreateObject, Prepare].("Bla", {})).must_equal "Prepare(#<OpenStruct>)"
 
 
     # render style.
-    P[Getter, StopOnNil, SkipRender, Prepare, Setter].(nil, {}).
+    _(P[Getter, StopOnNil, SkipRender, Prepare, Setter].(nil, {})).
       must_equal "Setter(Prepare(Yo))"
 
     # pipeline = Representable::Pipeline[SkipParse  , SetResult, ModifyResult]
@@ -46,8 +46,8 @@ class PipelineTest < MiniTest::Spec
 
 
     pipeline = Representable::Pipeline[SkipParse, Stopping, Prepare]
-    pipeline.(nil, fragment: "oy!").must_equal "Prepare()"
-    pipeline.(nil, fragment: "stop!").must_equal Representable::Pipeline::Stop
+    _(pipeline.(nil, fragment: "oy!")).must_equal "Prepare()"
+    _(pipeline.(nil, fragment: "stop!")).must_equal Representable::Pipeline::Stop
   end
 
   describe "Collect" do
@@ -55,11 +55,11 @@ class PipelineTest < MiniTest::Spec
     Add = ->(input, options) { "#{input}+" }
     let(:pipeline) { R::Collect[Reverse, Add] }
 
-    it { pipeline.(["yo!", "oy!"], {}).must_equal ["!oy+", "!yo+"] }
+    it { _(pipeline.(["yo!", "oy!"], {})).must_equal ["!oy+", "!yo+"] }
 
     describe "Pipeline with Collect" do
       let(:pipeline) { P[Reverse, R::Collect[Reverse, Add]] }
-      it { pipeline.(["yo!", "oy!"], {}).must_equal ["!yo+", "!oy+"] }
+      it { _(pipeline.(["yo!", "oy!"], {})).must_equal ["!yo+", "!oy+"] }
     end
   end
 
@@ -68,7 +68,7 @@ class PipelineTest < MiniTest::Spec
 
   ######### scalar property
 
-  let (:title) {
+  let(:title) {
     dfn = R::Definition.new(:title)
 
     R::Hash::Binding.new(dfn)
@@ -76,26 +76,26 @@ class PipelineTest < MiniTest::Spec
 
   it "rendering scalar property" do
     doc = {}
-    P[
+    _(P[
       R::GetValue,
       R::StopOnSkipable,
       R::AssignName,
       R::WriteFragment
-    ].(nil, {represented: Song.new("Lime Green"), binding: title, doc: doc}).must_equal "Lime Green"
+    ].(nil, {represented: Song.new("Lime Green"), binding: title, doc: doc})).must_equal "Lime Green"
 
-    doc.must_equal({"title"=>"Lime Green"})
+    _(doc).must_equal({"title"=>"Lime Green"})
   end
 
   it "parsing scalar property" do
-    P[
+    _(P[
       R::AssignName,
       R::ReadFragment,
       R::StopOnNotFound,
       R::OverwriteOnNil,
       # R::SkipParse,
       R::SetValue,
-    ].extend(P::Debug).(doc={"title"=>"Eruption"}, {represented: song=Song.new("Lime Green"), binding: title, doc: doc}).must_equal "Eruption"
-    song.title.must_equal "Eruption"
+    ].extend(P::Debug).(doc={"title"=>"Eruption"}, {represented: song=Song.new("Lime Green"), binding: title, doc: doc})).must_equal "Eruption"
+    _(song.title).must_equal "Eruption"
   end
 
 
@@ -105,17 +105,17 @@ class PipelineTest < MiniTest::Spec
     property :name
   end
 
-  let (:artist) {
+  let(:artist) {
     dfn = R::Definition.new(:artist, extend: ArtistRepresenter, class: Artist)
 
     R::Hash::Binding.new(dfn)
   }
 
-  let (:song_model) { Song.new("Lime Green", Artist.new("Diesel Boy")) }
+  let(:song_model) { Song.new("Lime Green", Artist.new("Diesel Boy")) }
 
   it "rendering typed property" do
     doc = {}
-    P[
+    _(P[
       R::GetValue,
       R::StopOnSkipable,
       R::StopOnNil,
@@ -123,13 +123,13 @@ class PipelineTest < MiniTest::Spec
       R::Serialize,
       R::AssignName,
       R::WriteFragment
-    ].extend(P::Debug).(nil, {represented: song_model, binding: artist, doc: doc, options: {}}).must_equal({"name" => "Diesel Boy"})
+    ].extend(P::Debug).(nil, {represented: song_model, binding: artist, doc: doc, options: {}})).must_equal({"name" => "Diesel Boy"})
 
-    doc.must_equal({"artist"=>{"name"=>"Diesel Boy"}})
+    _(doc).must_equal({"artist"=>{"name"=>"Diesel Boy"}})
   end
 
   it "parsing typed property" do
-    P[
+    _(P[
       R::AssignName,
       R::ReadFragment,
       R::StopOnNotFound,
@@ -139,21 +139,21 @@ class PipelineTest < MiniTest::Spec
       R::Decorate,
       R::Deserialize,
       R::SetValue,
-    ].extend(P::Debug).(doc={"artist"=>{"name"=>"Doobie Brothers"}}, {represented: song_model, binding: artist, doc: doc, options: {}}).must_equal model=Artist.new("Doobie Brothers")
-    song_model.artist.must_equal model
+    ].extend(P::Debug).(doc={"artist"=>{"name"=>"Doobie Brothers"}}, {represented: song_model, binding: artist, doc: doc, options: {}})).must_equal model=Artist.new("Doobie Brothers")
+    _(song_model.artist).must_equal model
   end
 
 
   ######### collection :ratings
 
-  let (:ratings) {
+  let(:ratings) {
     dfn = R::Definition.new(:ratings, collection: true, skip_render: ->(*) { false })
 
     R::Hash::Binding::Collection.new(dfn)
   }
   it "render scalar collection" do
     doc = {}
-    P[
+    _(P[
       R::GetValue,
       R::StopOnSkipable,
       R::Collect[
@@ -161,20 +161,20 @@ class PipelineTest < MiniTest::Spec
       ],
       R::AssignName,
       R::WriteFragment
-    ].extend(P::Debug).(nil, {represented: Album.new([1,2,3]), binding: ratings, doc: doc, options: {}}).must_equal([1,2,3])
+    ].extend(P::Debug).(nil, {represented: Album.new([1,2,3]), binding: ratings, doc: doc, options: {}})).must_equal([1,2,3])
 
-    doc.must_equal({"ratings"=>[1,2,3]})
+    _(doc).must_equal({"ratings"=>[1,2,3]})
   end
 
 ######### collection :songs, extend: SongRepresenter
-  let (:artists) {
+  let(:artists) {
     dfn = R::Definition.new(:artists, collection: true, extend: ArtistRepresenter, class: Artist)
 
     R::Hash::Binding::Collection.new(dfn)
   }
   it "render typed collection" do
     doc = {}
-    P[
+    _(P[
       R::GetValue,
       R::StopOnSkipable,
       R::Collect[
@@ -183,16 +183,16 @@ class PipelineTest < MiniTest::Spec
       ],
       R::AssignName,
       R::WriteFragment
-    ].extend(P::Debug).(nil, {represented: Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van Halen")]), binding: artists, doc: doc, options: {}}).must_equal([{"name"=>"Diesel Boy"}, {"name"=>"Van Halen"}])
+    ].extend(P::Debug).(nil, {represented: Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van Halen")]), binding: artists, doc: doc, options: {}})).must_equal([{"name"=>"Diesel Boy"}, {"name"=>"Van Halen"}])
 
-    doc.must_equal({"artists"=>[{"name"=>"Diesel Boy"}, {"name"=>"Van Halen"}]})
+    _(doc).must_equal({"artists"=>[{"name"=>"Diesel Boy"}, {"name"=>"Van Halen"}]})
   end
 
-let (:album_model) { Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van Halen")]) }
+let(:album_model) { Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van Halen")]) }
 
   it "parse typed collection" do
     doc = {"artists"=>[{"name"=>"Diesel Boy"}, {"name"=>"Van Halen"}]}
-    P[
+    _(P[
       R::AssignName,
       R::ReadFragment,
       R::StopOnNotFound,
@@ -205,51 +205,51 @@ let (:album_model) { Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van H
         R::Deserialize,
       ],
       R::SetValue,
-    ].extend(P::Debug).(doc, {represented: album_model, binding: artists, doc: doc, options: {}}).must_equal([Artist.new("Diesel Boy"), Artist.new("Van Halen")])
+    ].extend(P::Debug).(doc, {represented: album_model, binding: artists, doc: doc, options: {}})).must_equal([Artist.new("Diesel Boy"), Artist.new("Van Halen")])
 
-    album_model.artists.must_equal([Artist.new("Diesel Boy"), Artist.new("Van Halen")])
+    _(album_model.artists).must_equal([Artist.new("Diesel Boy"), Artist.new("Van Halen")])
   end
 
   # TODO: test with arrays, too, not "only" Pipeline instances.
   describe "#Insert Pipeline[], Function, replace: OldFunction" do
-    let (:pipeline) { P[R::GetValue, R::StopOnSkipable, R::StopOnNil] }
+    let(:pipeline) { P[R::GetValue, R::StopOnSkipable, R::StopOnNil] }
 
     it "returns Pipeline instance when passing in Pipeline instance" do
-      P::Insert.(pipeline, R::Default, replace: R::StopOnSkipable).must_be_instance_of(R::Pipeline)
+      _(P::Insert.(pipeline, R::Default, replace: R::StopOnSkipable)).must_be_instance_of(R::Pipeline)
     end
 
     it "replaces if exists" do
       # pipeline.insert!(R::Default, replace: R::StopOnSkipable)
-      P::Insert.(pipeline, R::Default, replace: R::StopOnSkipable).must_equal P[R::GetValue, R::Default, R::StopOnNil]
-      pipeline.must_equal P[R::GetValue, R::StopOnSkipable, R::StopOnNil]
+      _(P::Insert.(pipeline, R::Default, replace: R::StopOnSkipable)).must_equal P[R::GetValue, R::Default, R::StopOnNil]
+      _(pipeline).must_equal P[R::GetValue, R::StopOnSkipable, R::StopOnNil]
     end
 
     it "replaces Function instance" do
       pipeline = P[R::Prepare, R::StopOnSkipable, R::StopOnNil]
-      P::Insert.(pipeline, R::Default, replace: R::Prepare).must_equal P[R::Default, R::StopOnSkipable, R::StopOnNil]
-      pipeline.must_equal P[R::Prepare, R::StopOnSkipable, R::StopOnNil]
+      _(P::Insert.(pipeline, R::Default, replace: R::Prepare)).must_equal P[R::Default, R::StopOnSkipable, R::StopOnNil]
+      _(pipeline).must_equal P[R::Prepare, R::StopOnSkipable, R::StopOnNil]
     end
 
     it "does not replace when not existing" do
       P::Insert.(pipeline, R::Default, replace: R::Prepare)
-      pipeline.must_equal P[R::GetValue, R::StopOnSkipable, R::StopOnNil]
+      _(pipeline).must_equal P[R::GetValue, R::StopOnSkipable, R::StopOnNil]
     end
 
     it "applies on nested Collect" do
       pipeline = P[R::GetValue, R::Collect[R::GetValue, R::StopOnSkipable], R::StopOnNil]
 
-      P::Insert.(pipeline, R::Default, replace: R::StopOnSkipable).extend(P::Debug).inspect.must_equal "Pipeline[GetValue, Collect[GetValue, Default], StopOnNil]"
-      pipeline.must_equal P[R::GetValue, R::Collect[R::GetValue, R::StopOnSkipable], R::StopOnNil]
+      _(P::Insert.(pipeline, R::Default, replace: R::StopOnSkipable).extend(P::Debug).inspect).must_equal "Pipeline[GetValue, Collect[GetValue, Default], StopOnNil]"
+      _(pipeline).must_equal P[R::GetValue, R::Collect[R::GetValue, R::StopOnSkipable], R::StopOnNil]
 
 
-      P::Insert.(pipeline, R::Default, replace: R::StopOnNil).extend(P::Debug).inspect.must_equal "Pipeline[GetValue, Collect[GetValue, StopOnSkipable], Default]"
+      _(P::Insert.(pipeline, R::Default, replace: R::StopOnNil).extend(P::Debug).inspect).must_equal "Pipeline[GetValue, Collect[GetValue, StopOnSkipable], Default]"
     end
 
     it "applies on nested Collect with Function::CreateObject" do
       pipeline = P[R::GetValue, R::Collect[R::GetValue, R::CreateObject], R::StopOnNil]
 
-      P::Insert.(pipeline, R::Default, replace: R::CreateObject).extend(P::Debug).inspect.must_equal "Pipeline[GetValue, Collect[GetValue, Default], StopOnNil]"
-      pipeline.must_equal P[R::GetValue, R::Collect[R::GetValue, R::CreateObject], R::StopOnNil]
+      _(P::Insert.(pipeline, R::Default, replace: R::CreateObject).extend(P::Debug).inspect).must_equal "Pipeline[GetValue, Collect[GetValue, Default], StopOnNil]"
+      _(pipeline).must_equal P[R::GetValue, R::Collect[R::GetValue, R::CreateObject], R::StopOnNil]
     end
   end
 
@@ -257,8 +257,8 @@ let (:album_model) { Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van H
     let(:pipeline) { P[R::GetValue, R::StopOnNil] }
 
     it do
-      P::Insert.(pipeline, R::GetValue, delete: true).extend(P::Debug).inspect.must_equal "Pipeline[StopOnNil]"
-      pipeline.extend(P::Debug).inspect.must_equal "Pipeline[GetValue, StopOnNil]"
+      _(P::Insert.(pipeline, R::GetValue, delete: true).extend(P::Debug).inspect).must_equal "Pipeline[StopOnNil]"
+      _(pipeline.extend(P::Debug).inspect).must_equal "Pipeline[GetValue, StopOnNil]"
     end
   end
 
@@ -266,8 +266,8 @@ let (:album_model) { Album.new(nil, [Artist.new("Diesel Boy"), Artist.new("Van H
     let(:pipeline) { P[R::GetValue, R::Collect[R::GetValue, R::StopOnSkipable], R::StopOnNil] }
 
     it do
-      P::Insert.(pipeline, R::GetValue, delete: true).extend(P::Debug).inspect.must_equal "Pipeline[Collect[StopOnSkipable], StopOnNil]"
-      pipeline.extend(P::Debug).inspect.must_equal "Pipeline[GetValue, Collect[GetValue, StopOnSkipable], StopOnNil]"
+      _(P::Insert.(pipeline, R::GetValue, delete: true).extend(P::Debug).inspect).must_equal "Pipeline[Collect[StopOnSkipable], StopOnNil]"
+      _(pipeline.extend(P::Debug).inspect).must_equal "Pipeline[GetValue, Collect[GetValue, StopOnSkipable], StopOnNil]"
     end
   end
 end

data/test/populator_test.rb

@@ -16,11 +16,11 @@ class PopulatorTest < Minitest::Spec
       end
     end
 
-    let (:album) { Album.new([]) }
+    let(:album) { Album.new([]) }
 
     it do
       album.extend(representer).from_hash("songs"=>[{"id"=>1}, {"id"=>2}], "artist"=>{"name"=>"Waste"})
-      album.inspect.must_equal "#<struct PopulatorTest::Album songs=[#<struct PopulatorTest::Song id=1>, #<struct PopulatorTest::Song id=2>], artist=#<struct PopulatorTest::Artist name=\"Waste\">>"
+      _(album.inspect).must_equal "#<struct PopulatorTest::Album songs=[#<struct PopulatorTest::Song id=1>, #<struct PopulatorTest::Song id=2>], artist=#<struct PopulatorTest::Artist name=\"Waste\">>"
     end
   end
 
@@ -37,7 +37,7 @@ class PopulatorFindOrInstantiateTest < Minitest::Spec
     end
   end
 
-  Composer = Struct.new(:song)
+  Composer = Class.new
   Composer.class_eval do
     def song=(v)
       @song = v
@@ -55,22 +55,22 @@ class PopulatorFindOrInstantiateTest < Minitest::Spec
       end
     end
 
-    let (:album) { Composer.new.extend(representer).extend(Representable::Debug) }
+    let(:album) { Composer.new.extend(representer).extend(Representable::Debug) }
 
     it "finds by :id and creates new without :id" do
       album.from_hash({"song"=>{"id" => 1, "title"=>"Resist Stance"}})
 
-      album.song.title.must_equal "Resist Stance" # note how title is updated from "Resist Stan"
-      album.song.id.must_equal 1
-      album.song.uid.must_equal "abcd" # not changed via populator, indicating this is a formerly "persisted" object.
+      _(album.song.title).must_equal "Resist Stance" # note how title is updated from "Resist Stan"
+      _(album.song.id).must_equal 1
+      _(album.song.uid).must_equal "abcd" # not changed via populator, indicating this is a formerly "persisted" object.
     end
 
     it "creates new without :id" do
       album.from_hash({"song"=>{"title"=>"Lower"}})
 
-      album.song.title.must_equal "Lower"
-      album.song.id.must_equal nil
-      album.song.uid.must_equal nil
+      _(album.song.title).must_equal "Lower"
+      _(album.song.id).must_be_nil
+      _(album.song.uid).must_be_nil
     end
   end
 
@@ -82,7 +82,7 @@ class PopulatorFindOrInstantiateTest < Minitest::Spec
       end
     end
 
-    let (:album) { Struct.new(:songs).new([]).extend(representer) }
+    let(:album) { Struct.new(:songs).new([]).extend(representer) }
 
     it "finds by :id and creates new without :id" do
       album.from_hash({"songs"=>[
@@ -90,16 +90,16 @@ class PopulatorFindOrInstantiateTest < Minitest::Spec
         {"title"=>"Suffer"}
       ]})
 
-      album.songs[0].title.must_equal "Resist Stance" # note how title is updated from "Resist Stan"
-      album.songs[0].id.must_equal 1
-      album.songs[0].uid.must_equal "abcd" # not changed via populator, indicating this is a formerly "persisted" object.
+      _(album.songs[0].title).must_equal "Resist Stance" # note how title is updated from "Resist Stan"
+      _(album.songs[0].id).must_equal 1
+      _(album.songs[0].uid).must_equal "abcd" # not changed via populator, indicating this is a formerly "persisted" object.
 
-      album.songs[1].title.must_equal "Suffer"
-      album.songs[1].id.must_equal nil
-      album.songs[1].uid.must_equal nil
+      _(album.songs[1].title).must_equal "Suffer"
+      _(album.songs[1].id).must_be_nil
+      _(album.songs[1].uid).must_be_nil
     end
 
     # TODO: test with existing collection
   end
 
-end
+end