representable 2.4.0.rc4 → 2.4.0.rc5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 37e722a1246b50c21ee87fe22a3a712bc03c3ea0
-  data.tar.gz: 4c7cdfbdeb505aaff4f6295ef2b3c717cf4667e4
+  metadata.gz: 2344bb3bc4adbb5cbd3f0f920e70caac2159b017
+  data.tar.gz: 4a3fce1275ac3b335f1a8c211c20d4096d067a40
 SHA512:
-  metadata.gz: c64248b241a38e218d0078116f3fbd3ba79591ca6d9cbed24c80eaa0903c0b017aa5cd18dd1a7bc70f76ee26bf7a2b29b2b6b4c764579762be6a10181555f99a
-  data.tar.gz: a3a01d1dcd3ca21b5a2796eb4ad49f708b4d21d9710c160e176465710c45544b2894512322420e295c4dd6a70c8321d9d71814f8a8d448b977912fc99f17c895
+  metadata.gz: b3a65a2f4ad0968bb128552e60f6f2e0c27b5914ce3f8f159ac05e52f3a9fb2fdcda7d9c8b0cef72f661aeb4670e6baf811861da2889a0816eef7891c2b6a426
+  data.tar.gz: 750cf2b8042556afc0e440e1cf7304ee42f6326c3ff0fe730d5eeb8e438b8024aaffd1460283a2c179b78d8d9e777c126bd29922888cb934d80cfa6a27b24a3c

data/CHANGES.md

@@ -1,5 +1,7 @@
 # 2.4.0
 
+Full migration guide here: http://trailblazer.to/gems/representable/upgrading-guide.html#to-24
+
 * Breaking API change: `:parse_filter` and `:render_filter` have no deprecation as all the other, they receive one options.
 render_filter: val, doc, options
 * `Decorator` always needs a format engine included, e.g. `Representable::JSON` to build bindings at compile-time.
@@ -44,6 +46,11 @@ and it suddenly is super simple to understand
 * Removed `Binding@represented` (which was never public anyway). Use `Binding#represented`.
 * Changed signature: `Binding#get(represented:)`. In now needs a hash `{represented: ..}`.
 
+# 2.4.0.rc5
+
+* Fix double definition of `Insert`.
+* Deprecate `:binding`.
+
 # 2.4.0.rc4
 
 * The preferred way of passing user options is now `to_hash(user_options: {})`.

data/lib/representable/binding.rb

@@ -6,10 +6,13 @@ module Representable
     class FragmentNotFound
     end
 
-    def self.build(definition)
-      return definition.create_binding if definition[:binding]
-      build_for(definition)
+    module ClassDeprecatable
+      def build(definition)
+        return definition.create_binding if definition[:binding]
+        build_for(definition)
+      end
     end
+    extend ClassDeprecatable
 
     def initialize(definition)
       @definition       = definition

data/lib/representable/deprecations.rb

@@ -10,12 +10,11 @@ module Representable::Deprecation
 
       options      = options.dup
 
-      user_option_keys = options.keys - [:exclude, :include, :wrap, :user_options, * representable_attrs.keys.map(&:to_sym)]
+      user_option_keys = options.keys - [:doc, :exclude, :include, :wrap, :user_options, * representable_attrs.keys.map(&:to_sym)]
       if user_option_keys.any?
         user_options = {}
         warn "[Representable] Mixing user and representable options is deprecated. Please provide your options via :user_options."
         user_option_keys.each { |key| user_options[key] = options.delete(key) }
-
         options[:user_options] = user_options
       end
 
@@ -25,9 +24,21 @@ module Representable::Deprecation
 end
 
 module Representable::Binding::Deprecation
+  module Build
+    def build(definition)
+      warn "[Representable] The :binding option is deprecated and will be removed in 3.0. Please use your own pipeline instead." if definition[:binding]
+      super
+    end
+  end
+
   Options = Struct.new(:binding, :user_options, :represented, :decorator)
 
   module EvaluateOption
+      def self.included(includer)
+        super
+        includer.extend(Build)
+      end
+
     def evaluate_option(name, input=nil, options={})
       return evaluate_option_with_deprecation(name, input, options, :user_options) if name==:as
       return evaluate_option_with_deprecation(name, input, options, :user_options) if name==:if

data/lib/representable/insert.rb

@@ -1,5 +1,5 @@
 module Representable
-  Pipeline.class_eval do # FIXME: this doesn't define Function in Pipeline.
+  class Pipeline < Array # i hate that.
     module Function
       class Insert
         def call(arr, func, options)
@@ -32,7 +32,7 @@ module Representable
         end
       end
     end
-  end
 
-  Pipeline::Insert = Function::Insert.new
+    Insert = Pipeline::Function::Insert.new
+  end # Pipeline
 end

data/lib/representable/pipeline.rb

@@ -21,15 +21,14 @@ module Representable
     end
 
 
-    module Insert # TODO: explicit test.
+    module Macros # TODO: explicit test.
       # Macro to quickly modify an array of functions via Pipeline::Insert and return a
       # Pipeline instance.
       def insert(functions, new_function, options)
-        Pipeline.new(Insert.(functions, new_function, options))
-
+        Pipeline.new(Pipeline::Insert.(functions, new_function, options))
       end
     end
-    extend Insert
+    extend Macros
   end # Pipeline
 
 

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "2.4.0.rc4"
+  VERSION = "2.4.0.rc5"
 end

data/representable.gemspec

@@ -3,31 +3,33 @@ $:.unshift lib unless $:.include?(lib)
 
 require 'representable/version'
 
-Gem::Specification.new do |s|
-  s.name        = "representable"
-  s.version     = Representable::VERSION
-  s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Nick Sutterer"]
-  s.email       = ["apotonick@gmail.com"]
-  s.homepage    = "https://github.com/apotonick/representable/"
-  s.summary     = %q{Renders and parses JSON/XML/YAML documents from and to Ruby objects. Includes plain properties, collections, nesting, coercion and more.}
-  s.description = s.summary
+Gem::Specification.new do |spec|
+  spec.name        = "representable"
+  spec.version     = Representable::VERSION
+  spec.platform    = Gem::Platform::RUBY
+  spec.authors     = ["Nick Sutterer"]
+  spec.email       = ["apotonick@gmail.com"]
+  spec.homepage    = "https://github.com/apotonick/representable/"
+  spec.summary     = %q{Renders and parses JSON/XML/YAML documents from and to Ruby objects. Includes plain properties, collections, nesting, coercion and more.}
+  spec.description = spec.summary
 
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
-  s.license       = "MIT"
+  spec.files         = `git ls-files`.split("\n")
+  spec.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  spec.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+  spec.license       = "MIT"
 
-  s.add_dependency "uber", "~> 0.0.15"
-  s.add_dependency "declarative", "~> 0.0.5"
+  spec.required_ruby_version = '>= 1.9.3'
 
-  s.add_development_dependency "rake"
-  s.add_development_dependency "test_xml", "0.1.6"
-  s.add_development_dependency "minitest"
-  s.add_development_dependency "mongoid"
-  s.add_development_dependency "virtus"
-  s.add_development_dependency "json", '>= 1.7.7'
+  spec.add_dependency "uber", "~> 0.0.15"
+  spec.add_dependency "declarative", "~> 0.0.5"
 
-  s.add_development_dependency "ruby-prof"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "test_xml", "0.1.6"
+  spec.add_development_dependency "minitest"
+  spec.add_development_dependency "mongoid"
+  spec.add_development_dependency "virtus"
+  spec.add_development_dependency "json", '>= 1.7.7'
+
+  spec.add_development_dependency "ruby-prof"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 2.4.0.rc4
+  version: 2.4.0.rc5
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-23 00:00:00.000000000 Z
+date: 2015-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: uber
@@ -320,7 +320,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">"