representable 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 01a2c225e9cbfbb8c74843a07cac6d0616e8ea56
-  data.tar.gz: 8715c50c8f493f93d4a94a724001665a250bd91d
+  metadata.gz: 9ae87cf0d1e79ff26480467bc624e3df5633e2b5
+  data.tar.gz: f46dd9c54daa7efb76af07add37e17780fb81b59
 SHA512:
-  metadata.gz: 6883f8f9f7fcee4931b23ceb8b28794260c17a97ba5594a5bbea1dffc92224c1711f95e4a8e7df339e6a6b0a9929740b9de1edfa8de4d22e2e765c130a16db3c
-  data.tar.gz: 7c825c62ad5ba9103400edda45494e128eb53f901ad57cb8ae9190e0c974a8f78e9e49cfa340dad2d351f2fd564e83fa8c5dd3bdaae41aa0d40543588522ae2f
+  metadata.gz: 77511aff2f7d3d88a31c29b4feeec1d4b2c4dd31ec612a3c7521994007adcef4541b89ed14bf54338e796f539023b2cb6cbefc40efe71c7699c30d720c81bcce
+  data.tar.gz: 1983166eda318f1a45cbb349707aae61e2482952e9c29143a5791c6384ed9d4e7cfd1b0efc3a2d6ef083d9626e16e56aef9c6e857ad118775dbbe2d1d4e1859c

data/CHANGES.md

@@ -1,6 +1,11 @@
+# 2.0.4
+
+* Fix implicit rendering of JSON and XML collections where json/collection wasn't loaded properly, resulting in the native JSON's `#to_json` to be called.
+* Fix `:find_or_instantiate` parse strategy which wouldn't instantiate but raise an error. Thanks to @d4rky-pl.
+
 # 2.0.3
 
-# Fixed a bug where `Forwardable` wasn't available (because we didn't require it :).
+* Fixed a bug where `Forwardable` wasn't available (because we didn't require it :).
 
 # 2.0.2
 

data/lib/representable/decorator.rb

@@ -14,6 +14,7 @@ module Representable
 
     include Representable # include after class methods so Decorator::prepare can't be overwritten by Representable::prepare.
 
+    # TODO: implement that just by calling ::property(name, options){include mod} on the inheriting representer.
     module InheritModule
       def inherit_module!(parent)
         inherited_attrs = parent.representable_attrs[:definitions].keys

data/lib/representable/json.rb

@@ -1,5 +1,6 @@
 require 'multi_json'
 require 'representable/hash'
+require 'representable/json/collection'
 
 module Representable
   # Brings #to_json and #from_json to your object.

data/lib/representable/parse_strategies.rb

@@ -50,9 +50,9 @@ module Representable
           args = args.last # TODO: don't pass i as separate block parameter but in Options.
           object_class = args.binding[:class].evaluate(self, fragment, args)
 
-          object_class.find(fragment["id"]) or object_class.new
+          object_class.find_by(id: fragment["id"]) or object_class.new
         }
       end
     end
   end
-end
+end

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "2.0.3"
+  VERSION = "2.0.4"
 end

data/lib/representable/xml.rb

@@ -1,5 +1,6 @@
 require 'representable'
 require 'representable/bindings/xml_bindings'
+require 'representable/xml/collection'
 require 'nokogiri'
 
 module Representable

data/test/lonely_test.rb

@@ -1,6 +1,5 @@
 require 'test_helper'
 
-require 'representable/json/collection'
 require 'representable/json/hash'
 
 class LonelyRepresenterTest < MiniTest::Spec

data/test/parse_strategy_test.rb

@@ -145,8 +145,8 @@ class ParseStrategyFindOrInstantiateTest < BaseTest
 
   Song = Struct.new(:id, :title)
   Song.class_eval do
-    def self.find(id)
-      return new(1, "Resist Stan") if id==1# we should return the same object here
+    def self.find_by(attributes={})
+      return new(1, "Resist Stan") if attributes[:id]==1# we should return the same object here
       new
     end
   end
@@ -227,8 +227,8 @@ end
 class ParseStrategyLambdaTest < MiniTest::Spec
   Song = Struct.new(:id, :title)
   Song.class_eval do
-    def self.find(id)
-      return new(1, "Resist Stan") if id==1# we should return the same object here
+    def self.find_by(attributes={})
+      return new(1, "Resist Stan") if attributes[:id]==1# we should return the same object here
       new
     end
   end
@@ -276,4 +276,4 @@ class ParseStrategyLambdaTest < MiniTest::Spec
 
     # TODO: test with existing collection
   end
-end
+end

data/test/xml_test.rb

@@ -378,7 +378,6 @@ class CollectionTest < MiniTest::Spec
     end
   end
 
-  require 'representable/xml/collection'
   require 'representable/xml/hash'
   class LonelyRepresenterTest < MiniTest::Spec
     # TODO: where is the XML::Hash test?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-31 00:00:00.000000000 Z
+date: 2014-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -260,7 +260,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: Renders and parses JSON/XML/YAML documents from and to Ruby objects. Includes
@@ -308,3 +308,4 @@ test_files:
 - test/xml_bindings_test.rb
 - test/xml_test.rb
 - test/yaml_test.rb
+has_rdoc: