representable 1.7.3 → 1.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d73d9f923aac538f7a199d7c1f7c3f2e93de49fe
-  data.tar.gz: dd4330ac4acfef6810635ed20dc31e0a9752b445
+  metadata.gz: b9f91b5b5cb8555b93015a366704fe19f4da5009
+  data.tar.gz: 045d56ac5c0a9fc165856f3886e5984f95fef452
 SHA512:
-  metadata.gz: 8bd96f1c18ed6c3fc0d191cbb64a76b5163d81d40f98f4a0a8631697fee4cc9685f7448a48f6ed2a01a3f1f1905570d7cf9cb09980257c220f1c84b5f046d6ac
-  data.tar.gz: 7a40442475d412225a7009b411359c90be019d5c6fa6163f9cbb75bb548f0fc90d0694ace4fabe293a59ae7af473cd1ebd80b97dcab30c931962a3b2c3e44ba1
+  metadata.gz: e5eb71ab3db99396efbf0804c3612afa380eec0deee5f67697985d560852f0701efad8ab69fd99cf022b9b45b8c7ece5c7707dd60ba00a9dfc7451832aa67727
+  data.tar.gz: 9acf292ac0687fcb3316a8cecf0f34ea2497664ab354424c1de73462c2458af3d69e8737f07815eee0df31e8702fb13ffce87525a622501842c4074b417b6990

data/CHANGES.md

@@ -1,4 +1,17 @@
-h2. 17.3
+h2. 1.8.0
+
+* Major API change: Remove defaults for collections. This fixes a major design flaw - when parsing a document a collection would be reset to `[]` even if it is not present in the parsed document.
+* Minor API change: Rename `Definition#sought_type` to `#deserialize_class`.
+-> constantize :class etc (requires AS)
+-> make all options lambda-able
+-> make major steps lambda-able
+-> strategies for deserialization (lambda-able!)
+
+h2. 1.7.4
+
+* propagate all options for ::property to ::inline_representer.
+
+h2. 1.7.3
 
 * Fix segfaulting with XML by passing the document to nested objects. Reported by @timoschilling and fixed by @canadaduane.
 

data/lib/representable/binding.rb

@@ -128,7 +128,7 @@ module Representable
       end
 
       def class_from(fragment, *args)
-        call_proc_for(sought_type, fragment)
+        call_proc_for(deserialize_class, fragment)
       end
 
       def instance_for(fragment, *args)

data/lib/representable/definition.rb

@@ -7,8 +7,6 @@ module Representable
     def initialize(sym, options={})
       @name     = sym.to_s
       @options  = options
-
-      @options[:default] ||= [] if array?  # FIXME: move to CollectionBinding!
     end
 
     def clone
@@ -20,7 +18,7 @@ module Representable
     end
 
     def typed?
-      sought_type.is_a?(Class) or representer_module or options[:instance]  # also true if only :extend is set, for people who want solely rendering.
+      deserialize_class.is_a?(Class) or representer_module or options[:instance]  # also true if only :extend is set, for people who want solely rendering.
     end
 
     def array?
@@ -31,7 +29,7 @@ module Representable
       options[:hash]
     end
 
-    def sought_type
+    def deserialize_class
       options[:class]
     end
 

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "1.7.3"
+  VERSION = "1.7.4"
 end

data/test/definition_test.rb

@@ -43,8 +43,8 @@ class DefinitionTest < MiniTest::Spec
       assert_equal :"songs=", @def.setter
     end
 
-    it "responds to #sought_type" do
-      assert_equal nil, @def.sought_type
+    it "responds to #deserialize_class" do
+      assert_equal nil, @def.deserialize_class
     end
 
     describe "#clone" do
@@ -67,11 +67,6 @@ class DefinitionTest < MiniTest::Spec
     it "returns true if :default set" do
       assert_equal true, Representable::Definition.new(:song, :default => nil).has_default?
     end
-
-    it "returns true if :collection" do
-      assert_equal true, Representable::Definition.new(:songs, :collection => true).has_default?
-    end
-
   end
 
 
@@ -208,12 +203,12 @@ class DefinitionTest < MiniTest::Spec
       assert @def.array?
     end
 
-    it "responds to #sought_type" do
-      assert_equal nil, @def.sought_type
+    it "responds to #deserialize_class" do
+      assert_equal nil, @def.deserialize_class
     end
 
     it "responds to #default" do
-      assert_equal [], @def.send(:default)
+      assert_equal nil, @def.send(:default)
     end
   end
 
@@ -222,8 +217,8 @@ class DefinitionTest < MiniTest::Spec
       @def = Representable::Definition.new(:songs, :class => Hash)
     end
 
-    it "responds to #sought_type" do
-      assert_equal Hash, @def.sought_type
+    it "responds to #deserialize_class" do
+      assert_equal Hash, @def.deserialize_class
     end
   end
 

data/test/generic_test.rb

@@ -13,14 +13,15 @@ class GenericTest < MiniTest::Spec
       collection :songs
     end
 
-    it "initializes property with empty array" do
+    it "doesn't initialize property" do
       new_album.from_hash({})
-      new_album.songs.must_equal [] # DISCUSS: do we really want this?
+      new_album.songs.must_equal nil
     end
 
-    it "overrides property with empty array" do
+    it "leaves properties untouched" do
       album.from_hash({})
-      album.songs.must_equal [] # DISCUSS: do we really want this?
+      # TODO: test property.
+      album.songs.must_equal ["Fuck Armageddon"] # DISCUSS: do we really want this?
     end
   end
 
@@ -189,7 +190,6 @@ class GenericTest < MiniTest::Spec
     end
   end
 
-
   describe "mix :extend and inline representers" do
     representer! do
       rpr_module = Module.new do

data/test/json_test.rb

@@ -392,11 +392,6 @@ end
             {:name => "Diesel Boy"}]}.to_json)
           assert_equal ["Cobra Skulls", "Diesel Boy"], cd.bands.map(&:name).sort
         end
-
-        it "creates emtpy array from default if configured" do
-          cd = Compilation.from_json("{}")
-          assert_equal [], cd.bands
-        end
       end
 
       it "responds to #to_json" do

data/test/xml_test.rb

@@ -310,14 +310,6 @@ class CollectionTest < MiniTest::Spec
         })
         assert_equal ["Cobra Skulls", "Diesel Boy"], cd.bands.map(&:name).sort
       end
-
-      it "collections can be empty when default set" do
-        cd = Compilation.from_xml(%{
-          <compilation>
-          </compilation>
-        })
-        assert_equal [], cd.bands
-      end
     end
 
     it "responds to #to_xml" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 1.7.3
+  version: 1.7.4
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-25 00:00:00.000000000 Z
+date: 2013-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri