representable 1.7.2 → 1.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 585370fa8b9543301be8e4a6804f2aff74639f1d
-  data.tar.gz: dd72e65cd02b0e5215a49957335088aab429be8d
+  metadata.gz: d73d9f923aac538f7a199d7c1f7c3f2e93de49fe
+  data.tar.gz: dd4330ac4acfef6810635ed20dc31e0a9752b445
 SHA512:
-  metadata.gz: 0164fdb08a11640bb6d3a42b24f5ea97f8d0c35b995abd4129adfe859ae4d6fde41767d01298bf969f41771fcb90a50f0824dde32f062fd15765dc6b827e5241
-  data.tar.gz: bf1a835d25ec7ac0d3e5c1465c634ef4ec3e67af5ef914adf7a92c6ff378f0b7d42e51b24a0621bc642a708231c17d552e7695a2f3dcae7d28c8d84139fedd39
+  metadata.gz: 8bd96f1c18ed6c3fc0d191cbb64a76b5163d81d40f98f4a0a8631697fee4cc9685f7448a48f6ed2a01a3f1f1905570d7cf9cb09980257c220f1c84b5f046d6ac
+  data.tar.gz: 7a40442475d412225a7009b411359c90be019d5c6fa6163f9cbb75bb548f0fc90d0694ace4fabe293a59ae7af473cd1ebd80b97dcab30c931962a3b2c3e44ba1

data/CHANGES.md

@@ -1,3 +1,7 @@
+h2. 17.3
+
+* Fix segfaulting with XML by passing the document to nested objects. Reported by @timoschilling and fixed by @canadaduane.
+
 h2. 1.7.2
 
 * `Representable#update_properties_from` is private now.

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "1.7.2"
+  VERSION = "1.7.3"
 end

data/lib/representable/xml.rb

@@ -51,9 +51,10 @@ module Representable
 
     # Returns a Nokogiri::XML object representing this object.
     def to_node(options={})
+      options[:doc] ||= Nokogiri::XML::Document.new
       root_tag = options[:wrap] || representation_wrap
 
-      create_representation_with(Nokogiri::XML::Node.new(root_tag.to_s, Nokogiri::XML::Document.new), options, PropertyBinding)
+      create_representation_with(Nokogiri::XML::Node.new(root_tag.to_s, options[:doc]), options, PropertyBinding)
     end
 
     def to_xml(*args)

data/test/generic_test.rb

@@ -18,10 +18,9 @@ class GenericTest < MiniTest::Spec
       new_album.songs.must_equal [] # DISCUSS: do we really want this?
     end
 
-    it "leaves properties untouched" do
+    it "overrides property with empty array" do
       album.from_hash({})
-      # TODO: test property.
-      album.songs.must_equal ["Fuck Armageddon"] # DISCUSS: do we really want this?
+      album.songs.must_equal [] # DISCUSS: do we really want this?
     end
   end
 
@@ -190,6 +189,7 @@ class GenericTest < MiniTest::Spec
     end
   end
 
+
   describe "mix :extend and inline representers" do
     representer! do
       rpr_module = Module.new do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.7.3
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-14 00:00:00.000000000 Z
+date: 2013-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri