representable 1.4.1 → 1.4.2

data/CHANGES.textile

@@ -1,3 +1,7 @@
+h2. 1.4.2
+
+* Fix the processing of `:setter`, we called both the setter lambda and the setter method.
+
 h2. 1.4.1
 
 * Added `:representer_exec` to have lambdas be executed in decorator instance context.

data/README.md

@@ -560,10 +560,12 @@ Use the `:type` option to specify the conversion target. Note that `:default` st
 
 * If you need a special binding for a property you're free to create it using the `:binding` option.
 
+<!-- here comes some code -->
     property :title, :binding => lambda { |*args| JSON::TitleBinding.new(*args) }
 
 * Lambdas are usually executed in the represented object's context. If your writing a `Decorator` representer and you need to execute lambdas in its context use the `:representer_exec` option.
 
+<!-- and some more in a beautiful cuddle -->
     class SongRepresenter < Representable::Decorator
       property :title, :representer_exec => true, :getter => lambda {..}
     end

data/lib/representable/binding.rb

@@ -82,7 +82,7 @@ module Representable
     end
 
     def set(value)
-      value = represented_exec_for(:setter, value) if options[:setter]
+      return represented_exec_for(:setter, value) if options[:setter]
       represented.send(setter, value)
     end
 

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "1.4.1"
+  VERSION = "1.4.2"
 end

data/representable.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Nick Sutterer"]
   s.email       = ["apotonick@gmail.com"]
-  s.homepage    = "http://representable.apotomo.de"
+  s.homepage    = "https://github.com/apotonick/representable/"
   s.summary     = %q{Maps representation documents from and to Ruby objects. Includes XML and JSON support, plain properties, collections and compositions.}
   s.description = %q{Maps representation documents from and to Ruby objects. Includes XML and JSON support, plain properties, collections and compositions.}
 

data/test/representable_test.rb

@@ -499,19 +499,28 @@ class RepresentableTest < MiniTest::Spec
 
   describe ":getter and :setter" do
     representer! do
-      property :name,
-        :getter => lambda { |args| "#{args[:welcome]} #{name}" },
-        :setter => lambda { |val, args| self.name = "#{args[:welcome]} #{val}" }
+      property :name, # key under :name.
+        :getter => lambda { |args| "#{args[:welcome]} #{song_name}" },
+        :setter => lambda { |val, args| self.song_name = "#{args[:welcome]} #{val}" }
     end
 
-    subject { OpenStruct.new(:name => "Mony Mony").extend(representer) }
+    subject { OpenStruct.new(:song_name => "Mony Mony").extend(representer) }
 
     it "uses :getter when rendering" do
+      subject.instance_eval { def name; raise; end }
       subject.to_hash(:welcome => "Hi").must_equal({"name" => "Hi Mony Mony"})
     end
 
+    it "does not call original reader when rendering" do
+      subject.instance_eval { def name; raise; end; self }.to_hash
+    end
+
     it "uses :setter when parsing" do
-      subject.from_hash({"name" => "Eyes Without A Face"}, :welcome => "Hello").name.must_equal "Hello Eyes Without A Face"
+      subject.from_hash({"name" => "Eyes Without A Face"}, :welcome => "Hello").song_name.must_equal "Hello Eyes Without A Face"
+    end
+
+    it "does not call original writer when parsing" do
+      subject.instance_eval { def name=(*); raise; end; self }.from_hash({"name"=>"Dana D And Talle T"})
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-26 00:00:00.000000000 Z
+date: 2013-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -206,7 +206,7 @@ files:
 - test/xml_bindings_test.rb
 - test/xml_test.rb
 - test/yaml_test.rb
-homepage: http://representable.apotomo.de
+homepage: https://github.com/apotonick/representable/
 licenses: []
 post_install_message: 
 rdoc_options: []