representable 1.3.4 → 1.3.5

data/CHANGES.textile

@@ -1,3 +1,7 @@
+h2. 1.3.5
+
+* Added `:reader` and `:writer` to allow overriding rendering/parsing of a property fragment and to give the user access to the entire document.
+
 h2. 1.3.4
 
 * Replacing `json` gem with `multi_json` hoping not to cause trouble.

data/README.md

@@ -65,7 +65,7 @@ If your property name doesn't match the name in the document, use the `:as` opti
       property :title, as: :name
       property :track
     end
-    
+
     song.to_json #=> {"name":"Fallout","track":1}
 
 
@@ -207,7 +207,7 @@ Sometimes it's useful to override accessors to customize output or parsing.
 
     module AlbumRepresenter
       include Representable::JSON
-      
+
       property :name
       collection :songs
 
@@ -260,9 +260,9 @@ Given we not only have songs, but also cover songs.
 
 And a non-homogenous collection of songs.
 
-    songs = [ Song.new(title: "Weirdo", track: 5), 
+    songs = [ Song.new(title: "Weirdo", track: 5),
               CoverSong.new(title: "Truth Hits Everybody", track: 6, copyright: "The Police")]
-    
+
     album = Album.new(name: "Incognito", songs: songs)
 
 
@@ -286,7 +286,7 @@ Rendering heterogenous collections usually implies that you also need to parse t
       include Representable::JSON
 
       property :name
-      collection :songs, 
+      collection :songs,
         :extend => ...,
         :class  => lambda { |hsh| hsh.has_key?("copyright") ? CoverSong : Song }
     end
@@ -299,7 +299,7 @@ If this is not enough, you may override the entire object creation process using
       include Representable::JSON
 
       property :name
-      collection :songs, 
+      collection :songs,
         :extend   => ...,
         :instance => lambda { |hsh| hsh.has_key?("copyright") ? CoverSong.new : Song.new(original: true) }
     end
@@ -308,7 +308,7 @@ If this is not enough, you may override the entire object creation process using
 ## Hashes
 
 As an addition to single properties and collections representable also offers to represent hash attributes.
-    
+
     module SongRepresenter
       include Representable::JSON
 
@@ -318,7 +318,7 @@ As an addition to single properties and collections representable also offers to
 
     Song.new(title: "Bliss", ratings: {"Rolling Stone" => 4.9, "FryZine" => 4.5}).
     extend(SongRepresenter).to_json
-    
+
     #=> {"title":"Bliss","ratings":{"Rolling Stone":4.9,"FryZine":4.5}}
 
 
@@ -400,7 +400,7 @@ You can also map properties to tag attributes in representable.
       property :title, attribute: true
       property :track, attribute: true
     end
-    
+
     Song.new(title: "American Idle").to_xml
     #=> <song title="American Idle" />
 
@@ -418,7 +418,7 @@ It is sometimes unavoidable to wrap tag lists in a container tag.
 
 Note that `:wrap` defines the container tag name.
 
-    Album.new.to_xml #=> 
+    Album.new.to_xml #=>
       <album>
         <songs>
           <song>Laundry Basket</song>
@@ -445,6 +445,19 @@ I do not recommend this approach as it bloats your domain classes with represent
 
 Here's a quick overview about other available options for `#property` and its bro `#collection`.
 
+
+### Overriding Read And Write
+
+This can be handy if a property needs to be compiled from several fragments. The lambda has access to the entire object document (either hash or `Nokogiri` node) and user options.
+
+    property :title, :writer => lambda { |doc, args| doc["title"] = title || original_title }
+
+When using the `:writer` option it is up to you to add fragments to the `doc` - representable won't add anything for this property.
+
+The same works for parsing using `:reader`.
+
+    property :title, :reader => lambda { |doc, args| self.title = doc["title"] || doc["name"] }
+
 ### Read/Write Restrictions
 
 Using the `:readable` and `:writeable` options access to properties can be restricted.
@@ -472,7 +485,7 @@ You can also define conditions on properties using `:if`, making them being cons
       property :title
       property :track, if: lambda { track > 0 }
     end
-  
+
 When rendering or parsing, the `track` property is considered only if track is valid. Note that the block is executed in instance context, giving you access to instance methods.
 
 As always, the block retrieves your options. Given this render call
@@ -505,7 +518,7 @@ Use the `:type` option to specify the conversion target. Note that `:default` st
     module SongRepresenter
       include Representable::JSON
       include Representable::Coercion
-      
+
       property :title
       property :recorded_at, :type => DateTime, :default => "May 12th, 2012"
     end

data/TODO

@@ -15,3 +15,14 @@ document `XML::AttributeHash` etc
 * Song < OpenStruct in test_helper
 
 * have representable-options (:include, :exclude) and user-options
+
+
+
+
+def compile_fragment(doc)
+module ReaderWriter
+  def compile_fragment(doc)
+    do whatever
+    super
+  end
+=> do that for all "features" (what parts would that be?: getter/setter, reader/writer, readable/writeable )?

data/lib/representable.rb

@@ -28,18 +28,18 @@ require 'representable/feature/readable_writeable'
 #   hero.extend(HeroRepresenter).to_json
 module Representable
   attr_writer :representable_attrs
-  
+
   def self.included(base)
     base.class_eval do
       extend ClassInclusions, ModuleExtensions
       extend ClassMethods
       extend ClassMethods::Declarations
-      
+
       include Deprecations
       include Feature::ReadableWriteable
     end
   end
-  
+
   # Reads values from +doc+ and sets properties accordingly.
   def update_properties_from(doc, options, format)
     representable_bindings_for(format, options).each do |bin|
@@ -47,7 +47,7 @@ module Representable
     end
     self
   end
-  
+
 private
   # Compiles the document going through all properties.
   def create_representation_with(doc, options, format)
@@ -70,16 +70,16 @@ private
   # Checks and returns if the property should be included.
   def skip_property?(binding, options)
     return true if skip_excluded_property?(binding, options)  # no need for further evaluation when :exclude'ed
-    
+
     skip_conditional_property?(binding)
   end
-  
+
   def skip_excluded_property?(binding, options)
     return unless props = options[:exclude] || options[:include]
     res   = props.include?(binding.name.to_sym)
     options[:include] ? !res : res
   end
-  
+
   def skip_conditional_property?(binding)
     # TODO: move to Binding.
     return unless condition = binding.options[:if]
@@ -89,30 +89,26 @@ private
 
     not instance_exec(*args, &condition)
   end
-  
-  # Retrieve value and write fragment to the doc.
+
+  # TODO: remove in 1.4.
   def compile_fragment(bin, doc)
-    value = bin.get
-    
-    bin.write_fragment(doc, value)
+    bin.compile_fragment(doc)
   end
-  
-  # Parse value from doc and update the model property.
+
+  # TODO: remove in 1.4.
   def uncompile_fragment(bin, doc)
-    bin.read_fragment(doc) do |value|
-      bin.set(value)
-    end
+    bin.uncompile_fragment(doc)
   end
 
   def representable_attrs
     @representable_attrs ||= self.class.representable_attrs # DISCUSS: copy, or better not?
   end
-  
+
   def representable_bindings_for(format, options)
     options = cleanup_options(options)  # FIXME: make representable-options and user-options two different hashes.
     representable_attrs.map {|attr| format.build(attr, self, options) }
   end
-  
+
   # Returns the wrapper for the representation. Mostly used in XML.
   def representation_wrap
     representable_attrs.wrap_for(self.class.name)
@@ -122,14 +118,14 @@ private
   def cleanup_options(options) # TODO: remove me.
     options.reject { |k,v| [:include, :exclude].include?(k) }
   end
-  
+
   module ClassInclusions
     def included(base)
       super
       base.representable_attrs.inherit(representable_attrs)
     end
   end
-  
+
   module ModuleExtensions
     # Copies the representable_attrs to the extended object.
     def extended(object)
@@ -137,26 +133,26 @@ private
       object.representable_attrs=(representable_attrs)
     end
   end
-  
-  
+
+
   module ClassMethods
-    # Create and yield object and options. Called in .from_json and friends. 
+    # Create and yield object and options. Called in .from_json and friends.
     def create_represented(document, *args)
       new.tap do |represented|
         yield represented, *args if block_given?
       end
     end
-    
-    
+
+
     module Declarations
       def representable_attrs
         @representable_attrs ||= build_config
       end
-      
+
       def representation_wrap=(name)
         representable_attrs.wrap = name
       end
-      
+
       # Declares a represented document node, which is usually a XML tag or a JSON key.
       #
       # Examples:
@@ -171,7 +167,7 @@ private
       def property(name, options={})
         representable_attrs << definition_class.new(name, options)
       end
-      
+
       # Declares a represented document node collection.
       #
       # Examples:
@@ -183,14 +179,14 @@ private
         options[:collection] = true
         property(name, options)
       end
-      
+
       def hash(name=nil, options={})
         return super() unless name  # allow Object.hash.
-        
+
         options[:hash] = true
         property(name, options)
       end
-      
+
     private
       def definition_class
         Definition
@@ -201,19 +197,19 @@ private
       end
     end
   end
-  
-  
+
+
   # NOTE: the API of Config is subject to change so don't rely too much on this private object.
   class Config < Array
     attr_accessor :wrap
-    
+
     # Computes the wrap string or returns false.
     def wrap_for(name)
       return unless wrap
       return infer_name_for(name) if wrap === true
       wrap
     end
-    
+
     def clone
       self.class.new(collect { |d| d.clone })
     end

data/lib/representable/binding.rb

@@ -11,7 +11,7 @@ module Representable
       return definition.create_binding(*args) if definition.binding
       build_for(definition, *args)
     end
-    
+
     def definition  # TODO: remove in 1.4.
       raise "Binding#definition is no longer supported as all Definition methods are now delegated automatically."
     end
@@ -23,20 +23,35 @@ module Representable
     end
 
     attr_reader :user_options, :represented # TODO: make private/remove.
-    
+
     # Main entry point for rendering/parsing a property object.
     def serialize(value)
       value
     end
-    
+
     def deserialize(fragment)
       fragment
     end
-    
+
+    # Retrieve value and write fragment to the doc.
+    def compile_fragment(doc)
+      return represented_exec_for(:writer, doc) if options[:writer]
+
+      write_fragment(doc, get)
+    end
+
+    # Parse value from doc and update the model property.
+    def uncompile_fragment(doc)
+      return represented_exec_for(:reader, doc) if options[:reader]
+
+      read_fragment(doc) do |value|
+        set(value)
+      end
+    end
 
     def write_fragment(doc, value)
       value = default_for(value)
-      
+
       write_fragment_for(value, doc)
     end
 
@@ -47,7 +62,7 @@ module Representable
 
     def read_fragment(doc)
       value = read_fragment_for(doc)
-      
+
       if value == FragmentNotFound
         return unless has_default?
         value = default
@@ -61,16 +76,23 @@ module Representable
     end
 
     def get
-      return represented.instance_exec(user_options, &options[:getter]) if options[:getter]
+      return represented_exec_for(:getter) if options[:getter]
       represented.send(getter)
     end
 
     def set(value)
-      value = represented.instance_exec(value, user_options, &options[:setter]) if options[:setter]
+      value = represented_exec_for(:setter, value) if options[:setter]
       represented.send(setter, value)
     end
-    
-    
+
+  private
+    # Execute the block for +option_name+ on the represented object.
+    def represented_exec_for(option_name, *args)
+      return unless options[option_name]
+      represented.instance_exec(*args+[user_options], &options[option_name])
+    end
+
+
     # Hooks into #serialize and #deserialize to extend typed properties
     # at runtime.
     module Extend
@@ -78,11 +100,11 @@ module Representable
       def serialize(*)
         extend_for(super)
       end
-      
+
       def deserialize(*)
         extend_for(super)
       end
-      
+
       def extend_for(object)
         if mod = representer_module_for(object) # :extend.
           object.extend(*mod)
@@ -90,7 +112,7 @@ module Representable
 
         object
       end
-    
+
     private
       def representer_module_for(object, *args)
         call_proc_for(representer_module, object)   # TODO: how to pass additional data to the computing block?`
@@ -98,24 +120,25 @@ module Representable
 
       def call_proc_for(proc, *args)
         return proc unless proc.is_a?(Proc)
+        # DISCUSS: use represented_exec_for here?
         @represented.instance_exec(*args, &proc)
       end
     end
-    
+
     module Object
       include Binding::Extend  # provides #serialize/#deserialize with extend.
-      
+
       def serialize(object)
         return object if object.nil?
-        
+
         super.send(serialize_method, @user_options.merge!({:wrap => false}))  # TODO: pass :binding => self
       end
-      
+
       def deserialize(data)
         # DISCUSS: does it make sense to skip deserialization of nil-values here?
         super(create_object(data)).send(deserialize_method, data, @user_options)
       end
-      
+
       def create_object(fragment)
         instance_for(fragment) or class_for(fragment)
       end
@@ -131,7 +154,7 @@ module Representable
       end
 
       def instance_for(fragment, *args)
-        return unless options[:instance] 
+        return unless options[:instance]
         call_proc_for(options[:instance], fragment)
       end
     end

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "1.3.4"
+  VERSION = "1.3.5"
 end

data/representable.gemspec

@@ -13,12 +13,12 @@ Gem::Specification.new do |s|
   s.homepage    = "http://representable.apotomo.de"
   s.summary     = %q{Maps representation documents from and to Ruby objects. Includes XML and JSON support, plain properties, collections and compositions.}
   s.description = %q{Maps representation documents from and to Ruby objects. Includes XML and JSON support, plain properties, collections and compositions.}
-  
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
-  
+
   s.add_dependency "nokogiri"
   s.add_dependency "multi_json"
 

data/test/representable_test.rb

@@ -6,55 +6,55 @@ class RepresentableTest < MiniTest::Spec
     property :name
     attr_accessor :name
   end
-  
+
   class PunkBand < Band
     property :street_cred
     attr_accessor :street_cred
   end
-  
+
   module BandRepresentation
     include Representable
-    
+
     property :name
   end
-  
+
   module PunkBandRepresentation
     include Representable
     include BandRepresentation
-    
+
     property :street_cred
   end
-  
-  
+
+
   describe "#representable_attrs" do
     it "responds to #representable_attrs" do
       assert_equal 1, Band.representable_attrs.size
       assert_equal "name", Band.representable_attrs.first.name
     end
-    
+
     describe "in module" do
       it "returns definitions" do
         assert_equal 1, BandRepresentation.representable_attrs.size
         assert_equal "name", BandRepresentation.representable_attrs.first.name
       end
-      
+
       it "inherits to including modules" do
         assert_equal 2,  PunkBandRepresentation.representable_attrs.size
         assert_equal "name", PunkBandRepresentation.representable_attrs.first.name
         assert_equal "street_cred", PunkBandRepresentation.representable_attrs.last.name
       end
-      
+
       it "inherits to including class" do
         band = Class.new do
           include Representable
           include PunkBandRepresentation
         end
-        
+
         assert_equal 2,  band.representable_attrs.size
         assert_equal "name", band.representable_attrs.first.name
         assert_equal "street_cred", band.representable_attrs.last.name
       end
-      
+
       it "allows including the concrete representer module later" do
         vd = class VD
           attr_accessor :name, :street_cred
@@ -65,7 +65,7 @@ class RepresentableTest < MiniTest::Spec
         vd.street_cred = 1
         assert_json "{\"name\":\"Vention Dention\",\"street_cred\":1}", vd.to_json
       end
-      
+
       #it "allows including the concrete representer module only" do
       #  require 'representable/json'
       #  module RockBandRepresentation
@@ -78,29 +78,29 @@ class RepresentableTest < MiniTest::Spec
       #  vd.name        = "Van Halen"
       #  assert_equal "{\"name\":\"Van Halen\"}", vd.to_json
       #end
-      
+
       it "doesn't share inherited properties between family members" do
         parent = Module.new do
           include Representable
           property :id
         end
-        
+
         child = Module.new do
           include Representable
           include parent
         end
-        
+
         assert parent.representable_attrs.first != child.representable_attrs.first, "definitions shouldn't be identical"
       end
-      
+
     end
   end
-  
-  
+
+
   describe "Representable" do
     describe "inheritance" do
       class CoverSong < OpenStruct
-      end 
+      end
       module SongRepresenter
         include Representable::Hash
         property :name
@@ -124,36 +124,36 @@ class RepresentableTest < MiniTest::Spec
         include Representable::XML
         include Representable::JSON
         include PunkBandRepresentation
-        
+
         self.representation_wrap = "band"
         attr_accessor :name, :street_cred
       end
-      
+
       band = Bodyjar.new
       band.name = "Bodyjar"
-      
+
       assert_json "{\"band\":{\"name\":\"Bodyjar\"}}", band.to_json
       assert_xml_equal "<band><name>Bodyjar</name></band>", band.to_xml
     end
-    
+
     it "allows extending with different representers subsequentially" do
       module SongXmlRepresenter
         include Representable::XML
         property :name, :from => "name", :attribute => true
       end
-      
+
       module SongJsonRepresenter
         include Representable::JSON
         property :name
       end
-      
+
       @song = Song.new("Days Go By")
       assert_xml_equal "<song name=\"Days Go By\"/>", @song.extend(SongXmlRepresenter).to_xml
       assert_json "{\"name\":\"Days Go By\"}", @song.extend(SongJsonRepresenter).to_json
     end
   end
-  
-  
+
+
   describe "#property" do
     describe ":from" do
       # TODO: do this with all options.
@@ -166,68 +166,68 @@ class RepresentableTest < MiniTest::Spec
         band = Class.new(Band) { property :friends, :as => :friend }
         assert_equal "friend", band.representable_attrs.last.from
       end
-      
+
       it "is infered from the name implicitly" do
         band = Class.new(Band) { property :friends }
         assert_equal "friends", band.representable_attrs.last.from
       end
     end
   end
-  
+
   describe "#collection" do
     class RockBand < Band
       collection :albums
     end
-    
+
     it "creates correct Definition" do
       assert_equal "albums", RockBand.representable_attrs.last.name
       assert RockBand.representable_attrs.last.array?
     end
   end
-  
+
   describe "#hash" do
     it "also responds to the original method" do
       assert_kind_of Integer, BandRepresentation.hash
     end
   end
-  
-  
+
+
   describe "#representation_wrap" do
     class HardcoreBand
       include Representable
     end
-  
+
     class SoftcoreBand < HardcoreBand
     end
-    
+
     before do
       @band = HardcoreBand.new
     end
-    
-    
+
+
     it "returns false per default" do
       assert_equal nil, SoftcoreBand.new.send(:representation_wrap)
     end
-    
+
     it "infers a printable class name if set to true" do
       HardcoreBand.representation_wrap = true
       assert_equal "hardcore_band", @band.send(:representation_wrap)
     end
-    
+
     it "can be set explicitely" do
       HardcoreBand.representation_wrap = "breach"
       assert_equal "breach", @band.send(:representation_wrap)
     end
   end
-  
-  
+
+
   describe "#definition_class" do
     it "returns Definition class" do
       assert_equal Representable::Definition, Band.send(:definition_class)
     end
   end
 
-  
+
   # DISCUSS: i don't like the JSON requirement here, what about some generic test module?
   class PopBand
     include Representable::JSON
@@ -240,19 +240,19 @@ class RepresentableTest < MiniTest::Spec
     before do
       @band = PopBand.new
     end
-    
+
     it "copies values from document to object" do
       @band.update_properties_from({"name"=>"No One's Choice", "groupies"=>2}, {}, Representable::Hash::PropertyBinding)
       assert_equal "No One's Choice", @band.name
       assert_equal 2, @band.groupies
     end
-    
+
     it "accepts :exclude option" do
       @band.update_properties_from({"name"=>"No One's Choice", "groupies"=>2}, {:exclude => [:groupies]}, Representable::Hash::PropertyBinding)
       assert_equal "No One's Choice", @band.name
       assert_equal nil, @band.groupies
     end
-    
+
     it "accepts :include option" do
       @band.update_properties_from({"name"=>"No One's Choice", "groupies"=>2}, {:include => [:groupies]}, Representable::Hash::PropertyBinding)
       assert_equal 2, @band.groupies
@@ -265,11 +265,11 @@ class RepresentableTest < MiniTest::Spec
       assert_equal "Iron Maiden", @band.name
       assert_equal nil, @band.founders
     end
-    
+
     it "always returns self" do
       assert_equal @band, @band.update_properties_from({"name"=>"Nofx"}, {}, Representable::Hash::PropertyBinding)
     end
-    
+
     it "includes false attributes" do
       @band.update_properties_from({"groupies"=>false}, {}, Representable::Hash::PropertyBinding)
       assert_equal false, @band.groupies
@@ -281,21 +281,21 @@ class RepresentableTest < MiniTest::Spec
       end
       @band.update_properties_from({}, {}, Representable::Hash::PropertyBinding)
     end
-    
+
     it "ignores (no-default) properties not present in the incoming document" do
-      { Representable::JSON => [{}, Representable::Hash::PropertyBinding], 
+      { Representable::JSON => [{}, Representable::Hash::PropertyBinding],
         Representable::XML  => [xml(%{<band/>}), Representable::XML::PropertyBinding]
       }.each do |format, config|
         nested_repr = Module.new do # this module is never applied.
           include format
           property :created_at
         end
-        
+
         repr = Module.new do
           include format
           property :name, :class => Object, :extend => nested_repr
         end
-        
+
         @band = Band.new.extend(repr)
         @band.update_properties_from(config.first, {}, config.last)
         assert_equal nil, @band.name, "Failed in #{format}"
@@ -335,23 +335,23 @@ class RepresentableTest < MiniTest::Spec
       end
     end
   end
-  
+
   describe "#create_representation_with" do
     before do
       @band = PopBand.new
       @band.name = "No One's Choice"
       @band.groupies = 2
     end
-    
+
     it "compiles document from properties in object" do
       assert_equal({"name"=>"No One's Choice", "groupies"=>2}, @band.send(:create_representation_with, {}, {}, Representable::Hash::PropertyBinding))
     end
-    
+
     it "accepts :exclude option" do
       hash = @band.send(:create_representation_with, {}, {:exclude => [:groupies]}, Representable::Hash::PropertyBinding)
       assert_equal({"name"=>"No One's Choice"}, hash)
     end
-    
+
     it "accepts :include option" do
       hash = @band.send(:create_representation_with, {}, {:include => [:groupies]}, Representable::Hash::PropertyBinding)
       assert_equal({"groupies"=>2}, hash)
@@ -375,7 +375,7 @@ class RepresentableTest < MiniTest::Spec
       @band.groupies = false
       assert_equal({"name"=>"No One's Choice","groupies"=>false}, @band.send(:create_representation_with, {}, {}, Representable::Hash::PropertyBinding))
     end
-    
+
     describe "when :render_nil is true" do
       it "includes nil attribute" do
         mod = Module.new do
@@ -383,20 +383,20 @@ class RepresentableTest < MiniTest::Spec
           property :name
           property :groupies, :render_nil => true
         end
-        
+
         @band.extend(mod) # FIXME: use clean object.
         @band.groupies = nil
         hash = @band.send(:create_representation_with, {}, {}, Representable::Hash::PropertyBinding)
         assert_equal({"name"=>"No One's Choice", "groupies" => nil}, hash)
       end
-      
+
       it "includes nil attribute without extending" do
         mod = Module.new do
           include Representable::JSON
           property :name
           property :groupies, :render_nil => true, :extend => BandRepresentation
         end
-        
+
         @band.extend(mod) # FIXME: use clean object.
         @band.groupies = nil
         hash = @band.send(:create_representation_with, {}, {}, Representable::Hash::PropertyBinding)
@@ -417,33 +417,33 @@ class RepresentableTest < MiniTest::Spec
         to_hash(:include => [:original]).must_equal({"original"=>{"title"=>"Roxanne (Don't Put On The Red Light)"}})
     end
   end
-  
+
   describe ":if" do
     before do
       @pop = Class.new(PopBand) { attr_accessor :fame }
     end
-    
+
     it "respects property when condition true" do
       @pop.class_eval { property :fame, :if => lambda { true } }
       band = @pop.new
       band.update_properties_from({"fame"=>"oh yes"}, {}, Representable::Hash::PropertyBinding)
       assert_equal "oh yes", band.fame
     end
-    
+
     it "ignores property when condition false" do
       @pop.class_eval { property :fame, :if => lambda { false } }
       band = @pop.new
       band.update_properties_from({"fame"=>"oh yes"}, {}, Representable::Hash::PropertyBinding)
       assert_equal nil, band.fame
     end
-    
+
     it "ignores property when :exclude'ed even when condition is true" do
       @pop.class_eval { property :fame, :if => lambda { true } }
       band = @pop.new
       band.update_properties_from({"fame"=>"oh yes"}, {:exclude => [:fame]}, Representable::Hash::PropertyBinding)
       assert_equal nil, band.fame
     end
-    
+
     it "executes block in instance context" do
       @pop.class_eval { property :fame, :if => lambda { groupies } }
       band = @pop.new
@@ -470,8 +470,8 @@ class RepresentableTest < MiniTest::Spec
 
   describe ":getter and :setter" do
     representer! do
-      property :name, 
-        :getter => lambda { |args| "#{args[:welcome]} #{name}" }, 
+      property :name,
+        :getter => lambda { |args| "#{args[:welcome]} #{name}" },
         :setter => lambda { |val, args| self.name = "#{args[:welcome]} #{val}" }
     end
 
@@ -486,17 +486,35 @@ class RepresentableTest < MiniTest::Spec
     end
   end
 
+  describe ":reader and :writer" do
+    representer! do
+      property :name,
+        :writer => lambda { |doc, args| doc["title"] = "#{args[:nr]}) #{name}" },
+        :reader => lambda { |doc, args| self.name = doc["title"].split(") ").last }
+    end
+
+    subject { OpenStruct.new(:name => "Disorder And Disarray").extend(representer) }
+
+    it "uses :writer when rendering" do
+      subject.to_hash(:nr => 14).must_equal({"title" => "14) Disorder And Disarray"})
+    end
+
+    it "uses :reader when parsing" do
+      subject.from_hash({"title" => "15) The Wars End"}).name.must_equal "The Wars End"
+    end
+  end
+
   describe ":extend and :class" do
     module UpcaseRepresenter
       def to_hash(*); upcase; end
       def from_hash(hsh, *args); self.class.new hsh.upcase; end   # DISCUSS: from_hash must return self.
     end
-    module DowncaseRepresenter 
+    module DowncaseRepresenter
       def to_hash(*); downcase; end
       def from_hash(hsh, *args); hsh.downcase; end
     end
     class UpcaseString < String; end
-    
+
 
     describe "lambda blocks" do
       representer! do
@@ -614,29 +632,29 @@ class RepresentableTest < MiniTest::Spec
         OpenStruct.new(:title => "Affliction").extend(representer).to_hash.must_equal({:title => "Affliction"})
       end
     end
-    
+
   end
-  
+
   describe "Config" do
     subject { Representable::Config.new }
     PunkRock = Class.new
-    
+
     describe "wrapping" do
       it "returns false per default" do
         assert_equal nil, subject.wrap_for("Punk")
       end
-      
+
       it "infers a printable class name if set to true" do
         subject.wrap = true
         assert_equal "punk_rock", subject.wrap_for(PunkRock)
       end
-      
+
       it "can be set explicitely" do
         subject.wrap = "Descendents"
         assert_equal "Descendents", subject.wrap_for(PunkRock)
       end
     end
-    
+
     describe "clone" do
       it "clones all definitions" do
         subject << Object.new

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-13 00:00:00.000000000 Z
+date: 2013-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -184,7 +184,6 @@ files:
 - lib/representable/json.rb
 - lib/representable/json/collection.rb
 - lib/representable/json/hash.rb
-- lib/representable/readable_writeable.rb
 - lib/representable/version.rb
 - lib/representable/xml.rb
 - lib/representable/xml/collection.rb

data/lib/representable/readable_writeable.rb

@@ -1,29 +0,0 @@
-module Representable
-  module Feature
-    module ReadableWriteable
-      def deserialize_property(binding, doc, options)
-        return unless binding.writeable?
-        super
-      end
-
-      def serialize_property(binding, doc, options)
-        return unless binding.readable?
-        super
-      end
-    end
-  end
-
-  # TODO: i hate monkey-patching Definition here since it globally adds this options. However, for now this should be ok :-)
-  class Definition
-    # TODO: make this generic like `option :writeable, :default => true`
-    def writeable?
-      return options[:writeable] if options.has_key?(:writeable)
-      true
-    end
-
-    def readable?
-      return options[:readable] if options.has_key?(:readable)
-      true
-    end
-  end
-end