reportable 1.0.2 → 1.0.3

data/HISTORY.md

@@ -1,3 +1,8 @@
+v1.0.3
+------
+
+* Fixed bug in reportable method that broke cumulated reports and reports with options
+
 v1.0.2
 ------
 

data/README.md

@@ -22,7 +22,7 @@ the number of updated users records per second or the number of registrations of
 
       reportable :last_name_starting_with_a_registrations, :aggregation => :count, :grouping => :month, :conditions => ["last_name LIKE 'A%'"]
 
-      reportable :updated_per_second, :aggregation => :count, :grouping => :second, :date_column => :updated_at
+      reportable :updated_per_second, :aggregation => :count, :grouping => :hour, :date_column => :updated_at
 
     end
 

data/lib/saulabs/reportable.rb

@@ -44,14 +44,15 @@ module Saulabs
       #  end
       def reportable(name, options = {})
         (class << self; self; end).instance_eval do
-          define_method "#{name.to_s}_report".to_sym do |*args|
-            if options.delete(:cumulate)
-              report = Saulabs::Reportable::CumulatedReport.new(self, name, options)
-            else
-              report = Saulabs::Reportable::Report.new(self, name, options)
-            end
-            raise ArgumentError.new unless args.length == 0 || (args.length == 1 && args[0].is_a?(Hash))
-            report.run(args.length == 0 ? {} : args[0])
+          report_klass = if options.delete(:cumulate)
+            Saulabs::Reportable::CumulatedReport
+          else
+            Saulabs::Reportable::Report
+          end
+          define_method("#{name.to_s}_report".to_sym) do |*args|
+            report = report_klass.new(self, name, options)
+            raise ArgumentError.new unless args.empty? || (args.length == 1 && args.first.is_a?(Hash))
+            report.run(args.first || {})
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: reportable
 version: !ruby/object:Gem::Version 
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors: 
 - Marco Otte-Witte