reply 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84e5fad805dc4cab2fe9e826bc77cb5791fd59a9
-  data.tar.gz: 60dd5002b7358d651b624dfb7a11ab09fe3373b5
+  metadata.gz: 4af0f4c02de394ac3c9c0ef136327011accd1766
+  data.tar.gz: ff55a29937b2cf76ae2ceea6dc090968b0c36f55
 SHA512:
-  metadata.gz: 4d5381706a43524c06584cf7d1e7072a9b1ac6b75519fca327f2be0fc949a8162cf7b9744e3dcf0e2c3754267f35f0e176dc501f44f1344803bd64e10b7e373a
-  data.tar.gz: 6630adb3454a143d1e22ae4306b76351f3a04dea9db528fa2e4ae6bfdf53de290f35845d81d2732bd75c53a9f0147a5eb35dc7f1f3f9c91f69982aa8804ad793
+  metadata.gz: 8fc1aca59c88a5d0ebc4cfdf98618453a24fc66f372313e6d2f7ee23fecd4b1b0f8663b87dcb9a16d85ecf8e002dfcdffbd4e8ca89777691651a9633c1edf0a4
+  data.tar.gz: b192c27a99beb86ffad139b9d7f946a50529fac715ae9a0922cfb911de93b7473f32c81b12ada01e1931a1d2ca1b8f3ec6961dc23d38ea3c2751e93c0562dc23

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/lib/reply/reply.rb

@@ -50,8 +50,10 @@ class Reply
   end
   alias :add_error :add_errors
 
-  def mark_as_success
+  def mark_as_success(msg=nil)
     @simple_status = SIMPLE_STATUS_SUCCESS
+    add_messages(msg) if msg
+    self
   end
   alias :success! :mark_as_success
 
@@ -63,8 +65,10 @@ class Reply
   alias :error! :mark_as_error
   alias :fail! :mark_as_error
 
-  def mark_as_warning
+  def mark_as_warning(msg=nil)
     @simple_status = SIMPLE_STATUS_WARNING
+    add_messages(msg) if msg
+    self
   end
   alias :warning! :mark_as_warning
 

data/readme.md

@@ -32,7 +32,7 @@ Usage
   # add error messages and mark as error
   reply.add_error(["Error 1", "Error 2"])
 
-  # reply.error! also accepts an optional message
+  # reply.error! .success!, .warning! also accept an optional message
   reply.error!("I don't like you")
 
   # reply.error returns the reply itself, so you can do one liners like:

data/reply.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: reply 0.5.0 ruby lib
+# stub: reply 0.5.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "reply"
-  s.version = "0.5.0"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Sebastian Porto"]
-  s.date = "2014-03-05"
+  s.date = "2014-03-07"
   s.description = "An standarized reply object"
   s.email = "s@porto5.com"
   s.extra_rdoc_files = [

data/spec/lib/reply/reply_spec.rb

@@ -13,7 +13,7 @@ describe Reply do
 
   let(:reply) { Reply.new }
 
-  describe '.simple_status' do
+  describe '#simple_status' do
 
     it "is successful by default" do
       expect(reply).to be_successful
@@ -34,7 +34,7 @@ describe Reply do
     end
   end
 
-  describe '.status' do
+  describe '#status' do
     it 'can be set in the initialiser' do
       reply = Reply.new(status: 401)
       expect(reply.status).to eq(401)
@@ -46,7 +46,7 @@ describe Reply do
     end
   end
 
-  describe '.replace_messages' do
+  describe '#replace_messages' do
 
     it 'accepts an array' do
       arr = [1,2]
@@ -59,10 +59,9 @@ describe Reply do
       reply.replace_messages(str)
       expect(reply.messages).to eq([str])
     end
-
   end
 
-  describe '.add_messages' do
+  describe '#add_messages' do
 
     it 'accepts an array' do
       arr = [1,2]
@@ -78,7 +77,7 @@ describe Reply do
 
   end
 
-  describe ".add_error" do
+  describe "#add_error" do
     before do
       reply.add_error("Error")
     end
@@ -92,7 +91,7 @@ describe Reply do
     end
   end
 
-  describe ".add_errors" do
+  describe '#add_errors' do
     before do
       reply.add_errors(["Error", "Another Error"])
     end
@@ -106,27 +105,36 @@ describe Reply do
     end
   end
 
-  describe ".mark_as_success" do
+  describe '#mark_as_success' do
     it "marks the reply as success" do
       reply.mark_as_success
       expect(reply).to be_successful
     end
-  end
 
-  describe "#success!" do
-    it "marks the reply as success" do
-      reply.success!
-      expect(reply).to be_successful
+    it "returns self" do
+      expect(reply.mark_as_success).to eq(reply)
+    end
+
+    it 'accepts a message' do
+      msg = "XYZ"
+      reply.mark_as_success(msg)
+      expect(reply.messages).to include(msg)
+    end
+
+    it 'doesnt remove previous messages' do
+      reply.mark_as_success('a')
+      reply.mark_as_success('b')
+      expect(reply.messages.count).to eq(2)
     end
   end
 
-  describe "#mark_as_error" do
+  describe '#mark_as_error' do
     it "marks the reply as error" do
       reply.mark_as_error
       expect(reply).to be_failure
     end
 
-    it "returns the reply" do
+    it "returns self" do
       expect(reply.mark_as_error).to eq(reply)
     end
 
@@ -135,35 +143,62 @@ describe Reply do
       reply.mark_as_error(err)
       expect(reply.messages).to include(err)
     end
+
+    it 'doesnt remove previous messages' do
+      reply.mark_as_error('a')
+      reply.mark_as_error('b')
+      expect(reply.messages.count).to eq(2)
+    end
   end
 
-  describe "#error!" do
-    it 'delegates to mark_as_error' do
-      expect(reply.method(:error!)).to eq(reply.method(:mark_as_error))
+  describe '#mark_as_warning' do
+    it "marks the reply as warning" do
+      reply.mark_as_warning
+      expect(reply).to be_warning
+    end
+
+    it "returns self" do
+      expect(reply.mark_as_warning).to eq(reply)
+    end
+
+    it 'accepts a message' do
+      msg = "XYZ"
+      reply.mark_as_warning(msg)
+      expect(reply.messages).to include(msg)
+    end
+
+    it 'doesnt remove previous messages' do
+      reply.mark_as_warning('a')
+      reply.mark_as_warning('b')
+      expect(reply.messages.count).to eq(2)
     end
   end
 
-  describe "#fail!" do
+  describe '#success!' do
+    it "delegates to mark_as_success" do
+      expect(reply.method(:success!)).to eq(reply.method(:mark_as_success))
+    end
+  end
+
+  describe '#error!' do
     it 'delegates to mark_as_error' do
-      expect(reply.method(:fail!)).to eq(reply.method(:mark_as_error))
+      expect(reply.method(:error!)).to eq(reply.method(:mark_as_error))
     end
   end
 
-  describe ".mark_as_warning" do
-    it "marks the reply as warning" do
-      reply.mark_as_warning
-      expect(reply).to be_warning
+  describe '#fail!' do
+    it 'delegates to mark_as_error' do
+      expect(reply.method(:fail!)).to eq(reply.method(:mark_as_error))
     end
   end
 
-  describe ".warning!" do
-    it "marks the reply as warning" do
-      reply.warning!
-      expect(reply).to be_warning
+  describe '#warning!' do
+    it "delegates to mark_as_warning" do
+      expect(reply.method(:warning!)).to eq(reply.method(:mark_as_warning))
     end
   end
 
-  describe ".replace_messages_with_errors_for" do
+  describe '#replace_messages_with_errors_for' do
     let(:invalid_object) { Monkey.new }
 
     before do
@@ -180,5 +215,4 @@ describe Reply do
     end
   end
 
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reply
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Sebastian Porto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-05 00:00:00.000000000 Z
+date: 2014-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr