replacer_bot 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23103f3309929ba37a8304f164716728a5122ab7
-  data.tar.gz: b3d9501eae3299651daaf44eaa76a90fc58e2294
+  metadata.gz: ad595f8f205c0125c27951dd1c71547bb460afd1
+  data.tar.gz: 95f74b265bf1278d9e84c2fac3efc108806a24e4
 SHA512:
-  metadata.gz: c53f8bbe6fdbec5baed871eda81cfb92eef5c884667c09828113e4bcf015f6faa8ee004ac69a1c7f0e15e01259c77b976f5285df76df716909995af0e9a15601
-  data.tar.gz: a332cffdb4dda9aeff889280a57e0c187e157900454a1dc8e815236fc938810bca4f09c227d837cab8c4fa8830cf2535342c0b3446b299929872156bd16e11a5
+  metadata.gz: 98c1ffe621cbdcb9dac2723df758ec3b7117aa87e324662f2f4c3e1dbe87b080c106602b65d80241f41b1ecdc0de3f1cd7f9fa9feaca6264f7be2db69daf9d78
+  data.tar.gz: 627097f0f0063258534404ad9a164df4c825960b8f6781e56442e756a7b773fd4eb70eb0dce7bc3ef7658fc2b8f4a691b1f753700b0610ac0c8ddd0b087a5f0e

data/README.md

@@ -40,7 +40,10 @@ The default config is [here](https://github.com/pikesley/replacer_bot/blob/maste
 Notes:
 
 * The search-and-replace terms will be applied in the order listed, which you may or may not care about
-* The search part of the search-and-replace is case-insensitive
+* The search and replace has a number of passes based on some of my finger-in-the-air Reckons, which are probably easiest to understand via the [specs](https://github.com/pikesley/replacer_bot/blob/master/spec/lib/replacer_bot/case_spec.rb). After it tries each of these search-and-replace operations, it does a case-insensitive regex search-and-replace using the raw terms from the YAML (in order to catch SHittily-typeD things, because Twitter is a mess)
+* Your takeaway from this should be that if your replacement is a name or whatever, put it in the YAML Titlecased, otherwise lowercase it, and it should do the Right Thing
+
+### Twitter credentials
 
 You'll also need some Twitter credentials, store them in `~/.replacer_botrc` like this:
 

data/config/defaults.yml

@@ -4,6 +4,7 @@ language: en
 ignore_spaces: true
 save_file: last.tweet
 seen_tweets: seen.tweets
+max_seen_tweets: 1000
 replacements:
   - Open Data: Taylor Swift
   - opendata: TaylorSwift

data/lib/replacer_bot/helpers.rb

@@ -121,7 +121,7 @@ module ReplacerBot
       (self.replacement_extender(substitute) << substitute).each do |s|
         s.each do |search, replace|
           our_string = self.despace our_string
-          our_string.gsub! /#{search}/, replace
+          our_string.gsub! search, replace
         end
       end
     end

data/lib/replacer_bot/seen_tweets.rb

@@ -75,9 +75,19 @@ module ReplacerBot
       nuke_hashtags clean_urls tweet
     end
 
+    def self.unshift set
+      a = set.to_a
+      max_size = Config.instance.config.max_seen_tweets
+      if a.count > max_size
+        a = a[-max_size..-1]
+      end
+
+      Set.new a
+    end
+
     def self.save set
       File.open Config.instance.config.seen_tweets, 'w' do |file|
-        Marshal.dump set, file
+        Marshal.dump unshift(set), file
       end
     end
   end

data/lib/replacer_bot/version.rb

@@ -1,3 +1,3 @@
 module ReplacerBot
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/spec/lib/replacer_bot/case_spec.rb

@@ -0,0 +1,41 @@
+module ReplacerBot
+  describe 'Helpers' do
+    context 'case handling' do
+      it 'has case variants for replacements' do
+        expect(ReplacerBot.replacement_caser 'Open Data' => 'Taylor Swift').
+        to eq(
+          [
+            {'OPEN DATA' => 'TAYLOR SWIFT'},
+            {'open data' => 'Taylor Swift'},
+            {'Open Data' => 'Taylor Swift'}
+          ]
+        )
+
+        expect(ReplacerBot.replacement_caser 'blockchain' => 'Beyoncé').
+        to eq(
+          [
+            {'BLOCKCHAIN' => 'BEYONCÉ'},
+            {'blockchain' => 'Beyoncé'},
+            {'Blockchain' => 'Beyoncé'}
+          ]
+        )
+
+        expect(ReplacerBot.replacement_caser 'cyber' => 'spider').
+        to eq(
+          [
+            {'CYBER' => 'SPIDER'},
+            {'cyber' => 'spider'},
+            {'Cyber' => 'Spider'}
+          ]
+        )
+      end
+
+      it 'preserves case when replacing' do
+        expect(ReplacerBot.replace string: 'Open Data').to eq 'Taylor Swift'
+        expect(ReplacerBot.replace string: 'OPEN DATA').to eq 'TAYLOR SWIFT'
+        expect(ReplacerBot.replace string: 'OPEn DAta').to eq 'Taylor Swift'
+        expect(ReplacerBot.replace string: 'OPEN DATA Open Data open data').to eq 'TAYLOR SWIFT Taylor Swift Taylor Swift'
+      end
+    end
+  end
+end

data/spec/lib/replacer_bot/helpers_spec.rb

@@ -79,41 +79,6 @@ module ReplacerBot
           to eq 'FYI via @DBMph: The 2016 proposed budget is now in Taylor Swift format! You may access it on our website: http://t.co/EO6Lep3PeW'
       end
 
-      it 'has case variants for replacements' do
-        expect(ReplacerBot.replacement_caser 'Open Data' => 'Taylor Swift').
-          to eq(
-            [
-              {'OPEN DATA' => 'TAYLOR SWIFT'},
-              {'open data' => 'Taylor Swift'},
-              {'Open Data' => 'Taylor Swift'}
-            ]
-          )
-
-          expect(ReplacerBot.replacement_caser 'blockchain' => 'Beyoncé').
-            to eq(
-              [
-                {'BLOCKCHAIN' => 'BEYONCÉ'},
-                {'blockchain' => 'Beyoncé'},
-                {'Blockchain' => 'Beyoncé'}
-              ]
-            )
-
-            expect(ReplacerBot.replacement_caser 'cyber' => 'spider').
-              to eq(
-                [
-                  {'CYBER' => 'SPIDER'},
-                  {'cyber' => 'spider'},
-                  {'Cyber' => 'Spider'}
-                ]
-              )
-      end
-
-      it 'preserves case when replacing' do
-        expect(ReplacerBot.replace string: 'Open Data').to eq 'Taylor Swift'
-        expect(ReplacerBot.replace string: 'OPEN DATA').to eq 'TAYLOR SWIFT'
-        expect(ReplacerBot.replace string: 'OPEN DATA Open Data open data').to eq 'TAYLOR SWIFT Taylor Swift Taylor Swift'
-      end
-
       it 'replaces text' do
         expect(ReplacerBot.replace string: 'Something about Open Data goes here').to eq 'Something about Taylor Swift goes here'
         expect(ReplacerBot.replace string: 'Something about #opendata http://foo.bar/').to eq 'Something about #TaylorSwift http://foo.bar/'

data/spec/lib/replacer_bot/seen_tweets_spec.rb

@@ -116,5 +116,20 @@ module ReplacerBot
       expect(Marshal.load File.open Config.instance.config.seen_tweets).to include 1
       expect(Marshal.load File.open Config.instance.config.seen_tweets).to include 3
     end
+
+    it 'keeps a set to reasonable size' do
+      a = []
+      1010.times do |i|
+        a.push i
+      end
+      set = Set.new a
+
+      described_class.save set
+      expect(Marshal.load File.open Config.instance.config.seen_tweets).to be_a Set
+      expect(Marshal.load(File.open(Config.instance.config.seen_tweets)).count).to eq 1000
+      expect(Marshal.load File.open Config.instance.config.seen_tweets).to include 1000
+      expect(Marshal.load File.open Config.instance.config.seen_tweets).not_to include 0
+      expect(Marshal.load File.open Config.instance.config.seen_tweets).not_to include 9
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: replacer_bot
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - pikesley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-18 00:00:00.000000000 Z
+date: 2015-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: twitter
@@ -250,6 +250,7 @@ files:
 - lib/replacer_bot/twitter_client.rb
 - lib/replacer_bot/version.rb
 - replacer_bot.gemspec
+- spec/lib/replacer_bot/case_spec.rb
 - spec/lib/replacer_bot/config_spec.rb
 - spec/lib/replacer_bot/helpers_spec.rb
 - spec/lib/replacer_bot/replacer_spec.rb
@@ -300,6 +301,7 @@ summary: Search, mangle and tweet
 test_files:
 - features/replacer.feature
 - features/support/env.rb
+- spec/lib/replacer_bot/case_spec.rb
 - spec/lib/replacer_bot/config_spec.rb
 - spec/lib/replacer_bot/helpers_spec.rb
 - spec/lib/replacer_bot/replacer_spec.rb