repla 0.4.0 → 0.5.0

data/lib/repla/logger/test/lib/test_view_helper.rb

@@ -1,27 +1,26 @@
 require_relative 'test_setup'
 
+# Helper for testing view class
 class TestViewHelper
+  def initialize(window_id, view_id)
+    @view = Repla::View.new(window_id, view_id)
+    javascript = File.read(TEST_JAVASCRIPT_FILE)
+    @view.do_javascript(javascript)
+  end
 
-    def initialize(window_id, view_id)
-      @view = Repla::View.new(window_id, view_id)
-      javascript = File.read(TEST_JAVASCRIPT_FILE)
-      @view.do_javascript(javascript)
-    end
+  def log_message_at_index(index)
+    @view.do_javascript_function('innerTextOfBodyChildAtIndex', [index])
+  end
 
-    def log_message_at_index(index)
-      @view.do_javascript_function('innerTextOfBodyChildAtIndex', [index])
-    end
+  def number_of_log_messages
+    @view.do_javascript(TEST_MESSAGE_COUNT_JAVASCRIPT)
+  end
 
-    def number_of_log_messages
-      @view.do_javascript(TEST_MESSAGE_COUNT_JAVASCRIPT)
-    end
-
-    def last_log_message
-      @view.do_javascript(TEST_MESSAGE_JAVASCRIPT)
-    end
-  
-    def last_log_class
-      @view.do_javascript(TEST_CLASS_JAVASCRIPT)
-    end
+  def last_log_message
+    @view.do_javascript(TEST_MESSAGE_JAVASCRIPT)
+  end
 
+  def last_log_class
+    @view.do_javascript(TEST_CLASS_JAVASCRIPT)
+  end
 end

data/lib/repla/logger/test/tc_logger.rb

@@ -1,36 +1,35 @@
 #!/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
 
-require "test/unit"
+require 'test/unit'
 
-require_relative 'lib/test_setup.rb'
+require_relative 'lib/test_setup'
 
-require_relative "lib/test_view_helper"
-require_relative "../../logger"
+require_relative 'lib/test_view_helper'
+require_relative '../../logger'
 
+# Test constants
 class TestConstants < Test::Unit::TestCase
-
   def test_constants
     message_prefix = Repla::Logger::MESSAGE_PREFIX
-    assert_not_nil(message_prefix, "The message prefix should not be nil.")
+    assert_not_nil(message_prefix)
     error_prefix = Repla::Logger::ERROR_PREFIX
-    assert_not_nil(message_prefix, "The error prefix should not be nil.")
+    assert_not_nil(error_prefix)
   end
-
 end
 
-
+# Test unitialized logger
 class TestUnintializedLogger < Test::Unit::TestCase
-
   def teardown
-    Repla::Test::Helper::quit
-    assert(!Repla::Test::Helper::running?, "The application should not be running.")
+    Repla::Test::Helper.quit
+    assert(!Repla::Test::Helper.app_running?,
+           'The application should not be running.')
   end
 
   def test_uninitialized_logger
     logger = Repla::Logger.new
 
     # Test Message
-    message = "Testing log message"
+    message = 'Testing log message'
     logger.info(message)
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
 
@@ -41,17 +40,14 @@ class TestUnintializedLogger < Test::Unit::TestCase
     test_view_helper = TestViewHelper.new(logger.window_id, logger.view_id)
 
     test_message = test_view_helper.last_log_message
-    assert_equal(message, test_message, "The messages should match")
+    assert_equal(message, test_message, 'The messages should match')
     test_class = test_view_helper.last_log_class
-    assert_equal("message", test_class, "The classes should match")
-
+    assert_equal('message', test_class, 'The classes should match')
   end
-
 end
 
-
+# Test logger
 class TestLogger < Test::Unit::TestCase
-
   def setup
     @logger = Repla::Logger.new
     @logger.show
@@ -59,82 +55,85 @@ class TestLogger < Test::Unit::TestCase
   end
 
   def teardown
-    Repla::Test::Helper::quit
-    assert(!Repla::Test::Helper::running?, "The application should not be running.")
+    Repla::Test::Helper.quit
+    assert(!Repla::Test::Helper.app_running?)
   end
 
   def test_logger
     test_count = 0
 
     # Test Error
-    message = "Testing log error"
+    message = 'Testing log error'
     @logger.error(message)
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
     test_message = @test_view_helper.last_log_message
-    assert_equal(message, test_message, "The messages should match")
+    assert_equal(message, test_message)
     test_class = @test_view_helper.last_log_class
-    assert_equal("error", test_class, "The classes should match")
+    assert_equal('error', test_class)
     result_count = @test_view_helper.number_of_log_messages
     test_count += 1
-    assert_equal(test_count, result_count, "The number of log messages should match")
+    assert_equal(test_count, result_count)
 
     # Test Message
-    message = "Testing log message"
+    message = 'Testing log message'
     @logger.info(message)
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
     test_message = @test_view_helper.last_log_message
-    assert_equal(message, test_message, "The messages should match")
+    assert_equal(message, test_message)
     test_class = @test_view_helper.last_log_class
-    assert_equal("message", test_class, "The classes should match")
+    assert_equal('message', test_class)
     result_count = @test_view_helper.number_of_log_messages
     test_count += 1
-    assert_equal(test_count, result_count, "The number of log messages should match")
+    assert_equal(test_count, result_count)
 
     # Test Only Error Prefix
-    message = Repla::Logger::ERROR_PREFIX.rstrip # Note the trailing whitespace is trimmed
+    # Note the trailing whitespace is trimmed
+    message = Repla::Logger::ERROR_PREFIX.rstrip
     @logger.info(message)
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
     test_message = @test_view_helper.last_log_message
-    assert_equal(message, test_message, "The messages should match")
+    assert_equal(message, test_message)
     test_class = @test_view_helper.last_log_class
-    assert_equal("message", test_class, "The classes should match")
+    assert_equal('message', test_class)
     result_count = @test_view_helper.number_of_log_messages
     test_count += 1
-    assert_equal(test_count, result_count, "The number of log messages should match")
+    assert_equal(test_count, result_count)
 
     # Test Only Message Prefix
-    message = Repla::Logger::MESSAGE_PREFIX.rstrip # Note the trailing whitespace is trimmed
+    # Note the trailing whitespace is trimmed
+    message = Repla::Logger::MESSAGE_PREFIX.rstrip
     @logger.info(message)
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
     test_message = @test_view_helper.last_log_message
-    assert_equal(message, test_message, "The messages should match")
+    assert_equal(message, test_message)
     test_class = @test_view_helper.last_log_class
-    assert_equal("message", test_class, "The classes should match")
+    assert_equal('message', test_class)
     result_count = @test_view_helper.number_of_log_messages
     test_count += 1
-    assert_equal(test_count, result_count, "The number of log messages should match")
+    assert_equal(test_count, result_count)
 
     # Test Blank Spaces
     @logger.info("  \t")
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
-    test_message = @test_view_helper.last_log_message()
-    assert_equal(message, test_message, "The messages should match")
-    test_class = @test_view_helper.last_log_class()
-    assert_equal("message", test_class, "The classes should match")
+    test_message = @test_view_helper.last_log_message
+    assert_equal(message, test_message)
+    test_class = @test_view_helper.last_log_class
+    assert_equal('message', test_class)
 
     # Test Empty String
-    @logger.info("")
+    @logger.info('')
     sleep Repla::Test::TEST_PAUSE_TIME # Pause for output to be processed
-    test_message = @test_view_helper.last_log_message()
-    assert_equal(message, test_message, "The messages should match")
-    test_class = @test_view_helper.last_log_class()
-    assert_equal("message", test_class, "The classes should match")
+    test_message = @test_view_helper.last_log_message
+    assert_equal(message, test_message)
+    test_class = @test_view_helper.last_log_class
+    assert_equal('message', test_class)
 
     # TODO: Also add the following tests the `Log.wcplugin`
 
     # Test Whitespace
-    # White space to the left should be preserved, whitespace to the right should be removed
-    # This test fails because retrieving the `innerText` doesn't preserve whitepace.
+    # White space to the left should be preserved, whitespace to the right
+    # should be removed This test fails because retrieving the `innerText`
+    # doesn't preserve whitepace.
 
     # message = "\t Testing log message"
     # @logger.info(message + "\t ")
@@ -145,26 +144,27 @@ class TestLogger < Test::Unit::TestCase
     # assert_equal("message", test_class, "The classes should match")
     # result_count = @test_view_helper.number_of_log_messages
     # test_count += 1
-    # assert_equal(test_count, result_count, "The number of log messages should match")
+    # assert_equal(test_count, result_count)
   end
 
   def test_long_input
-    message = %q(
+    message = '
 Line 1
 
 Line 2
 Line 3
-)
+'
     @logger.info(message)
     sleep Repla::Test::TEST_PAUSE_TIME * 2 # Pause for output to be processed
     result_count = @test_view_helper.number_of_log_messages
-    assert_equal(result_count, 3, "The number of log messages should match")    
+    assert_equal(result_count, 3, 'The number of log messages should match')
 
-    (1..3).each { |i|
+    (1..3).each do |i|
       result = @test_view_helper.log_message_at_index(i - 1)
       test_result = "Line #{i}"
-      assert_equal(result, test_result, "The number of log messages should match")    
-    }
+      assert_equal(result,
+                   test_result,
+                   'The number of log messages should match')
+    end
   end
-
 end

data/lib/repla/logger.rb

@@ -1,34 +1,34 @@
 require_relative '../repla'
 
 module Repla
-
+  # Logger
   class Logger
-    MESSAGE_PREFIX = 'MESSAGE '
-    ERROR_PREFIX = 'ERROR '
-    LOG_PLUGIN_NAME = 'Log'
+    MESSAGE_PREFIX = 'MESSAGE '.freeze
+    ERROR_PREFIX = 'ERROR '.freeze
+    LOG_PLUGIN_NAME = 'Log'.freeze
 
     # Toggle
 
-    SHOW_LOG_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, "show_log.scpt")
+    SHOW_LOG_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, 'show_log.scpt')
     def show
-      Repla::run_applescript(SHOW_LOG_SCRIPT, [window_id])
+      Repla.run_applescript(SHOW_LOG_SCRIPT, [window_id])
     end
-    
-    HIDE_LOG_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, "hide_log.scpt")
+
+    HIDE_LOG_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, 'hide_log.scpt')
     def hide
-      Repla::run_applescript(HIDE_LOG_SCRIPT, [window_id])
+      Repla.run_applescript(HIDE_LOG_SCRIPT, [window_id])
     end
-    
-    TOGGLE_LOG_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, "toggle_log.scpt")
+
+    TOGGLE_LOG_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, 'toggle_log.scpt')
     def toggle
-      Repla::run_applescript(TOGGLE_LOG_SCRIPT, [window_id])
+      Repla.run_applescript(TOGGLE_LOG_SCRIPT, [window_id])
     end
 
     # Messages
 
     def info(message)
       message = message.dup
-      message.gsub!(%r{^}, MESSAGE_PREFIX) # Prefix all lines
+      message.gsub!(/^/, MESSAGE_PREFIX) # Prefix all lines
       # Strip trailing white space
       # Add a line break
       log_message(message)
@@ -36,33 +36,34 @@ module Repla
 
     def error(message)
       message = message.dup
-      message.gsub!(%r{^}, ERROR_PREFIX)
+      message.gsub!(/^/, ERROR_PREFIX)
       log_message(message)
     end
 
     # Properties
 
     def window_id
-      @window_id ||= ENV.has_key?(WINDOW_ID_KEY) ? ENV[WINDOW_ID_KEY] : Repla::create_window
+      key = WINDOW_ID_KEY
+      @window_id ||= ENV.key?(key) ? ENV[key] : Repla.create_window
     end
-  
+
     def view_id
-      @view_id ||= Repla::split_id_in_window(window_id, LOG_PLUGIN_NAME)
+      @view_id ||= Repla.split_id_in_window(window_id, LOG_PLUGIN_NAME)
       return @view_id unless @view_id.nil?
 
-      @view_id = Repla::split_id_in_window_last(window_id)
-      Repla::run_plugin_in_split(LOG_PLUGIN_NAME, window_id, @view_id)
-      @view_id  
+      @view_id = Repla.split_id_in_window_last(window_id)
+      Repla.run_plugin_in_split(LOG_PLUGIN_NAME, window_id, @view_id)
+      @view_id
     end
 
     private
 
-    READ_FROM_STANDARD_INPUT_SCRIPT = File.join(APPLESCRIPT_DIRECTORY, "read_from_standard_input.scpt")  
+    READ_FROM_STANDARD_INPUT_SCRIPT = File.join(APPLESCRIPT_DIRECTORY)
     def log_message(message)
       message.rstrip!
       message += "\n"
-      Repla::run_applescript(READ_FROM_STANDARD_INPUT_SCRIPT, [message, window_id, view_id])
+      Repla.run_applescript(READ_FROM_STANDARD_INPUT_SCRIPT,
+                            [message, window_id, view_id])
     end
-  
   end
 end

data/lib/repla/repl/lib/input_controller.rb

@@ -1,18 +1,17 @@
-module Repla::REPL
-  class InputController < Repla::Controller
-
-    attr_accessor :view
-    def initialize(view)
-      @view = view
-    end
+module Repla
+  module REPL
+    # Input controller
+    class InputController < Repla::Controller
+      attr_accessor :view
+      def initialize(view)
+        @view = view
+      end
 
-    def parse_input(input)
-      input = input.dup
-      input.chomp!
-      if !input.strip.empty? # Ignore empty lines
-        @view.add_input(input)
+      def parse_input(input)
+        input = input.dup
+        input.chomp!
+        @view.add_input(input) unless input.strip.empty? # Ignore empty lines
       end
     end
-
   end
 end

data/lib/repla/repl/lib/output_controller.rb

@@ -1,19 +1,18 @@
-module Repla::REPL
-  class OutputController < Repla::Controller
-
-    attr_accessor :view
-    def initialize(view)
-      @view = view
-    end
+module Repla
+  module REPL
+    # Output controller
+    class OutputController < Repla::Controller
+      attr_accessor :view
+      def initialize(view)
+        @view = view
+      end
 
-    def parse_output(output)
-      output = output.dup
-      output.gsub!(/\x1b[^m]*m/, "") # Remove escape sequences
-      output.chomp!
-      if !output.strip.empty? # Ignore empty lines
-        @view.add_output(output)
+      def parse_output(output)
+        output = output.dup
+        output.gsub!(/\x1b[^m]*m/, '') # Remove escape sequences
+        output.chomp!
+        @view.add_output(output) unless output.strip.empty? # Ignore empty lines
       end
     end
-
   end
 end

data/lib/repla/repl/lib/view.rb

@@ -1,23 +1,27 @@
-module Repla::REPL
-  class View < Repla::View
-    ROOT_ACCESS_DIRECTORY = File.join(File.dirname(__FILE__), '../../')
-    HTML_DIRECTORY = File.join(File.dirname(__FILE__), '../html/')
-    VIEW_TEMPLATE = File.join(HTML_DIRECTORY, 'index.html')
-    def initialize
-      super
-      self.root_access_directory_path = File.expand_path(ROOT_ACCESS_DIRECTORY)
-      load_file(VIEW_TEMPLATE)
-    end
+module Repla
+  module REPL
+    # REPL view
+    class View < Repla::View
+      ROOT_ACCESS_DIRECTORY = File.join(File.dirname(__FILE__), '../../')
+      HTML_DIRECTORY = File.join(File.dirname(__FILE__), '../html/')
+      VIEW_TEMPLATE = File.join(HTML_DIRECTORY, 'index.html')
+      def initialize
+        super
+        self.root_access_directory_path = File.expand_path(
+          ROOT_ACCESS_DIRECTORY
+        )
+        load_file(VIEW_TEMPLATE)
+      end
 
-    ADD_INPUT_JAVASCRIPT_FUNCTION = "WcREPL.addInput"
-    def add_input(input)
-      do_javascript_function(ADD_INPUT_JAVASCRIPT_FUNCTION, [input])      
-    end
-    
-    ADD_OUTPUT_JAVASCRIPT_FUNCTION = "WcREPL.addOutput"
-    def add_output(output)
-      do_javascript_function(ADD_OUTPUT_JAVASCRIPT_FUNCTION, [output])      
-    end
+      ADD_INPUT_JAVASCRIPT_FUNCTION = 'WcREPL.addInput'.freeze
+      def add_input(input)
+        do_javascript_function(ADD_INPUT_JAVASCRIPT_FUNCTION, [input])
+      end
 
+      ADD_OUTPUT_JAVASCRIPT_FUNCTION = 'WcREPL.addOutput'.freeze
+      def add_output(output)
+        do_javascript_function(ADD_OUTPUT_JAVASCRIPT_FUNCTION, [output])
+      end
+    end
   end
 end

data/lib/repla/repl.rb

@@ -1,48 +1,49 @@
 require_relative '../repla'
 
-module Repla::REPL
-  require_relative "repl/lib/input_controller"
-  require_relative "repl/lib/output_controller"
-  require_relative "repl/lib/view"
-
-  class Wrapper
-    require 'pty'
-
-    def initialize(command)
-
-      PTY.spawn(command) do |output, input, pid|
-        Thread.new do
-          output.each { |line|
-            output_controller.parse_output(line)
-          }
+module Repla
+  # REPL
+  module REPL
+    require_relative 'repl/lib/input_controller'
+    require_relative 'repl/lib/output_controller'
+    require_relative 'repl/lib/view'
+
+    # Wrapper
+    class Wrapper
+      require 'pty'
+
+      def initialize(command)
+        PTY.spawn(command) do |output, input, _pid|
+          Thread.new do
+            output.each do |line|
+              output_controller.parse_output(line)
+            end
+          end
+          @input = input
         end
-        @input = input
       end
 
-    end
+      def parse_input(input)
+        input_controller.parse_input(input)
+        write_input(input)
+      end
 
-    def parse_input(input)
-      input_controller.parse_input(input)
-      write_input(input)
-    end
+      def write_input(input)
+        @input.write(input)
+      end
 
-    def write_input(input)
-      @input.write(input)
-    end
+      private
 
-    private
+      def input_controller
+        @input_controller ||= InputController.new(view)
+      end
 
-    def input_controller
-      @input_controller ||= InputController.new(view)
-    end
-    
-    def output_controller
-      @output_controller ||= OutputController.new(view)
-    end
-    
-    def view
-      @view ||= View.new
-    end
+      def output_controller
+        @output_controller ||= OutputController.new(view)
+      end
 
+      def view
+        @view ||= View.new
+      end
+    end
   end
 end

data/lib/repla/resources/js/bullets/test/run_tests.rb

@@ -2,6 +2,6 @@
 
 require 'Shellwords'
 
-HTML_FILE = File.join(File.dirname(__FILE__), "lib/index.html")
+HTML_FILE = File.join(File.dirname(__FILE__), 'lib/index.html')
 
 exec("mocha-phantomjs #{Shellwords.escape(HTML_FILE)}")

data/lib/repla/test/bundles/HelloWorld.wcplugin/Contents/Resources/hello_world.rb

@@ -1,3 +1,3 @@
 #!/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
 
-puts "Hello World"
+puts 'Hello World'

data/lib/repla/test/bundles/Print.wcplugin/Contents/Resources/lib/controller.rb

@@ -1,18 +1,22 @@
 require_relative 'view'
+require_relative '../../../../../../lib/escape'
 
-module Repla::Print
-  class Controller < Repla::Controller
+module Repla
+  # Print module
+  module Print
+    using Escape
+    # Print controller
+    class Controller < Repla::Controller
+      def initialize
+        @view = View.new
+      end
 
-    def initialize
-      @view = View.new
+      def parse_line(line)
+        line.chomp!
+        line.javascript_escape!
+        javascript = %[addOutput('#{line}');]
+        @view.do_javascript(javascript)
+      end
     end
-
-    def parse_line(line)
-      line.chomp!
-      line.javascript_escape!
-      javascript = %Q[addOutput('#{line}');]
-      @view.do_javascript(javascript)
-    end
-
   end
 end

data/lib/repla/test/bundles/Print.wcplugin/Contents/Resources/lib/view.rb

@@ -1,13 +1,19 @@
-module Repla::Print
-  class View < Repla::View
-    ROOT_ACCESS_DIRECTORY = File.join(File.dirname(__FILE__), '../../../../../../')
-    HTML_DIRECTORY = File.join(File.dirname(__FILE__), '../html/')
-    VIEW_TEMPLATE = File.join(HTML_DIRECTORY, 'index.html')
+module Repla
+  module Print
+    # Print view
+    class View < Repla::View
+      ROOT_ACCESS_DIRECTORY = File.join(File.dirname(__FILE__),
+                                        '../../../../../../')
+      HTML_DIRECTORY = File.join(File.dirname(__FILE__), '../html/')
+      VIEW_TEMPLATE = File.join(HTML_DIRECTORY, 'index.html')
 
-    def initialize
-      super
-      self.root_access_directory_path = File.expand_path(ROOT_ACCESS_DIRECTORY)
-      load_file(VIEW_TEMPLATE)
+      def initialize
+        super
+        self.root_access_directory_path = File.expand_path(
+          ROOT_ACCESS_DIRECTORY
+        )
+        load_file(VIEW_TEMPLATE)
+      end
     end
   end
 end

data/lib/repla/test/bundles/TestEnvironment.wcplugin/Contents/Resources/constants.rb

@@ -1 +1 @@
-TEST_PLUGIN_NAME = "TestEnvironment"
+TEST_PLUGIN_NAME = 'TestEnvironment'.freeze