repack 2.4.5 → 2.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dddd4f86a84a71e0772c3358f49778275790406
-  data.tar.gz: ba58125c4df9427321ffce56224bd620b24c1c50
+  metadata.gz: 3fab8aaa9ae24afdc4e14d927127db9c4c82f9a9
+  data.tar.gz: 3bac01c904f00cff49182a71257fdfd7d1d6e275
 SHA512:
-  metadata.gz: 37143eb51c791f4791d8ee20b9032ce1b72d79d57f8d20aef9fd6e091588f0e9319fcfd48942a699eeb1532ef2387325963e1c2c5e811280740a3fa12badefe1
-  data.tar.gz: 84e8c735aa86959f9e6509a6681fcb7f5ecd7f8bef5cf4bc0afd4bb64c512cd9d2237ea67b736ba12b6d5eaa215c1453861c78d9007b6151164a956c60a3952c
+  metadata.gz: 2b8cce958e30c5de7c0e56e088d2a41c56af0eec86b0c03abc9633ece20374b90b55511806f8c5f5b4b51ab77f1e1240c0144f7249e582eb05b4a0273217ca32
+  data.tar.gz: 6f9ca0dc8d7f752eff6c250b3a2eff1b7ae7306715e6374e250553672a4635e41ea7d333afe19943d84fa787af42ab4fd8b6694fde2f7d55a91fc2f568aa29a2

data/README.md

@@ -17,6 +17,7 @@ This gem has been tested against Rails 4.2 and Ruby 2.2. Earlier versions of Rai
   2. --router -> Webpack / React / React Router Boilerplate
   3. --redux -> Webpack / React / Redux Boilerplate
   4. --router --redux -> Webpack / React / Router / Redux Boilerplate
+  5. --god -> Webpack / React / Router / Redux / Devise / Auth
 
 ### Installation
 
@@ -56,6 +57,32 @@ If you're using the webpack dev server's live reload feature (not the React hot
   * Webpacked assets will be compiled to `public/client`
   * The manifest file is named `manifest.json`
 
+## View Generator
+1. Generate a controller
+2. Add at least an index route for the controller
+3. rails g repack:view name_of_view (should match controller name)
+
+EXAMPLE:
+``` bash
+rails g controller Admin index
+rails g repack:view admin
+```
+
+NOTE: The view generator will try to match its argument to a currently existing controller name, but if a controller cannot be found with that name, the generator will follow typical Rails convention and pluralize the view directory being created.
+
+In an example where I have an AdminController &  SessionsController:
+
+``` bash
+rails g repack:view admin
+(will find the AdminController and create views/admin/index.html.erb)
+
+rails g repack:view sessions
+(will find the SessionsController and create views/sessions/index.html.erb)
+
+rails g repack:view user
+(will not find a controller, will follow Rails controller naming convention and create views/users/index.html.erb)
+```
+
 ### Working with browser tests
 
 In development, we make sure that the `webpack-dev-server` is running when browser tests are running.
@@ -108,13 +135,6 @@ If you're using `[chunkhash]` in your build asset filenames (which you should be
 * Port example apps to Repack
 
 
-## Experimental
-A view generator has been added.
-
-  1.Generate a controller
-  2.Add at least an index route for the controller
-  3.rails g repack:view name_of_view (should be singular and match controller)
-
 
 ## Contributing
 

data/example/boilerplate/god_mode/scss/alert.css.scss

@@ -1,6 +1,5 @@
 .alert {
-  position: fixed;
-  top: 65px;
+  top: 0px;
   left: 0px;
   right: 0px;
   padding: 15px 0px;

data/lib/generators/repack/view_generator.rb

@@ -10,8 +10,9 @@ module Repack
       @view = args[0]
     end
 
+    # ASSUMPTION: entry file will be snake_cased
     def update_webpack_entry
-      name = @view.downcase.gsub(/ /, "_")
+      name = @view.underscore
       path = "'#{name}': './client/#{name}.js',"
       insert_into_file 'config/webpack.config.js', after: /entry: {\n/ do
         <<-CONFIG
@@ -21,12 +22,13 @@ module Repack
     end
 
     def create_entry_file
-      file = "client/#{@view.gsub(/ /, '')}.js"
+      file = "client/#{@view.underscore}.js"
       name = @view.titleize.gsub(/ /, '')
       copy_file "boilerplate/views/ViewTemplate.js", file
       gsub_file file, /Placeholder/, name
     end
 
+    # ASSUMPTION: container will be PascalCased
     def create_container
       name = @view.titleize.gsub(/ /, '')
       file = "client/containers/#{name}.js"
@@ -34,15 +36,19 @@ module Repack
       gsub_file file, /Placeholder/, name
     end
 
+    # ASSUMPTION: Rails controllers will be PascalCased, file & directory names will be snake_cased
     def create_rails_view
-      name = @view.downcase.gsub(/ /, '_')
-      empty_directory "app/views/#{name.pluralize}"
+      name = @view.underscore
+      Rails.application.eager_load! if ApplicationController.descendants.length == 0
+      controllers = ApplicationController.descendants.map { |cont| cont.name.gsub('Controller', '').underscore }
+      dirname = controllers.include?(name) ? name : name.pluralize
+      empty_directory "app/views/#{dirname}"
       if Gem.loaded_specs.has_key? 'haml-rails'
-        file = "app/views/#{name.pluralize}/index.html.haml"
+        file = "app/views/#{dirname}/index.html.haml"
         copy_file "boilerplate/views/rails_view.html.haml", file
         gsub_file file, /placeholder/, name
       else
-        file = "app/views/#{name.pluralize}/index.html.erb"
+        file = "app/views/#{dirname}/index.html.erb"
         copy_file "boilerplate/views/rails_view.html.erb", file
         gsub_file file, /placeholder/, name
       end

data/lib/repack/version.rb

@@ -1,3 +1,3 @@
 module Repack
-  VERSION = "2.4.5"
+  VERSION = "2.4.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: repack
 version: !ruby/object:Gem::Version
-  version: 2.4.5
+  version: 2.4.6
 platform: ruby
 authors:
 - Dave Jungst
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-13 00:00:00.000000000 Z
+date: 2017-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails