rentlinx 0.9.6 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4262fdfbae34cb0b07cae309ea4951ec252c1079
-  data.tar.gz: 6edeb0ae2679e64cdd2da2d52b02ae3c99e7d497
+  metadata.gz: 5d84ca87dc674c10fafbf7c3768f741604c35071
+  data.tar.gz: f4a5aa6c95773c2aceea5430b7ed9613d33a9684
 SHA512:
-  metadata.gz: 53353972541e04bc5041328882e663cd74ec3e6c54243d6ba2e2dcb9c700cbf8cea7a5092d341603cce60f4b7b90e0ac4eeacab1763526044473d346a7674deb
-  data.tar.gz: 6cdf39903e498e3c0afa2fdf7c2b91874a8e333623a223b23e864827ca082d11b2eeeb8acd65f898eb5fa102ff57f5a9ca645b543fdcba97e5041c4497b31d6c
+  metadata.gz: 8c8f68214467b6510fe357f5b8807da5b1f4d66b83c9386ef4e2a5e13dbe9c2fddef2a5b9e007e2bd1d3654dcc3cb584abcffc73dc9366671fd7f250c2f08684
+  data.tar.gz: a559470f580ab80c11238dec51c805719acb0825e7fb3539ac6681c884188661fe7a739d43963a15e3eb1a77abdbd1b878e4c7eee14a09725a9770822c3d7087

data/lib/rentlinx.rb

@@ -31,8 +31,8 @@ module Rentlinx
     #     rentlinx.site_url 'https://rentlinx.com/api/v2'
     #     rentlinx.log_level :error
     #   end
-    def configure(&block)
-      block.call(self)
+    def configure
+      yield(self)
     end
 
     # Sets and retrieves the username used to log in to Rentlinx

data/lib/rentlinx/models/base.rb

@@ -23,7 +23,7 @@ module Rentlinx
         send("#{at}=", attrs[at])
       end
       remaining_attrs = attrs.keys - attributes
-      raise UnexpectedAttributes, "Unexpected Attributes: #{remaining_attrs.join(', ')}" if remaining_attrs.compact.size > 0
+      raise UnexpectedAttributes, "Unexpected Attributes: #{remaining_attrs.join(', ')}" unless remaining_attrs.compact.empty?
     end
 
     # Provides a list of attributes supported by the class.
@@ -117,22 +117,24 @@ module Rentlinx
 
     private
 
-    def self.unpost(id)
-      Rentlinx.client.unpost(type, id)
-    end
+    class << self
+      def unpost(id)
+        Rentlinx.client.unpost(type, id)
+      end
+
+      def get_from_id(type, id)
+        Rentlinx.client.get(type.to_sym, id)
+      end
 
-    def self.get_from_id(type, id)
-      Rentlinx.client.get(type.to_sym, id)
+      def type
+        name.split('::').last.downcase.to_sym
+      end
     end
 
     def type
       self.class.type
     end
 
-    def self.type
-      name.split('::').last.downcase.to_sym
-    end
-
     def identity
       type.to_s + 'ID'
     end

data/lib/rentlinx/models/company.rb

@@ -1,9 +1,9 @@
 module Rentlinx
   # An object that represents a Rentlinx company.
   class Company < Base
-    ATTRIBUTES = [:companyID, :companyCapAmount]
+    ATTRIBUTES = [:companyID, :companyCapAmount].freeze
 
-    REQUIRED_ATTRIBUTES = [:companyID]
+    REQUIRED_ATTRIBUTES = [:companyID].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/rentlinx/models/lead.rb

@@ -1,8 +1,8 @@
 module Rentlinx
   # An object that represets Rentlinx Leads
   class Lead < Base
-    ATTRIBUTES = [:leadID, :refunded, :refund_reason]
-    REQUIRED_ATTRIBUTES = [:leadID, :refunded, :refund_reason]
+    ATTRIBUTES = [:leadID, :refunded, :refund_reason].freeze
+    REQUIRED_ATTRIBUTES = [:leadID, :refunded, :refund_reason].freeze
 
     attr_accessor(*ATTRIBUTES)
   end

data/lib/rentlinx/models/property.rb

@@ -10,10 +10,10 @@ module Rentlinx
                   :website, :yearBuilt, :numUnits, :phoneNumber, :extension,
                   :faxNumber, :emailAddress, :acceptsHcv, :propertyType,
                   :activeURL, :companyName, :leadsURL,
-                  :premium, :capAmount]
+                  :premium, :capAmount].freeze
 
     REQUIRED_ATTRIBUTES = [:propertyID, :address, :city, :state, :zip,
-                           :phoneNumber, :emailAddress]
+                           :phoneNumber, :emailAddress].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/rentlinx/models/property_amenity.rb

@@ -1,9 +1,9 @@
 module Rentlinx
   # An amenity on a propery
   class PropertyAmenity < Base
-    ATTRIBUTES = [:details, :name, :propertyID]
+    ATTRIBUTES = [:details, :name, :propertyID].freeze
 
-    REQUIRED_ATTRIBUTES = [:name, :propertyID]
+    REQUIRED_ATTRIBUTES = [:name, :propertyID].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/rentlinx/models/property_link.rb

@@ -1,9 +1,9 @@
 module Rentlinx
   # A link on a property
   class PropertyLink < Base
-    ATTRIBUTES = [:propertyID, :title, :url]
+    ATTRIBUTES = [:propertyID, :title, :url].freeze
 
-    REQUIRED_ATTRIBUTES = [:propertyID, :title, :url]
+    REQUIRED_ATTRIBUTES = [:propertyID, :title, :url].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/rentlinx/models/property_photo.rb

@@ -1,9 +1,9 @@
 module Rentlinx
   # A photo on a property
   class PropertyPhoto < Base
-    ATTRIBUTES = [:url, :caption, :position, :propertyID, :unitID]
+    ATTRIBUTES = [:url, :caption, :position, :propertyID, :unitID].freeze
 
-    REQUIRED_ATTRIBUTES = [:url, :propertyID]
+    REQUIRED_ATTRIBUTES = [:url, :propertyID].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/rentlinx/models/unit.rb

@@ -10,9 +10,9 @@ module Rentlinx
                   :bedrooms, :fullBaths, :halfBaths, :isMobilityAccessible,
                   :isVisionAccessible, :isHearingAccessible, :rentIsBasedOnIncome,
                   :isOpenToLease, :dateAvailable, :dateLeasedThrough, :numUnits,
-                  :numAvailable]
+                  :numAvailable].freeze
 
-    REQUIRED_ATTRIBUTES = [:unitID]
+    REQUIRED_ATTRIBUTES = [:unitID].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/rentlinx/modules/amenityable.rb

@@ -17,7 +17,7 @@ module Rentlinx
     def post_amenities
       return if @amenities.nil?
 
-      if @amenities.length == 0
+      if @amenities.empty?
         Rentlinx.client.unpost_amenities_for(self)
       else
         Rentlinx.client.post_amenities(@amenities)
@@ -58,8 +58,8 @@ module Rentlinx
     #   {Rentlinx::PropertyAmenity}
     # @return the updated list of amenities on the object
     def add_amenity(options)
-      options.merge!(propertyID: propertyID)
-      options.merge!(unitID: unitID) if defined? unitID
+      options[:propertyID] = propertyID
+      options[:unitID] = unitID if defined? unitID
       @amenities ||= []
       @amenities << amenity_class.new(options)
     end

data/lib/rentlinx/modules/linkable.rb

@@ -17,7 +17,7 @@ module Rentlinx
     def post_links
       return if @links.nil?
 
-      if @links.length == 0
+      if @links.empty?
         Rentlinx.client.unpost_links_for(self)
       else
         Rentlinx.client.post_links(@links)
@@ -45,8 +45,8 @@ module Rentlinx
     end
 
     def add_link(options)
-      options.merge!(propertyID: propertyID)
-      options.merge!(unitID: unitID) if defined? unitID
+      options[:propertyID] = propertyID
+      options[:unitID] = unitID if defined? unitID
       @links ||= []
       @links << link_class.new(options)
     end

data/lib/rentlinx/modules/photoable.rb

@@ -12,7 +12,7 @@ module Rentlinx
     def post_photos
       return if @photos.nil?
 
-      if @photos.length == 0
+      if @photos.empty?
         Rentlinx.client.unpost_photos_for(self)
       else
         Rentlinx.client.post_photos(@photos)
@@ -32,8 +32,8 @@ module Rentlinx
     end
 
     def add_photo(options)
-      options.merge!(propertyID: propertyID)
-      options.merge!(unitID: unitID) if defined? unitID
+      options[:propertyID] = propertyID
+      options[:unitID] = unitID if defined? unitID
       @photos ||= []
       @photos << photo_class.new(options)
     end

data/lib/rentlinx/validators/attribute_processor_service.rb

@@ -56,7 +56,7 @@ module Rentlinx
     #
     # @return [Boolean] true if valid, false if not
     def valid?
-      @errors.size == 0
+      @errors.empty?
     end
   end
 end

data/lib/rentlinx/validators/phone_validator.rb

@@ -5,24 +5,18 @@ module Rentlinx
     def processed_value
       return '' if value_blank?
       return @value unless valid?
-      @value.gsub(/\D/, '')
+      @value.gsub(/[\+\(\)\s\-]/, '')
     end
 
     private
 
     def validate
-      return if value_blank? ||
-                valid_us_number_without_country_code?(processed_value) ||
-                valid_us_number_with_country_code?(processed_value)
+      return if value_blank? || valid_us_phone_number?(processed_value)
       @error = "#{@value} is not a valid phone number"
     end
 
-    def valid_us_number_with_country_code?(number)
-      number.start_with?('1') && valid_us_number_without_country_code?(number[1..-1])
-    end
-
-    def valid_us_number_without_country_code?(number)
-      !number.start_with?('1') && !number.start_with?('0') && number.size == 10
+    def valid_us_phone_number?(number)
+      /^1?[2-9][0-9]{2}[2-9][0-9]{6}$/.match(number)
     end
   end
 end

data/lib/rentlinx/validators/state_validator.rb

@@ -5,7 +5,7 @@ module Rentlinx
   class StateValidator < BaseValidator
     STATES = %w(AK AL AR AS AZ CA CO CT DC DE FL GA GU HI IA ID IL IN KS KY LA
                 MA MD ME MI MN MO MP MS MT NC ND NE NH NJ NM NV NY OH OK OR PA
-                PR RI SC SD TN TX UT VA VI VT WA WI WV WY)
+                PR RI SC SD TN TX UT VA VI VT WA WI WV WY).freeze
 
     private
 

data/lib/rentlinx/version.rb

@@ -1,5 +1,5 @@
 # This is the main rentlinx module. All Rentlinx objects
 # and methods are namespaced under this module.
 module Rentlinx
-  VERSION = '0.9.6'
+  VERSION = '0.10.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rentlinx
 version: !ruby/object:Gem::Version
-  version: 0.9.6
+  version: 0.10.0
 platform: ruby
 authors:
 - AppFolio, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-11 00:00:00.000000000 Z
+date: 2016-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -115,9 +115,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: API Wrapper for the Rentlinx API
 test_files: []
-has_rdoc: