rentlinx 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b5b566cfebed779111d78efd37f82571407bf98
-  data.tar.gz: e941ff23098e8a4634836a0d7083fcaf3667185c
+  metadata.gz: 0d9edda5dacfcfcfc5bacb55131280a97b10d17f
+  data.tar.gz: 34bbbd157f68b05db896d3d758fa4aa77369fa01
 SHA512:
-  metadata.gz: 799d668a581182b0a1d7204b964c8d4bfb405627442dda8de9771da23f18eea6ab19279c5673a1690855f5f44adcd5e77ffffcfd94e9f101f71b70f7dde04988
-  data.tar.gz: c65076091494c0da9eb34638f52fe660e4dcae8952c03acf8334267f74fa951dfa8d46361f14692b38129310137a1edaa6603f6d9530d701a22f9012c8bb1287
+  metadata.gz: e24d4cd7d154e0e78c00e89b35ff86c5a9efc632f967a221bcea7eb9f1021af1e5aeecffc188260f2c858d5b35d43f83cb46d3dc9f1a290c567daab9c6da4e65
+  data.tar.gz: 592290b007d27b614c5023bb43606b4143167bc50bbdcf723698c7ac933eb543fec5db0b0d1dcd9824a979705f5f335f83497ca5d2a58c5956402c69753cbb03

data/lib/rentlinx/errors.rb

@@ -16,7 +16,7 @@ module Rentlinx
 
   class InvalidObject < RentlinxError
     def initialize(object)
-      super("#{object.class} is invalid: #{object.missing_attributes}")
+      super("#{object.class} is invalid: #{object.error_messages}")
     end
   end
 

data/lib/rentlinx/models/base.rb

@@ -1,11 +1,13 @@
 module Rentlinx
   class Base
     def initialize(attrs)
+      @processor = AttributeProcessor.new(attrs)
+      attrs = @processor.process
       attributes.each do |at|
         send("#{at}=", attrs[at])
       end
       remaining_attrs = attrs.keys - attributes
-      raise UnexpectedAttributes, "Unexpected Attributes: #{remaining_attrs.join(', ')}" if remaining_attrs.size > 0
+      raise UnexpectedAttributes, "Unexpected Attributes: #{remaining_attrs.join(', ')}" if remaining_attrs.compact.size > 0
     end
 
     def attributes
@@ -49,17 +51,24 @@ module Rentlinx
     end
 
     def valid?
-      required_attributes.none? { |at| blank?(send(at)) }
+      error_messages.empty?
     end
 
     def valid_for_post?
       required_attributes_for_post.none? { |at| blank?(send(at)) }
     end
 
-    def missing_attributes
-      missing = required_attributes.select { |at| blank?(send(at)) }
+    def error_messages
+      @processor = AttributeProcessor.new(to_hash)
+      @processor.process
 
-      "Missing required attributes: #{missing.join(', ')}"
+      missing_attrs = required_attributes.select { |at| blank?(send(at)) }
+
+      missing_errors = missing_attrs.each_with_object({}) do |at, obj|
+        obj[at] = 'is missing'
+      end
+
+      @processor.errors.merge(missing_errors)
     end
 
     private

data/lib/rentlinx/validators/attribute_processor_service.rb

@@ -0,0 +1,31 @@
+module Rentlinx
+  class AttributeProcessor
+    attr_reader :errors
+    attr_reader :processed_attrs
+
+    def initialize(attrs)
+      @attrs = attrs
+      @processed_attrs = @attrs
+      @errors = {}
+    end
+
+    def process
+      validators = { phoneNumber: PhoneValidator,
+                     state: StateValidator,
+                     zip: ZipValidator }
+
+      @attrs.each do |field, val|
+        next unless validators.keys.include?(field)
+        validator = validators[field].new(val)
+        @processed_attrs[field] = validator.processed_value
+        @errors[field] = validator.error unless validator.valid?
+      end
+
+      @processed_attrs
+    end
+
+    def valid?
+      @errors.size == 0
+    end
+  end
+end

data/lib/rentlinx/validators/base_validator.rb

@@ -0,0 +1,23 @@
+module Rentlinx
+  class BaseValidator
+    attr_reader :error
+
+    def initialize(val)
+      @value = val
+      @error = ''
+      validate
+    end
+
+    def valid?
+      @error == ''
+    end
+
+    def processed_value
+      @value
+    end
+
+    def value_blank?
+      @value.nil? || @value == ''
+    end
+  end
+end

data/lib/rentlinx/validators/phone_validator.rb

@@ -0,0 +1,14 @@
+module Rentlinx
+  class PhoneValidator < BaseValidator
+    def validate
+      return if value_blank? || Phony.plausible?(@value) || Phony.plausible?('1' + @value)
+      @error = "#{@value} is not a valid phone number"
+    end
+
+    def processed_value
+      return '' if value_blank?
+      return @value unless valid?
+      Phony.normalize(@value)
+    end
+  end
+end

data/lib/rentlinx/validators/state_validator.rb

@@ -0,0 +1,8 @@
+module Rentlinx
+  class StateValidator < BaseValidator
+    def validate
+      return if @value.nil? || @value == '' || @value.size == 2
+      @error = "#{@value} is not a valid state, states must be two characters (CA)"
+    end
+  end
+end

data/lib/rentlinx/validators/zip_validator.rb

@@ -0,0 +1,8 @@
+module Rentlinx
+  class ZipValidator < BaseValidator
+    def validate
+      return if value_blank? || @value.match(/^\d{5}$/)
+      @error = "#{@value} is not a valid zip code, zip codes must be five digits (93117)"
+    end
+  end
+end

data/lib/rentlinx/version.rb

@@ -1,3 +1,3 @@
 module Rentlinx
-  VERSION = '0.3.2'
+  VERSION = '0.4.0'
 end

data/lib/rentlinx.rb

@@ -4,6 +4,11 @@ require 'rentlinx/errors'
 require 'rentlinx/models/base'
 require 'rentlinx/models/property'
 require 'rentlinx/models/unit'
+require 'rentlinx/validators/attribute_processor_service'
+require 'rentlinx/validators/base_validator'
+require 'rentlinx/validators/phone_validator'
+require 'rentlinx/validators/state_validator'
+require 'rentlinx/validators/zip_validator'
 
 module Rentlinx
   @username = nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rentlinx
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - AppFolio, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-29 00:00:00.000000000 Z
+date: 2015-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: phony
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.14.6
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.14.6
 description: 
 email: bryce.boe@appfolio.com
 executables: []
@@ -53,6 +67,11 @@ files:
 - lib/rentlinx/models/base.rb
 - lib/rentlinx/models/property.rb
 - lib/rentlinx/models/unit.rb
+- lib/rentlinx/validators/attribute_processor_service.rb
+- lib/rentlinx/validators/base_validator.rb
+- lib/rentlinx/validators/phone_validator.rb
+- lib/rentlinx/validators/state_validator.rb
+- lib/rentlinx/validators/zip_validator.rb
 - lib/rentlinx/version.rb
 homepage: https://github.com/appfolio/rentlinx_client
 licenses: