rentjuicer 0.7.1 → 0.7.2

data/VERSION

@@ -1 +1 @@
-0.7.1
+0.7.2

data/lib/rentjuicer/listings.rb

@@ -65,7 +65,7 @@ module Rentjuicer
       end
       
       def properties
-        return [] if self.body.listings.blank?
+        return [] if !self.success? || self.body.listings.blank?
         @cached_properties ||= begin
           props = []
           self.body.listings.each do |listing|

data/lib/rentjuicer.rb

@@ -1,6 +1,5 @@
 require 'rubygems'
 require 'httparty'
-require 'hashie'
 require 'rash'
 require 'will_paginate/collection'
 require 'active_support/core_ext/array/grouping'

data/rentjuicer.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rentjuicer}
-  s.version = "0.7.1"
+  s.version = "0.7.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["tcocca"]
-  s.date = %q{2011-10-30}
+  s.date = %q{2012-01-27}
   s.description = %q{Ruby API wrapper for rentjuice.com built with httparty}
   s.email = %q{tom.cocca@gmail.com}
   s.extra_rdoc_files = [
@@ -40,6 +40,7 @@ Gem::Specification.new do |s|
     "spec/rentjuicer/neighborhoods_spec.rb",
     "spec/rentjuicer/response_spec.rb",
     "spec/rentjuicer_api_key.yml.example",
+    "spec/responses/empty_response.json",
     "spec/responses/error.json",
     "spec/responses/featured.json",
     "spec/responses/find_all_1.json",
@@ -51,9 +52,10 @@ Gem::Specification.new do |s|
     "spec/responses/lead.json",
     "spec/responses/lead_error.json",
     "spec/responses/listings.json",
+    "spec/responses/missing_listings.json",
     "spec/responses/mls_listings.json",
     "spec/responses/neighborhoods.json",
-    "spec/responses/no_listings.json",
+    "spec/responses/null_listings.json",
     "spec/spec_helper.rb",
     "spec/support/listing_helper.rb",
     "spec/support/webmock_helper.rb"

data/spec/rentjuicer/listing_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
 describe Rentjuicer::Listing do
-  
+
   before do
     @listing = Rentjuicer::Listing.new(valid_listing_rash)
   end
-  
+
   it "should create methods from all hash keys" do
     @listing.should respond_to(
       "address", "agent_phone", "bedrooms", "latitude", "title", "photos", "featured", "url", "date_available", 
@@ -14,23 +14,23 @@ describe Rentjuicer::Listing do
       "longitude", "description", "agent_name", "rentjuice_id"
     )
   end
-  
+
   it "should return rentjuice_id for id" do
     @listing.id.should == 200306
   end
-  
+
   it "should return the first neighborhood in the array for neighborhood_name" do
     @listing.neighborhood_name.should == 'South Boston'
   end
-  
+
   it "should return the thumbnail url of the first sorted pic for thumb_pic" do
     @listing.thumb_pic.should == "http://static.rentjuice.com/frames/2010/08/25/3008760.jpg"
   end
-  
+
   it "should return the fullsize url of the first sorted pic for first_pic" do
     @listing.first_pic.should == "http://static.rentjuice.com/frames/2010/08/25/3008757.jpg"
   end
-  
+
   it "should return the first element of the sorted photos for main_pic" do
     @listing.main_pic.should == Hashie::Rash.new({
       "thumbnail" => "http://static.rentjuice.com/frames/2010/08/25/3008760.jpg",
@@ -39,11 +39,11 @@ describe Rentjuicer::Listing do
       "fullsize" => "http://static.rentjuice.com/frames/2010/08/25/3008757.jpg"
     })
   end
-  
+
   it "should return an array of photos sorted by the sort_order key for sorted_photos" do
     @listing.sorted_photos.should == sorted_photos_array
   end
-  
+
   context "default similar listings" do
     before do
       @rentjuicer = new_rentjuicer
@@ -61,14 +61,14 @@ describe Rentjuicer::Listing do
       })
       @similar_props = @listing.similar_listings(@rentjuicer)
     end
-    
+
     it "should return an array of listings" do
       @similar_props.should be_kind_of(Array)
       @similar_props.should have_at_most(6).listings
       @similar_props.collect{|x| x.id}.should_not include(@listing.id)
     end
   end
-  
+
   context "similar listings with custom limit" do
     before do
       @rentjuicer = new_rentjuicer
@@ -86,14 +86,85 @@ describe Rentjuicer::Listing do
       })
       @similar_props = @listing.similar_listings(@rentjuicer, 4)
     end
-    
+
     it "should return an array of listings" do
       @similar_props.should be_kind_of(Array)
       @similar_props.should have_at_most(4).listings
       @similar_props.collect{|x| x.id}.should_not include(@listing.id)
     end
   end
-  
+
+  context "nil similar listings" do
+    context "null listings" do
+      before do
+        @rentjuicer = new_rentjuicer
+        mock_get('/listings.json', 'null_listings.json', {
+            :neighborhoods => "South Boston", 
+            :min_rent => "2250.0",
+            :max_rent => "2750.0",
+            :min_beds => "2",
+            :max_beds => "4",
+            :min_baths => "0",
+            :max_baths => "2",
+            :limit => "7",
+            :order_by => "rent",
+            :order_direction => "asc"
+        })
+        @similar_props = @listing.similar_listings(@rentjuicer)
+      end
+
+      it "should return an empty array of listings" do
+        @similar_props.should be_empty
+      end
+    end
+
+    context "missing listings" do
+      before do
+        @rentjuicer = new_rentjuicer
+        mock_get('/listings.json', 'missing_listings.json', {
+            :neighborhoods => "South Boston", 
+            :min_rent => "2250.0",
+            :max_rent => "2750.0",
+            :min_beds => "2",
+            :max_beds => "4",
+            :min_baths => "0",
+            :max_baths => "2",
+            :limit => "7",
+            :order_by => "rent",
+            :order_direction => "asc"
+        })
+        @similar_props = @listing.similar_listings(@rentjuicer)
+      end
+
+      it "should return an empty array of listings" do
+        @similar_props.should be_empty
+      end
+    end
+
+    context "empty response" do
+      before do
+        @rentjuicer = new_rentjuicer
+        mock_get('/listings.json', 'empty_response.json', {
+            :neighborhoods => "South Boston", 
+            :min_rent => "2250.0",
+            :max_rent => "2750.0",
+            :min_beds => "2",
+            :max_beds => "4",
+            :min_baths => "0",
+            :max_baths => "2",
+            :limit => "7",
+            :order_by => "rent",
+            :order_direction => "asc"
+        })
+        @similar_props = @listing.similar_listings(@rentjuicer)
+      end
+
+      it "should return an empty array of listings" do
+        @similar_props.should be_empty
+      end
+    end
+  end
+
   context "mls_listing" do
     context "mlspin - 2 br tags" do
       before do
@@ -103,14 +174,14 @@ describe Rentjuicer::Listing do
           "attribution" => "This listing courtesy of Holly Kampler at Classic Realty<br \/><br \/>The property listing data and information, or the Images, set forth herein were provided to MLS Property Information Network, Inc. from third party sources, including sellers, lessors and public records, and were compiled by MLS Property Information Network, Inc.  The property listing data and information, and the Images, are for the personal, non-commercial use of consumers having a good faith interest in purchasing or leasing listed properties of the type displayed to them and may not be used for any purpose other than to identify prospective properties which such consumers may have a good faith interest in purchasing or leasing.  MLS Property Information Network, Inc. and its subscribers disclaim any and all representations and warranties as to the accuracy of the property listing data and information, or as to the accuracy of any of the Images, set forth herein."
         }))
       end
-      
+
       it { @listing.mls_listing?.should be_true }
       it { @listing.source_name.should == "MLS PIN" }
       it { @listing.attribution.should == "This listing courtesy of Holly Kampler at Classic Realty<br \/><br \/>The property listing data and information, or the Images, set forth herein were provided to MLS Property Information Network, Inc. from third party sources, including sellers, lessors and public records, and were compiled by MLS Property Information Network, Inc.  The property listing data and information, and the Images, are for the personal, non-commercial use of consumers having a good faith interest in purchasing or leasing listed properties of the type displayed to them and may not be used for any purpose other than to identify prospective properties which such consumers may have a good faith interest in purchasing or leasing.  MLS Property Information Network, Inc. and its subscribers disclaim any and all representations and warranties as to the accuracy of the property listing data and information, or as to the accuracy of any of the Images, set forth herein."}
       it { @listing.courtesy_of.should == "This listing courtesy of Holly Kampler at Classic Realty"}
       it { @listing.mls_disclaimer.should == "The property listing data and information, or the Images, set forth herein were provided to MLS Property Information Network, Inc. from third party sources, including sellers, lessors and public records, and were compiled by MLS Property Information Network, Inc.  The property listing data and information, and the Images, are for the personal, non-commercial use of consumers having a good faith interest in purchasing or leasing listed properties of the type displayed to them and may not be used for any purpose other than to identify prospective properties which such consumers may have a good faith interest in purchasing or leasing.  MLS Property Information Network, Inc. and its subscribers disclaim any and all representations and warranties as to the accuracy of the property listing data and information, or as to the accuracy of any of the Images, set forth herein."}
     end
-    
+
     context "RAMB - no disclaimer, attribution only" do
       before do
         @listing = Rentjuicer::Listing.new(valid_listing_rash.merge({
@@ -119,14 +190,14 @@ describe Rentjuicer::Listing do
           "attribution" => "This listing is courtesy of XYZ Realty"
         }))
       end
-      
+
       it { @listing.mls_listing?.should be_true }
       it { @listing.source_name.should == "RAMB" }
       it { @listing.attribution.should == "This listing is courtesy of XYZ Realty"}
       it { @listing.courtesy_of.should == "This listing is courtesy of XYZ Realty"}
       it { @listing.mls_disclaimer.should be_nil}
     end
-    
+
     context "MRED - 1 br and an image" do
       before do
         @listing = Rentjuicer::Listing.new(valid_listing_rash.merge({
@@ -135,14 +206,14 @@ describe Rentjuicer::Listing do
           "attribution" => "<img src=\"http://idx.advancedaccess.com/disclaimer/brlogo125.jpg\" style=\"float:left; padding-right:10px;\" />Listing office: XYZ Realty<br />Properties marked with the MRED approved icon are courtesy of Midwest Real Estate Data, LLC.  Information deemed reliable but not guaranteed.  Copyright&copy; 2010 Midwest Real Estate Data LLC.  All rights reserved."
         }))
       end
-      
+
       it { @listing.mls_listing?.should be_true }
       it { @listing.source_name.should == "MRED" }
       it { @listing.attribution.should == "<img src=\"http://idx.advancedaccess.com/disclaimer/brlogo125.jpg\" style=\"float:left; padding-right:10px;\" />Listing office: XYZ Realty<br />Properties marked with the MRED approved icon are courtesy of Midwest Real Estate Data, LLC.  Information deemed reliable but not guaranteed.  Copyright&copy; 2010 Midwest Real Estate Data LLC.  All rights reserved."}
       it { @listing.courtesy_of.should == "<img src=\"http://idx.advancedaccess.com/disclaimer/brlogo125.jpg\" style=\"float:left; padding-right:10px;\" />Listing office: XYZ Realty"}
       it { @listing.mls_disclaimer.should == "Properties marked with the MRED approved icon are courtesy of Midwest Real Estate Data, LLC.  Information deemed reliable but not guaranteed.  Copyright&copy; 2010 Midwest Real Estate Data LLC.  All rights reserved."}
     end
-    
+
     context "nil attribution" do
       before do
         @listing = Rentjuicer::Listing.new(valid_listing_rash.merge({
@@ -151,14 +222,14 @@ describe Rentjuicer::Listing do
           "attribution" => nil
         }))
       end
-      
+
       it { @listing.mls_listing?.should be_true }
       it { @listing.source_name.should == "MLS PIN" }
       it { @listing.attribution.should == nil}
       it { @listing.courtesy_of.should == nil}
       it { @listing.mls_disclaimer.should == nil}
     end
-    
+
     context "missing attribution" do
       before do
         @listing = Rentjuicer::Listing.new(valid_listing_rash.merge({
@@ -166,14 +237,14 @@ describe Rentjuicer::Listing do
           "source_name" => "MLS PIN"
         }))
       end
-      
+
       it { @listing.mls_listing?.should be_true }
       it { @listing.source_name.should == "MLS PIN" }
       it { @listing.attribution.should == nil}
       it { @listing.courtesy_of.should == nil}
       it { @listing.mls_disclaimer.should == nil}
     end
-    
+
     context "blank attribution" do
       before do
         @listing = Rentjuicer::Listing.new(valid_listing_rash.merge({
@@ -182,7 +253,7 @@ describe Rentjuicer::Listing do
           "attribution" => ""
         }))
       end
-      
+
       it { @listing.mls_listing?.should be_true }
       it { @listing.source_name.should == "MLS PIN" }
       it { @listing.attribution.should == ""}
@@ -190,5 +261,5 @@ describe Rentjuicer::Listing do
       it { @listing.mls_disclaimer.should == nil}
     end
   end
-  
+
 end

data/spec/rentjuicer/listings_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe Rentjuicer::Listing do
-  
+
   before do
     @rentjuicer = new_rentjuicer
     @listings = Rentjuicer::Listings.new(@rentjuicer)
   end
-  
+
   context "search" do
     before do
       mock_get('/listings.json', 'listings.json', {
@@ -16,21 +16,22 @@ describe Rentjuicer::Listing do
       })
       @result = @listings.search(:neighborhoods => "South Boston")
     end
-    
+
     it { @result.should be_kind_of(Rentjuicer::Listings::SearchResponse) }
     it { @result.success?.should be_true }
-    
+
     context "search response" do
       it { @result.should be_kind_of(Rentjuicer::Response)}
+
       it { @result.should respond_to(:properties, :paginator) }
-      
+
       it "should return an array of properties" do
         @result.properties.should be_kind_of(Array)
         @result.properties.each do |property|
           property.should be_kind_of(Rentjuicer::Listing)
         end
       end
-      
+
       it "should return a will_paginate collection" do
         @result.paginator.should be_kind_of(WillPaginate::Collection)
         @result.paginator.collect{|p| p.id}.should == @result.properties.collect{|p| p.id}
@@ -47,10 +48,10 @@ describe Rentjuicer::Listing do
       })
       @result = @listings.search(:include_mls => "1")
     end
-    
+
     context "search response" do
       it { @result.mls_results?.should be_true }
-      
+
       it "should return an array of uniq property mls_disclaimers" do
         @result.mls_disclaimers.should == [
           "The property listing data and information, or the Images, set forth herein were provided to MLS Property Information Network, Inc. from third party sources, including sellers, lessors and public records, and were compiled by MLS Property Information Network, Inc.  The property listing data and information, and the Images, are for the personal, non-commercial use of consumers having a good faith interest in purchasing or leasing listed properties of the type displayed to them and may not be used for any purpose other than to identify prospective properties which such consumers may have a good faith interest in purchasing or leasing.  MLS Property Information Network, Inc. and its subscribers disclaim any and all representations and warranties as to the accuracy of the property listing data and information, or as to the accuracy of any of the Images, set forth herein."
@@ -66,21 +67,62 @@ describe Rentjuicer::Listing do
       })
       @listing = @listings.find_by_id(200306)
     end
-    
+
     it { @listing.should be_kind_of(Rentjuicer::Listing) }
   end
-  
+
   context "find_by_id missing" do
     before do
-      mock_get('/listings.json', 'no_listings.json', {
+      mock_get('/listings.json', 'null_listings.json', {
         :rentjuice_id => "1"
       })
       @listing = @listings.find_by_id(1)
     end
-    
+
     it { @listing.should be_nil }
   end
-  
+
+  context "nil listings" do
+    context "null listings" do
+      before do
+        mock_get('/listings.json', 'null_listings.json', {
+          :limit => "20",
+          :order_by => "rent",
+          :order_direction => "asc"
+        })
+        @results = @listings.search(:limit => 20, :order_by => "rent", :order_direction => "asc")
+      end
+
+      it { @results.properties.should be_empty }
+    end
+
+    context "missing listings" do
+      before do
+        mock_get('/listings.json', 'missing_listings.json', {
+          :limit => "20",
+          :order_by => "rent",
+          :order_direction => "asc"
+        })
+        @results = @listings.search(:limit => 20, :order_by => "rent", :order_direction => "asc")
+      end
+
+      it { @results.properties.should be_empty }
+    end
+
+    context "empty response" do
+      before do
+        mock_get('/listings.json', 'empty_response.json', {
+          :limit => "20",
+          :order_by => "rent",
+          :order_direction => "asc"
+        })
+        @results = @listings.search(:limit => 20, :order_by => "rent", :order_direction => "asc")
+      end
+
+      it { @results.properties.should be_empty }
+    end
+  end
+
   context "featured" do
     before do
       mock_get('/listings.json', 'featured.json', {
@@ -90,15 +132,16 @@ describe Rentjuicer::Listing do
       })
       @result = @listings.featured
     end
-    
+
     it { @result.should be_kind_of(Rentjuicer::Listings::SearchResponse) }
+
     it { @result.success?.should be_true }
-    
+
     it "should only return featured properties" do
       @result.properties.collect{|p| p.featured == 1}.size.should == @result.properties.size
     end
   end
-  
+
   context "find_all_by_ids" do
     before do
       @find_ids = [
@@ -119,14 +162,14 @@ describe Rentjuicer::Listing do
       })
       @properties = @listings.find_all_by_ids(@find_ids.join(','))
     end
-    
+
     context "passing a string of ids" do
       before do
         @properties = @listings.find_all_by_ids(@find_ids.join(','))
       end
-      
+
       it { @properties.should be_kind_of(Array) }
-      
+
       it "should only return properties for requested ids" do
         @property_ids = @properties.collect{|p| p.rentjuice_id}
         @find_ids.each do |id|
@@ -134,14 +177,14 @@ describe Rentjuicer::Listing do
         end
       end
     end
-    
+
     context "passing an array of ids" do
       before do
         @properties = @listings.find_all_by_ids(@find_ids)
       end
-      
+
       it { @properties.should be_kind_of(Array) }
-      
+
       it "should only return properties for requested ids" do
         @property_ids = @properties.collect{|p| p.rentjuice_id}
         @find_ids.each do |id|
@@ -150,7 +193,7 @@ describe Rentjuicer::Listing do
       end
     end
   end
-  
+
   context "find_all" do
     before do
       search_params = {
@@ -164,9 +207,8 @@ describe Rentjuicer::Listing do
       mock_get('/listings.json', 'find_all_3.json', mock_parms.merge!(:page => "3"))
       @properties = @listings.find_all(search_params)
     end
-    
+
     it { @properties.should be_kind_of(Array)}
-    
   end
-  
+
 end

data/spec/responses/missing_listings.json

@@ -0,0 +1,7 @@
+{
+    "status": "ok",
+    "page": 1,
+    "count": 0,
+    "total_count": 0,
+    "runtime": 0.056
+}

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rentjuicer
 version: !ruby/object:Gem::Version 
-  hash: 1
+  hash: 7
   prerelease: 
   segments: 
   - 0
   - 7
-  - 1
-  version: 0.7.1
+  - 2
+  version: 0.7.2
 platform: ruby
 authors: 
 - tcocca
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-10-30 00:00:00 -04:00
+date: 2012-01-27 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -159,6 +159,7 @@ files:
 - spec/rentjuicer/neighborhoods_spec.rb
 - spec/rentjuicer/response_spec.rb
 - spec/rentjuicer_api_key.yml.example
+- spec/responses/empty_response.json
 - spec/responses/error.json
 - spec/responses/featured.json
 - spec/responses/find_all_1.json
@@ -170,9 +171,10 @@ files:
 - spec/responses/lead.json
 - spec/responses/lead_error.json
 - spec/responses/listings.json
+- spec/responses/missing_listings.json
 - spec/responses/mls_listings.json
 - spec/responses/neighborhoods.json
-- spec/responses/no_listings.json
+- spec/responses/null_listings.json
 - spec/spec_helper.rb
 - spec/support/listing_helper.rb
 - spec/support/webmock_helper.rb