rentjuicer 0.5.1 → 0.6.0

data/README.rdoc

@@ -34,6 +34,9 @@ Rentjuicer::Response also implements some method_missing so any methods on respo
 
   @results.neighborhoods == @results.body.neighborhoods
 
+Rentjuicer::Response by default does not raise an exception if the API errors, but the success? method will return false.
+There are some methods that you can call that will trigger exceptions (typically the ! methods, see below).
+
 In the rest of the README I will be accessing the methods off of response as I think it is cleaner to use and read.
 
 
@@ -53,7 +56,11 @@ To get a list of your neighborhoods in rentjuice you can access the neighborhood
   
   @response.neighborhoods contains an array of Rentjuice neighborhood objects in Hashie::Rash format
 
-if the request is invalid a Rentjuicer::Error exception will be raised
+If the request is invalid a Rentjuicer::Error exception will be not be raised but the @response.success? will return false.
+To trigger an error to raise if the request is invalid call:
+
+  @response = @neighborhoods.find_all!
+
 
 
 === Adding a lead to your account

data/VERSION

@@ -1 +1 @@
-0.5.1
+0.6.0

data/lib/rentjuicer/client.rb

@@ -11,5 +11,19 @@ module Rentjuicer
       self.class.base_uri "api.rentjuice.com/#{self.api_key}"
     end
     
+    def process_get(resource, params = {})
+      begin
+        unless params.blank?
+          self.class.get(resource, :query => params)
+        else
+          self.class.get(resource)
+        end
+      rescue Timeout::Error
+        {"status" => "timeout", "code" => "0", "message" => "Rentjuice API is timing out."}
+      rescue Exception
+        {"status" => "busted", "code" => "0", "message" => "Rentjuice API is erroring."}
+      end
+    end
+    
   end
 end

data/lib/rentjuicer/lead.rb

@@ -10,7 +10,7 @@ module Rentjuicer
     
     def create(name, params = {}, raise_error = false)
       params.merge!(:name => name)
-      Response.new(self.client.class.get(resource, :query => params), raise_error)
+      Response.new(self.client.process_get(resource, params), raise_error)
     end
     
     def create!(name, params = {})

data/lib/rentjuicer/listings.rb

@@ -12,7 +12,7 @@ module Rentjuicer
       limit = params[:limit] || 20
       params[:order_by] ||= "rent"
       params[:order_direction] ||= "asc"
-      SearchResponse.new(self.client.class.get(resource, :query => params), limit)
+      SearchResponse.new(self.client.process_get(resource, params), limit)
     end
     
     def featured(params = {})
@@ -21,7 +21,7 @@ module Rentjuicer
     end
     
     def find_by_id(listing_id)
-      response = SearchResponse.new(self.client.class.get(resource, :query => {:rentjuice_id => listing_id}))
+      response = SearchResponse.new(self.client.process_get(resource, {:rentjuice_id => listing_id}))
       (response.success? && response.properties.size > 0) ? response.properties.first : nil
     end
     

data/lib/rentjuicer/neighborhoods.rb

@@ -8,8 +8,12 @@ module Rentjuicer
       self.resource = "/neighborhoods.json"
     end
     
-    def find_all
-      Response.new(self.client.class.get(resource))
+    def find_all(raise_error = false)
+      Response.new(self.client.process_get(resource), raise_error)
+    end
+    
+    def find_all!
+      find_all(true)
     end
     
   end

data/lib/rentjuicer/response.rb

@@ -3,13 +3,13 @@ module Rentjuicer
     
     attr_accessor :body
     
-    def initialize(response, raise_error = true)
+    def initialize(response, raise_error = false)
       rash_response(response)
       raise Error.new(self.body.code, self.body.message) if !success? && raise_error
     end
     
     def success?
-      self.body.status == "ok"
+      self.body && !self.body.blank? && self.body.respond_to?(:status) && self.body.status == "ok"
     end
     
     def method_missing(method_name, *args)

data/rentjuicer.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rentjuicer}
-  s.version = "0.5.1"
+  s.version = "0.6.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["tcocca"]
-  s.date = %q{2011-04-19}
+  s.date = %q{2011-04-21}
   s.description = %q{Ruby API wrapper for rentjuice.com built with httparty}
   s.email = %q{tom.cocca@gmail.com}
   s.extra_rdoc_files = [

data/spec/rentjuicer/error_spec.rb

@@ -8,9 +8,15 @@ describe Rentjuicer::Error do
     mock_get(@neighborhoods.resource, 'error.json')
   end
   
-  it "should return an error" do
+  it "should not return an error" do
     lambda {
       @neighborhoods.find_all
+    }.should_not raise_exception
+  end
+  
+  it "should return an error" do
+    lambda {
+      @neighborhoods.find_all!
     }.should raise_exception(Rentjuicer::Error, "Rentjuicer Error: Invalid API key. (code: 1)")
   end
   

data/spec/rentjuicer/response_spec.rb

@@ -9,26 +9,26 @@ describe Rentjuicer::Response do
       mock_get(@neighborhoods.resource, 'error.json')
     end
     
-    it "should raise an exception" do
+    it "should not raise an exception" do
       lambda {
         @neighborhoods.find_all
-      }.should raise_exception
-    end
-  end
-  
-  context "passing raise_errors = false" do
-    it "should not raise errors when raise_errors is false" do
-      lambda {
-        Rentjuicer::Response.new(httparty_get('/neighborhoods.json', 'error.json'), false)
       }.should_not raise_exception
     end
     
     it "should not be a success" do
-      @response = Rentjuicer::Response.new(httparty_get('/neighborhoods.json', 'error.json'), false)
+      @response = Rentjuicer::Response.new(httparty_get('/neighborhoods.json', 'error.json'))
       @response.success?.should be_false
     end
   end
   
+  context "passing raise_errors = true" do
+    it "should raise errors when raise_errors is false" do
+      lambda {
+        Rentjuicer::Response.new(httparty_get('/neighborhoods.json', 'error.json'), true)
+      }.should raise_exception(Rentjuicer::Error, "Rentjuicer Error: Invalid API key. (code: 1)")
+    end
+  end
+  
   context "should return a response" do
     before do
       @rentjuicer = new_rentjuicer

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rentjuicer
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 7
   prerelease: 
   segments: 
   - 0
-  - 5
-  - 1
-  version: 0.5.1
+  - 6
+  - 0
+  version: 0.6.0
 platform: ruby
 authors: 
 - tcocca
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-19 00:00:00 -04:00
+date: 2011-04-21 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency