renstar 0.4.4 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5990b28a9195f211562ebc90e3164440e0a8e401272fa87c7d9a3f0bf8636a4
-  data.tar.gz: de3c2bc468511bbc4ce4e57030883996384a83572a70fa649fb882980318a78f
+  metadata.gz: d565afcb49d0a987fb6c54e0026fd2eb96f795ebf846ead087cc9c1afbab913e
+  data.tar.gz: fa3a09141ed51a0c586b899d9a6b7aad61d59c5618af55acaf44cf685341edcd
 SHA512:
-  metadata.gz: '08cb4e79d6675044dad081a517a5efd9c683b80e593f566459202084c35962f7c37c7f92448cad5d1a957a1753d972de8cbb7ca96e08db0d86716701af1aec6c'
-  data.tar.gz: 70a6044088c34b6a0c56d410cc63a1bfee460b6a4c2290846d09f03ed9263504f33c2b1706228e459a2be233de1e0a55439aa6a824b7047d2cc7721950ceb51d
+  metadata.gz: c39898c02620535be19828bbf95b797136df8f8993cdfd9e61d4da50aed1b5ee78e9365f4887a8a055137c087cc8692b5fc408f1a926ef32f840939a50d3fdad
+  data.tar.gz: 79513ae66be4d099d3d04ff254496e4755f3be8c547de9a46c68f5117099313bf443bf548fea646a36d47b7ef6f6fd16007fd573e3d8b849c717ac5d9fa57dcf

data/.github/workflows/ci.yml

@@ -0,0 +1,27 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.3'
+          - '3.4'
+          - '4.0'
+
+    steps:
+      - uses: actions/checkout@v5
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run test suite
+        run: bundle exec rake test

data/.ruby-version

@@ -1 +1 @@
-3.0.4
+3.4.10

data/README.md

@@ -4,6 +4,8 @@ Renstar is a Ruby SDK for interacting with the Venstar Thermostat Local API.
 
 You can control your thermostat programmatically!
 
+[![Maintainability](https://api.codeclimate.com/v1/badges/bf690d0fd84e34b70080/maintainability)](https://codeclimate.com/github/mikerodrigues/renstar/maintainability)
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -143,6 +145,25 @@ thermo.away
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
+## Testing
+
+Run the full test suite locally with:
+
+```bash
+bundle exec rake test
+```
+
+If you want to run the suite across the currently maintained MRI branches that
+this project targets, use:
+
+```bash
+script/test-supported-rubies
+```
+
+That script looks for installed `rbenv` versions matching the maintained MRI
+branches as of July 22, 2026: `3.3`, `3.4`, and `4.0`. CI runs the same matrix
+automatically on every push and pull request.
+
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing

data/Rakefile

@@ -1,4 +1,12 @@
 # frozen_string_literal: true
 
-require 'bundler/gem_tasks'
-task default: %i[]
+require 'rake/testtask'
+
+Rake::TestTask.new(:test) do |test|
+  test.libs << 'test'
+  test.pattern = 'test/**/*_test.rb'
+end
+
+require 'bundler/gem_tasks' if (ARGV & %w[build install release]).any?
+
+task default: :test

data/bin/renstar.rb

@@ -83,7 +83,13 @@ command = if ARGV.nil? || ARGV.empty?
             ARGV
           end
 
-response = thermo.send(*command)
+begin
+  response = thermo.send(*command)
+rescue NoMethodError
+  puts "'#{command.join(' ')}' is not a valid command"
+  exit 1
+end
+
 case response
 when String
   puts response

data/lib/renstar/api_client.rb

@@ -13,16 +13,26 @@ module Renstar
   # The actual client that handles getting, posting, and parsing API responses
   #
   module APIClient
+    class APIError < StandardError; end
+    class APIUnknownResponseError < StandardError; end
+
     def get(endpoint)
       uri = URI(location + endpoint)
-      response = Net::HTTP.get(uri)
-      JSON.parse(response)
+      response = Net::HTTP.get_response(uri)
+      JSON.parse(response.body)
     end
 
     def post(endpoint, options = {})
       uri = URI(location + endpoint)
       response = Net::HTTP.post_form(uri, options)
-      JSON.parse(response.body)
+      json = JSON.parse(response.body)
+      if json['error']
+        raise APIError, json['reason']
+      elsif json['success']
+        json
+      else
+        raise APIUnknownResponseError, response.body
+      end
     end
 
     include Query

data/lib/renstar/discovery.rb

@@ -22,7 +22,7 @@ module Renstar
     def ssdp_search(ip, timeout = 5)
       puts "Searching subnet associated with #{ip.ip_address}"
       ssdp = SSDP::Consumer.new({ bind: ip.ip_address })
-      thermos = ssdp.search(service: SERVICE, timeout: timeout)
+      ssdp.search(service: SERVICE, timeout: timeout)
     end
   end
 end

data/lib/renstar/thermostat.rb

@@ -31,14 +31,12 @@ module Renstar
     end
 
     def self.search(timeout = 3)
-      all_thermos = []
-      ips.each do |ip|
-        all_thermos << ssdp_search(ip, timeout)
+      all_thermos = ips.flat_map do |ip|
+        ssdp_search(ip, timeout)
       end
+
       all_thermos.flatten.map do |thermo|
-        location = thermo[:params]['Location']
-        usn = thermo[:params]['USN']
-        Renstar::Thermostat.new(location, usn)
+        Renstar::Thermostat.new(thermo[:params]['Location'], thermo[:params]['USN'])
       end
     end
 
@@ -54,27 +52,14 @@ module Renstar
     end
 
     def heat(heattemp = nil)
-      update
-      if heattemp
-        cooltemp = heattemp.to_i + 1
-      else
-        cooltemp = @cached_info.cooltemp
-        heattemp = @cached_info.heattemp
-      end
+      cooltemp, heattemp = set_temps(heattemp, 1)
       response = control("mode": 1, "cooltemp": cooltemp, "heattemp": heattemp)
       update
       response
     end
 
     def cool(cooltemp = nil)
-      update
-      if cooltemp
-        heattemp = cooltemp.to_i - 1
-        # heattemp = cooltemp - @cached_info.setpointdelta
-      else
-        cooltemp = @cached_info.cooltemp
-        heattemp = @cached_info.heattemp
-      end
+      cooltemp, heattemp = set_temps(cooltemp, 2)
       response = control("mode": 2, "cooltemp": cooltemp, "heattemp": heattemp)
       update
       response
@@ -134,5 +119,24 @@ module Renstar
       update
       response
     end
+
+    private
+
+    def set_temps(temp, mode)
+      update
+      if temp
+        if mode == 1
+          cooltemp = temp.to_i + 1
+          heattemp = temp.to_i
+        else
+          cooltemp = temp.to_i
+          heattemp = temp.to_i - 1
+        end
+      else
+        cooltemp = @cached_info.cooltemp
+        heattemp = @cached_info.heattemp
+      end
+      [cooltemp, heattemp]
+    end
   end
 end

data/lib/renstar/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Renstar
-  VERSION = '0.4.4'
+  VERSION = '0.4.6'
 end

data/renstar.gemspec

@@ -30,6 +30,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'json'
   spec.add_runtime_dependency 'ssdp', '~> 1.2.0'
+  spec.add_development_dependency 'minitest', '~> 5.25'
 
   # Uncomment to register a new dependency of your gem
   # spec.add_dependency "example-gem", "~> 1.0"

data/script/test-supported-rubies

@@ -0,0 +1,52 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+rbenv_bin="${RBENV_BIN:-$HOME/.rbenv/bin/rbenv}"
+supported_branches=(3.3 3.4 4.0)
+
+if [[ ! -x "$rbenv_bin" ]]; then
+  echo "rbenv was not found at $rbenv_bin" >&2
+  exit 1
+fi
+
+export PATH="$(dirname "$rbenv_bin"):$HOME/.rbenv/shims:$PATH"
+
+mapfile -t installed_versions < <("$rbenv_bin" versions --bare)
+
+resolve_version() {
+  local branch="$1"
+  local version=""
+
+  for candidate in "${installed_versions[@]}"; do
+    if [[ "$candidate" == "$branch"* ]]; then
+      version="$candidate"
+    fi
+  done
+
+  if [[ -n "$version" ]]; then
+    printf '%s\n' "$version"
+    return 0
+  fi
+
+  return 1
+}
+
+status=0
+
+cd "$repo_root"
+
+for branch in "${supported_branches[@]}"; do
+  if version="$(resolve_version "$branch")"; then
+    echo "==> Running tests on Ruby $version"
+    if ! RBENV_VERSION="$version" "$rbenv_bin" exec ruby -Itest \
+      -e 'Dir.glob("test/**/*_test.rb").sort.each { |file| require File.expand_path(file) }'; then
+      status=1
+    fi
+  else
+    echo "Missing rbenv Ruby for supported branch $branch" >&2
+    status=1
+  fi
+done
+
+exit "$status"

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: renstar
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.6
 platform: ruby
 authors:
 - Michael Rodrigues
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -38,6 +37,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.25'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.25'
 description: Control Venstar thermostats with Ruby via their local API.
 email:
 - mikebrodrigues@gmail.com
@@ -48,6 +61,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".ruby-version"
 - Gemfile
@@ -72,13 +86,13 @@ files:
 - lib/renstar/thermostat.rb
 - lib/renstar/version.rb
 - renstar.gemspec
+- script/test-supported-rubies
 homepage: https://github.com/mikerodrigues/renstar
 licenses: []
 metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/mikerodrigues/renstar
   source_code_uri: https://github.com/mikerodrigues/renstar
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -93,8 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Control Venstar thermostats.
 test_files: []