renstar 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5990b28a9195f211562ebc90e3164440e0a8e401272fa87c7d9a3f0bf8636a4
-  data.tar.gz: de3c2bc468511bbc4ce4e57030883996384a83572a70fa649fb882980318a78f
+  metadata.gz: 0af30640855c7d5568a2a8fbd16ac0f554f5bdf20415c5085974354120aedfd0
+  data.tar.gz: 04ddf28ef495cb77a1bfebe74d2ae508c9bac487f4eeb86bceddab6cbd2dd228
 SHA512:
-  metadata.gz: '08cb4e79d6675044dad081a517a5efd9c683b80e593f566459202084c35962f7c37c7f92448cad5d1a957a1753d972de8cbb7ca96e08db0d86716701af1aec6c'
-  data.tar.gz: 70a6044088c34b6a0c56d410cc63a1bfee460b6a4c2290846d09f03ed9263504f33c2b1706228e459a2be233de1e0a55439aa6a824b7047d2cc7721950ceb51d
+  metadata.gz: 2b8c6e5eb3c7e8e31481d9689c29f01e26f945f89a95342460d2f0864b74c51f9b2003116af4644c5e7f796213db8d016db4706b513b630c70f4a005b41c84ec
+  data.tar.gz: 6afab4dc745a6a18da67f1ecfff3e5047aed24930c23a7d5208864947a780f758ee0fab0f733e5824262b62ae0e198e4663b0b200b835df580ed6ccfcc39e5c2

data/README.md

@@ -4,6 +4,8 @@ Renstar is a Ruby SDK for interacting with the Venstar Thermostat Local API.
 
 You can control your thermostat programmatically!
 
+[![Maintainability](https://api.codeclimate.com/v1/badges/bf690d0fd84e34b70080/maintainability)](https://codeclimate.com/github/mikerodrigues/renstar/maintainability)
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/bin/renstar.rb

@@ -83,7 +83,13 @@ command = if ARGV.nil? || ARGV.empty?
             ARGV
           end
 
-response = thermo.send(*command)
+begin
+  response = thermo.send(*command)
+rescue NoMethodError
+  puts "'#{command.join(' ')}' is not a valid command"
+  exit 1
+end
+
 case response
 when String
   puts response

data/lib/renstar/api_client.rb

@@ -13,16 +13,26 @@ module Renstar
   # The actual client that handles getting, posting, and parsing API responses
   #
   module APIClient
+    class APIError < StandardError; end
+    class APIUnknownResponseError < StandardError; end
+
     def get(endpoint)
       uri = URI(location + endpoint)
-      response = Net::HTTP.get(uri)
-      JSON.parse(response)
+      response = Net::HTTP.get_response(uri)
+      JSON.parse(response.body)
     end
 
     def post(endpoint, options = {})
       uri = URI(location + endpoint)
       response = Net::HTTP.post_form(uri, options)
-      JSON.parse(response.body)
+      json = JSON.parse(response.body)
+      if json['error']
+        raise APIError, json['reason']
+      elsif json['success']
+        json
+      else
+        raise APIUnknownResponseError, response.body
+      end
     end
 
     include Query

data/lib/renstar/discovery.rb

@@ -22,7 +22,7 @@ module Renstar
     def ssdp_search(ip, timeout = 5)
       puts "Searching subnet associated with #{ip.ip_address}"
       ssdp = SSDP::Consumer.new({ bind: ip.ip_address })
-      thermos = ssdp.search(service: SERVICE, timeout: timeout)
+      ssdp.search(service: SERVICE, timeout: timeout)
     end
   end
 end

data/lib/renstar/thermostat.rb

@@ -31,14 +31,12 @@ module Renstar
     end
 
     def self.search(timeout = 3)
-      all_thermos = []
-      ips.each do |ip|
+      all_thermos = ips.each do |ip|
         all_thermos << ssdp_search(ip, timeout)
       end
+
       all_thermos.flatten.map do |thermo|
-        location = thermo[:params]['Location']
-        usn = thermo[:params]['USN']
-        Renstar::Thermostat.new(location, usn)
+        Renstar::Thermostat.new(thermo[:params]['Location'], thermo[:params]['USN'])
       end
     end
 
@@ -54,27 +52,14 @@ module Renstar
     end
 
     def heat(heattemp = nil)
-      update
-      if heattemp
-        cooltemp = heattemp.to_i + 1
-      else
-        cooltemp = @cached_info.cooltemp
-        heattemp = @cached_info.heattemp
-      end
+      cooltemp, heattemp = set_temps(heattemp, 1)
       response = control("mode": 1, "cooltemp": cooltemp, "heattemp": heattemp)
       update
       response
     end
 
     def cool(cooltemp = nil)
-      update
-      if cooltemp
-        heattemp = cooltemp.to_i - 1
-        # heattemp = cooltemp - @cached_info.setpointdelta
-      else
-        cooltemp = @cached_info.cooltemp
-        heattemp = @cached_info.heattemp
-      end
+      cooltemp, heattemp = set_temps(cooltemp, 2)
       response = control("mode": 2, "cooltemp": cooltemp, "heattemp": heattemp)
       update
       response
@@ -134,5 +119,24 @@ module Renstar
       update
       response
     end
+
+    private
+
+    def set_temps(temp, mode)
+      update
+      if temp
+        if mode == 1
+          cooltemp = temp.to_i + 1
+          heattemp = temp.to_i
+        else
+          cooltemp = temp.to_i
+          heattemp = temp.to_i - 1
+        end
+      else
+        cooltemp = @cached_info.cooltemp
+        heattemp = @cached_info.heattemp
+      end
+      [cooltemp, heattemp]
+    end
   end
 end

data/lib/renstar/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Renstar
-  VERSION = '0.4.4'
+  VERSION = '0.4.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: renstar
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Michael Rodrigues
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-31 00:00:00.000000000 Z
+date: 2024-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json