render_turbo_stream 4.3.3 → 4.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d66f0d9cb7dc4822dbcaf38e286b855386e8637b07a922db1714b14ab63d0c6d
-  data.tar.gz: 017a6047f0c07a1f2847f7be92d810483c00690e1c31f0cb31581004d48f8f18
+  metadata.gz: dd429fcf5885a88fd9362d97a3af9c7cca947d173911b4552e16ef752edfc93a
+  data.tar.gz: 1070b77583f60c208f1f38f9b7b6963d4604710fcb8bba0dd2746c379ce47739
 SHA512:
-  metadata.gz: a3853c69389798f965cb41e629fb208e6926b3a4ce2d5f0f925554cec41d470fa5963ad6d88dd1712e787be3db683f1e61cce7411c78f8dda574069f7d5a9b55
-  data.tar.gz: 78719ff0ab9c7299639161ba2a966786d18dc79b9f401e8112b58656f2270436c51119c3eb6297f73c4df4e40dc7843bebe4496a9a5cbcc6d187b6898fa00245
+  metadata.gz: 7be3a88170fb10070ddee8cb81670c5684949961214dd855e724c1cabe9004615fbb2c64fadb3f3339f23a776b623d1c2d14efdd07c67557d647951797684db6
+  data.tar.gz: d303cf736a91ebb95d35a06023d487d1073f2fed926c5bf0e5a72ec4b29cd5a2cbc4d928a0df83364157d951ed9727cf6181f5425f69cf85b079cd4eb58e11c4

data/README.md

@@ -109,7 +109,7 @@ The Rails team has integrated `ActionCable` as `Turbo::StreamsChannel` into `Tur
 
 ```ruby
 
-def update
+def create
   turbo_stream_save(
     @article.update(article_params),
     if_success_redirect_to: articles_path,
@@ -118,6 +118,8 @@ def update
 end
 ```
 
+Note that if you want to redirect to show path, but the save action fails, `article_path(@article)` would throw an error. For this, the arguments `if_success_turbo_redirect_to` and `if_success_redirect_to` accept procs that are evaluated only on success. So your line would look like this `if_success_redirect_to: ->{article_path(@article)}`.
+
 Assuming we want to build a form that works within a turbo-frame, including flash messages and redirects, we have to build all that inside a `turbo-frame`, and, within that we need a target-id, that must not be a turbo-frame. For that, there is a helper:
 
 ```haml
@@ -190,9 +192,6 @@ The target ID for turbo has to be unique for sure, and it has to be nice, becaus
 ```ruby
 # target_id(virtual_view_path, object)
 target_id('customers/_form', Customer.new) #=> 'new-customer-form'
-target_id('customers/_form', Customer.first) #=> 'customer-1-form'
-target_id('customers/_form', nil) #=> 'customers-form'
-target_id('customers/_form', 'hi-joe') #=> 'hi-joe'
 ```
 
 View-helper: Assuming we are inside `customers/_my_form`:
@@ -202,10 +201,13 @@ View-helper: Assuming we are inside `customers/_my_form`:
 target_id 
 #=> 'customer-1-my-form'
 
-target_id(Customer.new) 
-#=> 'new-customer-my-form'
+target_id(Customer.first) #=> 'customer-1-my-form'
+target_id( [Customer.first, Article.last, 'hello'] ) #=> 'customer-1-article-7-hello-my-form'
+target_id('hi-joe') #=> 'hi-joe'
 ```
 
+Why include the filename in a html-id? Because for turbo its likely to have multiple cases for the same object on the same page, for example: _form, _show, _password. These can all be the same customer.
+
 **Target-ID: Avoid the same definition in multiple places**
 
 Without this gem a turbo action would be wrapped within two frames, for example:
@@ -213,7 +215,6 @@ Without this gem a turbo action would be wrapped within two frames, for example:
 ```haml
 = turbo_stream.replace 'target-id' do 
   = render 'a partial'
- 
 ```
 
 and within a partial:

data/lib/render_turbo_stream/controller_helpers.rb

@@ -82,15 +82,23 @@ module RenderTurboStream
         Rails.logger.debug("  • Successful saved && Redirect by «turbo_redirect_to»")
         Rails.logger.debug("  • Set flash[:alert] => #{flashes[:alerts]}") if flashes[:alerts].present?
         Rails.logger.debug("  • Set flash[:notice] => #{flashes[:notices]}") if flashes[:notices].present?
+
+        if if_success_turbo_redirect_to.is_a?(Proc)
+          redirect_path = if_success_turbo_redirect_to.call
+        else
+          redirect_path = if_success_turbo_redirect_to
+        end
+
         render_turbo_stream([
                               [
                                 :redirect_to,
-                                if_success_turbo_redirect_to
+                                redirect_path
                               ]
                             ])
 
       elsif save_action && if_success_redirect_to.present?
         response.status = 303
+
         if allow_channel
           Rails.logger.debug("  • Send actions through Turbo::StreamsChannel")
           c_libs = RenderTurboStream::ChannelLibs.new(response)
@@ -103,7 +111,11 @@ module RenderTurboStream
           Rails.logger.debug("  • Set flash[:notice] => #{flashes[:notices]}") if flashes[:notices].present?
           Rails.logger.debug("  • Could not send #{streams.length} actions => #{streams}")
         end
-        redirect_to if_success_redirect_to
+        if if_success_redirect_to.is_a?(Proc)
+          redirect_to if_success_redirect_to.call
+        else
+          redirect_to if_success_redirect_to
+        end
 
       else
         Rails.logger.debug("  • Respond by TurboStream in #{streams.length} #{'action'.pluralize(streams.length)}")

data/lib/render_turbo_stream/libs.rb

@@ -53,26 +53,34 @@ module RenderTurboStream
     end
 
     def self.target_id(virt_view_path, id)
+
       if id.is_a?(String)
         id
-      elsif !id
-        [
-          virt_view_path.gsub('/', '-').gsub('-_', '-')
-        ].join('-')
-      else
-        unless id.methods.include?(:id)
-          raise("target_id / argument ID: Only String or object with method :id accepted")
-        end
+      elsif id
         (
-          (
-            id.id ?
-              [id.class.to_s.downcase, id.id] :
-              ['new', id.class.to_s.downcase]
-          ) +
+          (id.is_a?(Array) ? id : [id]).map do |_id|
+
+            if _id.is_a?(String)
+              _id
+            elsif _id.methods.include?(:id)
+              (
+                _id.id ?
+                  [_id.class.to_s.downcase, _id.id] :
+                  ['new', _id.class.to_s.downcase]
+              ).join('-')
+            else
+              _id.to_s
+            end
+          end +
             [
               virt_view_path.split('/').last.sub(/^_/, '')
             ]
         ).join('-')
+
+      else
+        [
+          virt_view_path.gsub('/', '-').gsub('-_', '-')
+        ].join('-')
       end
     end
 

data/lib/render_turbo_stream/version.rb

@@ -1,3 +1,3 @@
 module RenderTurboStream
-  VERSION = "4.3.3"
+  VERSION = "4.3.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: render_turbo_stream
 version: !ruby/object:Gem::Version
-  version: 4.3.3
+  version: 4.3.5
 platform: ruby
 authors:
 - christian
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-17 00:00:00.000000000 Z
+date: 2023-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails