render_turbo_stream 1.4.8 → 1.4.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2867377565fa534235ee93511f311d9c1c89ad883fc03f09a49e5e4675a5a491
-  data.tar.gz: 130ad91aabf627e127ab35bd68e496a559f51611116ae0beff7a9c4d923ec7ff
+  metadata.gz: 64b60c79e4190078560e1f08d175acfe17563316c6bf6079401841e9ac316198
+  data.tar.gz: 42d0f14d62ad08acb537658b2b83b113297e464da77ac95a33d41b9667e6da6a
 SHA512:
-  metadata.gz: c6649a22e9d313a214023d4bf2cb06128bdd4352fe41f0790a51938d5091048c03520c87bcb70398f1b7b32daa0ca67100fe6445b15b336193bdf22ce93de221
-  data.tar.gz: 3e964aec46ed46844c479d07267c2887c8c9392a14d6ea416f0975dfafb41fdfb32c6a3ca94bfacef3144dc5d0deaca6c3c6c2c1ce9d0d0854820d63464b5f64
+  metadata.gz: b47e40f983bff09126f2307f0b3f40e64a16132899cdb032573b4fcfa6ab1f9fb01256a8237eb15b17ce0c1e250a25e2e9f18af7efbdc14fd94f2ca4882c5b5c
+  data.tar.gz: 4e0c932e70b68297d69aecdda5259abc5bcd11e0c355c9c12b27dcda204d656f90680b97b5bff2472cda64d9828d0b51c9cadf3e58415acf155f034407a9a95d

data/README.md

@@ -81,6 +81,8 @@ def update
   turbo_stream_save(
     @customer.update(customer_params),
     turbo_redirect_on_success_to: edit_customer_path(@customer),
+    id: 'customer-form',
+    partial: 'form'
   )
 end
 ```
@@ -91,7 +93,7 @@ This will set a status, generate a flash message and perform `render_turbo_strea
 render_turbo_stream(
   [
     {
-      id: 'form',
+      id: 'customer-form',
       partial: 'customers/form'
     },
     {
@@ -103,7 +105,7 @@ render_turbo_stream(
 )
 ```
 
-The `stream_partial` method is just for rendering a partial alone.
+The `stream_partial` method is for rendering a partial alone.
 
 ```ruby
 stream_partial(
@@ -118,7 +120,7 @@ stream_partial(
 
 **More options**
 
-`render_turbo_stream` interprets a hash as a partial to be sent by `turbo_stream` and an array as a command to be sent. This allows you to perform most actions from e.g. [turbo_power](https://github.com/marcoroth/turbo_power). An example of adding a css class to an html element and updating the browser history would look like this:
+`render_turbo_stream` interprets a hash as a partial to be sent by `turbo_stream` and an array as a command to be sent. This allows you to perform most actions from, e.g., [turbo_power](https://github.com/marcoroth/turbo_power). An example of adding a css class to an html element and updating the browser history would look like this:
 
 ```ruby
 render_turbo_stream(
@@ -140,7 +142,7 @@ Under the hood, inside a `*.turbo_stream.erb` template, it does the following: `
 
 **WORKAROUND for redirects inside frame**
 
-Suppose you have a CRUD controller that should do all its actions inside a turbo frame. Classic redirect_to, along with a Flash message, would raise "Render and/or redirect were called multiple times in this action". See [issue] (https://gitlab.com/sedl/renderturbostream/-/issues/3).
+Suppose you have a CRUD controller that should do all its actions inside a turbo frame. Classic redirect_to, along with a Flash message, would raise «Render and/or redirect were called multiple times in this action». See [issue](https://gitlab.com/sedl/renderturbostream/-/issues/3).
 
 You can handle this by reloading the parent frame's src attribute. The code might look like this:
 
@@ -154,6 +156,9 @@ def update
           :turbo_frame_set_src,
           'cars-box',
           cars_path
+        ],
+        [
+          #... more actions possible ...
         ]
       ]
     )
@@ -276,10 +281,10 @@ includes the plugin and has tests done by rspec/request and capybara.
 
 ## More Configs
 
-On test helpers, the marker for a turbo-stream target is in most cases the id of the target element. This is true for the standard turbo-stream functions. On `turbo_power` it is the same in most cases. `RenderTurboStream::Libs.first_attr_is_html_id()` checks for which methods this is true. You can override this:
+On test helpers, the marker for a turbo-stream target is in most cases the id of the target element. This is true for the standard turbo-stream functions. On `turbo_power` it is the same in most cases. `RenderTurboStream::Libs.first_arg_is_html_id()` checks for which methods this is true. You can override this:
 
 ```ruby
-config.x.render_turbo_stream.first_attribute_is_html_id = %[replace append prepend turbo_frame_set_src]
+config.x.render_turbo_stream.first_argument_is_html_id = %[replace append prepend turbo_frame_set_src]
 ```
 
 This setting is relevant for testing helpers.

data/app/views/render_turbo_stream.html.erb

@@ -4,7 +4,7 @@
 <% streams.each do |s| %>
 
   <% if s.is_a?(Array) %>
-    <% attr_id = RenderTurboStream::Libs.first_attr_is_html_id(s.first) %>
+    <% attr_id = RenderTurboStream::Libs.first_arg_is_html_id(s.first) %>
     <% h = { attributes: s, type: 'command' } %>
     <% h[:target] = "##{s.second}" if attr_id %>
     <% rendered_partials.push(h) %>

data/app/views/render_turbo_stream.turbo_stream.erb

@@ -7,25 +7,22 @@
   <% if args.is_a?(Array) %>
 
     <% ctl = "turbo_stream.#{args.first}, #{args[1..-1].join(', ')}" %>
-    <% Rails.logger.debug("  RENDER TURBO STREAM => #{ctl}") %>
+    <% Rails.logger.debug("  • render-turbo-stream => #{ctl}") %>
     <%= turbo_stream.send args.first, *(args[1..-1]) %>
 
 
   <% else %>
     <% ctl = { partial: args[:partial], id: args[:id], action: args[:action] } %>
     <% info = { id: args[:id], partial: args[:partial], locals: args[:locals] } %>
-    <% if !args[:action].present? %>
-      <% Rails.logger.error("  ERROR RENDER TURBO STREAM => MISSING ACTION => #{args}") %>
-      <% error = true %>
-
-    <% elsif args[:action].present? %>
+    <% if args[:action].present? %>
       <% Rails.logger.debug("  • render-turbo-stream #{args[:action].upcase} => #{info}") %>
       <%= turbo_stream.send args[:action].to_sym, args[:id] do %>
         <%= render args[:partial], locals: args[:locals]&.symbolize_keys %>
       <% end %>
 
     <% else %>
-      <% Rails.logger.error("  ERROR RENDER TURBO STREAM => NOTHING DONE! => #{args}") %>
+      <% Rails.logger.error("  ERROR RENDER TURBO STREAM => MISSING ACTION => #{args}") %>
+      <% error = true %>
     <% end %>
   <% end %>
 

data/lib/render_turbo_stream/test/request_helpers.rb

@@ -62,7 +62,7 @@ module RenderTurboStream
 
           if r['type'] == 'command'
             act = r['attributes'].first
-            is_id = RenderTurboStream::Libs.first_attr_is_html_id(act)
+            is_id = RenderTurboStream::Libs.first_arg_is_html_id(act)
             if action.to_s == act && is_id && r['attributes'].second == id.to_s
               k = [act, r['attributes'].second].join('-')
               counts[k] ||= 0

data/lib/render_turbo_stream/version.rb

@@ -1,3 +1,3 @@
 module RenderTurboStream
-  VERSION = "1.4.8"
+  VERSION = "1.4.10"
 end

data/lib/render_turbo_stream.rb

@@ -260,8 +260,8 @@ module RenderTurboStream
     # This method checks for that
     # it includes the methods from turbo-power
     # used for test helpers
-    def self.first_attr_is_html_id(method)
-      config = Rails.configuration.x.render_turbo_stream.first_attribute_is_html_id
+    def self.first_arg_is_html_id(method)
+      config = Rails.configuration.x.render_turbo_stream.first_argument_is_html_id
       default = [
         :graft,
         :morph,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: render_turbo_stream
 version: !ruby/object:Gem::Version
-  version: 1.4.8
+  version: 1.4.10
 platform: ruby
 authors:
 - christian
@@ -72,6 +72,6 @@ requirements: []
 rubygems_version: 3.4.12
 signing_key:
 specification_version: 4
-summary: Render partials and run javascripts directly from the controller. With test
+summary: Run javascripts and render partials directly from the controller. With test
   helpers.
 test_files: []