render_turbo_stream 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 395968d08aa5420fbd50bb63bccb641098503d33002a36a1a9f753b52caaae2b
-  data.tar.gz: 537a3ed1c128c26df63083c545c7ba53c02167c30a38a69adf08261bbb27e069
+  metadata.gz: cf65f7ac19c9387a4ee6a42f9e2227082ec7996aef74e672cc45aa04f75becf7
+  data.tar.gz: 558ecbee422b8eab39c292f82ae0df3df54cc5b439b0e8a7b83008dc863e00ec
 SHA512:
-  metadata.gz: a793feeaa175a29b27bd2811f6248de5e5e913224f455547b6fdb5cd1707e36f76d3e2b23824cd3c4a2c7197a5c25e50f99800c355ed0b55c76bae78f127586a
-  data.tar.gz: 0d0294aed7dc3c57e580d34a939145c3ccd423a434da2bfad40d8daf7a769b3e4efece554d814a4f533f0eb21fb1efcdba4d223a6fc701106434635bd2e58a32
+  metadata.gz: 11549d8a9b8145ca04e7e025516a74edbeeb726bfa9d3bfca0fa819c2d8bf76da7d354c860ec01ec461b4d50b80e0fb197aaf34b30502b1d29d72718982cf149
+  data.tar.gz: 8405143aeae7793da5011b56e5993843dac2f0f97c5d0cce712d5fac0eca5a1e4045dd7680b72db76f6c5c761dd35f7f3fa24fb71e029dbde6bda8b49b140281

data/README.md

@@ -195,7 +195,7 @@ it 'update failed' do
   expect_successful_saved('customer-form', 'flash-box')
   # expects response.status 200
   # Make sure that the responses point to exactly these 2 IDs ('form' and 'flash-box').
-  # Make sure that each ID is responded to exactly once.
+  # Make sure that to each ID is responded to exactly once.
 end
 ```
 
@@ -218,7 +218,7 @@ expect(stream_response('customer-form')).to eq(true)
 # Make sure that the id «customer-form» is targeted exactly once.
 
 expect(stream_response('customer-form', css: '.field_with_errors', include_string: 'Title')).to eq(true)
-# Check the content inside at least one in any of the elements that match the given css and check the id that turbo has pointed to..
+# Verify that the response targeted to "customer-form" contains the specified html.
 ```
 
 **More detailed**
@@ -240,11 +240,13 @@ expect(
   end
 ).to eq(1)
 ```
-`stream_target_response_count` always returns the number of matched responses.
+`stream_target_response_count` returns the number of matched responses.
 
-Possible matchers can be found at [Nokogiri](https://nokogiri.org/tutorials/searching_a_xml_html_document.html). That should be enough for this level. For more detailed testing of partials, there are view tests. And many of the partials are regularly accessed in two ways, for example a `form': it is pushed by turbo_stream as well as by calling edit_customer_path.
+Possible matchers can be found at [Nokogiri](https://nokogiri.org/tutorials/searching_a_xml_html_document.html). 
 
-P.S.:
+For more detailed testing of partials, there are view tests.
+
+**P.S.:**
 
 Testing the plugin itself: There is a [quick-and-dirty app](https://gitlab.com/sedl/renderturbostream_railsapp) which
 includes the plugin and has tests done by rspec/request and capybara.

data/lib/render_turbo_stream/version.rb

@@ -1,3 +1,3 @@
 module RenderTurboStream
-  VERSION = "1.4.1"
+  VERSION = "1.4.2"
 end

data/lib/render_turbo_stream.rb

@@ -8,7 +8,8 @@ module RenderTurboStream
 
   def turbo_stream_save(
     save_action,
-    redirect_on_success_to: nil,
+    redirect_on_success_to: nil, # does a regular redirect. Works if you are inside a turbo_frame and just want to redirect inside that frame
+    turbo_redirect_on_success_to: nil, # does a full page redirect (break out of all frames by turbo_power redirect)
     object: nil, # object used in save_action, example: @customer
     id: 'form', # if nil: no partial is rendered
     partial: nil, # example: 'customers/form' default: "#{controller_path}/#{id}"
@@ -122,16 +123,27 @@ module RenderTurboStream
 
     #== render
 
-    if save_action && redirect_on_success_to.present?
+    if save_action && turbo_redirect_on_success_to.present?
       response.status = 302
       flash[:alert] = flash_alerts
       flash[:notice] = flash_notices
       render_turbo_stream([
                             [
                               :redirect_to,
-                              redirect_on_success_to
+                              turbo_redirect_on_success_to
                             ]
                           ])
+    elsif save_action && redirect_on_success_to.present?
+      response.status = 302
+      flash.now[:alert] = flash_alerts
+      flash.now[:notice] = flash_notices
+      render_turbo_stream([
+                            [
+                              :redirect_to,
+                              turbo_redirect_on_success_to
+                            ]
+                          ])
+
     else
       flash.now[:alert] = flash_alerts
       flash.now[:notice] = flash_notices

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: render_turbo_stream
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - christian