render_csv 1.0.0 → 2.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5ad9d5c8bda0efcb8407450d74c467aa0912882
-  data.tar.gz: 49d9fa1e8d4464c0c432e71f279dfcc72d084c9c
+  metadata.gz: 0456d41778a62cf6042dcf1afe16f46e54967ae3
+  data.tar.gz: aeae7731318782ed808fecb6b8eb43c1ac8b03ef
 SHA512:
-  metadata.gz: e8e20a0d0e3b957f199f943a7f6bc69d2b9e0a6a2ad19edc4657708dbcb0dbd944ad6812a388777aaabd9b5c3c21f1c144d349a63cb20067054264c6e07f8a6e
-  data.tar.gz: d7fab3e3c13ac5dd0706a07597ff52af665547e663d5da19fbb7750bbb455e646d7ebf6bac836b551d57fb4c646c4f5a41d4ef309ab5e3e70162af04fa9be44f
+  metadata.gz: 84a934923c771e3f17aa484e95c9cc4dbfa81fef0fc6d9d4e19db8afd14b70da94b8b22b279a517353abc48f3e546f2581243c8cfc8b5a382b38f4a945b61217
+  data.tar.gz: b298832ae25962b4c9ade57b9485f63557a6a1512c0eba8f2fde6689e1a8d4e31ef3b5d45b01594fbbad6cc31ab5456dfec064436bff78f91020e13ccebf780d

data/.travis.yml

@@ -1,14 +1,10 @@
 language: ruby
 rvm:
-  - 1.8.7
   - 1.9.3
   - 2.0.0
+  - 2.1.0
 gemfile:
   - gemfiles/Gemfile.rails-3.0.x
   - gemfiles/Gemfile.rails-3.1.x
   - gemfiles/Gemfile.rails-3.2.x
   - gemfiles/Gemfile.rails-4.0.x
-matrix:
-  exclude:
-    - rvm: 1.8.7
-      gemfile: gemfiles/Gemfile.rails-4.0.x

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+
+## 2.0.0 (unreleased)
+
+  * Removes support for Ruby 1.8.7.
+  * Moves renderer into an after_initialize block so the Rails app is
+    loaded before it tries to register itself. Should fix intermittent
+    issues with it not working in production environments.
+  * Use Ruby's CSV library instead of manually building strings.
+
+## 1.0.0
+
+  * Initial Release

data/README.md

@@ -11,7 +11,7 @@ Rails CSV renderer for ActiveRecord collections
 
 *Rails:* 3.0.x - 4.0.x
 
-*Ruby:* 1.8.7, 1.9.2, 1.9.3 and 2.0.0
+*Ruby:* 1.9.2, 1.9.3 and 2.0.0
 
 ## Installation
 
@@ -88,5 +88,5 @@ end
 
 ## Copyright
 
-Copyright (c) 2011-2013 Peter Brown. See LICENSE.txt for
+Copyright © 2011-2014 Peter Brown. See LICENSE.txt for
 further details.

data/lib/render_csv.rb

@@ -1,6 +1,14 @@
-require 'render_csv/extension'
-require 'action_controller/metal/renderers'
+module RenderCsv
+  class RenderCsvRailtie < ::Rails::Railtie
+    config.after_initialize do
+      require 'render_csv/extension'
+      require 'action_controller/metal/renderers'
 
-ActionController.add_renderer :csv do |csv, options|
-  self.response_body = csv.respond_to?(:to_csv) ? csv.to_csv(options) : csv
+      ActionController.add_renderer :csv do |csv, options|
+        filename = options[:filename] || options[:template]
+        data = csv.respond_to?(:to_csv) ? csv.to_csv(options) : csv
+        send_data data, type: Mime::CSV, disposition: "attachment; filename=#{filename}.csv"
+      end
+    end
+  end
 end

data/lib/render_csv/extension.rb

@@ -1,3 +1,5 @@
+require 'csv'
+
 class Array
 
   # Converts an array to CSV formatted string
@@ -14,9 +16,11 @@ class Array
     columns -= options[:except].map(&:to_s) if options[:except]
     columns += options[:add_methods].map(&:to_s) if options[:add_methods]
 
-    csv = [columns.join(',')]
-    csv.concat(map {|v| columns.map {|c| v.send(c) }.join(',') })
-
-    csv.join("\n")
+    CSV.generate(encoding: 'utf-8') do |row|
+      row << columns
+      self.each do |obj|
+        row << columns.map { |c| obj.send(c) }
+      end
+    end
   end
 end

data/lib/render_csv/version.rb

@@ -1,3 +1,3 @@
 module RenderCsv
-  VERSION = "1.0.0"
+  VERSION = "2.0.0.beta1"
 end

data/spec/lib/array_spec.rb

@@ -1,73 +1,59 @@
 require './spec/spec_helper'
 
 describe Array do
-  let(:sebastian) { Dog.create!(:name => 'Sebastian', :age => 3, :weight => 76.8) }
-  let(:ruby) { Dog.create!(:name => 'Ruby', :age => 3, :weight => 68.2) }
-  let(:shelby) { Dog.create!(:name => 'Shelby', :age => 5, :weight => 64.0) }
-  let(:array) { [sebastian,ruby,shelby] }
-
-  it 'should return an empty string if array is empty' do
-    [].to_csv.should eql('')
+  let(:sebastian) { Dog.create!(name: "Sebastian O'Connor", age: 3, weight: 76.8) }
+  let(:ruby) { Dog.create!(name: 'Ruby', age: 3, weight: 68.2) }
+  let(:shelby) { Dog.create!(name: 'Shelby', age: 5, weight: 64.0) }
+  let(:array) { [sebastian, ruby, shelby] }
+
+  context 'array is empty' do
+    it 'returns an empty string' do
+      expect([].to_csv).to eql('')
+    end
   end
 
-  it 'should return return a csv of the array if it is not an AR class' do
-    [1,2,3].to_csv.should eql('1,2,3')
+  context 'object is not an instance of AR class' do
+    it 'returns a csv of the array' do
+      expect([1, 2, 3].to_csv).to eql('1,2,3')
+    end
   end
 
-  it 'should return a all columns with no option' do
-    csv = ["id,name,age,weight"]
-    csv << ["#{sebastian.id},Sebastian,3,76.8"]
-    csv << ["#{ruby.id},Ruby,3,68.2"]
-    csv << ["#{shelby.id},Shelby,5,64.0"]
-
-    array.to_csv.should eql(csv.join("\n"))
+  context 'options is blank' do
+    it 'returns all columns' do
+      expect(array.to_csv).to eql "id,name,age,weight\n1,Sebastian O'Connor,3,76.8\n2,Ruby,3,68.2\n3,Shelby,5,64.0\n"
+    end
   end
 
-  it 'should include only columns specified' do
-    csv = ["name,age"]
-    csv << ["Sebastian,3"]
-    csv << ["Ruby,3"]
-    csv << ["Shelby,5"]
-
-    options = {:only => [:name, :age] }
-
-    array.to_csv(options).should eql(csv.join("\n"))
+  context 'options with :only param' do
+    it 'returns only columns specified' do
+      options = { only: [:name, :age] }
 
+      expect(array.to_csv(options)).to eql "name,age\nSebastian O'Connor,3\nRuby,3\nShelby,5\n"
+    end
   end
 
-  it 'should exclude columns specified' do
-    csv = ["id,name,weight"]
-    csv << ["#{sebastian.id},Sebastian,76.8"]
-    csv << ["#{ruby.id},Ruby,68.2"]
-    csv << ["#{shelby.id},Shelby,64.0"]
-
-    options = {:except => [:age] }
+  context 'options with :exclude param' do
+    it 'excludes columns specified' do
+      options = { except: [:age] }
 
-    array.to_csv(options).should eql(csv.join("\n"))
+      expect(array.to_csv(options)).to eql "id,name,weight\n7,Sebastian O'Connor,76.8\n8,Ruby,68.2\n9,Shelby,64.0\n"
+    end
   end
 
-  it 'should include method values when specified' do
-    csv = ["id,name,age,weight,human_age"]
-    csv << ["#{sebastian.id},Sebastian,3,76.8,25"]
-    csv << ["#{ruby.id},Ruby,3,68.2,25"]
-    csv << ["#{shelby.id},Shelby,5,64.0,33"]
-
-    options = {:add_methods => [:human_age] }
-
-    array.to_csv(options).should eql(csv.join("\n"))
+  context 'options with :add_methods' do
+    it 'includes specified method values' do
+      options = { add_methods: [:human_age] }
 
+      expect(array.to_csv(options)).to eql "id,name,age,weight,human_age\n10,Sebastian O'Connor,3,76.8,25\n11,Ruby,3,68.2,25\n12,Shelby,5,64.0,33\n"
+    end
   end
 
-  it 'should include method values with other options' do
-    csv = ["age,weight,human_age"]
-    csv << ["3,76.8,25"]
-    csv << ["3,68.2,25"]
-    csv << ["5,64.0,33"]
-
-    options = {:except => [:id,:name], :add_methods => [:human_age] }
-
-    array.to_csv(options).should eql(csv.join("\n"))
+  context 'options with :expect and :add_methods' do
+    it 'includes method values with other options' do
+      options = { except: [:id,:name], add_methods: [:human_age] }
 
+      expect(array.to_csv(options)).to eql "age,weight,human_age\n3,76.8,25\n3,68.2,25\n5,64.0,33\n"
+    end
   end
 
 end

data/spec/spec_helper.rb

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 
 require 'rails/all'
 require 'rspec/rails'
-require 'render_csv'
+require 'render_csv/extension'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: render_csv
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0.beta1
 platform: ruby
 authors:
 - Peter Brown
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-20 00:00:00.000000000 Z
+date: 2014-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.12'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
 description: Adds a custom CSV renderer to Rails applications
@@ -73,9 +73,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
@@ -101,17 +102,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.9
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: Adds a custom CSV renderer to Rails applications