render_async 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e057fbb8641218f58f60e10f8f746028f74a02d9
-  data.tar.gz: 6ed74b31920f184c7331691e3682420e02fc0bf2
+  metadata.gz: c603221d8623559e475f5dd31847ca30d86c3a6a
+  data.tar.gz: 54c76dde479ea0cfc2c500126f419752e50749a6
 SHA512:
-  metadata.gz: 3a970ab3fd004b50f43d44fac587f3b651c2df007804f09d30a2e68a496d1dc7f1e1a0dde5a21f955b8274912f01a77f620308c2db5e26f541ca1a39e6aa0f81
-  data.tar.gz: 7d2ef5381bb2a6bd798c81d65437c75305a97ee9e56b3918071d357ad82b26b134a915702b93d3e4a21dde23d55f6c6ed351ce6ae6d10b8c9a8ac09205885584
+  metadata.gz: b111b20c0440b3933b687469f851521b17163b31b5b312b180d1c7393b5b1222f96704832b52ca61d8e6dbb013ece9bf45ee2625a977b2f8083aa1bb1ac16461
+  data.tar.gz: c5853c4de18b1c7af54980e5656a1badcb3d9e39c9005eb133a5f3ce1b93bafadd795b1a5e8b8fa6523a1c23f0925a15e806d37a4ba3782fc5f943972e70e368

data/.all-contributorsrc

@@ -77,6 +77,15 @@
         "code",
         "doc"
       ]
+    },
+    {
+      "login": "elsurudo",
+      "name": "Ernest Surudo",
+      "avatar_url": "https://avatars3.githubusercontent.com/u/50223?v=4",
+      "profile": "http://elsurudo.com",
+      "contributions": [
+        "code"
+      ]
     }
   ]
 }

data/README.md

@@ -1,5 +1,5 @@
 [![Build Status](https://semaphoreci.com/api/v1/renderedtext/render_async/branches/master/shields_badge.svg)](https://semaphoreci.com/renderedtext/render_async)
-[![All Contributors](https://img.shields.io/badge/all_contributors-7-orange.svg?style=flat-square)](#contributors)
+[![All Contributors](https://img.shields.io/badge/all_contributors-8-orange.svg?style=flat-square)](#contributors)
 [![Gem Version](https://badge.fury.io/rb/render_async.svg)](https://badge.fury.io/rb/render_async)
 [![Code Climate](https://codeclimate.com/github/renderedtext/render_async/badges/gpa.svg)](https://codeclimate.com/github/renderedtext/render_async)
 [![Test Coverage](https://codeclimate.com/github/renderedtext/render_async/badges/coverage.svg)](https://codeclimate.com/github/renderedtext/render_async/coverage)
@@ -38,24 +38,18 @@ And then execute:
 
 ## Usage
 
-1. Include `render_async` view helper somewhere in your views:
+1. Include `render_async` view helper somewhere in your views (e.g. `app/views/comments/show.html.erb`):
     ```erb
-    # app/views/comments/show.html.erb
-
     <%= render_async comment_stats_path %>
     ```
 
-2. Then create a route that will `config/routes.rb`
+2. Then create a route that will `config/routes.rb`:
     ```ruby
-    # config/routes.rb
-
     get :comment_stats, :controller => :comments
     ```
 
-3. Fill in the logic in your controller
+3. Fill in the logic in your controller (e.g. `app/controllers/comments_controller.rb`):
     ```ruby
-    # app/controllers/comments_controller.rb
-
     def comment_stats
       @stats = Comment.get_stats
 
@@ -63,19 +57,15 @@ And then execute:
     end
     ```
 
-4. Create a partial that will render
+4. Create a partial that will render (e.g. `app/views/comments/_comment_stats.html.erb`):
     ```erb
-    # app/views/comments/_comment_stats.html.erb
-
     <div class="col-md-6">
       <%= @stats %>
     </div>
     ```
 
-5. Add `content_for` in your base view file
+5. Add `content_for` in your base view file (e.g. `app/views/layouts/application.html.erb`):
     ```erb
-    # application.html.erb
-
     <%= content_for :render_async %>
     ```
 
@@ -174,17 +164,14 @@ document.addEventListener("users-loaded", function() {
 
 `render_async` can utilize view fragment caching to avoid extra AJAX calls.
 
-In your views:
+In your views (e.g. `app/views/comments/show.html.erb`):
 ```erb
-# app/views/comments/show.html.erb
-
 # note 'render_async_cache' instead of standard 'render_async'
 <%= render_async_cache comment_stats_path %>
 ```
 
+Then, in the partial (e.g. `app/views/comments/_comment_stats.html.erb`):
 ```erb
-# app/views/comments/_comment_stats.html.erb
-
 <% cache render_async_cache_key(request.path), :skip_digest => true do %>
   <div class="col-md-6">
     <%= @stats %>
@@ -207,7 +194,7 @@ likely show up as an empty div.
 To resolve, tell turbolinks to reload your `render_async` call as follows:
 
 ```erb
-  <%= render_async events_path, 'data-turbolinks-track': 'reload' %>
+<%= render_async events_path, 'data-turbolinks-track': 'reload' %>
 ```
 
 ## Development
@@ -231,6 +218,7 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
 <!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
 | [<img src="https://avatars2.githubusercontent.com/u/3028124?v=4" width="100px;"/><br /><sub>Nikola Đuza</sub>](http://nikoladjuza.me/)<br />[💬](#question-nikolalsvk "Answering Questions") [🐛](https://github.com/renderedtext/render_async/issues?q=author%3Anikolalsvk "Bug reports") [💻](https://github.com/renderedtext/render_async/commits?author=nikolalsvk "Code") [📖](https://github.com/renderedtext/render_async/commits?author=nikolalsvk "Documentation") [💡](#example-nikolalsvk "Examples") [👀](#review-nikolalsvk "Reviewed Pull Requests") | [<img src="https://avatars0.githubusercontent.com/u/3866868?v=4" width="100px;"/><br /><sub>Colin</sub>](http://www.colinxfleming.com)<br />[💻](https://github.com/renderedtext/render_async/commits?author=colinxfleming "Code") [📖](https://github.com/renderedtext/render_async/commits?author=colinxfleming "Documentation") | [<img src="https://avatars2.githubusercontent.com/u/334273?v=4" width="100px;"/><br /><sub>Kasper Grubbe</sub>](http://kaspergrubbe.com)<br />[💻](https://github.com/renderedtext/render_async/commits?author=kaspergrubbe "Code") | [<img src="https://avatars2.githubusercontent.com/u/163584?v=4" width="100px;"/><br /><sub>Sai Ram Kunala</sub>](https://sairam.xyz/)<br />[📖](https://github.com/renderedtext/render_async/commits?author=sairam "Documentation") | [<img src="https://avatars2.githubusercontent.com/u/3065882?v=4" width="100px;"/><br /><sub>Josh Arnold</sub>](https://github.com/nightsurge)<br />[💻](https://github.com/renderedtext/render_async/commits?author=nightsurge "Code") [📖](https://github.com/renderedtext/render_async/commits?author=nightsurge "Documentation") | [<img src="https://avatars3.githubusercontent.com/u/107798?v=4" width="100px;"/><br /><sub>Elad Shahar</sub>](https://eladshahar.com)<br />[💻](https://github.com/renderedtext/render_async/commits?author=SaladFork "Code") | [<img src="https://avatars3.githubusercontent.com/u/232392?v=4" width="100px;"/><br /><sub>Sasha</sub>](http://www.revzin.co.il)<br />[💻](https://github.com/renderedtext/render_async/commits?author=sasharevzin "Code") [📖](https://github.com/renderedtext/render_async/commits?author=sasharevzin "Documentation") |
 | :---: | :---: | :---: | :---: | :---: | :---: | :---: |
+| [<img src="https://avatars3.githubusercontent.com/u/50223?v=4" width="100px;"/><br /><sub>Ernest Surudo</sub>](http://elsurudo.com)<br />[💻](https://github.com/renderedtext/render_async/commits?author=elsurudo "Code") |
 <!-- ALL-CONTRIBUTORS-LIST:END -->
 
 This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Contributions of any kind welcome!

data/app/views/render_async/_render_async.html.erb

@@ -26,7 +26,7 @@
         request.onload = function() {
           if (request.status >= SUCCESS && request.status < ERROR) {
             var container = document.getElementById("<%= container_id %>");
-            container.parentNode.innerHTML = request.response;
+            container.outerHTML = request.response;
 
             <% if event_name.present? %>
               document.dispatchEvent(new Event("<%= event_name %>"));

data/lib/render_async/version.rb

@@ -1,3 +1,3 @@
 module RenderAsync
-  VERSION = "1.1.2"
+  VERSION = "1.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: render_async
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Kasper Grubbe
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-17 00:00:00.000000000 Z
+date: 2017-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler