render-later 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e1124bb4e36a64975fbdc6b79b35bbccf1afaf03
-  data.tar.gz: b8d83484ce27bb6a415238ecc88069e126bad8d6
+  metadata.gz: 55370f11139243c05ff90f7daf2c71d46fe1f20c
+  data.tar.gz: 70b2a0834e7502ea42de2525157eea36fc07fdb1
 SHA512:
-  metadata.gz: 860835d8c1a20743fd278850de9a5f66cb3d9131d8829a41a3eb6dd43611d98f4c4586ef17b8d792da564344db65b2fc7eb842622c7a8b4b5512a540ae9d513d
-  data.tar.gz: 63718790b5cac1da165f5e22be2960ea41370302d65cfd46f7b416aeb42b3a73a557c1299fa26a74350faba3cc4ef11244b959d6e65c7e66480e7d08038dc0ec
+  metadata.gz: bfdd1c0a4dbda416582e61c88dbdf5da2d503c1908adff8f2ba2964020908514fe4d526d64105e069ad959ddd0d888eb345d1d0856e421646041d56b4bc3c508
+  data.tar.gz: 9f02642e7c9cc19d81c3d233d22cb08b153e067ae8160fea10005f86b56de54ee276dd15181da16aec924544f877981a69987794b4f951dbcfc144ff1be4b4b2

data/.travis.yml

@@ -1,13 +1,13 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.1.8
-  - 2.2.4
-  - 2.3.0
+  - 2.3.4
+  - 2.4.1
 gemfile:
-  - test/gemfiles/rails-4.1.gemfile
   - test/gemfiles/rails-4.2.gemfile
+  - test/gemfiles/rails-5.0.gemfile
+  - test/gemfiles/rails-5.1.gemfile
 matrix:
   include:
-    - rvm: 2.3.0
-      gemfile: test/gemfiles/rails-5.0.gemfile
+    - rvm: 2.3.4
+      gemfile: test/gemfiles/rails-4.1.gemfile

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# v1.1.0
+
+Add support for render-later in tables and other elements:
+* Add ability to customize placeholder tag (#2)
+* Fix javascript temporary element to match parent one (#2)
+
+# v1.0.0
+
+Initial production release
+
+_Sept 10, 2016_

data/README.md

@@ -25,7 +25,14 @@ In your views, simply wrap a slow piece of code into a `render_later` block, and
   <% end %>
 </div>
 ```
-It's important to use the `<%=` erb tag here, as the helper will render a hidden span tag.
+It's important to use the `<%=` erb tag here, as the helper will render a hidden `span` tag. If a `span` tag doesn't work well for you (ex: in a table), you can customize the placeholder element with the `tag` keyword argument, ex:
+```erb
+<table>
+  <%= render_later "srv-uptime-#{server.id}", tag: :tr do %>
+    <tr><td><%= server.uptime %></td></tr>
+  <% end %>
+</table>
+```
 
 In your layout, before the end of the body tag, add a call to `render_now`:
 ```erb
@@ -36,6 +43,14 @@ In your layout, before the end of the body tag, add a call to `render_now`:
 ```
 This is where the deferred blocks will be rendered and injected into the page using inline javascript.
 
+And finally in your controller, you need to render with the `stream` option:
+
+```ruby
+  def index
+    render stream: true
+  end
+```
+
 ## Performance
 
 Performance-wise, this approach is quite interesting, let me explain why:
@@ -140,7 +155,6 @@ After checking out the repo, run `bundle install` to install dependencies. Then,
 - Wider test coverage across browsers using [Sauce Labs](https://saucelabs.com/opensauce/)
 - Parallel rendering (I tried quickly but the `capture` helper isn't thread-safe)
 - Add options to do caching at the same time (with the same key)
-- Add options to customize the generated temporary element (could be used for loading indication or to avoid CSS conflict)
 
 ## License
 

data/app/helpers/render_later/view_helper.rb

@@ -3,7 +3,7 @@ module RenderLater
     INSERT_FUNCTION = <<-JAVASCRIPT.freeze
       function rl_insert(name, data) {
         if (node = document.getElementById(name)) {
-          var div = document.createElement('div');
+          var div = document.createElement(node.parentNode.tagName || 'div');
           div.innerHTML = data;
           var elements = div.childNodes;
           for (var i = elements.length; i > 0; i--) {
@@ -14,9 +14,9 @@ module RenderLater
       };
     JAVASCRIPT
 
-    def render_later key, &block
+    def render_later key, tag: :span, class: "rl-placeholder", &block
       store_object(key, &block)
-      content_tag(:span, nil, id: "rl-#{key}", class: "rl-placeholder", style: 'display: none')
+      content_tag(tag, nil, id: "rl-#{key}", class: binding.local_variable_get(:class), style: 'display: none')
     end
 
     def render_now

data/lib/render-later/version.rb

@@ -1,3 +1,3 @@
 module RenderLater
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/render-later.gemspec

@@ -20,9 +20,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.11"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
-  spec.add_development_dependency "rails", "~> 4.0"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "minitest"
+  spec.add_development_dependency "rails", "~> 5.1"
   spec.add_development_dependency "puma"
   spec.add_development_dependency "poltergeist"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: render-later
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Adrien Jarthon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-10 00:00:00.000000000 Z
+date: 2017-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,44 +28,44 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: puma
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +105,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -139,4 +140,3 @@ signing_key:
 specification_version: 4
 summary: Defer rendering of slow parts to the end of the page
 test_files: []
-has_rdoc: