renalware-core 2.0.17 → 2.0.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69489313496ac73b284e01c603e89bd3acc20628157094223eb70536c4c688c9
-  data.tar.gz: a653b932c9d1f872b90999eead2cafa128551a71df247bcc888e9c7788f73ce4
+  metadata.gz: d8f98055c0ba3c1fa08f211f731247951b6b819e62c828e743e96962ce7968c6
+  data.tar.gz: 6e1bce7c200282e59707e523523f11de57cc8291abf707775fa3a33268c7c136
 SHA512:
-  metadata.gz: df3b9fcf4f0f138e2ce2f3f3a43c0962be563e3a39e4ee2acc2fdf22aa95fbe3e7701a60e87c76a9ab6b1f0f83e7963e32d8e9a43cbdf52783aac4523c63cffa
-  data.tar.gz: 0c78e6dbb66c7821052202c4961ef05a12a9b573998d6d8fed8b3faf6add3132a7ddb19a516cac0d237b96db175e0d8005289a3d36fa824eabb9a613e4e08c16
+  metadata.gz: b1c3dca6e10fc4e86ea191ed1331c9aff394599238db64850c3a0b50cbfa5f530f0551a239d0bfb62393bf431f40e79970c96719f9066f772434132fa9eb9910
+  data.tar.gz: ca427a97413003d6eaf1992ca8dcbd72b7fb74949232aed5714e3555ae2907439162a09af54de3e13951600b347864685aaea692ee00e9d368f67ba20944ac15

data/app/mailers/renalware/letters/delivery/practice_mailer.rb

@@ -8,7 +8,7 @@ module Renalware
   module Letters
     module Delivery
       class PracticeMailer < ApplicationMailer
-        def patient_letter(letter:, to:, recipient:)
+        def patient_letter(letter:, to:)
           validate_letter(letter)
           letter_presenter = LetterPresenterFactory.new(letter)
           attachments["letter.pdf"] = Letters::PdfRenderer.call(letter_presenter)

data/app/models/null_exception_notifier.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+# The host app can supply a handler for logging errors in background jobs, like so
+#  Renalware::Engine.exception_notifier = MyExceptionNotifier.new
+# where the supplied instance must respond to .notify(exception, **params).
+# Where a handler is not supplied we default to using this null handler.
+class NullExceptionNotifier
+  def notify(exception, **_params)
+    # noop
+  end
+end

data/app/models/renalware/feeds/message_processor.rb

@@ -32,7 +32,7 @@ module Renalware
       end
 
       def notify_exception(exception)
-        ExceptionNotifier.new.notify(exception)
+        Engine.exception_notifier.notify(exception)
       end
     end
   end

data/app/models/renalware/letters/delivery/email_letter_to_practice.rb

@@ -31,8 +31,7 @@ module Renalware
           Letter.transaction do
             PracticeMailer.patient_letter(
               letter: letter,
-              to: practice_email_address,
-              recipient: nil # TODO
+              to: practice_email_address
             ).deliver_later
 
             # Flag as sent

data/app/models/renalware/null_user.rb

@@ -0,0 +1,7 @@
+module Renalware
+  NullUser = Naught.build do |config|
+    config.black_hole
+    config.define_explicit_conversions
+    config.predicates_return false
+  end
+end

data/app/views/renalware/admin/users/_filters.html.slim

@@ -4,7 +4,7 @@
       .row
         .small-9.large-4.columns
           = f.label "Name or username contains"
-          = f.search_field :family_name_or_given_name_or_username_cont
+          = f.search_field :family_name_or_given_name_or_username_or_email_cont
         .small-3.large-4.columns.actions.end
           = f.submit t("helpers.submit.filter"), class: "button"
           span= " or "

data/config/routes.rb

@@ -21,7 +21,7 @@ Renalware::Engine.routes.draw do
   get "/session_timed_out" => "session_timeout#has_user_timed_out", as: "session_timed_out"
 
   super_admin_constraint = lambda do |request|
-    current_user = request.env["warden"].user || NullObject.instance
+    current_user = request.env["warden"].user || Renalware::NullUser.new
     current_user.has_role?(:super_admin)
   end
 

data/lib/renalware/engine.rb

@@ -65,6 +65,17 @@ module Renalware
   class Engine < ::Rails::Engine
     isolate_namespace Renalware
 
+    # Define a attr on the Engine's eigenclass so a host application
+    # can set an exception handler instance. It must accept a .notify(excetion) method.
+    # We use the exception handler when logging errors in background jobs only.
+    # Errors in the UI are bubbled up and handled in the host app in the usual way.
+    class << self
+      attr_writer :exception_notifier
+      def exception_notifier
+        @exception_notifier ||= NullExceptionNotifier.new
+      end
+    end
+
     config.autoload_paths += Dir["#{config.root}/lib/**/"]
     config.autoload_paths += %W(#{config.root}/app/validators/concerns)
 

data/lib/renalware/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Renalware
-  VERSION = "2.0.17"
+  VERSION = "2.0.18"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: renalware-core
 version: !ruby/object:Gem::Version
-  version: 2.0.17
+  version: 2.0.18
 platform: ruby
 authors:
 - Airslie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-23 00:00:00.000000000 Z
+date: 2018-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_type
@@ -1300,7 +1300,7 @@ files:
 - app/models/concerns/renalware/personable.rb
 - app/models/concerns/renalware/string_logging.rb
 - app/models/concerns/renalware/supersedeable.rb
-- app/models/exception_notifier.rb
+- app/models/null_exception_notifier.rb
 - app/models/renalware.rb
 - app/models/renalware/accesses.rb
 - app/models/renalware/accesses/assessment.rb
@@ -1532,6 +1532,7 @@ files:
 - app/models/renalware/modalities/modality.rb
 - app/models/renalware/modalities/pd_to_haemodialysis.rb
 - app/models/renalware/modalities/reason.rb
+- app/models/renalware/null_user.rb
 - app/models/renalware/pathology.rb
 - app/models/renalware/pathology/all_observation_codes.rb
 - app/models/renalware/pathology/clinic.rb

data/app/models/exception_notifier.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-# Responsible for wrapping a third-party exception notification client. This
-# wrapper allows us to switch notification service without affecting the
-# rest of the application.
-#
-class ExceptionNotifier
-  def notify(exception)
-    # TODO: add implementation here
-  end
-end