renalware-core 2.0.167 → 2.1.0

data/db/views/reporting_daily_letters_v03.sql

@@ -0,0 +1,4 @@
+select
+  (select count(*) from letter_letters where created_at::date = now()::date) as letters_created_today,
+  (select count(*) from letter_letters where completed_at::date = now()::date) as letters_printed_today,
+  (select count(*) from letter_letters where type = 'Renalware::Letters::Letter::Draft' and created_at < (current_date - interval '14 days')) as draft_letters_older_than_14_days;

data/lib/collection_presenter.rb

@@ -49,7 +49,7 @@ class CollectionPresenter
     end
   end
 
-  def respond_to?(method)
+  def respond_to?(method, _unused = nil)
     @decorated_collection.respond_to?(method) || @original_collection.respond_to?(method)
   end
 

data/lib/core_extensions/i18n/always_cascade.rb

@@ -21,8 +21,24 @@
 module CoreExtensions
   module I18n
     module AlwaysCascade
+      # Note changing offset from 2 to 1 causes errors in validates_timeliness gem in
+      # #format_error_value where it tries to lookup I18n.t(:date)
+      # It is actually trying to find the key :date in the scope
+      # "validates_timeliness.error_value_formats" but this does not exist so, becuase of the
+      # cascade, it settles on returning the root :date key which is actually a hash, and fails.
+      # Using offset: 2 prevents us from ever picking up the root :date key when using t(:date)
+      # or t(".date_"). It does mean we cannot put any translations under eg :en-GB directly, they
+      # must be under a sub key eg :thead, :btn etc.
+      # offset: 2 means we will be looking back up the tree for e.g. "list.type" if the key is
+      # :type and the partial is called 'list', so we would never find eg the translation
+      # renalware.type; offset: 1 and using skip_root: false seems to do the trick.
+      # See the loop in lib/i18n/backend/cascade.rb in the i18n gem.
+      # Another issue here is that if offset is 1 then any input called eg f.input :date
+      # could resolve to the root :date tranlsation which is a hash of options and not a real
+      # translation, leading to errors. Its not possible rename/reloacte these keys as they
+      # are hard-coded eg in actionview/lib/action_view/helpers/date_helper.rb
       def translate(key, options = {})
-        super(key, options.merge(cascade: { offset: 2, skip_root: false }))
+        super(key, options.merge(cascade: { offset: 2, skip_root: true }))
       end
       alias t translate
     end

data/lib/core_extensions/i18n/handle_blank_value.rb

@@ -3,7 +3,7 @@
 module CoreExtensions
   module I18n
     module HandleBlankValue
-      def localize(object, options = nil)
+      def localize(object, locale: nil, format: nil, **options)
         object.blank? ? "" : super
       end
       alias l localize

data/lib/renalware/engine.rb

@@ -92,8 +92,10 @@ module Renalware
     end
 
     initializer :add_locales do |app|
-      app.config.i18n.load_path += Dir[config.root.join("config/locales/**/*.{rb,yml}")]
-      app.config.i18n.default_locale = "en-GB"
+      app.config.i18n.load_path += Dir[config.root.join("config/locales/**/*.yml")]
+      app.config.i18n.load_path += Dir[config.root.join("app/components/**/*.yml")]
+      app.config.available_locales = [:en] # [:en, :pt]
+      app.config.i18n.default_locale = :"en-GB"
       app.config.i18n.fallbacks = [:en]
     end
 

data/lib/renalware/version_number.rb

@@ -5,6 +5,6 @@ module Renalware
   # to creat that class even though its not used. If we don't do this zeitwerk
   # complains that version.rb does export a constant called Version.
   class VersionNumber
-    VERSION = "2.0.167"
+    VERSION = "2.1.0"
   end
 end

data/lib/tasks/demo_data.rake

@@ -42,7 +42,6 @@ module Renalware
       10.times do
         letter = Letters::Letter::PendingReview.create!(
           patient: patient,
-          issued_on: 1.day.ago,
           pathology_timestamp: 1.day.ago,
           event: clinics_patient.clinic_visits.first,
           clinical: true,

data/spec/factories/events/categories.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :event_category, class: "Renalware::Events::Category" do
+    initialize_with { Renalware::Events::Category.find_or_create_by(name: name) }
+    name { "General" }
+  end
+end

data/spec/factories/events/{events_types.rb → types.rb}

@@ -2,7 +2,15 @@
 
 FactoryBot.define do
   factory :event_type, class: "Renalware::Events::Type" do
-    initialize_with { Renalware::Events::Type.find_or_create_by(name: name) }
+    initialize_with do
+      Renalware::Events::Type.find_or_create_by(
+        name: name,
+        category: category
+      )
+    end
+
+    category factory: :event_category
+    name { "Test" }
 
     factory :access_clinic_event_type do
       name { "Access--Clinic" }

data/spec/factories/letters/letters.rb

@@ -4,7 +4,7 @@ FactoryBot.define do
   factory :letter, class: "Renalware::Letters::Letter" do
     accountable
 
-    issued_on { Time.zone.today }
+    created_at { Time.zone.today }
     description { "This is a custom description" }
     body { "I am pleased to report a marked improvement in her condition." }
 

data/spec/factories/low_clearance/modality_descriptions.rb

@@ -4,7 +4,7 @@ FactoryBot.define do
   factory :low_clearance_modality_description,
           class: "Renalware::LowClearance::ModalityDescription" do
     initialize_with do
-      Renalware::LowClearance::ModalityDescription.find_or_create_by(name: "Low Clearance")
+      Renalware::LowClearance::ModalityDescription.find_or_create_by(name: "Advanced Kidney Care")
     end
   end
 end

data/spec/factories/modalities/modality_descriptions.rb

@@ -30,7 +30,7 @@ FactoryBot.define do
     end
 
     trait :low_clearance do
-      name { "Low Clearance" }
+      name { "Advanced Kidney Care" }
       type { "Renalware::LowClearance::ModalityDescription" }
       code { "low_clearance" }
     end

data/spec/support/date_helpers.rb

@@ -2,10 +2,10 @@
 
 module DateHelpers
   def todays_date
-    I18n.l(Time.zone.today)
+    l(Time.zone.today)
   end
 
   def todays_date_and_time
-    I18n.l(Time.zone)
+    l(Time.zone)
   end
 end

data/spec/support/letters_spec_helper.rb

@@ -42,7 +42,7 @@ module LettersSpecHelper
     end
   end
 
-  def create_aproved_letter_to_patient_with_cc_to_gp_and_one_contact(
+  def create_approved_letter_to_patient_with_cc_to_gp_and_one_contact(
     user: nil,
     body: "test",
     page_count: 1,

data/vendor/assets/stylesheets/foundation/components/_forms.scss

@@ -382,58 +382,60 @@ $select-hover-bg-color: scale-color($select-bg-color, $lightness: -3%) !default;
 @include exports("form") {
   @if $include-html-form-classes {
     /* Standard Forms */
-    form { margin: 0 0 $form-spacing; }
+    form.fn-form { margin: 0 0 $form-spacing; }
 
     /* Using forms within rows, we need to set some defaults */
-    form .row { @include form-row-base; }
-
-    /* Label Styles */
-    label { @include form-label;
-      &.right { @include form-label(right, false); }
-      &.inline { @include form-label(inline, false); }
-      /* Styles for required inputs */
-      small {
-        text-transform: $form-label-small-transform;
-        color: scale-color($form-label-font-color, $lightness: 15%);
+    form.fn-form .row { @include form-row-base; }
+
+    .fn-form {
+      /* Label Styles */
+      label { @include form-label;
+        &.right { @include form-label(right, false); }
+        &.inline { @include form-label(inline, false); }
+        /* Styles for required inputs */
+        small {
+          text-transform: $form-label-small-transform;
+          color: scale-color($form-label-font-color, $lightness: 15%);
+        }
       }
-    }
 
-    /* Attach elements to the beginning or end of an input */
-    .prefix,
-    .postfix { @include prefix-postfix-base; }
-
-    /* Adjust padding, alignment and radius if pre/post element is a button */
-    .postfix.button { @include button-size(false, false); @include postfix(false, false, false, true); }
-    .prefix.button { @include button-size(false, false); @include prefix(false, false, true); }
-
-    .prefix.button.radius { @include radius(0); @include side-radius($default-float, $button-radius); }
-    .postfix.button.radius { @include radius(0); @include side-radius($opposite-direction, $button-radius); }
-    .prefix.button.round { @include radius(0); @include side-radius($default-float, $button-round); }
-    .postfix.button.round { @include radius(0); @include side-radius($opposite-direction, $button-round); }
-
-    /* Separate prefix and postfix styles when on span or label so buttons keep their own */
-    span.prefix, label.prefix { @include prefix(); }
-    span.postfix, label.postfix { @include postfix(); }
-
-    /* We use this to get basic styling on all basic form elements */
-    input:not([type]), #{text-inputs(all, 'input')} {
-      -webkit-appearance: none;
-      -moz-appearance: none;
-      border-radius: 0;
-      @include form-element;
-      @if $input-include-glowing-effect == false {
-        -webkit-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
-        -moz-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
-        -ms-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
-        -o-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
-        transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
-      }
-      &.radius {
-        @include radius($input-border-radius);
+      /* Attach elements to the beginning or end of an input */
+      .prefix,
+      .postfix { @include prefix-postfix-base; }
+
+      /* Adjust padding, alignment and radius if pre/post element is a button */
+      .postfix.button { @include button-size(false, false); @include postfix(false, false, false, true); }
+      .prefix.button { @include button-size(false, false); @include prefix(false, false, true); }
+
+      .prefix.button.radius { @include radius(0); @include side-radius($default-float, $button-radius); }
+      .postfix.button.radius { @include radius(0); @include side-radius($opposite-direction, $button-radius); }
+      .prefix.button.round { @include radius(0); @include side-radius($default-float, $button-round); }
+      .postfix.button.round { @include radius(0); @include side-radius($opposite-direction, $button-round); }
+
+      /* Separate prefix and postfix styles when on span or label so buttons keep their own */
+      span.prefix, label.prefix { @include prefix(); }
+      span.postfix, label.postfix { @include postfix(); }
+
+      /* We use this to get basic styling on all basic form elements */
+      input:not([type]), #{text-inputs(all, 'input')} {
+        -webkit-appearance: none;
+        -moz-appearance: none;
+        border-radius: 0;
+        @include form-element;
+        @if $input-include-glowing-effect == false {
+          -webkit-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
+          -moz-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
+          -ms-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
+          -o-transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
+          transition: border-color $input-transition-fade-time $input-transition-fade-timing-function, background $input-transition-fade-time $input-transition-fade-timing-function;
+        }
+        &.radius {
+          @include radius($input-border-radius);
+        }
       }
     }
 
-    form {
+    form.fn-form {
       .row {
         .prefix-radius.row.collapse {
           input,
@@ -466,136 +468,139 @@ $select-hover-bg-color: scale-color($select-bg-color, $lightness: -3%) !default;
       }
     }
 
-    input[type="submit"] {
-      -webkit-appearance: none;
-      -moz-appearance: none;
-      border-radius: 0;
-    }
-
-    /* Respect enforced amount of rows for textarea */
-    textarea[rows] {
-      height: auto;
-    }
-
-    /* Not allow resize out of parent */
-    textarea {
-      max-width: 100%;
-    }
-
-    // style placeholder text cross browser
-    ::-webkit-input-placeholder {
-      color: $input-placeholder-font-color;
-    }
-
-    :-moz-placeholder { /* Firefox 18- */
-       color: $input-placeholder-font-color;
-    }
-
-    ::-moz-placeholder {  /* Firefox 19+ */
-       color: $input-placeholder-font-color;
-    }
-
-    :-ms-input-placeholder {
-       color: $input-placeholder-font-color;
-    }
+    .fn-form {
 
+      input[type="submit"] {
+        -webkit-appearance: none;
+        -moz-appearance: none;
+        border-radius: 0;
+      }
 
-    /* Add height value for select elements to match text input height */
-    select {
-      @include form-select;
-      height: ($input-font-size + ($form-spacing * 1.5) - rem-calc(1));
-      &[multiple] {
+      /* Respect enforced amount of rows for textarea */
+      textarea[rows] {
         height: auto;
       }
-    }
-
-    /* Adjust margin for form elements below */
-    input[type="file"],
-    input[type="checkbox"],
-    input[type="radio"],
-    select {
-      margin: 0 0 $form-spacing 0;
-    }
 
-    input[type="checkbox"] + label,
-    input[type="radio"] + label {
-      display: inline-block;
-      margin-#{$default-float}: $form-spacing * .5;
-      margin-#{$opposite-direction}: $form-spacing;
-      margin-bottom: 0;
-      vertical-align: baseline;
-    }
+      /* Not allow resize out of parent */
+      textarea {
+        max-width: 100%;
+      }
 
-    /* Normalize file input width */
-    input[type="file"] {
-      width:100%;
-    }
+      // style placeholder text cross browser
+      ::-webkit-input-placeholder {
+        color: $input-placeholder-font-color;
+      }
 
-    /* HTML5 Number spinners settings */
-    input[type=number] {
-      @include html5number(moz, $input-number-spinners)
-    }
-    input[type="number"]::-webkit-inner-spin-button,
-    input[type="number"]::-webkit-outer-spin-button {
-      @include html5number(webkit, $input-number-spinners);
-    }
+      :-moz-placeholder { /* Firefox 18- */
+        color: $input-placeholder-font-color;
+      }
 
-    /* We add basic fieldset styling */
-    fieldset {
-      @include fieldset;
-    }
+      ::-moz-placeholder {  /* Firefox 19+ */
+        color: $input-placeholder-font-color;
+      }
 
-    /* Error Handling */
+      :-ms-input-placeholder {
+        color: $input-placeholder-font-color;
+      }
 
 
-    span.error, small.error {
-      @include form-error-message;
-    }
+      /* Add height value for select elements to match text input height */
+      select {
+        @include form-select;
+        height: ($input-font-size + ($form-spacing * 1.5) - rem-calc(1));
+        &[multiple] {
+          height: auto;
+        }
+      }
 
-    .error {
-      input,
-      textarea,
+      /* Adjust margin for form elements below */
+      input[type="file"],
+      input[type="checkbox"],
+      input[type="radio"],
       select {
+        margin: 0 0 $form-spacing 0;
+      }
+
+      input[type="checkbox"] + label,
+      input[type="radio"] + label {
+        display: inline-block;
+        margin-#{$default-float}: $form-spacing * .5;
+        margin-#{$opposite-direction}: $form-spacing;
         margin-bottom: 0;
+        vertical-align: baseline;
       }
 
-      input[type="checkbox"],
-      input[type="radio"] {
-        margin-bottom: $form-spacing
+      /* Normalize file input width */
+      input[type="file"] {
+        width:100%;
+      }
+
+      /* HTML5 Number spinners settings */
+      input[type=number] {
+        @include html5number(moz, $input-number-spinners)
+      }
+      input[type="number"]::-webkit-inner-spin-button,
+      input[type="number"]::-webkit-outer-spin-button {
+        @include html5number(webkit, $input-number-spinners);
       }
 
-      label,
-      label.error {
-        @include form-label-error-color;
+      /* We add basic fieldset styling */
+      fieldset {
+        @include fieldset;
       }
 
-      small.error {
+      /* Error Handling */
+
+
+      span.error, small.error {
         @include form-error-message;
       }
 
-      > label {
-        > small {
-          background: transparent;
-          color: scale-color($form-label-font-color, $lightness: 15%);
-          display: inline;
-          font-size: 60%;
-          font-style: normal;
-          margin: 0;
-          padding: 0;
-          text-transform: $form-label-small-transform;
+      .error {
+        input,
+        textarea,
+        select {
+          margin-bottom: 0;
+        }
+
+        input[type="checkbox"],
+        input[type="radio"] {
+          margin-bottom: $form-spacing
+        }
+
+        label,
+        label.error {
+          @include form-label-error-color;
         }
-      }
 
-      span.error-message {
-        display: block;
+        small.error {
+          @include form-error-message;
+        }
+
+        > label {
+          > small {
+            background: transparent;
+            color: scale-color($form-label-font-color, $lightness: 15%);
+            display: inline;
+            font-size: 60%;
+            font-style: normal;
+            margin: 0;
+            padding: 0;
+            text-transform: $form-label-small-transform;
+          }
+        }
+
+        span.error-message {
+          display: block;
+        }
       }
-    }
 
-    input.error,
-    textarea.error,
-    select.error {
-      margin-bottom: 0;
+      input.error,
+      textarea.error,
+      select.error {
+        margin-bottom: 0;
+      }
+      label.error { @include form-label-error-color; }
     }
-    label.error { @include form-label-error-color; }
   }
 }