RubyGems - renalware-core - Versions diffs - 2.0.0.pre.beta11 → 2.0.0.pre.beta12 - Mend

renalware-core 2.0.0.pre.beta11 → 2.0.0.pre.beta12

Files changed (295) hide show

data/app/helpers/renalware/mdm_helper.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   module MDMHelper
     def link_to_mdm(patient)
       MDMLink.new(patient).to_html
     end

data/app/helpers/renalware/pd_regime_bags_helper.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   module PDRegimeBagsHelper
     def highlight_days_invalid(bag)
       if bag.errors.include?(:days)
         "validate-days-of-week"
@@ -12,6 +11,5 @@ module Renalware
         "validate-add-min-bag"
       end
     end
   end
 end

data/app/helpers/renalware/pd_regimes_helper.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   module PDRegimesHelper
     def system_options_for(regime)
       PD::System.for_pd_type(regime.pd_type) { |system| [system.name, system.id] }
     end

data/app/helpers/renalware/section_helper.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   module SectionHelper
     def section(title:)
       content_tag(:section, class: "display") do
         concat content_tag(:h4) { title }

data/app/helpers/renalware/tooltip_helper.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   module TooltipHelper
     def tooltip(label:, content:)
       content_tag(:span,
                   title: content,

data/app/helpers/renalware/transplant_helper.rb CHANGED

@@ -58,8 +58,10 @@ module Renalware
     def recipient_followup_breadcrumbs(patient, followup)
       [
         recipient_summary_breadcrumb(patient),
-         breadcrumb_for(recipient_followup_title(followup),
-            patient_transplants_recipient_operation_followup_path(patient, followup.operation))
+        breadcrumb_for(
+          recipient_followup_title(followup),
+          patient_transplants_recipient_operation_followup_path(patient, followup.operation)
+        )
       ]
     end

data/app/helpers/renalware/users_helper.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   module UsersHelper
     def current_user_is_super_admin?
       current_user.has_role?(:super_admin)
     end

data/app/inputs/inline_radio_buttons_input.rb CHANGED

@@ -4,6 +4,6 @@ class InlineRadioButtonsInput < SimpleForm::Inputs::CollectionRadioButtonsInput
   end
   def input_options
-    super.merge(item_wrapper_class: ["radio", ["radio", "inline"]])
+    super.merge(item_wrapper_class: ["radio", %w(radio inline)])
   end
 end

data/app/mailers/previews/user_mailer_preview.rb CHANGED

@@ -1,6 +1,5 @@
 module Renalware
   class Admin::UserMailerPreview < ActionMailer::Preview
     def approval
       user = User.first
       Admin::UserMailer.approval(user)
@@ -10,6 +9,5 @@ module Renalware
       user = User.first
       Admin::UserMailer.unexpiry(user)
     end
   end
 end

data/app/models/concerns/renalware/patients_ransack_helper.rb CHANGED

@@ -50,7 +50,6 @@ module Renalware
         { fuzzy_term: "#{query}%", exact_term: query, ucase_term: query&.upcase }
       end
-      # rubocop:disable Metrics/MethodLength
       def identity_sql(query)
         sql = <<-SQL.squish
           local_patient_id = :ucase_term OR

data/app/models/renalware.rb CHANGED

@@ -1,5 +1,4 @@
 module Renalware
   def self.table_name_prefix
     # 'renalware_' # TODO: eventually, prefix the tables
     ""

data/app/models/renalware/clinical/body_composition.rb CHANGED

@@ -30,7 +30,6 @@ module Renalware
       validates :body_cell_mass, presence: true, numeric_inclusion: { in: 0..150 }
       validates :quality_of_reading, presence: true, numeric_inclusion: { in: 50..100 }
       validates :assessed_on, presence: true, timeliness: { type: :date, allow_blank: false }
     end
   end
 end

data/app/models/renalware/clinical/create_allergy.rb CHANGED

@@ -5,7 +5,6 @@ require_dependency "renalware/failure"
 module Renalware
   module Clinical
     class CreateAllergy
       def initialize(patient, user)
         @patient = patient
         @user = user
@@ -35,7 +34,7 @@ module Renalware
       def save_allergy(allergy)
         Allergy.transaction do
           allergy.save!
-          unless patient.allergy_status.try!(:known_allergies?)
+          unless patient.allergy_status&.known_allergies?
             patient.allergy_status = :known_allergies
             patient.allergy_status_updated_at = Time.zone.now
             patient.by = user

data/app/models/renalware/clinical/delete_allergy.rb CHANGED

@@ -1,7 +1,6 @@
 module Renalware
   module Clinical
     class DeleteAllergy
       def initialize(allergy, user)
         @allergy = allergy
         @user = user

data/app/models/renalware/clinical/modality_description.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/clinical"
 module Renalware
   module Clinical
     class ModalityDescription < Modalities::Description
       def to_sym
         :clinical
       end

data/app/models/renalware/clinics/appointment.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/clinics"
 module Renalware
   module Clinics
     class Appointment < ApplicationRecord
       belongs_to :patient, touch: true
       belongs_to :clinic
       belongs_to :user

data/app/models/renalware/clinics/appointment_query.rb CHANGED

@@ -7,7 +7,7 @@ module Renalware
       def initialize(q = {})
         @q = q
-        @q[:s] = "starts_at ASC" unless @q[:s].present?
+        @q[:s] = "starts_at ASC" if @q[:s].blank?
       end
       def call

data/app/models/renalware/clinics/build_visit_from_appointment.rb CHANGED

@@ -1,7 +1,6 @@
 module Renalware
   module Clinics
     class BuildVisitFromAppointment
       def initialize(appointment)
         @appointment = appointment
       end

data/app/models/renalware/clinics/consultant.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/clinics"
 module Renalware
   module Clinics
     class Consultant < ActiveType::Record[Renalware::User]
     end
   end
 end

data/app/models/renalware/clinics/create_clinic_visit.rb CHANGED

@@ -5,7 +5,6 @@ require_dependency "renalware/failure"
 module Renalware
   module Clinics
     class CreateClinicVisit
       def self.call(patient, params)
         new(patient, params).call
       end

data/app/models/renalware/clinics/visit_query.rb CHANGED

@@ -7,7 +7,7 @@ module Renalware
       def initialize(q = {})
         @q = q
-        @q[:s] = "date DESC" unless @q[:s].present?
+        @q[:s] = "date DESC" if @q[:s].blank?
       end
       def call

data/app/models/renalware/events.rb CHANGED

@@ -1,5 +1,4 @@
 module Renalware
   module Events
   end
 end

data/app/models/renalware/feeds/persist_message.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/feeds"
 module Renalware
   module Feeds
     class PersistMessage
       # message_payload is an HL7Message (a decorator around ::HL7::Message)
       def call(message_payload)
         Message.create!(

data/app/models/renalware/hd/archive_yesterdays_slots_job.rb CHANGED

@@ -62,7 +62,6 @@ module Renalware
         #  diary year 2017 week 3
         #  select
       end
     end
   end
 end

data/app/models/renalware/hd/generate_monthly_statistics_for_patient.rb CHANGED

@@ -1,7 +1,6 @@
 module Renalware
   module HD
     class GenerateMonthlyStatisticsForPatient
       def initialize(patient:, period:)
         @patient = patient
         @period = period
@@ -40,7 +39,7 @@ module Renalware
       end
       def most_recently_used_hospital_unit(sessions)
-        sessions.last.try!(:hospital_unit)
+        sessions.last&.hospital_unit
       end
     end
   end

data/app/models/renalware/hd/master_diary.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/hd"
 module Renalware
   module HD
     class MasterDiary < Diary
       # Overwrite the existing master attribute to ensure it defaults to true
       attribute :master, :boolean, default: true
       validates :hospital_unit_id, uniqueness: true

data/app/models/renalware/hd/mdm_patients_query.rb CHANGED

@@ -28,7 +28,6 @@ module Renalware
       end
       module Scopes
         def with_current_key_pathology
           eager_load(:current_key_observation_set) # .joins(:current_key_observation)
         end

data/app/models/renalware/hd/patient_listener.rb CHANGED

@@ -1,4 +1,3 @@
-# rubocop:disable Rails/SkipsModelValidations
 module Renalware
   module HD
     class PatientListener

data/app/models/renalware/hd/patients_with_unmet_preferences_query.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/hd"
 module Renalware
   module HD
     class PatientsWithUnmetPreferencesQuery
       def initialize(query = {})
         @query = query
       end
@@ -28,7 +27,6 @@ module Renalware
       attr_reader :query
       module Scopes
         def having_an_unmet_preference
           sql = <<-SQL.squish
             (hd_preference_sets.hospital_unit_id > 0 AND

data/app/models/renalware/hd/revise_hd_profile.rb CHANGED

@@ -1,7 +1,6 @@
 module Renalware
   module HD
     class ReviseHDProfile
       def initialize(profile)
         raise(ArgumentError, "Cannot revise a new Profile") unless profile.persisted?
         @profile = profile

data/app/models/renalware/hd/schedule_definition.rb CHANGED

@@ -39,6 +39,10 @@ module Renalware
       # For example if day_of_week is 1 (Monday) find any schedules where the Postgres days[] array
       # contains a 1 - e.g. a Mon Wed Fri AM schedule (where days = [1,3,5])
       scope :for_day_of_week, ->(day_of_week) { where("days @> ?", "{#{day_of_week}}") }
+      def days_per_week
+        days&.length
+      end
     end
   end
 end

data/app/models/renalware/hd/sessions/auditable_patient_sessions_in_period_query.rb CHANGED

@@ -2,7 +2,6 @@ module Renalware
   module HD
     module Sessions
       class AuditablePatientSessionsInPeriodQuery
         def initialize(patient:, period:)
           @patient = patient
           @period = period

data/app/models/renalware/hd/sessions/auditable_patients_in_period_query.rb CHANGED

@@ -2,7 +2,6 @@ module Renalware
   module HD
     module Sessions
       class AuditablePatientsInPeriodQuery
         def initialize(period:)
           @period = period
         end

data/app/models/renalware/hd/sessions/auditable_session.rb CHANGED

@@ -11,7 +11,6 @@ module Renalware
   module HD
     module Sessions
       class AuditableSession < SimpleDelegator
         def blood_pressure_measurements
           [
             document.observations_before.blood_pressure,

data/app/models/renalware/hd/sessions/auditable_session_collection.rb CHANGED

@@ -15,7 +15,6 @@ module Renalware
   module HD
     module Sessions
       class AuditableSessionCollection < SimpleDelegator
         AUDITABLE_ATTRIBUTES = %i(
           number_of_missed_sessions
           dialysis_minutes_shortfall

data/app/models/renalware/hd/sessions/latest_patient_sessions_query.rb CHANGED

@@ -2,7 +2,6 @@ module Renalware
   module HD
     module Sessions
       class LatestPatientSessionsQuery
         def initialize(patient:)
           @patient = patient
         end
@@ -22,7 +21,6 @@ module Renalware
         attr_reader :patient
         module Scopes
           def for_patient(patient)
             where(patient: patient)
           end

data/app/models/renalware/hd/sessions/protocol_sessions_query.rb CHANGED

@@ -2,7 +2,6 @@ module Renalware
   module HD
     module Sessions
       class ProtocolSessionsQuery
         def initialize(patient:, limit: 3)
           @patient = patient
           @limit = limit

data/app/models/renalware/hd/sessions/save_session.rb CHANGED

@@ -1,7 +1,6 @@
 module Renalware
   module HD
     module Sessions
       # A generic service object which saves a (new or existing) HD::Session of any (STI) type.
       class SaveSession
         include Wisper::Publisher
@@ -39,7 +38,7 @@ module Renalware
         def parse_params(params)
           @session_type = params.delete(:type)
-          raise(ArgumentError, "Missing type in session params") unless session_type.present?
+          raise(ArgumentError, "Missing type in session params") if session_type.blank?
           params
         end

data/app/models/renalware/hd/update_rolling_patient_statistics.rb CHANGED

@@ -1,7 +1,6 @@
 module Renalware
   module HD
     class UpdateRollingPatientStatistics < ApplicationJob
       def initialize(patient:)
         @patient = patient
       end

data/app/models/renalware/letters/contact.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/letters"
 module Renalware
   module Letters
     class Contact < ApplicationRecord
       belongs_to :patient
       belongs_to :person, class_name: "Directory::Person"
       belongs_to :description, class_name: "ContactDescription"

data/app/models/renalware/letters/determine_counterpart_ccs.rb CHANGED

@@ -18,7 +18,7 @@ module Renalware
       def cc_primary_care_physican?
         pcp = patient.primary_care_physician
-        pcp && pcp.cc_on_letter?(self)
+        pcp&.cc_on_letter?(self)
       end
       def cc_patient?

data/app/models/renalware/letters/event/clinic_visit.rb CHANGED

@@ -26,7 +26,7 @@ module Renalware
           link_to(
             event.to_s,
             ::Renalware::Engine.routes.url_helpers.edit_patient_clinic_visit_path(patient, event)
-            )
+          )
         }
       end
     end

data/app/models/renalware/letters/event/unknown.rb CHANGED

@@ -3,7 +3,6 @@ require_dependency "renalware/letters/event"
 module Renalware
   module Letters
     class Event::Unknown < Event
       def description; end
       def to_s

data/app/models/renalware/letters/part/recent_pathology_results.rb CHANGED

@@ -3,7 +3,6 @@ require "renalware/letters/part"
 module Renalware
   module Letters
     class Part::RecentPathologyResults < Part
       delegate :each, :any?, :present?, to: :recent_pathology_results
       def to_partial_path

data/app/models/renalware/letters/patient_listener.rb CHANGED

@@ -1,4 +1,3 @@
-# rubocop:disable Rails/SkipsModelValidations
 module Renalware
   module Letters
     class PatientListener