remotipart 1.2.1 → 1.4.4

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: 6613ef182593408aa806dbc14790a9f5c31717d7096657f9238efec23e102977
+  data.tar.gz: 9f96a7481ff473943ae7b1e5ec745a8b179b8ae8f615809b3790f7683b687f1e
+SHA512:
+  metadata.gz: 58567b707f27b4eb40eb5020e8fed6763fbb1d895efacb9ddc4c1252b1073c5373180d668de6f9a2b306a922f807a06617458c9ac78eb3dff1723ee0481df1fb
+  data.tar.gz: e19c0a28fecdfa2a8bdfb5bc0024263a1fc4de5dadb3a9a425af75367de672c0ec0339bcced53c33bceb11100fdb382fee465a86a45e8215405d4cf741d213c8

data/.travis.yml

@@ -0,0 +1,35 @@
+language: ruby
+
+before_install:
+  # https://github.com/danmayer/coverband/issues/162#issuecomment-452173268
+  - rm /home/travis/.rvm/gems/*/specifications/bundler-2.*.gemspec || true
+  - gem install bundler -v '<2'
+
+bundler_args: --without development --jobs=3 --retry=3 --path=../vendor/bundle
+
+cache: bundler
+
+env:
+  matrix:
+    - JQUERY_VERSION=
+
+rvm:
+  - 2.5.5
+
+gemfile:
+  - gemfiles/rails_3.2.gemfile
+  - gemfiles/rails_4.2.gemfile
+  - gemfiles/rails_5.2.gemfile
+  - gemfiles/rails_6.0.gemfile
+
+dist: trusty
+
+sudo: false
+
+matrix:
+  include:
+    - env: JQUERY_VERSION=2
+      gemfile: gemfiles/rails_6.0.gemfile
+    - env: JQUERY_VERSION=3
+      gemfile: gemfiles/rails_6.0.gemfile
+  fast_finish: true

data/Appraisals

@@ -0,0 +1,25 @@
+appraise "rails-3.2" do
+  gem 'rails', '~> 3.2.0'
+  gem 'test-unit', '~> 3.0'
+  gem "strong_parameters"
+
+  group :development, :test do
+    gem 'sqlite3', '~> 1.3.5'
+  end
+end
+
+appraise "rails-4.2" do
+  gem 'rails', '~> 4.2.0'
+
+  group :development, :test do
+    gem 'sqlite3', '~> 1.3.6'
+  end
+end
+
+appraise "rails-5.2" do
+  gem 'rails', '~> 5.2.0'
+end
+
+appraise "rails-6.0" do
+  gem 'rails', '~> 6.0.0.rc1'
+end

data/Gemfile

@@ -2,9 +2,22 @@ source 'https://rubygems.org'
 
 group :development do
   gem 'rake'
-  gem 'jeweler'
+  gem 'jeweler', github: 'technicalpickles/jeweler'
   # This conflicts with jeweler gemspec generation,
   # causes dependencies to be added to gemspec recursively
   #gemspec
 end
 
+group :development, :test do
+  gem 'appraisal'
+  gem 'jquery-rails'
+  gem 'sqlite3'
+  gem 'paperclip'
+  gem 'remotipart', path: '.'
+end
+
+group :test do
+  gem 'database_cleaner'
+  gem 'poltergeist'
+  gem 'rspec-rails'
+end

data/History.rdoc

@@ -1,5 +1,39 @@
 = History
 
+=== 1.4.4 / 2019-12-29
+
+* Fixed Rails 6 autoloading deprecation.
+* Fixed ActiveScaffold incompatibility.
+
+=== 1.4.3 / 2019-05-23
+
+* Fixed xhr.responseText not being populated.
+* Security: fixed cross-site scripting vulnerability when server renders user input.
+
+=== 1.4.2 / 2018-04-25
+
+* Fixed ActionView::Template::Error in web-console.
+
+=== 1.4.0 / 2018-04-09
+
+* Added jQuery 3 compatibility.
+* Changed to use ActiveSupport lazy load hooks on initialization.
+* Changed jQuery iframe-transport to v1.0.1.
+* Fixed to preserve original return value of render call for non-remotipart requests.
+* Fixed remote javascript with " not being executed.
+* Fixed method signature of render_with_remotipart, making RJS templates not usable.
+
+=== 1.3.1 / 2016-10-06
+
+* Fixed remote form submit not working with Firefox 49.
+
+=== 1.3.0 / 2016-09-14
+
+* Added Rails 5 support.
+* Added an event `ajax:remotipartComplete`, which will be fired when the ajax upload completes.
+* Changed to preserve original input files upon submit.
+* Fixed TypeError when POST body is empty with Rails 3.
+
 === 1.2.1 / 2013-07-07
 
 * Added automatic authenticity_token detection and appending to iframe submission.

data/LICENSE

@@ -1,3 +1,7 @@
+============================================
+Remotipart is licensed under the MIT License
+============================================
+
 Copyright (c) 2009 Greg Leppert
 
 Permission is hereby granted, free of charge, to any person obtaining

data/README.rdoc

@@ -1,4 +1,8 @@
-= Remotipart: Rails jQuery File Upload
+= Remotipart: Rails jQuery File Uploads
+
+{<img src="https://badge.fury.io/rb/remotipart.svg" alt="Gem Version" />}[https://badge.fury.io/rb/remotipart]
+{<img src="https://travis-ci.com/JangoSteve/remotipart.svg?branch=master" alt="Build Status" />}[https://travis-ci.com/JangoSteve/remotipart]
+{<img src="https://codeclimate.com/github/JangoSteve/remotipart/badges/gpa.svg" />}[https://codeclimate.com/github/JangoSteve/remotipart]
 
 Remotipart is a Ruby on Rails gem enabling AJAX file uploads with jQuery in Rails 3 and Rails 4 remote forms.
 This gem augments the native Rails jQuery remote form functionality enabling asynchronous file uploads with little to no modification to your application.
@@ -9,7 +13,9 @@ This gem augments the native Rails jQuery remote form functionality enabling asy
 == Dependencies
 
 * {Rails 3 or Rails 4}[http://github.com/rails/rails]
-* {The jquery-rails gem}[http://rubygems.org/gems/jquery-rails] (included in Rails 3 and Rails 4 by default), which installs {jQuery}[http://jquery.com] and the {Rails jQuery driver (jquery-ujs)}[https://github.com/rails/jquery-ujs]
+* {The jquery-rails gem}[http://rubygems.org/gems/jquery-rails]
+
+<em>The jquery-rails gem is included in Rails 3 and Rails 4 by default, and installs {jQuery}[http://jquery.com] and the {Rails jQuery UJS driver (jquery-ujs)}[https://github.com/rails/jquery-ujs]</em>
 
 == Installation
 
@@ -29,7 +35,7 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
 
    bundle install
 
-=== Rails 3.1
+=== Rails 3.1 and Rails 4
 
 [2.]
   The necessary js files will automatically be added to the asset pipeline, so add the following to app/assets/javascripts/application.js (right after <tt>//= require jquery_ujs</tt>):
@@ -53,7 +59,7 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
 * For multipart / forms with file inputs, set your form_for to remote as you would for a normal ajax form:
    :remote => true
 * When Javascript is enabled in the user's browser, the form, including the file, will be submitted asynchronously to your controller with:
-   :format == 'js'
+   :format => 'js'
 * If you need to determine if a particular request was made via a remotipart-enabled form...
   * from your Rails controller or view:
 
@@ -63,10 +69,16 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
       $(form).bind("ajax:success", function(){
         if ( $(this).data('remotipartSubmitted') )
       });
+* If you want to be notified when the upload is complete (which can be either success or error)
+  * from your javascript:
 
+      $(form).on("ajax:remotipartComplete", function(e, data){
+        console.log(e, data)
+      });
+      
 === Example
 
-sample_layout.html.erb
+<tt>sample_layout.html.erb</tt>
   <%= form_for @sample, :html => { :multipart => true }, :remote => true do |f| %>
     <div class="field">
       <%= f.label :file %>
@@ -77,7 +89,7 @@ sample_layout.html.erb
     </div>
   <% end %>
 
-sample_controller.rb
+<tt>sample_controller.rb</tt>
   def create
     respond_to do |format|
       if @sample.save
@@ -86,7 +98,7 @@ sample_controller.rb
     end
   end
 
-create.js.erb
+<tt>create.js.erb</tt>
   // Display a Javascript alert
   alert('success!');
   <% if remotipart_submitted? %>
@@ -95,6 +107,21 @@ create.js.erb
     alert('submitted via native jquery-ujs')
   <% end %>
 
+The content type requested from the application can be overridden via the <tt>data-type</tt> HTML5 attribute:
+
+<tt>sample_layout2.html.erb</tt>
+  <%= form_for @sample, :html => { :multipart => true }, :remote => true, :data => { :type => :html } do |f| %>
+    <div class="field">
+      <%= f.label :file %>
+      <%= f.file_field :file %>
+    </div>
+    <div class="actions">
+      <%= f.submit %>
+    </div>
+  <% end %>
+
+In this case, the application should serve HTML using a <tt>create.html.erb</tt> template instead of JavaScript.
+
 == Note on Patches/Pull Requests
 
 <b>If you have a general improvement, optimization, or refactoring, please {read this first}[https://github.com/formasfunction/remotipart/wiki/Refactoring-and-Improving-Remotipart].</b>
@@ -114,7 +141,7 @@ to test the file upload functionality of remotipart (since the browsers running
 upload input using javascript). So, instead we created a demo Rails app using remotipart with all remotipart functionality tested using RSpec and Capybara.
 
 * {Demo Rails App with Tests}[https://github.com/JangoSteve/Rails-jQuery-Demo/tree/remotipart]
-  * {Tests}[https://github.com/JangoSteve/Rails-jQuery-Demo/blob/remotipart/spec/integration/comments_spec.rb]
+  * {Tests}[https://github.com/JangoSteve/Rails-jQuery-Demo/blob/master/spec/features/comments_spec.rb]
 
 To run tests:
 

data/Rakefile

@@ -21,13 +21,6 @@ rescue LoadError
   puts "Jeweler (or a dependency) not available. Install it with: gem install jeweler"
 end
 
-require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'lib' << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
-end
-
 begin
   require 'rcov/rcovtask'
   Rcov::RcovTask.new do |test|
@@ -51,3 +44,8 @@ Rake::RDocTask.new do |rdoc|
   rdoc.rdoc_files.include('README*')
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec

data/gemfiles/rails_3.2.gemfile

@@ -0,0 +1,26 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 3.2.0"
+gem "test-unit", "~> 3.0"
+gem "strong_parameters"
+
+group :development do
+  gem "rake"
+  gem "jeweler"
+end
+
+group :development, :test do
+  gem "appraisal"
+  gem "jquery-rails"
+  gem "sqlite3", "~> 1.3.5"
+  gem "paperclip"
+  gem "remotipart", path: "../"
+end
+
+group :test do
+  gem "database_cleaner"
+  gem "poltergeist"
+  gem "rspec-rails"
+end

data/gemfiles/rails_4.2.gemfile

@@ -0,0 +1,24 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.2.0"
+
+group :development do
+  gem "rake"
+  gem "jeweler"
+end
+
+group :development, :test do
+  gem "appraisal"
+  gem "jquery-rails"
+  gem "sqlite3", "~> 1.3.6"
+  gem "paperclip"
+  gem "remotipart", path: "../"
+end
+
+group :test do
+  gem "database_cleaner"
+  gem "poltergeist"
+  gem "rspec-rails"
+end

data/gemfiles/rails_5.2.gemfile

@@ -0,0 +1,24 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.2.0"
+
+group :development do
+  gem "rake"
+  gem "jeweler"
+end
+
+group :development, :test do
+  gem "appraisal"
+  gem "jquery-rails"
+  gem "sqlite3"
+  gem "paperclip"
+  gem "remotipart", path: "../"
+end
+
+group :test do
+  gem "database_cleaner"
+  gem "poltergeist"
+  gem "rspec-rails"
+end

data/gemfiles/rails_6.0.gemfile

@@ -0,0 +1,24 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 6.0.0.rc1"
+
+group :development do
+  gem "rake"
+  gem "jeweler"
+end
+
+group :development, :test do
+  gem "appraisal"
+  gem "jquery-rails"
+  gem "sqlite3"
+  gem "paperclip"
+  gem "remotipart", path: "../"
+end
+
+group :test do
+  gem "database_cleaner"
+  gem "poltergeist"
+  gem "rspec-rails"
+end

data/lib/remotipart/middleware.rb

@@ -1,6 +1,6 @@
 module Remotipart
 
-  # A middleware to look for our form parameters and 
+  # A middleware to look for our form parameters and
   # encourage Rails to respond with the requested format
   class Middleware
     def initialize app
@@ -9,7 +9,12 @@ module Remotipart
 
     def call env
       # Get request params
-      params = Rack::Request.new(env).params
+      begin
+        params = Rack::Request.new(env).params
+      rescue TypeError => e
+        ::Rails.logger.warn e.message
+        ::Rails.logger.warn e.backtrace.join("\n")
+      end
 
       if params
         # This was using an iframe transport, and is therefore an XHR
@@ -19,8 +24,8 @@ module Remotipart
         end
 
         # Override the accepted format, because it isn't what we really want
-        if params['X-Http-Accept']
-          env['HTTP_ACCEPT'] = params['X-Http-Accept']
+        if params['X-HTTP-Accept']
+          env['HTTP_ACCEPT'] = params['X-HTTP-Accept']
         end
       end
 

data/lib/remotipart/rails/engine.rb

@@ -4,17 +4,27 @@ module Remotipart
 
     class Engine < ::Rails::Engine
       initializer "remotipart.view_helper" do
-        ActionView::Base.send :include, RequestHelper
-        ActionView::Base.send :include, ViewHelper
+        ActiveSupport.on_load :action_view do
+          include RequestHelper
+          include ViewHelper
+        end
       end
 
       initializer "remotipart.controller_helper" do
-        ActionController::Base.send :include, RequestHelper
-        ActionController::Base.send :include, RenderOverrides
+        ActiveSupport.on_load :action_controller do
+          include RequestHelper
+          include RenderOverrides
+        end
       end
 
       initializer "remotipart.include_middelware" do
-        config.app_middleware.insert_after ActionDispatch::ParamsParser, Middleware
+        if ::Rails.version >= '5'
+          # Rails 5 no longer instantiates ActionDispatch::ParamsParser
+          # https://github.com/rails/rails/commit/a1ced8b52ce60d0634e65aa36cb89f015f9f543d
+          config.app_middleware.use Middleware
+        else
+          config.app_middleware.insert_after ActionDispatch::ParamsParser, Middleware
+        end
       end
     end
 

data/lib/remotipart/rails/railtie.rb

@@ -23,13 +23,17 @@ module Remotipart
       end
 
       initializer "remotipart.view_helper" do
-        ActionView::Base.send :include, RequestHelper
-        ActionView::Base.send :include, ViewHelper
+        ActiveSupport.on_load(:action_view) do
+          include RequestHelper
+          include ViewHelper
+        end
       end
 
       initializer "remotipart.controller_helper" do
-        ActionController::Base.send :include, RequestHelper
-        ActionController::Base.send :include, RenderOverrides
+        ActiveSupport.on_load(:action_controller) do
+          include RequestHelper
+          include RenderOverrides
+        end
       end
 
       initializer "remotipart.include_middelware" do

data/lib/remotipart/rails/version.rb

@@ -1,6 +1,6 @@
 module Remotipart
   module Rails
-    VERSION = "1.2.1"
-    IFRAMETRANSPORT_VERSION = "02.06.2013"
+    VERSION = "1.4.4"
+    IFRAMETRANSPORT_VERSION = "1.0.1.remotipart"
   end
 end

data/lib/remotipart/render_overrides.rb

@@ -3,21 +3,43 @@ module Remotipart
   # as expected by iframe-transport.
   module RenderOverrides
     include ERB::Util
+    include ActionView::Helpers::JavaScriptHelper
 
     def self.included(base)
       base.class_eval do
-        alias_method_chain :render, :remotipart
+        if respond_to? :prepend
+          base.prepend Prependable
+        else
+          base.include Includable
+          # Do not use alias_method_chain for compatibility
+          alias render_without_remotipart render
+          alias render render_with_remotipart
+        end
       end
     end
 
-    def render_with_remotipart *args
-      render_without_remotipart *args
+    module Prependable
+      def render(*args, &block)
+        treat_render_for_remotipart super(*args, &block)
+      end
+    end
+
+    module Includable
+      def render_with_remotipart(*args, &block)
+        treat_render_for_remotipart render_without_remotipart(*args, &block)
+      end
+    end
+
+    private
+
+    def treat_render_for_remotipart(render_return_value)
       if remotipart_submitted?
-        textarea_body = response.content_type == 'text/html' ? html_escape(response.body) : response.body
-        response.body = %{<textarea data-type=\"#{response.content_type}\" data-status=\"#{response.response_code}\" data-statusText=\"#{response.message}\">#{textarea_body}</textarea>}
-        response.content_type = Mime::HTML
+        response.body = %{<script type="text/javascript">try{window.parent.document;}catch(err){document.domain=document.domain;}</script><textarea data-type="#{response.content_type}" data-status="#{response.response_code}" data-statusText="#{response.message}"></textarea><script type="text/javascript">document.querySelector("textarea").value="#{escape_javascript(response.body)}";</script>}
+        response.content_type = ::Rails.version >= '5' ? Mime[:html] : Mime::HTML
+        response_body
+      else
+        render_return_value
       end
-      response_body
     end
   end
 end

data/lib/remotipart/request_helper.rb

@@ -2,6 +2,8 @@ module Remotipart
   module RequestHelper
     def remotipart_submitted?
       params[:remotipart_submitted] ? true : false
+    rescue
+      false
     end
     
     alias :remotipart_requested? :remotipart_submitted?

data/lib/remotipart/view_helper.rb

@@ -1,9 +1,11 @@
 module Remotipart
   module ViewHelper
+
     #No longer used
     #Retrained to prevent issues while updating
     def remotipart_response(options = {}, &block)
       with_output_buffer(&block)
     end
+
   end
 end