remotipart 1.2.1 → 1.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: f9e9bc4a555dcec65d5919d97b7f56952ef8b8aa
+  data.tar.gz: e84ba4304c5491427d6eff3d29aa86cb98ecf3f5
+SHA512:
+  metadata.gz: 441d87a73a0eee7e4304fd7dabebaf86ca189eb2ac9c274ee7ad0f69828963851c86c63387d869240255f74be6b582d3c46f0555f2aa08f45aab2a8c58eefb3e
+  data.tar.gz: 29deeb18c6fb76f3ef0a31f5e777a3d4ddd34124c01ad0b11cb53fea34655d238ceeb8e49c69369823318c4273d8cfd3dc36b82794cbc83382a09aa54f374609

data/History.rdoc

@@ -1,5 +1,12 @@
 = History
 
+=== 1.3.0 / 2016-09-14
+
+* Added Rails 5 support.
+* Added an event `ajax:remotipartComplete`, which will be fired when the ajax upload completes.
+* Changed to preserve original input files upon submit.
+* Fixed TypeError when POST body is empty with Rails 3.
+
 === 1.2.1 / 2013-07-07
 
 * Added automatic authenticity_token detection and appending to iframe submission.

data/LICENSE

@@ -1,3 +1,7 @@
+============================================
+Remotipart is licensed under the MIT License
+============================================
+
 Copyright (c) 2009 Greg Leppert
 
 Permission is hereby granted, free of charge, to any person obtaining

data/README.rdoc

@@ -1,4 +1,6 @@
-= Remotipart: Rails jQuery File Upload
+= Remotipart: Rails jQuery File Uploads
+
+{<img src="https://codeclimate.com/github/JangoSteve/remotipart/badges/gpa.svg" />}[https://codeclimate.com/github/JangoSteve/remotipart]
 
 Remotipart is a Ruby on Rails gem enabling AJAX file uploads with jQuery in Rails 3 and Rails 4 remote forms.
 This gem augments the native Rails jQuery remote form functionality enabling asynchronous file uploads with little to no modification to your application.
@@ -9,7 +11,9 @@ This gem augments the native Rails jQuery remote form functionality enabling asy
 == Dependencies
 
 * {Rails 3 or Rails 4}[http://github.com/rails/rails]
-* {The jquery-rails gem}[http://rubygems.org/gems/jquery-rails] (included in Rails 3 and Rails 4 by default), which installs {jQuery}[http://jquery.com] and the {Rails jQuery driver (jquery-ujs)}[https://github.com/rails/jquery-ujs]
+* {The jquery-rails gem}[http://rubygems.org/gems/jquery-rails]
+
+<em>The jquery-rails gem is included in Rails 3 and Rails 4 by default, and installs {jQuery}[http://jquery.com] and the {Rails jQuery UJS driver (jquery-ujs)}[https://github.com/rails/jquery-ujs]</em>
 
 == Installation
 
@@ -29,7 +33,7 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
 
    bundle install
 
-=== Rails 3.1
+=== Rails 3.1 and Rails 4
 
 [2.]
   The necessary js files will automatically be added to the asset pipeline, so add the following to app/assets/javascripts/application.js (right after <tt>//= require jquery_ujs</tt>):
@@ -53,7 +57,7 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
 * For multipart / forms with file inputs, set your form_for to remote as you would for a normal ajax form:
    :remote => true
 * When Javascript is enabled in the user's browser, the form, including the file, will be submitted asynchronously to your controller with:
-   :format == 'js'
+   :format => 'js'
 * If you need to determine if a particular request was made via a remotipart-enabled form...
   * from your Rails controller or view:
 
@@ -63,10 +67,16 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
       $(form).bind("ajax:success", function(){
         if ( $(this).data('remotipartSubmitted') )
       });
+* If you want to be notified when the upload is complete (which can be either success or error)
+  * from your javascript:
 
+      $(form).on("ajax:remotipartComplete", function(e, data){
+        console.log(e, data)
+      });
+      
 === Example
 
-sample_layout.html.erb
+<tt>sample_layout.html.erb</tt>
   <%= form_for @sample, :html => { :multipart => true }, :remote => true do |f| %>
     <div class="field">
       <%= f.label :file %>
@@ -77,7 +87,7 @@ sample_layout.html.erb
     </div>
   <% end %>
 
-sample_controller.rb
+<tt>sample_controller.rb</tt>
   def create
     respond_to do |format|
       if @sample.save
@@ -86,7 +96,7 @@ sample_controller.rb
     end
   end
 
-create.js.erb
+<tt>create.js.erb</tt>
   // Display a Javascript alert
   alert('success!');
   <% if remotipart_submitted? %>
@@ -95,6 +105,21 @@ create.js.erb
     alert('submitted via native jquery-ujs')
   <% end %>
 
+The content type requested from the application can be overridden via the <tt>data-type</tt> HTML5 attribute:
+
+<tt>sample_layout2.html.erb</tt>
+  <%= form_for @sample, :html => { :multipart => true }, :remote => true, :data => { :type => :html } do |f| %>
+    <div class="field">
+      <%= f.label :file %>
+      <%= f.file_field :file %>
+    </div>
+    <div class="actions">
+      <%= f.submit %>
+    </div>
+  <% end %>
+
+In this case, the application should serve HTML using a <tt>create.html.erb</tt> template instead of JavaScript.
+
 == Note on Patches/Pull Requests
 
 <b>If you have a general improvement, optimization, or refactoring, please {read this first}[https://github.com/formasfunction/remotipart/wiki/Refactoring-and-Improving-Remotipart].</b>
@@ -114,7 +139,7 @@ to test the file upload functionality of remotipart (since the browsers running
 upload input using javascript). So, instead we created a demo Rails app using remotipart with all remotipart functionality tested using RSpec and Capybara.
 
 * {Demo Rails App with Tests}[https://github.com/JangoSteve/Rails-jQuery-Demo/tree/remotipart]
-  * {Tests}[https://github.com/JangoSteve/Rails-jQuery-Demo/blob/remotipart/spec/integration/comments_spec.rb]
+  * {Tests}[https://github.com/JangoSteve/Rails-jQuery-Demo/blob/master/spec/features/comments_spec.rb]
 
 To run tests:
 

data/lib/remotipart/middleware.rb

@@ -1,6 +1,6 @@
 module Remotipart
 
-  # A middleware to look for our form parameters and 
+  # A middleware to look for our form parameters and
   # encourage Rails to respond with the requested format
   class Middleware
     def initialize app
@@ -9,7 +9,12 @@ module Remotipart
 
     def call env
       # Get request params
-      params = Rack::Request.new(env).params
+      begin
+        params = Rack::Request.new(env).params
+      rescue TypeError => e
+        ::Rails.logger.warn e.message
+        ::Rails.logger.warn e.backtrace.join("\n")
+      end
 
       if params
         # This was using an iframe transport, and is therefore an XHR

data/lib/remotipart/rails/engine.rb

@@ -14,7 +14,13 @@ module Remotipart
       end
 
       initializer "remotipart.include_middelware" do
-        config.app_middleware.insert_after ActionDispatch::ParamsParser, Middleware
+        if ::Rails.version >= '5'
+          # Rails 5 no longer instantiates ActionDispatch::ParamsParser
+          # https://github.com/rails/rails/commit/a1ced8b52ce60d0634e65aa36cb89f015f9f543d
+          config.app_middleware.use Middleware
+        else
+          config.app_middleware.insert_after ActionDispatch::ParamsParser, Middleware
+        end
       end
     end
 

data/lib/remotipart/rails/version.rb

@@ -1,6 +1,6 @@
 module Remotipart
   module Rails
-    VERSION = "1.2.1"
+    VERSION = "1.3.0"
     IFRAMETRANSPORT_VERSION = "02.06.2013"
   end
 end

data/lib/remotipart/render_overrides.rb

@@ -6,7 +6,9 @@ module Remotipart
 
     def self.included(base)
       base.class_eval do
-        alias_method_chain :render, :remotipart
+        # Use neither alias_method_chain nor prepend for compatibility
+        alias render_without_remotipart render
+        alias render render_with_remotipart
       end
     end
 
@@ -14,8 +16,8 @@ module Remotipart
       render_without_remotipart *args
       if remotipart_submitted?
         textarea_body = response.content_type == 'text/html' ? html_escape(response.body) : response.body
-        response.body = %{<textarea data-type=\"#{response.content_type}\" data-status=\"#{response.response_code}\" data-statusText=\"#{response.message}\">#{textarea_body}</textarea>}
-        response.content_type = Mime::HTML
+        response.body = %{<script type=\"text/javascript\">try{window.parent.document;}catch(err){document.domain=document.domain;}</script> <textarea data-type=\"#{response.content_type}\" data-status=\"#{response.response_code}\" data-statusText=\"#{response.message}\">#{textarea_body}</textarea>}
+        response.content_type = ::Rails.version >= '5' ? Mime[:html] : Mime::HTML
       end
       response_body
     end

data/remotipart.gemspec

@@ -2,14 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: remotipart 1.3.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "remotipart"
-  s.version = "1.2.1"
+  s.version = "1.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Greg Leppert", "Steve Schwartz"]
-  s.date = "2013-07-08"
+  s.date = "2016-09-14"
   s.description = "Remotipart is a Ruby on Rails gem enabling remote multipart forms (AJAX style file uploads) with jquery-rails.\n    This gem augments the native Rails 3 jQuery-UJS remote form function enabling asynchronous file uploads with little to no modification to your application.\n    "
   s.email = ["greg@formasfunction.com", "steve@alfajango.com"]
   s.extra_rdoc_files = [
@@ -20,7 +22,6 @@ Gem::Specification.new do |s|
     ".document",
     "CONTRIBUTING.md",
     "Gemfile",
-    "Gemfile.lock",
     "History.rdoc",
     "LICENSE",
     "README.rdoc",
@@ -41,12 +42,11 @@ Gem::Specification.new do |s|
     "vendor/assets/javascripts/jquery.remotipart.js"
   ]
   s.homepage = "http://opensource.alfajango.com/remotipart/"
-  s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.15"
+  s.rubygems_version = "2.5.1"
   s.summary = "Remotipart is a Ruby on Rails gem enabling remote multipart forms (AJAX style file uploads) with jquery-rails."
 
   if s.respond_to? :specification_version then
-    s.specification_version = 3
+    s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<rake>, [">= 0"])

data/vendor/assets/javascripts/jquery.iframe-transport.js

@@ -115,7 +115,10 @@
     // and should revert all changes made to the page to enable the
     // submission via this transport.
     function cleanUp() {
-      markers.prop('disabled', false);
+      markers.each(function(i){
+        $(this).replaceWith(files[i]);
+        markers.splice(i, 1);
+      });
       form.remove();
       iframe.bind("load", function() { iframe.remove(); });
       iframe.attr("src", "javascript:false;");

data/vendor/assets/javascripts/jquery.remotipart.js

@@ -51,7 +51,9 @@
           // Allow remotipartSubmit to be cancelled if needed
           if ($.rails.fire(form, 'ajax:remotipartSubmit', [xhr, settings])) {
             // Second verse, same as the first
-            $.rails.ajax(settings);
+            $.rails.ajax(settings).complete(function(data){
+              $.rails.fire(form, 'ajax:remotipartComplete', [data]);
+            });
             setTimeout(function(){ $.rails.disableFormElements(form); }, 20);
           }
 

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: remotipart
 version: !ruby/object:Gem::Version
-  version: 1.2.1
-  prerelease: 
+  version: 1.3.0
 platform: ruby
 authors:
 - Greg Leppert
@@ -10,34 +9,40 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-08 00:00:00.000000000Z
+date: 2016-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70170920954340 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70170920954340
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70170920953080 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70170920953080
-description: ! "Remotipart is a Ruby on Rails gem enabling remote multipart forms
-  (AJAX style file uploads) with jquery-rails.\n    This gem augments the native Rails
-  3 jQuery-UJS remote form function enabling asynchronous file uploads with little
-  to no modification to your application.\n    "
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: "Remotipart is a Ruby on Rails gem enabling remote multipart forms (AJAX
+  style file uploads) with jquery-rails.\n    This gem augments the native Rails 3
+  jQuery-UJS remote form function enabling asynchronous file uploads with little to
+  no modification to your application.\n    "
 email:
 - greg@formasfunction.com
 - steve@alfajango.com
@@ -47,10 +52,9 @@ extra_rdoc_files:
 - LICENSE
 - README.rdoc
 files:
-- .document
+- ".document"
 - CONTRIBUTING.md
 - Gemfile
-- Gemfile.lock
 - History.rdoc
 - LICENSE
 - README.rdoc
@@ -71,30 +75,26 @@ files:
 - vendor/assets/javascripts/jquery.remotipart.js
 homepage: http://opensource.alfajango.com/remotipart/
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -3061483236240277448
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 2.5.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Remotipart is a Ruby on Rails gem enabling remote multipart forms (AJAX style
   file uploads) with jquery-rails.
 test_files: []

data/Gemfile.lock

@@ -1,20 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-    git (1.2.5)
-    jeweler (1.8.4)
-      bundler (~> 1.0)
-      git (>= 1.2.5)
-      rake
-      rdoc
-    json (1.7.6)
-    rake (10.0.3)
-    rdoc (3.12)
-      json (~> 1.4)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  jeweler
-  rake