remotely 0.0.4 → 0.1.0

data/lib/remotely/model.rb

@@ -94,7 +94,7 @@ module Remotely
       #   model object is returned, otherwise false.
       #
       def create(params={})
-        new(params).save
+        new(params).tap { |n| n.save }
       end
 
       alias :create! :create
@@ -179,15 +179,8 @@ module Remotely
     # @return [Boolean] Did the save succeed.
     #
     def update_attributes(attrs={})
-      @attribute_cache = self.attributes.dup
       self.attributes.merge!(attrs.symbolize_keys)
-
-      if save && self.errors.empty?
-        true
-      else
-        self.attributes = @attribute_cache
-        false
-      end
+      save
     end
 
     # Persist this object to the remote API.
@@ -205,8 +198,8 @@ module Remotely
     #
     #   {"errors":{"attribute":["message", "message"]}}
     #
-    # @return [Boolean, Model] 
-    #   Remote API returns 200/201 status:   the new/updated model object
+    # @return [Boolean] 
+    #   Remote API returns 200/201 status:   true
     #   Remote API returns any other status: false
     #
     def save
@@ -220,11 +213,11 @@ module Remotely
 
       if resp.status == status && !body.nil?
         self.attributes.merge!(body.symbolize_keys)
+        true
       else
         set_errors(body.delete("errors")) unless body.nil?
+        false
       end
-
-      self
     end
 
     def savable_attributes

data/lib/remotely/version.rb

@@ -1,3 +1,3 @@
 module Remotely
-  VERSION = "0.0.4"
+  VERSION = "0.1.0"
 end

data/spec/remotely/model_spec.rb

@@ -156,7 +156,7 @@ describe Remotely::Model do
       end
 
       it "returns true when the save succeeds" do
-        Adventure.new(attributes).save.should be_a Adventure
+        Adventure.new(attributes).save.should be_true
       end
 
       it "sets errors when a save fails" do
@@ -168,8 +168,8 @@ describe Remotely::Model do
     end
 
     context "when creating" do
+      let!(:adventure) { Adventure.new(name: "To Be Saved...") }
       it "merges in the response body to attributes on success" do
-        adventure = Adventure.new(name: "To Be Saved...")
         stub_request(:post, %r(/adventures)).to_return(body: to_json(attributes.merge(name: "To Be Saved...", id: 2)), status: 201)
         adventure.save
         adventure.id.should == 2
@@ -178,7 +178,8 @@ describe Remotely::Model do
       it "sets errors on a failure" do
         body = Yajl.dump({errors: {base: ["error"]}})
         stub_request(:post, %r(/adventures)).to_return(status: 409, body: body)
-        Adventure.new(name: "name").save.errors.should_not be_empty
+        adventure.save
+        adventure.errors.should_not be_empty
       end
     end
   end
@@ -220,13 +221,6 @@ describe Remotely::Model do
       subject.update_attributes(updates)
       subject.errors[:base].should include("error")
     end
-
-    it "reverts the object's attributes if the save fails" do
-      body = Yajl.dump({errors: {base: ["error"]}})
-      stub_request(:put, %r[/adventures/1]).to_return(status: 500, body: body)
-      subject.update_attributes(updates)
-      subject.type.should == "MATHEMATICAL!"
-    end
   end
 
   describe "#destroy" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: remotely
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-20 00:00:00.000000000Z
+date: 2011-11-16 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152517620 !ruby/object:Gem::Requirement
+  requirement: &70188924310900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152517620
+  version_requirements: *70188924310900
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152517060 !ruby/object:Gem::Requirement
+  requirement: &70188924309560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 2.6.0
   type: :development
   prerelease: false
-  version_requirements: *2152517060
+  version_requirements: *70188924309560
 - !ruby/object:Gem::Dependency
   name: ZenTest
-  requirement: &2152516520 !ruby/object:Gem::Requirement
+  requirement: &70188924308220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152516520
+  version_requirements: *70188924308220
 - !ruby/object:Gem::Dependency
   name: autotest-growl
-  requirement: &2152513940 !ruby/object:Gem::Requirement
+  requirement: &70188924307380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152513940
+  version_requirements: *70188924307380
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2152513340 !ruby/object:Gem::Requirement
+  requirement: &70188924306540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152513340
+  version_requirements: *70188924306540
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &2152512920 !ruby/object:Gem::Requirement
+  requirement: &70188924305640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152512920
+  version_requirements: *70188924305640
 - !ruby/object:Gem::Dependency
   name: ruby-debug-completion
-  requirement: &2152512460 !ruby/object:Gem::Requirement
+  requirement: &70188924304980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152512460
+  version_requirements: *70188924304980
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2152511900 !ruby/object:Gem::Requirement
+  requirement: &70188924304340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152511900
+  version_requirements: *70188924304340
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &2152511300 !ruby/object:Gem::Requirement
+  requirement: &70188924302900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,10 +109,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152511300
+  version_requirements: *70188924302900
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2152510660 !ruby/object:Gem::Requirement
+  requirement: &70188924301560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.7.4
   type: :runtime
   prerelease: false
-  version_requirements: *2152510660
+  version_requirements: *70188924301560
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &2152510160 !ruby/object:Gem::Requirement
+  requirement: &70188924300100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -131,7 +131,7 @@ dependencies:
         version: 0.8.2
   type: :runtime
   prerelease: false
-  version_requirements: *2152510160
+  version_requirements: *70188924300100
 description: Remote API based model associations.
 email:
 - me@mattenoble.com